From nobody Tue May 13 23:16:17 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1677773804; cv=none; d=zohomail.com; s=zohoarc; b=XXOT4a5LonB7SoI8OJCDVjuaXHrY8EIuqQlyaS03wajqVjZM+VMJlP0X9oY7OVVQchWfFfdltU8XDG2QD2FPj4sv/MxXu12jIsJTUSOiXlsTWHNyf+e7cgR4LGhLhNXoMon0S+HqIhrGPHwp9qn7rIP/wKPzQwEEiDCmekKoRcw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1677773804; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TU08uC5MZfkpgoJqIEUyUQ6bHvBjCm7ZXXjE43gqREY=; b=a9xDMfANQfd4pETH4CYVOl55pD8RyxQ/1K0xsBofwsEd7NMW8WE07QdzFOHFPnOuqoqcBw4Yq6Tr9Cc7XMb0CQhj9e2KZB+kKObAY4Ek8nVB1tegncfN5+Vw7lCQ85nyaIjQM4irz1dkU7/1egK7ZVeoE+XmsO/9ol7S30N2j/A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1677773804454787.8363661555856; Thu, 2 Mar 2023 08:16:44 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXlbS-0006UV-GY; Thu, 02 Mar 2023 11:16:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlbF-0006F2-QP for qemu-devel@nongnu.org; Thu, 02 Mar 2023 11:16:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXlbB-0000JZ-C2 for qemu-devel@nongnu.org; Thu, 02 Mar 2023 11:16:07 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-546-1pfeqA_ROgie0q4V-RX5oA-1; Thu, 02 Mar 2023 11:15:48 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6932F80D0F0 for ; Thu, 2 Mar 2023 16:15:48 +0000 (UTC) Received: from dell-r430-03.lab.eng.brq2.redhat.com (dell-r430-03.lab.eng.brq2.redhat.com [10.37.153.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id D726D140EBF6; Thu, 2 Mar 2023 16:15:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677773751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TU08uC5MZfkpgoJqIEUyUQ6bHvBjCm7ZXXjE43gqREY=; b=gCwLurfm46woZMwFZaTLichEiA7mPfr0/SOb44pIdn1SbaxL+N4AgIwY6ZoBl83JIeEuwY 90slbrp2S1XBUwwIu/qjU/dlHt8KMXFWU0tkGs17hNb14PmBqVpbqxsNup8XMkWppVFnlJ dZYQPG6M8IZmL4gWUT71QSw8Zf3YtY0= X-MC-Unique: 1pfeqA_ROgie0q4V-RX5oA-1 From: Igor Mammedov To: qemu-devel@nongnu.org Cc: mst@redhat.com, berrange@redhat.com Subject: [PATCH v2 03/34] tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend test_acpi_piix4_no_acpi_pci_hotplug Date: Thu, 2 Mar 2023 17:15:12 +0100 Message-Id: <20230302161543.286002-4-imammedo@redhat.com> In-Reply-To: <20230302161543.286002-1-imammedo@redhat.com> References: <20230302161543.286002-1-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=imammedo@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1677773806286100011 test bridge AML generator with ACPI PCI hotplug disabled (i.e. with native hotplug enabled/disabled per bridge/root port) PS: while at make sure that devices on pci-bridge are starting from addr=3D1.0 as slot 0 is not available there and test passes only because of a bug in ACPI hotplug that will be fixed by follow up patch Signed-off-by: Igor Mammedov --- tests/qtest/bios-tables-test.c | 42 +++++++++++++++++++++++++++++++--- 1 file changed, 39 insertions(+), 3 deletions(-) diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c index d8c8cda58e..7828c6b7e6 100644 --- a/tests/qtest/bios-tables-test.c +++ b/tests/qtest/bios-tables-test.c @@ -949,9 +949,14 @@ static void test_acpi_piix4_no_acpi_pci_hotplug(void) data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=3Doff " "-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support= =3Doff " - "-device pci-bridge,chassis_nr=3D1 " - "-device pci-testdev,bus=3Dpci.0 " - "-device pci-testdev,bus=3Dpci.1", &data); + "-device pci-bridge,chassis_nr=3D1,addr=3D4.0 " + "-device pci-testdev,bus=3Dpci.0,addr=3D5.0 " + "-device pci-testdev,bus=3Dpci.0,addr=3D6.0,acpi-index= =3D101 " + "-device pci-testdev,bus=3Dpci.1,addr=3D1.0 " + "-device pci-testdev,bus=3Dpci.1,addr=3D2.0,acpi-index= =3D201 " + "-device pci-bridge,id=3Dnhpbr,chassis_nr=3D2,shpc=3Doff= ,addr=3D7.0 " + "-device pci-testdev,bus=3Dnhpbr,addr=3D1.0,acpi-index= =3D301 " + , &data); free_test_data(&data); } =20 @@ -1002,6 +1007,35 @@ static void test_acpi_q35_tcg_bridge(void) free_test_data(&data); } =20 +static void test_acpi_q35_tcg_no_acpi_hotplug(void) +{ + test_data data; + + memset(&data, 0, sizeof(data)); + data.machine =3D MACHINE_Q35; + data.variant =3D ".noacpihp"; + data.required_struct_types =3D base_required_struct_types; + data.required_struct_types_len =3D ARRAY_SIZE(base_required_struct_typ= es); + test_acpi_one("-global ICH9-LPC.acpi-pci-hotplug-with-bridge-support= =3Doff" + " -device pci-testdev,bus=3Dpcie.0,acpi-index=3D101,addr=3D3.0" + " -device pci-bridge,chassis_nr=3D1,id=3Dshpcbr,addr=3D4.0" + " -device pci-testdev,bus=3Dshpcbr,addr=3D1.0,acpi-index=3D201" + " -device pci-bridge,chassis_nr=3D2,shpc=3Doff,id=3Dnoshpcbr,addr= =3D5.0" + " -device pci-testdev,bus=3Dnoshpcbr,addr=3D1.0,acpi-index=3D301" + " -device pcie-root-port,id=3Dhprp,port=3D0x0,chassis=3D1,addr=3D6= .0" + " -device pci-testdev,bus=3Dhprp,acpi-index=3D401" + " -device pcie-root-port,id=3Dnohprp,port=3D0x0,chassis=3D2,hotplu= g=3Doff," + "addr=3D7.0" + " -device pci-testdev,bus=3Dnohprp,acpi-index=3D501" + " -device pcie-root-port,id=3Dnohprpint,port=3D0x0,chassis=3D3,hot= plug=3Doff," + "addr=3D8.0" + " -device pcie-root-port,id=3Dhprp2,port=3D0x0,chassis=3D4,bus=3Dn= ohprpint," + "addr=3D9.0" + " -device pci-testdev,bus=3Dhprp2,acpi-index=3D601" + , &data); + free_test_data(&data); +} + static void test_acpi_q35_multif_bridge(void) { test_data data =3D { @@ -2094,6 +2128,8 @@ int main(int argc, char *argv[]) test_acpi_q35_tcg_tpm12_tis); } qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge); + qtest_add_func("acpi/q35/no-acpi-hotplug", + test_acpi_q35_tcg_no_acpi_hotplug); qtest_add_func("acpi/q35/multif-bridge", test_acpi_q35_multif_bridge); qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64); --=20 2.39.1