hw/virtio/vhost.c | 14 -------------- 1 file changed, 14 deletions(-)
These hooks were introduced in:
80a1ea3748 ("memory: move ioeventfd ops to MemoryListener", 2012-02-29)
But they seem to be never used. Drop them.
Cc: Richard Henderson <rth@twiddle.net>
Signed-off-by: Peter Xu <peterx@redhat.com>
---
hw/virtio/vhost.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
index eb8c4c378c..c713dc5d9d 100644
--- a/hw/virtio/vhost.c
+++ b/hw/virtio/vhost.c
@@ -1291,18 +1291,6 @@ void vhost_virtqueue_stop(struct vhost_dev *dev,
0, virtio_queue_get_desc_size(vdev, idx));
}
-static void vhost_eventfd_add(MemoryListener *listener,
- MemoryRegionSection *section,
- bool match_data, uint64_t data, EventNotifier *e)
-{
-}
-
-static void vhost_eventfd_del(MemoryListener *listener,
- MemoryRegionSection *section,
- bool match_data, uint64_t data, EventNotifier *e)
-{
-}
-
static int vhost_virtqueue_set_busyloop_timeout(struct vhost_dev *dev,
int n, uint32_t timeout)
{
@@ -1457,8 +1445,6 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque,
.log_sync = vhost_log_sync,
.log_global_start = vhost_log_global_start,
.log_global_stop = vhost_log_global_stop,
- .eventfd_add = vhost_eventfd_add,
- .eventfd_del = vhost_eventfd_del,
.priority = 10
};
--
2.39.1
On Tue, Mar 7, 2023 at 3:32 AM Peter Xu <peterx@redhat.com> wrote: > > These hooks were introduced in: > > 80a1ea3748 ("memory: move ioeventfd ops to MemoryListener", 2012-02-29) > > But they seem to be never used. Drop them. > > Cc: Richard Henderson <rth@twiddle.net> > Signed-off-by: Peter Xu <peterx@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com> Thanks > --- > hw/virtio/vhost.c | 14 -------------- > 1 file changed, 14 deletions(-) > > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c > index eb8c4c378c..c713dc5d9d 100644 > --- a/hw/virtio/vhost.c > +++ b/hw/virtio/vhost.c > @@ -1291,18 +1291,6 @@ void vhost_virtqueue_stop(struct vhost_dev *dev, > 0, virtio_queue_get_desc_size(vdev, idx)); > } > > -static void vhost_eventfd_add(MemoryListener *listener, > - MemoryRegionSection *section, > - bool match_data, uint64_t data, EventNotifier *e) > -{ > -} > - > -static void vhost_eventfd_del(MemoryListener *listener, > - MemoryRegionSection *section, > - bool match_data, uint64_t data, EventNotifier *e) > -{ > -} > - > static int vhost_virtqueue_set_busyloop_timeout(struct vhost_dev *dev, > int n, uint32_t timeout) > { > @@ -1457,8 +1445,6 @@ int vhost_dev_init(struct vhost_dev *hdev, void *opaque, > .log_sync = vhost_log_sync, > .log_global_start = vhost_log_global_start, > .log_global_stop = vhost_log_global_stop, > - .eventfd_add = vhost_eventfd_add, > - .eventfd_del = vhost_eventfd_del, > .priority = 10 > }; > > -- > 2.39.1 >
On 6/3/23 20:32, Peter Xu wrote: > These hooks were introduced in: > > 80a1ea3748 ("memory: move ioeventfd ops to MemoryListener", 2012-02-29) > > But they seem to be never used. Drop them. Similar to bf83601fdd ("xen: drop no-op MemoryListener callbacks") few months later... Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Cc: Richard Henderson <rth@twiddle.net> > Signed-off-by: Peter Xu <peterx@redhat.com> > --- > hw/virtio/vhost.c | 14 -------------- > 1 file changed, 14 deletions(-)
© 2016 - 2024 Red Hat, Inc.