From nobody Tue Feb 10 16:19:03 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1678305955; cv=none; d=zohomail.com; s=zohoarc; b=Ghir0gs8ef1FK1mejLmI5CYLXLa18ISok6YKfFLlel0LMliudKcKL00SoIvKxH+RUi9dlA8vAheUTBjNNcDJY8/dSJO5tivO34oGp6cyIHsz+5TffbcmHbU060OZFkhbG1GgPACS0JLx2bfPynzvbXVBlZ/mNGX9mRzOOseeQoI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1678305955; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SR7Nzf/Ynf6gDendfnPnQChtOMCFkbv6WT+Z7RsIV44=; b=U0+8k2UHXP6qITvkOTDLAshnuABqztZ/yNI/ifxUaizve3dqn9LMstfKT2eErDZoub2xNrEgsWP2CdsvRdslVaNGkzVepXineNtGQ0A9YvkWrzl3SyJdHpcyR2AVJW//GcGwl74DLz5na8PpQ1+3eZ90XQhF2chXvm71Eu5G+eA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1678305955958166.11615874450376; Wed, 8 Mar 2023 12:05:55 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pa01a-00011w-MV; Wed, 08 Mar 2023 15:04:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pa01Y-000114-Tl for qemu-devel@nongnu.org; Wed, 08 Mar 2023 15:04:32 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pa01X-0006xY-0I for qemu-devel@nongnu.org; Wed, 08 Mar 2023 15:04:32 -0500 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-582-s47-NiY7Nd-A6-5ZtTt-1w-1; Wed, 08 Mar 2023 15:04:28 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 41F8A811E6E; Wed, 8 Mar 2023 20:04:28 +0000 (UTC) Received: from kostyanf14nb.redhat.com (unknown [10.45.224.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 801212026D4B; Wed, 8 Mar 2023 20:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678305870; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SR7Nzf/Ynf6gDendfnPnQChtOMCFkbv6WT+Z7RsIV44=; b=fCZDSx6ykEQReyhG9mpvvLMlf7CKC7Ga87Lqb1wm7rtDdpCoJF3ubEyAusy4P9+dyBOsbW EE2D+K5ZLfTpzY4+xr26drVgDke2rPumTf4z1wOuo8ZsLPFipp4v+0CoAPGueHDqZ9x3ZE eysLk2yg73vi+WxxY8PhADkbXECy97M= X-MC-Unique: s47-NiY7Nd-A6-5ZtTt-1w-1 From: Konstantin Kostiuk To: qemu-devel@nongnu.org, Peter Maydell , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [PULL 4/5] qga/win/vss: query VSS backup type Date: Wed, 8 Mar 2023 22:04:18 +0200 Message-Id: <20230308200419.453688-5-kkostiuk@redhat.com> In-Reply-To: <20230308200419.453688-1-kkostiuk@redhat.com> References: <20230308200419.453688-1-kkostiuk@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=kkostiuk@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1678305956568100002 Content-Type: text/plain; charset="utf-8" From: Kfir Manor Query VSS backup type number (DWORD) from QEMU Guest Agent VSS Provider reg= istry key registry value VssOption Translate the VSS backup type number (DWORD) into its VSS backup type (VSS_= BACKUP_TYPE) Returns the queried VSS backup type if the program encounters unexpected be= haviors or values return default VSS backup type VSS_BT_FULL instead Signed-off-by: Kfir Manor Reviewed-by: Konstantin Kostiuk Signed-off-by: Konstantin Kostiuk --- qga/vss-win32/requester.cpp | 38 +++++++++++++++++++++++++++++++++++++ qga/vss-win32/vss-handles.h | 3 +++ 2 files changed, 41 insertions(+) diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp index b371affeab..e06d516675 100644 --- a/qga/vss-win32/requester.cpp +++ b/qga/vss-win32/requester.cpp @@ -23,6 +23,8 @@ /* Call QueryStatus every 10 ms while waiting for frozen event */ #define VSS_TIMEOUT_EVENT_MSEC 10 =20 +#define DEFAULT_VSS_BACKUP_TYPE VSS_BT_FULL + #define err_set(e, err, fmt, ...) = \ ((e)->error_setg_win32_wrapper((e)->errp, __FILE__, __LINE__, __func__= , \ err, fmt, ## __VA_ARGS__)) @@ -234,6 +236,42 @@ out: } } =20 +DWORD get_reg_dword_value(HKEY baseKey, LPCSTR subKey, LPCSTR valueName, + DWORD defaultData) +{ + DWORD regGetValueError; + DWORD dwordData; + DWORD dataSize =3D sizeof(DWORD); + + regGetValueError =3D RegGetValue(baseKey, subKey, valueName, RRF_RT_DW= ORD, + NULL, &dwordData, &dataSize); + if (regGetValueError !=3D ERROR_SUCCESS) { + return defaultData; + } + return dwordData; +} + +bool is_valid_vss_backup_type(VSS_BACKUP_TYPE vssBT) +{ + return (vssBT > VSS_BT_UNDEFINED && vssBT < VSS_BT_OTHER); +} + +VSS_BACKUP_TYPE get_vss_backup_type( + VSS_BACKUP_TYPE defaultVssBT =3D DEFAULT_VSS_BACKUP_TYPE) +{ + VSS_BACKUP_TYPE vssBackupType; + + vssBackupType =3D static_cast( + get_reg_dword_value(HKEY_LOCAL_MACHINE, + QGA_PROVIDER_REGISTRY_ADDR= ESS, + "VssOption", + defaultVssBT)); + if (!is_valid_vss_backup_type(vssBackupType)) { + return defaultVssBT; + } + return vssBackupType; +} + void requester_freeze(int *num_vols, void *mountpoints, ErrorSet *errset) { COMPointer pAsync; diff --git a/qga/vss-win32/vss-handles.h b/qga/vss-win32/vss-handles.h index 0f8a741ad2..1a7d842129 100644 --- a/qga/vss-win32/vss-handles.h +++ b/qga/vss-win32/vss-handles.h @@ -6,6 +6,9 @@ #define QGA_PROVIDER_NAME "QEMU Guest Agent VSS Provider" #define QGA_PROVIDER_LNAME L(QGA_PROVIDER_NAME) #define QGA_PROVIDER_VERSION L(QEMU_VERSION) +#define QGA_PROVIDER_REGISTRY_ADDRESS "SYSTEM\\CurrentControlSet"\ + "\\Services"\ + "\\" QGA_PROVIDER_NAME =20 #define EVENT_NAME_FROZEN "Global\\QGAVSSEvent-frozen" #define EVENT_NAME_THAW "Global\\QGAVSSEvent-thaw" --=20 2.25.1