hw/virtio/vhost-user.c | 21 ++--------- hw/virtio/vhost-vdpa.c | 1 - hw/virtio/vhost.c | 62 ++++++++++++++++++++++++------- include/exec/cpu-common.h | 15 ++++++++ include/hw/virtio/vhost-backend.h | 9 +---- softmmu/physmem.c | 17 --------- 6 files changed, 68 insertions(+), 57 deletions(-)
Following up on my previous work to make virtio-mem consume multiple memslots dynamically [1] that requires precise accounting between used vs. reserved memslots, I realized that vhost makes this extra hard by filtering out some memory region sections (so they don't consume a memslot) in the vhost-user case, which messes up the whole memslot accounting. This series fixes what I found to be broken and prepares for more work on [1]. Further, it cleanes up the merge checks that I consider unnecessary. [1] https://lkml.kernel.org/r/20211027124531.57561-8-david@redhat.com Cc: "Michael S. Tsirkin" <mst@redhat.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com> Cc: Igor Mammedov <imammedo@redhat.com> v1 -> v2: - "vhost: Rework memslot filtering and fix "used_memslot" tracking" -- New approach: keep filtering, but make filtering less generic and track separately. This should keep any existing setups working. - "softmmu/physmem: Fixup qemu_ram_block_from_host() documentation" -- As requested by Igor David Hildenbrand (3): vhost: Rework memslot filtering and fix "used_memslot" tracking vhost: Remove vhost_backend_can_merge() callback softmmu/physmem: Fixup qemu_ram_block_from_host() documentation hw/virtio/vhost-user.c | 21 ++--------- hw/virtio/vhost-vdpa.c | 1 - hw/virtio/vhost.c | 62 ++++++++++++++++++++++++------- include/exec/cpu-common.h | 15 ++++++++ include/hw/virtio/vhost-backend.h | 9 +---- softmmu/physmem.c | 17 --------- 6 files changed, 68 insertions(+), 57 deletions(-) -- 2.39.2
On Thu, 16 Mar 2023 16:36:55 +0100 David Hildenbrand <david@redhat.com> wrote: > Following up on my previous work to make virtio-mem consume multiple > memslots dynamically [1] that requires precise accounting between used vs. > reserved memslots, I realized that vhost makes this extra hard by > filtering out some memory region sections (so they don't consume a > memslot) in the vhost-user case, which messes up the whole memslot > accounting. > > This series fixes what I found to be broken and prepares for more work on > [1]. Further, it cleanes up the merge checks that I consider unnecessary. Acked-by: Igor Mammedov <imammedo@redhat.com> > > [1] https://lkml.kernel.org/r/20211027124531.57561-8-david@redhat.com > > Cc: "Michael S. Tsirkin" <mst@redhat.com> > Cc: Stefan Hajnoczi <stefanha@redhat.com> > Cc: Dr. David Alan Gilbert <dgilbert@redhat.com> > Cc: Igor Mammedov <imammedo@redhat.com> > > v1 -> v2: > - "vhost: Rework memslot filtering and fix "used_memslot" tracking" > -- New approach: keep filtering, but make filtering less generic and > track separately. This should keep any existing setups working. > - "softmmu/physmem: Fixup qemu_ram_block_from_host() documentation" > -- As requested by Igor > > David Hildenbrand (3): > vhost: Rework memslot filtering and fix "used_memslot" tracking > vhost: Remove vhost_backend_can_merge() callback > softmmu/physmem: Fixup qemu_ram_block_from_host() documentation > > hw/virtio/vhost-user.c | 21 ++--------- > hw/virtio/vhost-vdpa.c | 1 - > hw/virtio/vhost.c | 62 ++++++++++++++++++++++++------- > include/exec/cpu-common.h | 15 ++++++++ > include/hw/virtio/vhost-backend.h | 9 +---- > softmmu/physmem.c | 17 --------- > 6 files changed, 68 insertions(+), 57 deletions(-) >
On 20.04.23 16:28, Igor Mammedov wrote: > On Thu, 16 Mar 2023 16:36:55 +0100 > David Hildenbrand <david@redhat.com> wrote: > >> Following up on my previous work to make virtio-mem consume multiple >> memslots dynamically [1] that requires precise accounting between used vs. >> reserved memslots, I realized that vhost makes this extra hard by >> filtering out some memory region sections (so they don't consume a >> memslot) in the vhost-user case, which messes up the whole memslot >> accounting. >> >> This series fixes what I found to be broken and prepares for more work on >> [1]. Further, it cleanes up the merge checks that I consider unnecessary. > > Acked-by: Igor Mammedov <imammedo@redhat.com> Thanks Igor! @MST, do you want to these patches (I can resend in case it's easier to fixup the typo in patch #3). Alternatively, I could send these patches along with another memory-backend patch I have queued. -- Thanks, David / dhildenb
On Wed, May 03, 2023 at 04:16:10PM +0200, David Hildenbrand wrote: > On 20.04.23 16:28, Igor Mammedov wrote: > > On Thu, 16 Mar 2023 16:36:55 +0100 > > David Hildenbrand <david@redhat.com> wrote: > > > > > Following up on my previous work to make virtio-mem consume multiple > > > memslots dynamically [1] that requires precise accounting between used vs. > > > reserved memslots, I realized that vhost makes this extra hard by > > > filtering out some memory region sections (so they don't consume a > > > memslot) in the vhost-user case, which messes up the whole memslot > > > accounting. > > > > > > This series fixes what I found to be broken and prepares for more work on > > > [1]. Further, it cleanes up the merge checks that I consider unnecessary. > > > > Acked-by: Igor Mammedov <imammedo@redhat.com> > > Thanks Igor! > > @MST, do you want to these patches (I can resend in case it's easier to > fixup the typo in patch #3). > > Alternatively, I could send these patches along with another memory-backend > patch I have queued. I think I'll queue them to make sure there are no conflicts. Pls do post with a typo fixed. Thanks! > -- > Thanks, > > David / dhildenb
© 2016 - 2024 Red Hat, Inc.