From nobody Tue May 7 15:34:41 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679224284; cv=none; d=zohomail.com; s=zohoarc; b=nZZtpRFwzmhOlj8aDlTYLuxRS3TCoGMeNqR1lDnZCiN1N4BigddOOziwFvj3dHMdGQqgcr+SbewXzhnCMNRNC+5PnlpHC/iK+ksSMZiIHkBgkho+l4q51dfVSojCdnMhsI7TZKsPoAHBsXs4h4ks9X8jl1DhOjZe6K05tk9cNLs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679224284; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=j9V3BE4SVaAZhY3ILk8MUzTlTSJ+FUwbhSAFZsO8Cys=; b=l8no3uVV6jZXvTVS7RUQ3FSu3lewHmwSsuDST7nxvwzlhoOHrezdQjCr/eDE1gpfa8sgP/e369KlZZata41TPBiEs3VI66+7mJ/1kppfuH+XtMw6L3SYg8FEzxFcg/L4LJmhBik1MsEE0JVDH2rFcMqnB6vmvZVq6VcQdp8Gdno= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167922428455186.00449542105343; Sun, 19 Mar 2023 04:11:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pdqvv-0004G1-NL; Sun, 19 Mar 2023 07:10:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdqvl-0004Fq-Dh for qemu-devel@nongnu.org; Sun, 19 Mar 2023 07:10:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pdqvi-000697-Ib for qemu-devel@nongnu.org; Sun, 19 Mar 2023 07:10:28 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-646-Idq3n66SPTGt8mC0I3jxdg-1; Sun, 19 Mar 2023 07:10:22 -0400 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C9A59830F9E for ; Sun, 19 Mar 2023 11:10:21 +0000 (UTC) Received: from localhost (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 94095401E30; Sun, 19 Mar 2023 11:10:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679224223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=j9V3BE4SVaAZhY3ILk8MUzTlTSJ+FUwbhSAFZsO8Cys=; b=Tvzb0gYsHfcZUvKPBwm/fHhqf1kCftjoohQLovR4+0kEx7F4bblFH4+2cnrIAfnvjfAHfR 3K+ePnZtcmtd21KeTyUovuFi3wEe0Q7X6ut9A4u3S1IgxDaaRZUzfrqqF16rEnLbC+b/mc xag4vGcO37gNu0B+joLQQGqUzj4n5Eo= X-MC-Unique: Idq3n66SPTGt8mC0I3jxdg-1 From: marcandre.lureau@redhat.com To: qemu-devel@nongnu.org Cc: berrange@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Gerd Hoffmann Subject: [PATCH] ui: return the default console cursor when con == NULL Date: Sun, 19 Mar 2023 15:10:17 +0400 Message-Id: <20230319111017.1319880-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=marcandre.lureau@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679224285568100002 From: Marc-Andr=C3=A9 Lureau VNC code relies on con=3D=3DNULL to mean the default console. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/1548 Fixes: commit 385ac97f8 ("ui: keep current cursor with QemuConsole") Signed-off-by: Marc-Andr=C3=A9 Lureau Reported-by: Helge Konetzka Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- ui/console.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ui/console.c b/ui/console.c index f3783021e5..6e8a3cdc62 100644 --- a/ui/console.c +++ b/ui/console.c @@ -2303,6 +2303,9 @@ QemuConsole *qemu_console_lookup_unused(void) =20 QEMUCursor *qemu_console_get_cursor(QemuConsole *con) { + if (con =3D=3D NULL) { + con =3D active_console; + } return con->cursor; } =20 --=20 2.39.2