From nobody Sun May 5 03:22:30 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1679309690; cv=none; d=zohomail.com; s=zohoarc; b=AVJ6UbKy75ueHHv919eSyRb3cZAEXooDKXnuJGwjpzim1ZQ6iL6JfvcLYnL0HJDjdImnA4BAWCSuXV02lx1VDQzLe/Nmlnklc1nhZOGeSTZA0aNnDhuScNamRDl3IwIJg+h+Iq/x7BLfcEl5oDduCl6ierZsepA3qrEhBwMAZrw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679309690; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=rGbkc4kQMzffOjMY9IESGRuQG00UxKWAneK/ddQQNcE=; b=Mg84oSgSq8PyTqRN8i5HeeL91d1tK9txX/VHZfWZVGpkYJ5Hmix2gMMlGDNiPrVmTvuqUBdvocYIEu9YfMFX45covBTtok8c1q8WhZVxRmxaxF7wN0vjc7v2EPL1e4dsZmer/oEdEqwGVld1e61TdMHAIFEzpwxbxqKCpieeM4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679309690962227.14440285750948; Mon, 20 Mar 2023 03:54:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peD9d-0001mD-RW; Mon, 20 Mar 2023 06:54:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peD9c-0001m1-0H for qemu-devel@nongnu.org; Mon, 20 Mar 2023 06:54:16 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peD9a-0004aK-E5 for qemu-devel@nongnu.org; Mon, 20 Mar 2023 06:54:15 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-426-hvDmxrV-MDeco6ASAiCXgg-1; Mon, 20 Mar 2023 06:54:08 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 38515101A531; Mon, 20 Mar 2023 10:54:08 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.33.36.143]) by smtp.corp.redhat.com (Postfix) with ESMTP id 75A01C15BA0; Mon, 20 Mar 2023 10:54:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679309652; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rGbkc4kQMzffOjMY9IESGRuQG00UxKWAneK/ddQQNcE=; b=E5EjuM10mUR2Gy3aGATBHM9x3Ey/GYwXOeNKuGS5tYhzgrCRr9J8pSPz2lMKCu3/X1gH31 1tX8P0KEoSaMwL6PaUF86EvjMeRPAG1TP2JGC/ay8g08cUwikn9tzjHitRItOpyr81N0iR mRqpU9OLEfNWZdkZh19wKr+qmrtgJrI= X-MC-Unique: hvDmxrV-MDeco6ASAiCXgg-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Vladimir Sementsov-Ogievskiy , Cleber Rosa , Beraldo Leal , John Snow , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH] python: honour message limit when using pre-opened socket Date: Mon, 20 Mar 2023 10:54:04 +0000 Message-Id: <20230320105404.637661-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1679309692533100001 The default message recv limit in asyncio is smaller than our needs, so when opening connections we override it. This was done when opening a connection using a socket address, but was missed when using a pre-opened socket file descriptor. This latent bug was exposed when the QEMUMachine class was enhanced to use socketpair() when no socket address was passed by: commit bd4c0ef409140bd1be393407c04005ac077d4574 Author: Marc-Andr=C3=A9 Lureau Date: Wed Jan 11 12:01:01 2023 +0400 python/qemu/machine: use socketpair() for QMP by default Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Tested-by: Vladimir Sementsov-Ogievskiy --- python/qemu/qmp/protocol.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/python/qemu/qmp/protocol.py b/python/qemu/qmp/protocol.py index 22e60298d2..2bd341a93e 100644 --- a/python/qemu/qmp/protocol.py +++ b/python/qemu/qmp/protocol.py @@ -307,7 +307,10 @@ async def open_with_socket(self, sock: socket.socket) = -> None: =20 :raise StateError: When the `Runstate` is not `IDLE`. """ - self._reader, self._writer =3D await asyncio.open_connection(sock= =3Dsock) + self._reader, self._writer =3D await asyncio.open_connection( + sock=3Dsock, + limit=3Dself._limit, + ) self._set_state(Runstate.CONNECTING) =20 @upper_half --=20 2.39.2