ui/gtk.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Do not attempt to move the pointer if the widget is not yet realized.
(this is reproducible with X11)
Fixes: 6effaa16ac98 ("ui: set cursor position upon listener
registration")
Reported-by: Bernhard Beschow <shentey@gmail.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
ui/gtk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index fd82e9b1ca..e9564f2baa 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -450,7 +450,8 @@ static void gd_mouse_set(DisplayChangeListener *dcl,
GdkDisplay *dpy;
gint x_root, y_root;
- if (qemu_input_is_absolute()) {
+ if (!gtk_widget_get_realized(vc->gfx.drawing_area) ||
+ qemu_input_is_absolute()) {
return;
}
--
2.39.2
On Mon, Mar 20, 2023 at 03:47:56PM +0400, marcandre.lureau@redhat.com wrote: > From: Marc-André Lureau <marcandre.lureau@redhat.com> > > Do not attempt to move the pointer if the widget is not yet realized. > (this is reproducible with X11) What is reproducible ? Can you describe the problem that was reported by Bernhard ? > > Fixes: 6effaa16ac98 ("ui: set cursor position upon listener > registration") > Reported-by: Bernhard Beschow <shentey@gmail.com> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> > --- > ui/gtk.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/ui/gtk.c b/ui/gtk.c > index fd82e9b1ca..e9564f2baa 100644 > --- a/ui/gtk.c > +++ b/ui/gtk.c > @@ -450,7 +450,8 @@ static void gd_mouse_set(DisplayChangeListener *dcl, > GdkDisplay *dpy; > gint x_root, y_root; > > - if (qemu_input_is_absolute()) { > + if (!gtk_widget_get_realized(vc->gfx.drawing_area) || > + qemu_input_is_absolute()) { > return; > } > > -- > 2.39.2 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
© 2016 - 2024 Red Hat, Inc.