From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684653; cv=pass; d=zohomail.com; s=zohoarc; b=C2yC7VNVAQDFozuRWoj2yjWIUPeMh41uBIhN8ivwoHiVxXH7vYUc/1KyDzq8imL5/Cm67eMR8dVjjr4h4A3rCcdRYAlW1AT16YWpK/xs+2HnRLNEHkpO//gMwzhrYiCICa6i5WMHU8FNvlCkNwCtqrixwkxreGj85pxBobaC/ho= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684653; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=itgiaMnPBLOR3CeHaN1XXjuBBARZTaaBCB7OunrOsfo=; b=QLlIW9nlT+A4ccmuKsMObaS3RR3ZX2zvoj5k5dB4wF9dmvhajv02gTTclKmz0/b1UlTXWA0Ed8qYzc3lFPFT6U+27pMovSwX5kgd5A71j7ExrDlOUIR4dXYYrHE3leO4rTLWIunkNZVQscAoga+TEDing3YB8otmeaWaL1+ZHtc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679684653667884.860526110719; Fri, 24 Mar 2023 12:04:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmhp-00035V-Uz; Fri, 24 Mar 2023 15:04:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmho-00035L-KL for qemu-devel@nongnu.org; Fri, 24 Mar 2023 15:04:04 -0400 Received: from mail-vi1eur04on2121.outbound.protection.outlook.com ([40.107.8.121] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmhm-0003Xr-Vn for qemu-devel@nongnu.org; Fri, 24 Mar 2023 15:04:04 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 18:58:57 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 18:58:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nlO4E3U+583tQcCQ676B9yhLwVxWrYBc2S0u/lErceavUEuM75Ofw1wLRjQbzeMlvz8VVyArJoID14Pr3OFee/aUkbtjHQNeQko43iXuVLo494yI0VmixU2O8OAgg53IJ2UgZlvT+I9StEjWSH3r1PuM7L3IClztedDsx5Uq1Fu3aeGL9c9Kn5GAl0H07DH+waWSHRBQxXbArVL5MBA0tlKZm3EaJw5iT9mveNGHX/CVAqjzzvjbRB13NqwNEZZn4ASPLqjGDJjzw3ui+YNktqW89KPlCtsHcHxmPD9fmD32e88g48Vi7F3sf3qrMGqKkJl97SEJ/G8MgLetHr4hsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=itgiaMnPBLOR3CeHaN1XXjuBBARZTaaBCB7OunrOsfo=; b=F8RtRluaqowitwABGYOk35qtubM7/e8yopvWa8hBSItOBOx1JS2mYuUUsq4smvLU9FPq+ZKRAEd+tJ+HeHetOeQCJwgiwQKrTFfgY+RLMV+rNP9tIsz4DqiP6ICEITpnRcv5ydgHYRDSVEqRVRcSUbZ8m7m+fw1OlJUz0axXlviG8yfyQ25wrlEes0sLTWzzmeXQOQuNAWHiQ/dIKbX7JmsLF/OU3BL/3Wrr7jUt6qg2Jbcm4GlDIrHmxpzhNLxyMuaihll/Xm94vsanbYRuwZ8elYBpLNSXg2Z/10X8L0psicyselET3GV3d1BzObJAY0PxviV7gaDUlbiGm5VAmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=itgiaMnPBLOR3CeHaN1XXjuBBARZTaaBCB7OunrOsfo=; b=S55E33/Q9/VhQeM1zqgb2Lz+JKr9fynnkeReHc8SqDxoOZZyU7Uio5q6yPuzMxUZDwyyZo97aZZrrPJWH3TvCVCpi5weUbIGou44sLL6BfpSsQXU0FAo2fTxyoJtLpQxXRCSbvX8j3O3sXq5jCa/8muAC0+jpA2nfJujOPKY6y0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 1/8] MAINTAINERS: Add Sriram Yagnaraman as a igb reviewer Date: Fri, 24 Mar 2023 16:34:54 +0100 Message-Id: <20230324153501.20695-2-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0118.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::31) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: 6912553a-014f-4e93-25a1-08db2c99d0ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BAb+iY/j+1X81CcZeQ192LQrOs+LeF0JI2Uv+Y//+rE52PEAsKwpdI3PD03Cu60cH90NqU3na+ag9lA4+fi9tRErg9hOKkzr8Aoaw9HfE/I51hQQrsy1QUuqvPcMBs74akUaoCkOoO9GdO+ZgjYE50PKUVAkdw3EQtuXU9jqK5DydfRrdZlJM9wA3msKxAuaDWtVikReXIEFhMkKbPgIDy3Rg30JS9uC0lyB/4cPJv//bJvGbASOTy/6mqh5AnfO+mQURfdCe3iknWz53zXFCl7BkK1mOZCuZTRz8t/Qu8vJeblwiVUdnQm+ac3nH/04c47Lu+dZtq37OYGhxNGSK9/XHOUL8JJ1DqDsK/i/VrCjnlUFB+IFPOAIMqRxLdfSPOYt+UucOhbpBccTlSpwAvr4E8glXJ1CttK3NKKwymDGDHBwg9nRjL//7va/MJFGukbGir00m5pJXYlIroAfxa2/945UhMHHG9N5Vt5GJknjW87pnEdQ65pBEAQJs/pnoMlkbBGsI2mNDewN/9yM7I8pDK7gZ0QditysaP73UMFn/mTBB5yoaKpqa9e1Fzf0i6jkmrYaXLTtyPAlNmnuHiumjSgBmWr/SlIY+EhDdQ1i7hVjeSNMs68ic4fa6uu5jpfE2Hp8e0ldq6LCECTsQw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(4744005)(186003)(2616005)(2906002)(6486002)(6666004)(26005)(6512007)(478600001)(1076003)(6506007)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?cXrak5uwhaRpwjtbGlgmOPJkd4RJNi07WPcF1P4VVHdNGcN6RGbTdFOBH6fH?= =?us-ascii?Q?VQTrVFpTouHfd7YIoGfSQees6+LXq6K1kYynkPEQfzaZki9Gb4aLJLDuT++s?= =?us-ascii?Q?l43uZg/NqwgKIVYNAU1HJXl4/5iGI8HAYnkM3qG7DL1+NA2JAFt52m9HKU+/?= =?us-ascii?Q?rTQsB1a5ryLq0gOMDEVKw+BHdO1dw2SyvrQ5gDFgf9tbxZb3mjBxtJNOAj5L?= =?us-ascii?Q?QE1ZinRX9W2u8Lzb+Lz6Ms/CIMSVK3cu5hbydd/H0BHzXkOKPE941A7xG8+r?= =?us-ascii?Q?hIs6s3oe0dkcO2Kq3WPE+ypBQDXr6NCwCHxBye8MR3TEQcoUnx9Wj23uv2B4?= =?us-ascii?Q?J0LKV4qLDDzS8c2Ht3TQ27GiUAtMUq39CpnJBCDuV1SJugMBO2f9UGKhyPzw?= =?us-ascii?Q?fx0aj26a+n4Wtky3/yZm6nbxnnN6LfcPdtePjI2vHkNFvcqPHORZg89ps/hg?= =?us-ascii?Q?xx5dNxPf0b92bypTh8GR/1+FmRzVoNXg5kXiXNS1K6sKTuB/MCE+dv09eRen?= =?us-ascii?Q?oDEke2he77kUYbYXX7axv4wM4J0rDO68cR1koq0IFYxIIL3BoCCYY+zGXpaw?= =?us-ascii?Q?/F0PV2h2DA7zKc2sDy9MCddlRVUL39cvPglS4IcTq0tY331+SuXAd1YQLRFI?= =?us-ascii?Q?idprNzL2bvDiLBd1iv4Fbpe/d6AAJVmE6oLvEezosShebIzt1VcAAhGJnI8I?= =?us-ascii?Q?gPSVT8FKoIr9Qko4E1MaoRb60YRSQEnnaFjMpSwkrfRWmiKC+AuhLAl+1Lwa?= =?us-ascii?Q?oKPPr12xRtOw1ZN5CbJ0IpQpTOpWRsjzxxBRpXkv/jkqDA1Rtmc/SDNLzgpD?= =?us-ascii?Q?guxUSp5MF88mBiwdtEIUgfKsd2x22Hn2bbpzko1bFIb6qhY/5FUeIIAJrhj3?= =?us-ascii?Q?9VTJCZ3wK2nZzvzfLUXGnMicW7x7JNMW0iRr2z/E1bgnmWJEpe+afBv+LhdP?= =?us-ascii?Q?f8iO4dHnh+O+Hj7dLZB2tyEwVPrO4UXzyvAeMtHDw1p/+Xl65FSm2jD4C7Pl?= =?us-ascii?Q?jHu5Q9HNnKXoo16Rie4noNy7TVZQ24fh3TsqYwpDgEQLjYHnd9Qw7tubpmBs?= =?us-ascii?Q?1q+Hf7edPRXqhqnKOlKbhiPy00mM8u7bHSE0fp3GtpXlE3qSWBYLwG7TVTZz?= =?us-ascii?Q?lTyUs7LnEfFRfnghzXDUWIUxwCMYVhnPdRilrNBbNXLAr693xWztV1Mm71Ku?= =?us-ascii?Q?/j4jSeMQhvM57Z7I3xmuN2m0qYXNS0S9TNfVQQ/brs5UbL9l2/F0ApY9vhWg?= =?us-ascii?Q?YBRn/5RYXoynny4RG6Pe+vo3pMhvxnNm+5KZcZgqFUCzYvJ7tAhraS9EK/eM?= =?us-ascii?Q?HU1S93Mw5LtbpBVOBZduve3Ksu/Cd4TNySSKepU01SLTBQ2+AUOxkciDep+F?= =?us-ascii?Q?11GkEJI87bnvD1S1zOJmppvW4+WugdEmwcF2qOEaTvq+D8eFVANzLZBmn/gz?= =?us-ascii?Q?jVURwwbyG36UuQdKxLQmxPeqcHKtccgTM0YXmVJYR9PQ7MrrGuUlBIidjsqU?= =?us-ascii?Q?EzV36BYOgRvfrGiIcYprm2572u5INFQaNZiVkhE7t+hkBxTrGmKIKs8BkFEw?= =?us-ascii?Q?+x31oPptvRCrrM49WtTgh7To8Z96HxaHC+sLUFLyMkZ26Lwz6tpLBuicBvsV?= =?us-ascii?Q?YA=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: 6912553a-014f-4e93-25a1-08db2c99d0ad X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 18:58:54.6933 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EP795gg65/nxB3tLudQSx44u4lo3S4iXQKUb+Kcp7QqQRyUyBD0UDxQzAcCqV08wQDA9fyiaQJojRSd/ZxWzwmZzmpOIowlax0eae5ZCBrw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=40.107.8.121; envelope-from=sriram.yagnaraman@est.tech; helo=EUR04-VI1-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684654750100003 Content-Type: text/plain; charset="utf-8" I would like to review and be informed on changes to igb device Signed-off-by: Sriram Yagnaraman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9b56ccdd92..a9ed6143f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2252,6 +2252,7 @@ F: tests/qtest/libqos/e1000e.* =20 igb M: Akihiko Odaki +R: Sriram Yagnaraman S: Maintained F: docs/system/devices/igb.rst F: hw/net/igb* --=20 2.34.1 From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684463; cv=pass; d=zohomail.com; s=zohoarc; b=aKbh695oHlxhMQMwRkec/sJgTJfP4dBimoiIyLeGH7gAHn20ZFUW6h2ishkeloMlwmvIFVTI3I4OjuyziFqg3pEylVqW/EItzzzRs6jd/JG4j1ykFnMYAl4CpaxByHk83FmnAAAJeRnSPa5Tk7kBNyzjrd9kMTGTmGnuUwB1NJg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684463; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=EdlgwlnFnzfYfvZAmdYzfm962tf25lAKxTLsWu10D6E=; b=I6I9PGNnVOQxT3PlmGI/nufNIfA8jCoFpv41tML6TWrBRgJe5UzEIW27uGracYZcPbTPZxIB4Qb8ILAyNC4nRikQ6jA1/ci6rAkCqL9Mz3mIG1JxdWvOKlLCzVuZGKtdgDhSRlfY2OxKKcJ0y56zQpsa2nDz4xynTFalMkJFQKo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679684463642129.45720024883929; Fri, 24 Mar 2023 12:01:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmd4-0005rP-DD; Fri, 24 Mar 2023 14:59:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmd2-0005rC-Ku for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:08 -0400 Received: from mail-am6eur05on20729.outbound.protection.outlook.com ([2a01:111:f400:7e1b::729] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmd0-0002ID-Rb for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:08 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 18:58:56 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 18:58:56 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZXDYzvuIcn0aQD1x8DL3JO0FlUpQlDoKAFEdKbTENg1J2HUxSLMmOMtgWx2wyrLZeTfkzdUM9J12hW7nxALyj+ZlYfs8H5Nv2NSnJdfheLl8Uqai1TDML/+EuKAoUtXiUkxDeGFfgxD6yLQwtAuLzCuDDU4VWz6RA0mtC71ooAGaiw/5B5xRmE7xAiLXnMMZY0i65LmGcXqOoTDO62JNshVITbMvnCX8gpf9zOlLxDNdbC7MMZfRSdpq2InnxeNeIHw9fHu4gZQMs2ZFrrFQmWB1APx4/CHbjO/Gblvs9CyrX7aHod8qyfwfsKpH4NV8bxyNP2Az03WmFsdlm9rm4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EdlgwlnFnzfYfvZAmdYzfm962tf25lAKxTLsWu10D6E=; b=Sl4mJgLWy+GJMJDv8WOsS/vsnBHc5g7O+78WSQilezZzBXUy3lTRJWNr1RDzPvYzU9qxZfdvyscUr5cdkIjknIlimwvXIzmToAY/JEsbJDaqVbb9/XlQTUI5V/7CS/ddEp2nWqKu97a2iwKjH+/6BY3Wigi2MAr4te9Vkel1lPlqwImpqgw8lzPt+EU2CNRY8zMJVB+6UlLfqbhPh9MFY9PiX6/G6F9tVuT/qvT0OSUOlGQ8F/A3/spqTJ/9ZltmhMsmZRpEPb8e19GkdwIq9y0BJ8uL5dcMPdHaQJpoGSZlRbHHPHom8i4cHl1rTY6In082/oLIGvInGtG+AR9X+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EdlgwlnFnzfYfvZAmdYzfm962tf25lAKxTLsWu10D6E=; b=OQ1Qib7/+BtuAGn7vQT6A/J007n7cGWbAasDr1h00SyvBpM2VTRQMbWS8KJ/r3dfx9skd5mllUzhQp0qrivD96/HHsYQqrJE/EMp2ToKMfCWDEeJKacf04apkZJBjBidIz8gfmHiFrXr5EODAhK2+B+F8x5PHFa0ge6zn0Xw/NE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 2/8] igb: handle PF/VF reset properly Date: Fri, 24 Mar 2023 16:34:55 +0100 Message-Id: <20230324153501.20695-3-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0119.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::20) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: 55807f87-b93b-4ffd-25a1-08db2c99d0ad X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: gYOrIiW9hE588lL23hNg91pI2eAFc9pF7bqM3oZucDfvGLl8BlO553L1xXCuecMPMuURJlTw07/ZLt/Tvy5GcjpZDc8TJC15qElG8vr+RMdVdlTiN9PfAXPmeOCXLGPcYxEW96M7PAwpKmD6ui5AH2xXpho4eyyxkUr/U7sQSzNZQHTiEBP6Ssb8T5Tq/Y/IW6u2AEsOBO8LoJPSvOttxuZcyU0EZ5E/9jkHruSYWi8A95Z8eJHoGr/KJbleoM+w8sGMGzRNx/Kyfm791dwriqR6zCxuNp5vFYnk2F5y7nAmbXqezDGoZB3H9uUuK6+yAPKhQUg68xP+Xr67iBP85f+Q7HLkjoCNbrDeg0eFhDhhplLv1SHeQ7J9nqN6hyyGaU7lt+LiDfN6RAPpe9k0SC+iI0GkEzjcX7QDz/8nw9zSoZs0dmK7P05VdLCufP2tCXh5P+ttzb3DioKOWgu3gWZfnss9RXVjkiOCpY2y8qNqjWF3rtJEQG4HSP6bsULpsN1q0WeRA3JbK9BQXQvBCR2paZWJldvk4T4t2qhW9HGzGosiRZ/ZBO6zQni4VZLaan9j2Wh/w/DCQFv7W8zpD5ZdhUCdvgZzCMvuOC3OiDMtgvNnd6A2Ruem1IxQ/v0pzouOWg0ZfEuRQyQ9gW1UwQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(186003)(2616005)(2906002)(6486002)(26005)(6512007)(478600001)(1076003)(6506007)(83380400001)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Fy+DBXT5cRrio1PihKY2YJ23uW6GX7VC4xo4+mtEdqeMm8UqYZV5n42lTpdz?= =?us-ascii?Q?yte9YJcpFvd3z66Gq1lCIzPOuPHv0W+A3S0nqvzj6g/uPEC9BfiNAi3EUV4y?= =?us-ascii?Q?drDsrhSFPYK7pESRN0jkIaPwYL5MkkvGMMK4yndkDEMxnhhFolaUDNS668Zm?= =?us-ascii?Q?1p9fxc3noQRfc9tDaXceES8rxeFokYgR/CpYtPgLEg+IwA8A4DE8wRg6CXU5?= =?us-ascii?Q?/Nagt7UXuGzJekJGPEEdkbf5NxUKK7Y9av0wJkTzOUoXDfFLvDQv/k4INMyx?= =?us-ascii?Q?5h1NC8y41dAmXsV/sprxQukKusMmbZunjKeLgWsm1wB/K5vCGwQ8O8synbvC?= =?us-ascii?Q?57NCBmr8Gu5z9/8Nar1g9pcOqNpftO3VIxq2IQ0Bel9tGlI5o6wbRw34GNBh?= =?us-ascii?Q?qvRgeovMZ0du+pVCMDKiN2FPRVcbyCYwp//Gt8jbVghLIyXL/8xPtBEwYdF8?= =?us-ascii?Q?/G/q8qYIbx+aKz/oqpBGscmRjRBZypnljWVvLkLD9xcWqYmkVk7sXzF7NdII?= =?us-ascii?Q?4CW5Nk+RwA7oJc7zWQuJXo/3RyL0feI2iAhkCg11wZr+YswCO8hw1bt4wQZp?= =?us-ascii?Q?TD0CwZzE0O7PDsBvPdgQaTywrPgZWyJ7u6s0zw95xQK4Rw02xv6gZXdvFDRk?= =?us-ascii?Q?nuuWdQ1thOC/dj6P/CoZhnLN5TAh14LfDnsJjNCm8mMpJAY7wagjQDO/jgZL?= =?us-ascii?Q?1TSOy9fdLlTxMxEeWeB2+tjVAhXqQsU4UXgY8zzXQQYBvVwNtSfG4oQ4/VrX?= =?us-ascii?Q?fmPTali5eDhjZSm2ZJNsGeU7kCuuxCkiLGBs2m1qgQuNiMr8mBY7nNORan9S?= =?us-ascii?Q?E0q7kgDKTDRWPYz8eviP4r4nGg4RGqceHIAiK4wPn8Lx2roeCU2IAiEG3mjE?= =?us-ascii?Q?sY4dYqDDSFQAI6uzu9GA+yQOPvOqbb40YgJxz213SHwaidHIxYh5AIAk4p2u?= =?us-ascii?Q?JtM8Qm75f6TM7o+VhlqS/tGqrWigTjb9ylfj/9e17cp5aunzwygK1pImiQLz?= =?us-ascii?Q?h69jwmXWSajUPrTyoW+3qpuvF5vaLzn5lNvB++5zdRV54KbUEgpp2Laj0wod?= =?us-ascii?Q?Y8Cqhr9P1DvBsQS2gZpiX4jEBqPfG9dVQQJ+263i+Cry1JBXQlgyzbJwWKYj?= =?us-ascii?Q?gD3Qgwv2pzcakaSvO4QjsE6RoAZ6ypLu2u2Z3QWf4r2qEsFDUQYU4+O0F/77?= =?us-ascii?Q?pVoK/utffarbwLXPv2MPyfoMhFWC/G5J+zPeUD70PwNrgTxfAgVidvn3WL49?= =?us-ascii?Q?SXdeaIcYhi4mSF0tbOh7hIcf4Rtx+pApHVhUGNxO/Plxxtgjtv8L2qlTavrB?= =?us-ascii?Q?tt2iI0D6f2U35q94t3G1kqF2IXZ351jKiSEsyQjtr8pyZyH1c53W/TAcEpI1?= =?us-ascii?Q?pft1lp6VVP1P4beVsJ88kzRzL+lfw9JqOTmRUUh5ARCSWhGEb7S0kOA169QM?= =?us-ascii?Q?7Aq5+PtLMEEXyyoc/PuWpcpq57SDfkDk9i2MfQmNkQMCkOXH8gGOw8mu/IQj?= =?us-ascii?Q?AK50CMEy4/4GTXud67Zq97RBpAbdck5hgHh+7nNuUVTi8vXTkpHTwwRTdt7T?= =?us-ascii?Q?W184e4TdpxBmo5dK9lB/6ipn3gy+nhnQbvowEhsYVxe5vF+CmIoiNvRMK3EK?= =?us-ascii?Q?dA=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: 55807f87-b93b-4ffd-25a1-08db2c99d0ad X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 18:58:54.6777 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a6tlcDKIDoeQLhBfpPcuuk7vdiie96Yh0lS7z03TpGeBaTlafdhaNXjT8conPGkLNF32XjDSdHI/kv+cRgDLlJRDLKJ3hcKvcS7s+9+9ln8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1b::729; envelope-from=sriram.yagnaraman@est.tech; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684465633100003 Content-Type: text/plain; charset="utf-8" Use PFRSTD to reset RSTI bit for VFs, and raise VFLRE interrupt when VF is reset. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 ++++++++++++++++++++++++++------------ hw/net/igb_regs.h | 3 +++ hw/net/trace-events | 2 ++ 3 files changed, 31 insertions(+), 12 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 78d30738e6..6ba9696637 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1898,14 +1898,6 @@ static void igb_set_eims(IGBCore *core, int index, u= int32_t val) igb_update_interrupt_state(core); } =20 -static void igb_vf_reset(IGBCore *core, uint16_t vfn) -{ - /* TODO: Reset of the queue enable and the interrupt registers of the = VF. */ - - core->mac[V2PMAILBOX0 + vfn] &=3D ~E1000_V2PMAILBOX_RSTI; - core->mac[V2PMAILBOX0 + vfn] =3D E1000_V2PMAILBOX_RSTD; -} - static void mailbox_interrupt_to_vf(IGBCore *core, uint16_t vfn) { uint32_t ent =3D core->mac[VTIVAR_MISC + vfn]; @@ -1983,6 +1975,17 @@ static void igb_set_vfmailbox(IGBCore *core, int ind= ex, uint32_t val) } } =20 +static void igb_vf_reset(IGBCore *core, uint16_t vfn) +{ + /* disable Rx and Tx for the VF*/ + core->mac[VFTE] &=3D ~BIT(vfn); + core->mac[VFRE] &=3D ~BIT(vfn); + /* indicate VF reset to PF */ + core->mac[VFLRE] |=3D BIT(vfn); + /* VFLRE and mailbox use the same interrupt cause */ + mailbox_interrupt_to_pf(core); +} + static void igb_w1c(IGBCore *core, int index, uint32_t val) { core->mac[index] &=3D ~val; @@ -2237,14 +2240,20 @@ igb_set_status(IGBCore *core, int index, uint32_t v= al) static void igb_set_ctrlext(IGBCore *core, int index, uint32_t val) { - trace_e1000e_link_set_ext_params(!!(val & E1000_CTRL_EXT_ASDCHK), - !!(val & E1000_CTRL_EXT_SPD_BYPS)); - - /* TODO: PFRSTD */ + trace_igb_link_set_ext_params(!!(val & E1000_CTRL_EXT_ASDCHK), + !!(val & E1000_CTRL_EXT_SPD_BYPS), + !!(val & E1000_CTRL_EXT_PFRSTD)); =20 /* Zero self-clearing bits */ val &=3D ~(E1000_CTRL_EXT_ASDCHK | E1000_CTRL_EXT_EE_RST); core->mac[CTRL_EXT] =3D val; + + if (core->mac[CTRL_EXT] & E1000_CTRL_EXT_PFRSTD) { + for (int vfn =3D 0; vfn < IGB_MAX_VF_FUNCTIONS; vfn++) { + core->mac[V2PMAILBOX0 + vfn] &=3D ~E1000_V2PMAILBOX_RSTI; + core->mac[V2PMAILBOX0 + vfn] |=3D E1000_V2PMAILBOX_RSTD; + } + } } =20 static void @@ -4027,6 +4036,11 @@ static void igb_reset(IGBCore *core, bool sw) =20 e1000x_reset_mac_addr(core->owner_nic, core->mac, core->permanent_mac); =20 + for (int vfn =3D 0; vfn < IGB_MAX_VF_FUNCTIONS; vfn++) { + /* Set RSTI, so VF can identify a PF reset is in progress */ + core->mac[V2PMAILBOX0 + vfn] |=3D E1000_V2PMAILBOX_RSTI; + } + for (i =3D 0; i < ARRAY_SIZE(core->tx); i++) { tx =3D &core->tx[i]; net_tx_pkt_reset(tx->tx_pkt, NULL); diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h index 00934d4f20..a658f9b53f 100644 --- a/hw/net/igb_regs.h +++ b/hw/net/igb_regs.h @@ -240,6 +240,9 @@ union e1000_adv_rx_desc { =20 /* from igb/e1000_defines.h */ =20 +/* Physical Func Reset Done Indication */ +#define E1000_CTRL_EXT_PFRSTD 0x00004000 + #define E1000_IVAR_VALID 0x80 #define E1000_GPIE_NSICR 0x00000001 #define E1000_GPIE_MSIX_MODE 0x00000010 diff --git a/hw/net/trace-events b/hw/net/trace-events index 65753411fc..d35554fce8 100644 --- a/hw/net/trace-events +++ b/hw/net/trace-events @@ -280,6 +280,8 @@ igb_core_mdic_read_unhandled(uint32_t addr) "MDIC READ:= PHY[%u] UNHANDLED" igb_core_mdic_write(uint32_t addr, uint32_t data) "MDIC WRITE: PHY[%u] =3D= 0x%x" igb_core_mdic_write_unhandled(uint32_t addr) "MDIC WRITE: PHY[%u] UNHANDLE= D" =20 +igb_link_set_ext_params(bool asd_check, bool speed_select_bypass, bool pfr= std) "Set extended link params: ASD check: %d, Speed select bypass: %d, PF = reset done: %d" + igb_rx_desc_buff_size(uint32_t b) "buffer size: %u" igb_rx_desc_buff_write(uint64_t addr, uint16_t offset, const void* source,= uint32_t len) "addr: 0x%"PRIx64", offset: %u, from: %p, length: %u" =20 --=20 2.34.1 From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684526; cv=pass; d=zohomail.com; s=zohoarc; b=G6dsxPICgA1yYr2TUbIzMuGQlwJ8Z1Z7NLpp+s+xoGQ39cF5kZv682snRz0d65et5h/SKumDI0Edx+WjAI20Ud5Gd7QJU4UgaxLNAzkSWcGbCDX49uyKeHbZd9+usRUvIwVU1QE8eQhRwHTEHDvryPBp+iMZLPZAgjOpzHjvxoU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684526; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=d5j8s7q6DgkB0IBldXGQq8X2/Bdscwa+1Yo5hQ5yQYI=; b=fQ5ZwWrNuuvblY4qFGlrcLV/SljN+Wolb52WiRXTSSrnKCz+Kf1xg11zb/Po0RcdQ9LThLW6yPo5+7yyQYvuAv4Y0WFQaYyArMZaPhceWBM3f46PKkWNPCYBv2U8XAYD3FLaZnfr/KsIWOlm1qULUjvPUK/ifkZuJR6SB2SpiAQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679684526394728.2726318753037; Fri, 24 Mar 2023 12:02:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmfg-0001Ti-Q0; Fri, 24 Mar 2023 15:01:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmfc-0001TA-GG for qemu-devel@nongnu.org; Fri, 24 Mar 2023 15:01:48 -0400 Received: from mail-he1eur01on0726.outbound.protection.outlook.com ([2a01:111:f400:fe1e::726] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmfa-00034J-Mj for qemu-devel@nongnu.org; Fri, 24 Mar 2023 15:01:48 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 19:01:10 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 19:01:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZrSmGgo8Z3NZfK4yZv6IYLAcB8Db++7TZ9rPoVTp7yQIIUOpOb6A4Ynib84PDySQd5y9ug7Ikz/TSjF9PhaB3/u1GEheo/PDcxMELCPXG3vfoZSWjMYV/x6DR7kF7ydiLjcmEQVD2NjzWoMlXMsXn2qYsiPp2t03CDxWasKBqiJDqKJ6M0h6cHOxzl3Eg5YtJmg+d4S3lWTiH1jH4OgOR7SL2Wv3esjGYNtKYRpkc+3RoveyFLMUndLTlu/J+8rsaMzRvh5+fgmBN39GhQ5C/c7K8BOuzpkyYQc+nVtoc7VpsLLO3uxMCv/sfy2DrFzw1OzTfE8tGt/r2/gbxObx9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d5j8s7q6DgkB0IBldXGQq8X2/Bdscwa+1Yo5hQ5yQYI=; b=BgkK7UVTz9eA3WkAIM1fzVjP9Xnv4hiY4dMP05vrat4aNdcIdPDwUszPBGXQVb+/Z9aG44K4ATLPK1EndEkPhEtqw4tDtM5WH6V3elTVgUqnxyx4O9GpT0vyiBjo6h1tRz5Qfblz0uTk/AyO+H7AxRFgbzq/HbXKfwSAMZ7tfUImXOm+6e/lCoTnUVvtb5Wq852VXihOT5H4BdcDx4HcVEEyZXOz0NIhbsBSUqAVDBF8MqOGCWvFIV23dHFn/s2j4Ux2jQC2pKPBFbE6U19joN5UOOCLh8xL8xUmXKy+j+SMyrgGpq66m8xA1yb5VTl04uM8Eb1vWh2zvf5+HG7bYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d5j8s7q6DgkB0IBldXGQq8X2/Bdscwa+1Yo5hQ5yQYI=; b=SZI1GEISCGGu3CdKZsO7YH2vimUuQnRYmYDizZ9Tmnd+/EesHpAZ81yCscpYmADHHAocoLuO/GZwGOqftXOoL6nZjfQn5+HM4d9bNMJL8R7qDoo54RttruyDlgoF+o3dvp6T9iRXR/d1fvPwqAz2Gbihqllms7UzQlcyWQXdQKk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 3/8] igb: add ICR_RXDW Date: Fri, 24 Mar 2023 16:34:56 +0100 Message-Id: <20230324153501.20695-4-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0062.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::18) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: 6021f18c-767d-455c-2365-08db2c9a21b4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rfrGs8N3i1Gm5aTSkvWxJN3Sw0hj5N2Nlm4D+HaQif5MYphRw05J65dPua5e48rLkILCoRoAN4yjpVh+rcLV9wgOr/f6hJSPcL8VFeYxDPmYG47HJBzdFwJb5ga8eYdl1dMDx660AgQ66PbI9YPY3FoOLVS/tp2z0CkY6wLSQRd2rVlSbwh2Q5uOY4L8uBhsRGi+k4HxrKfCXh1D6ubyT/7C8Z5W5pIuuUpQ7VKhpzntcYPTe93LYC8EulCf/i2d/9KKHeuoLZLXihiVRZ7ox0dLjHP5iaGDtC7WWRxOOp7qnYgyqKJZ6vzgRCeHhcpFqGqeyRweximGg4kkIVstovqZyZ5dGLHbZ24JjkReTLdYSjMNlCjDfL7v6GVDWP+DMScZSXN+DxDQ0aWr/+yKNM/Qyp6u87bm9h6bFfFMAw8fUORnxAVlPvQ6USvoPoGTuXFFNB9Kahrs+sYgE1RidW2RdVGNzZHJsc9M/TOc9ilitbCiY1VVLC4OQ/s9TKLwRMlTqRi/MoaKTOqXDYIVGgtp6DWhcMbs3XtZWhS8roj1+/2LlZ+0md1bjnbXUYmA5Lg3B5zOdmZBRVhLfCEwBFQB5uugM5nPToD/Bit3x8R8KHF3Ao1ksHxQIrwOJsMIqGa5S1swJGBcWq56Orjr9g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(186003)(2616005)(2906002)(6486002)(6666004)(26005)(6512007)(478600001)(1076003)(6506007)(83380400001)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?A+OoxQi19RFofYULTXhAbK6o8dsy/TZVcnZmybXYC5zvbrleEGMjHD7aXdTd?= =?us-ascii?Q?LRqepa9N2SzjGVwdAvSTR6sBgJJ8PVlSEfbcTt+tM4brA8DmvFgvUhSQCgXb?= =?us-ascii?Q?ATcv/R7+rIwcJIs7fYDpJC6s+uIO9CE6Q5HRze2hQhBe3GzlJmoiYC5N8bLS?= =?us-ascii?Q?VSTuAXurInhnABs1gw0ej9lty1rvZLnQor4de9ArnW7HOyt4sES71D/PG+GE?= =?us-ascii?Q?bNgK2dBi5w5WFv/vL9MD3Fo5J0ql4+bwwVsj0dK5hK/Q+9B3kztxQOThBAEQ?= =?us-ascii?Q?trIoq5RRSk7WRzCNQFyF9YdgTH5Z7mEkzXr9aHbgIddi8/OWvVhOl5VegoD6?= =?us-ascii?Q?c+/QIsL5vG4nnm7CEJeEvJS4AsGB/liCS0LxPD2NXOIngifqX+lX6pbcl3hc?= =?us-ascii?Q?0QPChRavYK1PtD+Vhd4grXveKO46PjkBWaMb94AxPOQ2DmXjEO6rQV6McZ3/?= =?us-ascii?Q?4cBK3Bi6TlQ60WPvcRz0rYUyPRlP16prtcziUJwJ0kfs+bvZw2X3rrEwgAN3?= =?us-ascii?Q?5z6nR5H+R9sY9FZv99h/WS6EL2CSq8HYTCANfmCzGnixturKgHpezHUJla3H?= =?us-ascii?Q?a6gcFHxCvRg3qtaj0Ujj8zgc1JNwctKyui6NWlVEMa1GJtYWvxfcjOP024/A?= =?us-ascii?Q?M0tRtuyBeEsarWEZj63N0liMCPoSCPSGZPFBVKBLs0W0j9+UiFlWDICyPbj8?= =?us-ascii?Q?dVbgx5LCML/94MRt0LffUutHEq6r3KZGGlGiswdjhHVjRxZwbprYoeQeUCcQ?= =?us-ascii?Q?SHCVli7i/G+ZX+WR7weQcLlUuPmMdxYl/m6+9vdabn795JIuAc/jvjxJKLYr?= =?us-ascii?Q?uyu93I+K5dA8oq6ub2jpWzCFpFK5PToSakLFa6NSvha+oLqD9aj2UofYB4FB?= =?us-ascii?Q?+N9G23kPmkJX0hbFfY/PZXFF7nG3RZcG4hRJLUfVqbLbNZXZkGN9XTXgwL8N?= =?us-ascii?Q?c8Qgne5kjn5dUzdW6sYrBkc34V+WS/iJFyWtJVuC7XiVZmcVuRX5Ts0Od7FK?= =?us-ascii?Q?1eg+Od+cH2w6ht7N1d/rdYrRjgHVefr4GMPoSrhoXftyBaJYdUg5NJIUDcUB?= =?us-ascii?Q?1gG8krQj151hWLosnImXc+CB8zkH29F/JAN1msL9LKi3eKVC7wg3HUgD3gHs?= =?us-ascii?Q?zvT43cf896yabNRKefRglCxWasmOITjEZmF8k1/+dCF5Kn5FTsuufFdua8YI?= =?us-ascii?Q?Fvi75e1Rtxh9QsPyBxdLVAVxcDRXHSvkDL81GmVjA7MMAT93y5//xYy+OU7H?= =?us-ascii?Q?l3it/S+B4O8ndGBfzuoGvwkjjJaciCBTr6Bw43OSIR4HdoYMEFQohz4ZGN87?= =?us-ascii?Q?6T3jHGCSJ/YoFNciEeavAO63z9oscDAbZDtTKXZsdPevBBKFxkUJGRPTtIAp?= =?us-ascii?Q?v1we/e9dFnK1lUX3akJqiCkwYiIm/vqRxPUbA7YVcGl4Q5CiXTBkNTDs/9qz?= =?us-ascii?Q?FPa+jszpP4WSjWkvpANQF5N60IHnvI32gnJCwbXS9U3DDN7eKGqVYo04IIlW?= =?us-ascii?Q?euP55zmXONDZFMJTDZbK6FkXZcXxNf2L3IPJ+UcnXOgjHOzmnbjlTTvvTDaD?= =?us-ascii?Q?bMWNHuQQmyIET/x2adoRqaJ4rQGacQFZSqRM9t7oH7xpzLW6sKNwIH65WXQe?= =?us-ascii?Q?gw=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: 6021f18c-767d-455c-2365-08db2c9a21b4 X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 19:01:10.6358 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ri6YEWUtSDvctXlBMCl/cdKeNvsKBY7IxhdMwBn4E5QsxFR3E5WEHYJBc80DVMoWP8ehEnYrSr02mtBuI7n6E0ObU1Sf24W7Lcm6pYRllhI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:fe1e::726; envelope-from=sriram.yagnaraman@est.tech; helo=EUR01-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684527799100001 Content-Type: text/plain; charset="utf-8" IGB uses RXDW ICR bit to indicate that rx descriptor has been written back. This is the same as RXT0 bit in older HW. Signed-off-by: Sriram Yagnaraman --- hw/net/e1000x_regs.h | 4 ++++ hw/net/igb_core.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/net/e1000x_regs.h b/hw/net/e1000x_regs.h index c0832fa23d..6d3c4c6d3a 100644 --- a/hw/net/e1000x_regs.h +++ b/hw/net/e1000x_regs.h @@ -335,6 +335,7 @@ #define E1000_ICR_RXDMT0 0x00000010 /* rx desc min. threshold (0) */ #define E1000_ICR_RXO 0x00000040 /* rx overrun */ #define E1000_ICR_RXT0 0x00000080 /* rx timer intr (ring 0) */ +#define E1000_ICR_RXDW 0x00000080 /* rx desc written back */ #define E1000_ICR_MDAC 0x00000200 /* MDIO access complete */ #define E1000_ICR_RXCFG 0x00000400 /* RX /c/ ordered set */ #define E1000_ICR_GPI_EN0 0x00000800 /* GP Int 0 */ @@ -378,6 +379,7 @@ #define E1000_ICS_RXDMT0 E1000_ICR_RXDMT0 /* rx desc min. threshold = */ #define E1000_ICS_RXO E1000_ICR_RXO /* rx overrun */ #define E1000_ICS_RXT0 E1000_ICR_RXT0 /* rx timer intr */ +#define E1000_ICS_RXDW E1000_ICR_RXDW /* rx desc written back */ #define E1000_ICS_MDAC E1000_ICR_MDAC /* MDIO access complete */ #define E1000_ICS_RXCFG E1000_ICR_RXCFG /* RX /c/ ordered set */ #define E1000_ICS_GPI_EN0 E1000_ICR_GPI_EN0 /* GP Int 0 */ @@ -407,6 +409,7 @@ #define E1000_IMS_RXDMT0 E1000_ICR_RXDMT0 /* rx desc min. threshold = */ #define E1000_IMS_RXO E1000_ICR_RXO /* rx overrun */ #define E1000_IMS_RXT0 E1000_ICR_RXT0 /* rx timer intr */ +#define E1000_IMS_RXDW E1000_ICR_RXDW /* rx desc written back */ #define E1000_IMS_MDAC E1000_ICR_MDAC /* MDIO access complete */ #define E1000_IMS_RXCFG E1000_ICR_RXCFG /* RX /c/ ordered set */ #define E1000_IMS_GPI_EN0 E1000_ICR_GPI_EN0 /* GP Int 0 */ @@ -441,6 +444,7 @@ #define E1000_IMC_RXDMT0 E1000_ICR_RXDMT0 /* rx desc min. threshold = */ #define E1000_IMC_RXO E1000_ICR_RXO /* rx overrun */ #define E1000_IMC_RXT0 E1000_ICR_RXT0 /* rx timer intr */ +#define E1000_IMC_RXDW E1000_ICR_RXDW /* rx desc written back */ #define E1000_IMC_MDAC E1000_ICR_MDAC /* MDIO access complete */ #define E1000_IMC_RXCFG E1000_ICR_RXCFG /* RX /c/ ordered set */ #define E1000_IMC_GPI_EN0 E1000_ICR_GPI_EN0 /* GP Int 0 */ diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 6ba9696637..9ab90e8576 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1583,7 +1583,7 @@ igb_receive_internal(IGBCore *core, const struct iove= c *iov, int iovcnt, continue; } =20 - n |=3D E1000_ICR_RXT0; + n |=3D E1000_ICR_RXDW; =20 igb_rx_fix_l4_csum(core, core->rx_pkt); igb_write_packet_to_guest(core, core->rx_pkt, &rxr, &rss_info); --=20 2.34.1 From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684392; cv=pass; d=zohomail.com; s=zohoarc; b=iaxdEmYoBJJ54E2+RSV32+Kv0fALYzFVox7EI+TBkb0EmHyBL4vBVYjTVszlZs2fe9jt2WiY1kL8hl+mMCSiKa5ienmByV6Nb630bvP6bS17BPGMsFnfqCjVehY1RbNI0vSnBE2vxCOZL+D3p1+98CRcdlJTNEFmRG9C1Vv1y7Y= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684392; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=wbBMtpj8FYd2Ki/VRN/suTF2u/B5rtMbbWK5nwz9bhU=; b=CjPrCZybgZwTyx5D40UFQOo4ZVePBTd6jpkrPgLhHnS5+3DkNt1ubHa0fCxL7m0a2aNzb96fZx3Yk4IymJf2ubwB2AAAuCWu3pWjHzBk3X7NL5KFzWZVXOV6ApLYx5dfVY3Esn2XQcHj75eybwYkcj5Loe9jigJUl18fgXOh4KY= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 167968439256564.44093485666008; Fri, 24 Mar 2023 11:59:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmdE-0005uC-Rf; Fri, 24 Mar 2023 14:59:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmdA-0005sx-GS for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:16 -0400 Received: from mail-am6eur05on20729.outbound.protection.outlook.com ([2a01:111:f400:7e1b::729] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmd8-0002ID-Pu for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:16 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 18:58:57 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 18:58:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sx5XqhGB4mx+Etb4eURUwmhhU02otPF2KLsRzGOk9Pgfgc9LGB6p/RL51Es+q23snlZQAcaU086+7DEZYUVuS8CHM6Y0FFkQWyyy+R5uunsF1MOSSoUgIIYd7t7bXNOa/Sleh1VPcpzZV3Q6OpqvHFfFcvYU3mviFRZJ5LcrTXnDzgtHKgb5OaJcoc383Z4LdGSzFd35n46HNTDChkEdQVDKk8Q6x2NHsnml6pOrziOhq4G5tsIibC6y/5g7WNeVf/XwK/xALZpPH+9qUfVR7f+woMNUfvGORCpaLqFTb83wtOFok5aB7bOPZaZgDG0laGqQyCjNubc2DHWpIV9rWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wbBMtpj8FYd2Ki/VRN/suTF2u/B5rtMbbWK5nwz9bhU=; b=fBrO0VRBFT2bxPKqFP/dOg5J6Zx5G5vzjblyUvFE/L4zsq5Zcm/6tTCKwh54SDcekBxxzXV9qzli8qGqFsDEaEixLlSc07H9f1c/egB4j4NGblxhaZv1BBBfsqDnO8EyjzG12nC52nCLHN35hP3qUapCRJosIbXWC/S/S/ahJMiv4YMzg7KvnQZF35E+lN8tNGuygy02t/gi05wCw+FVCxx2j56iI1FpV4EpwFrD5LU+9Iwg+wd1WQkPbbQaeLBcXK7hnPWf6HYgevtqtnaTcLUIwQJj7LDXlROtMaVZF8dH2enlG+do7cDBxLj7JK8/WT3L60T+wjzvT4+170AhBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wbBMtpj8FYd2Ki/VRN/suTF2u/B5rtMbbWK5nwz9bhU=; b=hco+ITYwVEyEz6FMHixpK+OyQCH5Kcsuoq04FlquQwfIo40K4r0kbzCARdVHLDlgXkabdzQLslnrL5AJgOhZ0trwzt+e2vCPlDJmXf2SuE8mNMjwZx+ERTFhIX+9fw9Wfhy03ut/ht4SRUdgKMu/utcNkOcDX0gWF5eVcIuyE2E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 4/8] igb: implement VFRE and VFTE registers Date: Fri, 24 Mar 2023 16:34:57 +0100 Message-Id: <20230324153501.20695-5-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0100.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::14) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: c718d75b-4ed0-48a0-5e1d-08db2c99d0c7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6uoCor2MR5EMmbP0RfwpO1sjvoQeZGmiBuLkQw7MVdlP6XVFslzdZ1KO3atFVxzkIykCsSM44GaRrm+5HXvhOR8J3RKQw6Usw768DXpaWBzSIRDxELpZUCk02vHBIUY3kzk9gW6eSdkr5fEYfgU+6GIPnUKGy0rRmCqlNzjM9eBwLcCi+R8zYax8JtwYokYcxmF7yIBvTqgq1mwTAtRvZb2K5NgD6KwrrDyl2+YjoOUzf+95XmZA2GOjuYdREkkG3F9vV72Pqf6UfazDFPHdMkcvYVeSV+Z5bGLlKkZITQGcZgIA6dSLBDTEBpmi+ZWsPKnhvmRoqhnNVEWWCFVZZ6wtLgeIUJrnic/8WRa2aC7asR5ZFhN5bTDAGIBQc7+2lisOcnSvkdGXLXTGsZvuoPuHk99FpEjsHbTHOTYr4r5PkfyAx/1tRkO6SVKLMFzpB7xM0ulsd9vUGsmv0UIn94GG7G9qfqeFFj/c4RqZFJSawt5Ui9GoPx2eDdQQ+yJiTvOmnpRr3Xo0p+04YMggXdRCu3BKZ6oWmrmbAhx1fTWgz2riFfClXrY272QMb0TGyt6l59rTE5/1kyAqDGXgcPGhsFFgKwZLwIu73EyLovZoFKPPRy0kFpKec59TKWTO53h0Q3F8SOkSbjvMGO+T+w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(186003)(2616005)(2906002)(6486002)(26005)(6512007)(478600001)(1076003)(6506007)(83380400001)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xWQJoBd4T2POgRj5s/qWh+5OXOL9G0RI7sT6+D0WUAVikUJfOuRDVNhd3p2m?= =?us-ascii?Q?//wke8Be9bv0MYcY9ZDpa5vHl35LuUblxb8yf0yH/GPWZjLMrl+4ACV1Kf9q?= =?us-ascii?Q?r3jgAsP5UyEwpZQXrbGsZvhy9C1x9PtaUO+lALxw7PsxcGIxQN4lYNNhak8f?= =?us-ascii?Q?MAO8Q/aPA57kR4nTk5KgQmaRD+6+I0hwy+zsDvMjQPe8XZiDS23QvqYeUvwk?= =?us-ascii?Q?PoRrz1hJsjQIGpRk3MFtmZbfbqgAAiOrCMGA/7wiw+rP8j1LKrkY9nuStqaM?= =?us-ascii?Q?e+UKrxdMkjhemmReY5HL2OFzdk4Tk0Z8D1wD1rAsN19QvvuYSXOlfXklIupZ?= =?us-ascii?Q?Tv4M5oid6WxQqNOv+2YPF31/w2ZSP4pZJ11tus6WctGY9422zBoeI8h4c4/E?= =?us-ascii?Q?HBxucacA7CcUEZYf3+B4uoRhXAXKMeAJIXD5ivSLWp1eGLDYantJMV0xfeaS?= =?us-ascii?Q?VSm7x+SrO7swziWm6X3LpBmf/5xIkRwxwWWn3QyQ+yfN7oLkYFsmGSRi98mS?= =?us-ascii?Q?780P3ujkB9vuG6JRS8k7yGNhSnEcJUpzrGGUkv0Y1R1yV8Vthpx32aSwhFWz?= =?us-ascii?Q?XFF+s96em+KXtbE8imi0GKPVmysQ48NtTSUsEPNkr9/hcnOGbw1pzcRqLEve?= =?us-ascii?Q?uo3Rgu8+sW2EsQ598OTYl1it8os20KdLv0zMAq+Ko4ZieI5RDqscAAr80eya?= =?us-ascii?Q?8N0qbTUvxMUhxyoJGhOjGgNbNaNZ4WdJBGaxuYOVyXraTBeK5cl97FFMQiuH?= =?us-ascii?Q?dzCefQsGa+TS5mbOE+sjtLvq6fAml+e2A7WsjpVByJ43gozbwprVfz4wuqmg?= =?us-ascii?Q?IlmEgSdy1HWKylh/Rk3NPnIbyu4UYxJEfF/dJj+HwnjyPnByPZOvM96wyIa0?= =?us-ascii?Q?wMGnRpFlawheH2cMsEB2yS9lIR3SaKJFLWVCKekOIZevaOl8mrCJZyE6axGI?= =?us-ascii?Q?68LRs6cLeOqKGZ5DcBamu8k2YjFAYpkJGl2x86L7qQzUY11fRo9nOWe9U10m?= =?us-ascii?Q?ZdCvnOIMdhuT89zsuI9DSQPSTnOQ2XDkVaLBZqpANA6eQNz/on7uvrLwZL8M?= =?us-ascii?Q?0Wn1+sFBzTwBlAICCp2sOeNJJIOjiUUQcDX/Fsh8UoP/VcfC8V+/CjrrMy4m?= =?us-ascii?Q?Vnbwad8L5hl9JQi7Y8qr9YWzgajRpLfR73QsLjkf00pKC3cTTz/3Y2zhw+Uq?= =?us-ascii?Q?ngZmylLKjzrOAxA5SOQLaXu4RxyFlylTo5S4tl/Ofk7tNsnY/EWTkGTQjHn5?= =?us-ascii?Q?4xCXpFxks+i1x1YnqMeuteoevz/pbbQC3VBPX3FHnZgovp1LT9iLrYfmYT4s?= =?us-ascii?Q?UsSjd8kQj2eZrUr1G4HZHnvMuVaETwV2OdlzM2S78FE1RnTXUB4c+Cqy9DQA?= =?us-ascii?Q?m2wAWm0uJmJYqn7bBCWsv9FOh8vzOIEiJlWF1Bax4oX80ObnZH63LC53hHy4?= =?us-ascii?Q?PolbB8tnmK6/gZPhfYUzFJ2av4bhm4mTUSpTTt/EnmgGT7Fcj/pld74/WtzL?= =?us-ascii?Q?D7Zqnp/fJSwaZex9qG8KRcAgEXAbmzz6H0NJZe2i6akN+5KOXrSEZPtl3iFy?= =?us-ascii?Q?gS5Ch+yBVfy8gD5/ynuJ6b8wNwc7iEbuu1cznRhD9Z1SvcWH7Dz/0hIgv39o?= =?us-ascii?Q?SA=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: c718d75b-4ed0-48a0-5e1d-08db2c99d0c7 X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 18:58:54.8340 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L3HP5TAD5t6wETcWLPBOeXCS137q7qQmnKKVhURb8Kq8RwM0WKNs34oAWVNvXcPzmyMf8N3Dz0UfjapFhokIjDGFKLC23sTVimkIG3qZTbs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1b::729; envelope-from=sriram.yagnaraman@est.tech; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684394504100007 Content-Type: text/plain; charset="utf-8" Also introduce: - Checks for RXDCTL/TXDCTL queue enable bits - IGB_NUM_VM_POOLS enum (Sec 1.5: Table 1-7) Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 38 +++++++++++++++++++++++++++++++------- hw/net/igb_core.h | 1 + hw/net/igb_regs.h | 3 +++ 3 files changed, 35 insertions(+), 7 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 9ab90e8576..753f17b40c 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -784,6 +784,18 @@ igb_txdesc_writeback(IGBCore *core, dma_addr_t base, return igb_tx_wb_eic(core, txi->idx); } =20 +static inline bool +igb_tx_enabled(IGBCore *core, const E1000E_RingInfo *txi) +{ + bool vmdq =3D core->mac[MRQC] & 1; + uint16_t qn =3D txi->idx; + uint16_t pool =3D qn % IGB_NUM_VM_POOLS; + + return (core->mac[TCTL] & E1000_TCTL_EN) && + (!vmdq || core->mac[VFTE] & BIT(pool)) && + (core->mac[TXDCTL0 + (qn * 16)] & E1000_TXDCTL_QUEUE_ENABLE); +} + static void igb_start_xmit(IGBCore *core, const IGB_TxRing *txr) { @@ -793,8 +805,7 @@ igb_start_xmit(IGBCore *core, const IGB_TxRing *txr) const E1000E_RingInfo *txi =3D txr->i; uint32_t eic =3D 0; =20 - /* TODO: check if the queue itself is enabled too. */ - if (!(core->mac[TCTL] & E1000_TCTL_EN)) { + if (!igb_tx_enabled(core, txi)) { trace_e1000e_tx_disabled(); return; } @@ -872,6 +883,9 @@ igb_can_receive(IGBCore *core) =20 for (i =3D 0; i < IGB_NUM_QUEUES; i++) { E1000E_RxRing rxr; + if (!(core->mac[RXDCTL0 + (i * 16)] & E1000_RXDCTL_QUEUE_ENABLE)) { + continue; + } =20 igb_rx_ring_init(core, &rxr, i); if (igb_ring_enabled(core, rxr.i) && igb_has_rxbufs(core, rxr.i, 1= )) { @@ -938,7 +952,7 @@ static uint16_t igb_receive_assign(IGBCore *core, const= struct eth_header *ehdr, =20 if (core->mac[MRQC] & 1) { if (is_broadcast_ether_addr(ehdr->h_dest)) { - for (i =3D 0; i < 8; i++) { + for (i =3D 0; i < IGB_NUM_VM_POOLS; i++) { if (core->mac[VMOLR0 + i] & E1000_VMOLR_BAM) { queues |=3D BIT(i); } @@ -972,7 +986,7 @@ static uint16_t igb_receive_assign(IGBCore *core, const= struct eth_header *ehdr, f =3D ta_shift[(rctl >> E1000_RCTL_MO_SHIFT) & 3]; f =3D (((ehdr->h_dest[5] << 8) | ehdr->h_dest[4]) >> f) & = 0xfff; if (macp[f >> 5] & (1 << (f & 0x1f))) { - for (i =3D 0; i < 8; i++) { + for (i =3D 0; i < IGB_NUM_VM_POOLS; i++) { if (core->mac[VMOLR0 + i] & E1000_VMOLR_ROMPE) { queues |=3D BIT(i); } @@ -995,7 +1009,7 @@ static uint16_t igb_receive_assign(IGBCore *core, cons= t struct eth_header *ehdr, } } } else { - for (i =3D 0; i < 8; i++) { + for (i =3D 0; i < IGB_NUM_VM_POOLS; i++) { if (core->mac[VMOLR0 + i] & E1000_VMOLR_AUPE) { mask |=3D BIT(i); } @@ -1011,6 +1025,7 @@ static uint16_t igb_receive_assign(IGBCore *core, con= st struct eth_header *ehdr, queues =3D BIT(def_pl >> E1000_VT_CTL_DEFAULT_POOL_SHIFT); } =20 + queues &=3D core->mac[VFRE]; igb_rss_parse_packet(core, core->rx_pkt, external_tx !=3D NULL, rs= s_info); if (rss_info->queue & 1) { queues <<=3D 8; @@ -1571,7 +1586,8 @@ igb_receive_internal(IGBCore *core, const struct iove= c *iov, int iovcnt, e1000x_fcs_len(core->mac); =20 for (i =3D 0; i < IGB_NUM_QUEUES; i++) { - if (!(queues & BIT(i))) { + if (!(queues & BIT(i)) || + !(core->mac[RXDCTL0 + (i * 16)] & E1000_RXDCTL_QUEUE_ENABLE)) { continue; } =20 @@ -1977,9 +1993,16 @@ static void igb_set_vfmailbox(IGBCore *core, int ind= ex, uint32_t val) =20 static void igb_vf_reset(IGBCore *core, uint16_t vfn) { + uint16_t qn0 =3D vfn; + uint16_t qn1 =3D vfn + IGB_NUM_VM_POOLS; + /* disable Rx and Tx for the VF*/ - core->mac[VFTE] &=3D ~BIT(vfn); + core->mac[RXDCTL0 + (qn0 * 16)] &=3D ~E1000_RXDCTL_QUEUE_ENABLE; + core->mac[RXDCTL0 + (qn1 * 16)] &=3D ~E1000_RXDCTL_QUEUE_ENABLE; + core->mac[TXDCTL0 + (qn0 * 16)] &=3D ~E1000_TXDCTL_QUEUE_ENABLE; + core->mac[TXDCTL0 + (qn1 * 16)] &=3D ~E1000_TXDCTL_QUEUE_ENABLE; core->mac[VFRE] &=3D ~BIT(vfn); + core->mac[VFTE] &=3D ~BIT(vfn); /* indicate VF reset to PF */ core->mac[VFLRE] |=3D BIT(vfn); /* VFLRE and mailbox use the same interrupt cause */ @@ -3914,6 +3937,7 @@ igb_phy_reg_init[] =3D { static const uint32_t igb_mac_reg_init[] =3D { [LEDCTL] =3D 2 | (3 << 8) | BIT(15) | (6 << 16) | (7 << 24), [EEMNGCTL] =3D BIT(31), + [TXDCTL0] =3D E1000_TXDCTL_QUEUE_ENABLE, [RXDCTL0] =3D E1000_RXDCTL_QUEUE_ENABLE | (1 << 16), [RXDCTL1] =3D 1 << 16, [RXDCTL2] =3D 1 << 16, diff --git a/hw/net/igb_core.h b/hw/net/igb_core.h index 8914e0b801..9cbbfd516b 100644 --- a/hw/net/igb_core.h +++ b/hw/net/igb_core.h @@ -47,6 +47,7 @@ #define IGB_MSIX_VEC_NUM (10) #define IGBVF_MSIX_VEC_NUM (3) #define IGB_NUM_QUEUES (16) +#define IGB_NUM_VM_POOLS (8) =20 typedef struct IGBCore IGBCore; =20 diff --git a/hw/net/igb_regs.h b/hw/net/igb_regs.h index a658f9b53f..c5c5b3c3b8 100644 --- a/hw/net/igb_regs.h +++ b/hw/net/igb_regs.h @@ -160,6 +160,9 @@ union e1000_adv_rx_desc { #define E1000_MRQC_RSS_FIELD_IPV6_UDP 0x00800000 #define E1000_MRQC_RSS_FIELD_IPV6_UDP_EX 0x01000000 =20 +/* Additional Transmit Descriptor Control definitions */ +#define E1000_TXDCTL_QUEUE_ENABLE 0x02000000 /* Enable specific Tx Queue = */ + /* Additional Receive Descriptor Control definitions */ #define E1000_RXDCTL_QUEUE_ENABLE 0x02000000 /* Enable specific Rx Queue = */ =20 --=20 2.34.1 From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684555; cv=pass; d=zohomail.com; s=zohoarc; b=TXxFzs+FX79emx1Oc8qzurkDFrzHwsF521kGRUEeXGfXYSJD6uFQysOcdQvAjYV3iUD6WnpSQ27AnZjl7/FiS3VVlbHU5qo8F0qq114OdkiH4r6tJNiUSTDZZMS1V83h2/o4pQuJKtLAztHnXB+BXYWbyRl2CuARI0ffBf9R6nU= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684555; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=npij/M0YiYbD/I4U8XgJdMzejWTRN6wiqD7L+2mvBx0=; b=PXYRKK2J1acEVpeTRM/TKGA8lA7IRnx653qdkBHoI78iou7/JAdrtmOYGBb4VTtNvdcanOBqR4q1V7nasw5fzBhHQEsKZlAYWgG4bcnMCXikzaqZst8v+A3PqFm4jIBDC1S++eNQ5DXOtyem7Elk79TKMPDQ+g4OS5fx1SMnMbI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679684555337550.0936287903448; Fri, 24 Mar 2023 12:02:35 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmfi-0001W9-6b; Fri, 24 Mar 2023 15:01:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmff-0001Tg-1N for qemu-devel@nongnu.org; Fri, 24 Mar 2023 15:01:52 -0400 Received: from mail-he1eur01on0726.outbound.protection.outlook.com ([2a01:111:f400:fe1e::726] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmfc-00034J-VV for qemu-devel@nongnu.org; Fri, 24 Mar 2023 15:01:50 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 19:01:11 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 19:01:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W3cyKPMj2PTNk0o9PN5D4Q0ZNOKTEwRPKMKKpV/FLJ0DdCk6ANBne3qOb8k0GtstIVJxt21YADvCdyk2/1XOBq+mJeukrgMOo+SQxXFp0qDwNz37B4OAgU6c5KAPH2sVLfZYCW3cnrDk3MtJLb1gCYKGYDoNCurwV33+OqOB94CfRRKp5aKrSR8/Yar3ckU4lED1BsInM9JjAlaQq350rNSKgAsy40IK0wooRwnbQL7Eb60pSqdv2nFcVeMHWYCWPJAKrL/WRhNoVH/fidnaTQJZ46rcq7JxOPNI62NKe6jqgYkiqLk72RzbHbBeHDsp02t5Y+xBk82c52N1OtJDsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=npij/M0YiYbD/I4U8XgJdMzejWTRN6wiqD7L+2mvBx0=; b=oB1EPJUskn3tPZbrHHHO4Ngg0HPI6LaMMzAM3GXaQAc1tnAxooIMt6BAbVicG0fgDoEFzRaVIm9Q0WnKPeWNn6w1V7BTcxMXINIt9Ywz8DMtWYhGNbdPMfodWtORv/L6PTPiMgII2xvoVncQ7Yfb0rA2roL/KxLvdtCR5KsGOmlyNgpDcgkWHwS6qhTHoJI9jv81npo1OrsTY9dzCAVteyEyAB6DgdBGVNv4onSKVbIZ0K574KF7BF/e5ODcHeHu+tRNdSf30ktAoiAdVh95Uc8Yr8RND2eC7jqpnXMqUg64vXXsDaeYcCK4XsJg3T1LA4KKvgFzseOmOtcdt0XDHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=npij/M0YiYbD/I4U8XgJdMzejWTRN6wiqD7L+2mvBx0=; b=bySyEgwErmDOnsCDCnbAtuM+dK0b0rrUYDcHH8fx6mXV77M7VfDqkRSA5RtDukIkM58xohLXaKW+XY/gi7iZPKKhMs5l0R+OKKhAAKK+OnX/TFcJeGzITM6vIWPDDByIag80E1fcSau1nqE0Gxp7TusU0LmUNl3IrcD0r8yXnMU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 5/8] igb: check oversized packets for VMDq Date: Fri, 24 Mar 2023 16:34:58 +0100 Message-Id: <20230324153501.20695-6-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0062.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::18) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e96fa52-3b0e-44d0-f8cd-08db2c9a2221 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QNa5tkHJ+zTE50SjzP/ciYIbdW4//CnHJqsEwXwnMyBH55bTdQlHl6zQfjuIdD6k8GhtueMYJTQ737PtlmAbCrW6c/s1GgZ3pHnHE1leVffsn8Az5QyR3E4MbswVHAtR2+wF4UugCJxeguPqD8yPiUydsMjAaKrZEzTeEY1bXMAJ5SjaY/pjF//0bM5thtYb3eiFN9MHL+5oqMQ1cmMtx8QyGakVPXvakuvNs2yE94HmukRhbEjc9kXFwMvmN9ZJSXHEtnsGHUR3WaFWTUEy2jNsp/fw9LMdQO3lYH4ANONI7KeCUAZvMxS8oiusWRnba0G7e/IKO15ZYqUgW53w5nT/HLB2lsu4K2jzFIeQFWMtgcDukSGizTEbkavtkZVEtxcVv/+R82xWI25ZKHfMB2yacJ3IbYF0am2evni0+bO/aBr1Nfzbt95Acz8Ux3RTQJ6JUBf+0vovlnlUCePJP1mL7MNU8aEfLju/mJ0U28u5mgRx1qDpeXYUcOAXeuGGb11X6eMIcM5aztMt1qHxIPlB7wUIhCrOtJLd8iqFxchXxgxUzt53xguRNFLbgu6JAP133QVsThQE5OEkMK0MPt985ekdRN4BcixIvgWLLMPsIMVzBViIsBWN56Y9nGSM/T9gatposBkSriGDz//PIg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(186003)(2616005)(2906002)(6486002)(6666004)(26005)(6512007)(478600001)(1076003)(6506007)(83380400001)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oMaacRQTJg5WO9VJ8IpK7VQr30ilP7LaZb/8Rn2OZm/lx++gEF0EtvEboH4N?= =?us-ascii?Q?RX43X3mq6RqZ702TF9rB9Ua3u0H7QXg4LM0XL4vD1fj6IN6/InkWj/rbVwgb?= =?us-ascii?Q?Z9QAN9eKELdYW56FgUGnh3S1kzeN+QClg3Q5210vjJv0Bp4o248KiTCQlHcC?= =?us-ascii?Q?jlkwmTohYnnY292oX/y8uts7bFN9JpfMGeH+THLgGOL0qGPN4jVzv0X+TzCA?= =?us-ascii?Q?3pn0RCgNXIc1AqTndiYVV6rHTxXs28ayCGnEs5oGe98yaXz4M4UxXq7mZ5hS?= =?us-ascii?Q?MeZemQHHi6O0Bq2fWrGrMpSlEHR6Im0ki/iQldGA2ettX5vibqxg6wV8n98S?= =?us-ascii?Q?k37+C+hE0E3Czn0Is4PwxY3qQKNd1FHq05+GXwcvxccdILy4G4gnS6m/TCl2?= =?us-ascii?Q?R7+mziDfA+TybBATnShfTfTikTisSJJ47/ogg3208mrQx8EFYab/lUsf+hRr?= =?us-ascii?Q?0QJqxnkwgtCVAJlTPAdlCDbrCYYZuIWrAxDasQ/8C1tTlGN5y4aVUdYJ6K/Z?= =?us-ascii?Q?qIQS79ENcgzOBmzKH5j0DnlcmZJKZg+vERMS020ophDy3fE6Lr/VgT4NJBgE?= =?us-ascii?Q?Thr6M7gH4Y3Av2u23iPqtZXrl1jRT/nGPnzoiD+d3sB9+USl9UnsMQQ+10ht?= =?us-ascii?Q?Da7kD1FCdKxm74an5Bcl8gtSCKhyPlRkyM3ORv+b/PyJ6YivfRtLI756CfUJ?= =?us-ascii?Q?F2UmWn3P6oLdRvna4Zi4dyMVDGudsWpDAdmi07eEzPbUhLdTglt5EAbh3Ee7?= =?us-ascii?Q?dJC4tTOsxCbT75n29QI3Kz1E5b/UTFQhapgbZjJB9nXClh3Vz+bKOmMDWLOI?= =?us-ascii?Q?A/7IB9TXK4vyn2Y/mcdodxJT8sdxxw4qm6XCIODaHP+YoTDL3zf3vHkU4BYh?= =?us-ascii?Q?pvnPXEACSKjdgp/ADd0B4CD28AlcMnXyhiO3tKuesv1Mh86njlQHw+rJl61d?= =?us-ascii?Q?IZ1NDKkakIs2CMUinosjn/uvW2GsFbZpnORtwN+QCgAzc0owre3ygzqSN4+H?= =?us-ascii?Q?zd/Kpw182dsBH86LEc4GcZPALk+ZB/+vbEqqhdkKTfTVwu1N6UIuWYEtmVpz?= =?us-ascii?Q?r8GCOlP3KC932jQgfPAABs1/IpjSl7wmY5uFefGX0A3pc/8Hu6HT67/79qRJ?= =?us-ascii?Q?xihEzXGvF/q5PA7RR2TKCOO/+rtz3qmqRzf7bUsDGovYyRSbX4/dK3uy5+NV?= =?us-ascii?Q?QoxlEzmaH6q0RCeXWjKC46vsJLBBsc/3TlyiwzMUihd4ddjx72Dl4/qwUxJq?= =?us-ascii?Q?OdOxf9xlbgHEf/SI2gtv7iSNJr2UukfrV2GvQNTgwuvjoIcNzOZPZ3o/W0gt?= =?us-ascii?Q?nBjK/h87G7S7npjAM0vpHKHMurI/YyI5mbn1+AWLg26GYWkWhFG3IMF3gV7c?= =?us-ascii?Q?EWB/6GNvKXQA4GdKeCmHHR7ErsWIg1vfqt+VZlNY7yECP2Ou+rN/rK0wSFaT?= =?us-ascii?Q?tP9dDLhg+vRUmwc81BVqJMiXJWkgNMG2QWAN5oHAL+6KTVMsf2c03Xl8yOeb?= =?us-ascii?Q?JljOO4M0CM34alYblxZD+FuzYFGF4o/sUjrgO+vQpkGQHK4P6UWRGqsD4SQ+?= =?us-ascii?Q?eRa3zPh9a55IRyfc/+7tc7MQdAnpMWYsV+o+41tMLk4rFSLPaKVDHeqFKqpS?= =?us-ascii?Q?oA=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: 3e96fa52-3b0e-44d0-f8cd-08db2c9a2221 X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 19:01:11.3544 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: lkz6y9P/cRQnmeevcFVJhcDj47o2OtU5OEieK00YQoXp7mwLUG6QiM8cCWUClWkJYcFeJgTiTaKgOVKBVFEK85CeaS5X94wIr6OOhlQJnr8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:fe1e::726; envelope-from=sriram.yagnaraman@est.tech; helo=EUR01-HE1-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684555871100001 Content-Type: text/plain; charset="utf-8" Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 41 ++++++++++++++++++++++++++++++++++++----- 1 file changed, 36 insertions(+), 5 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 753f17b40c..38aa4596b1 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -921,12 +921,26 @@ igb_rx_l4_cso_enabled(IGBCore *core) return !!(core->mac[RXCSUM] & E1000_RXCSUM_TUOFLD); } =20 +static bool +igb_rx_is_oversized(IGBCore *core, uint16_t qn, size_t size) +{ + uint16_t pool =3D qn % IGB_NUM_VM_POOLS; + bool lpe =3D !!(core->mac[VMOLR0 + pool] & E1000_VMOLR_LPE); + int max_ethernet_lpe_size =3D + core->mac[VMOLR0 + pool] & E1000_VMOLR_RLPML_MASK; + int max_ethernet_vlan_size =3D 1522; + + return size > (lpe ? max_ethernet_lpe_size : max_ethernet_vlan_size); +} + static uint16_t igb_receive_assign(IGBCore *core, const struct eth_header = *ehdr, - E1000E_RSSInfo *rss_info, bool *externa= l_tx) + size_t size, E1000E_RSSInfo *rss_info, + bool *external_tx) { static const int ta_shift[] =3D { 4, 3, 2, 0 }; uint32_t f, ra[2], *macp, rctl =3D core->mac[RCTL]; uint16_t queues =3D 0; + uint16_t oversized =3D 0; uint16_t vid =3D lduw_be_p(&PKT_GET_VLAN_HDR(ehdr)->h_tci) & VLAN_VID_= MASK; bool accepted =3D false; int i; @@ -1026,9 +1040,26 @@ static uint16_t igb_receive_assign(IGBCore *core, co= nst struct eth_header *ehdr, } =20 queues &=3D core->mac[VFRE]; - igb_rss_parse_packet(core, core->rx_pkt, external_tx !=3D NULL, rs= s_info); - if (rss_info->queue & 1) { - queues <<=3D 8; + if (queues) { + for (i =3D 0; i < IGB_NUM_VM_POOLS; i++) { + if ((queues & BIT(i)) && igb_rx_is_oversized(core, i, size= )) { + oversized |=3D BIT(i); + } + } + /* 8.19.37 increment ROC if packet is oversized for all queues= */ + if (oversized =3D=3D queues) { + trace_e1000x_rx_oversized(size); + e1000x_inc_reg_if_not_full(core->mac, ROC); + } + queues &=3D ~oversized; + } + + if (queues) { + igb_rss_parse_packet(core, core->rx_pkt, + external_tx !=3D NULL, rss_info); + if (rss_info->queue & 1) { + queues <<=3D 8; + } } } else { switch (net_rx_pkt_get_packet_type(core->rx_pkt)) { @@ -1576,7 +1607,7 @@ igb_receive_internal(IGBCore *core, const struct iove= c *iov, int iovcnt, e1000x_vlan_enabled(core->mac), core->mac[VET] & 0xffff); =20 - queues =3D igb_receive_assign(core, ehdr, &rss_info, external_tx); + queues =3D igb_receive_assign(core, ehdr, size, &rss_info, external_tx= ); if (!queues) { trace_e1000e_rx_flt_dropped(); return orig_size; --=20 2.34.1 From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684390; cv=pass; d=zohomail.com; s=zohoarc; b=KzFxYCR1xcl6aAKnVQosJ1bZbPGuRTpTY6KTkz3UatPigm9UxGEfdkFze2NqrgugVXrM5Zy0uh8qSfjh7rX5tYuQjdFP4MVa2WZAvONXOhxfwH+J2BsEFX4/Za+xD8UB3oH+Cj7bussAAP6PUEQlQRd+g9GHweqM6n7qC+Dkwek= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684390; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=NdvzBXNgxJy6TqWUHB5WSZYF29QYHgnkWv6O5g2F1YE=; b=P/rkmKTPcWSoF8Yr2hwg3BiqWyMi+4TAgTYzUpYW+06FiclMs8At+cBypMazvNov2eyCmKKovue7SiSrjjbsBxORqEREFtArOaK2W/5xbF4pqanuSRfsPq7TTp8NFMeldqkSiLHDyrAoqtCre+5VzLWt+8cBZQnz/NotIIXDxNM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679684390563432.62285783705227; Fri, 24 Mar 2023 11:59:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmdE-0005tx-7k; Fri, 24 Mar 2023 14:59:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmdC-0005tM-4E for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:18 -0400 Received: from mail-am6eur05on20729.outbound.protection.outlook.com ([2a01:111:f400:7e1b::729] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmdA-0002ID-Pg for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:17 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 18:58:58 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 18:58:58 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XDJwEVY5fmSXi1IMBWQL12Zfx6fsKtFQkKpfsYyxuvKoN4bcwJb3CXGoBsAK8e46XQ7dp4EvaD5m9fcmRI9uDH3ANG1Yy0XTJ7Uc0no5HcaWx29gLG2gk6e5MMnVqOy+UYMWxTqbHJsOT1g4dWGRhYluUd0tTE5XjioFj+XkxpZNDeRoBUOl8D5hH1iyguScZq6s6YPEYe2gZcWB3QXbNqlSjad3+3hDtS8q/OCD4VynVQQgjtX+9dN4IfB4zy48MzL3TGmn+5Qj7T+eEB6fAoMUsNxeaOn8IFOFu5cXyHSu2NWWnGx1yBa3eHbZUZLq1/GLg5h0fk3QWICv9kvUCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NdvzBXNgxJy6TqWUHB5WSZYF29QYHgnkWv6O5g2F1YE=; b=bZbOBme6wy1EJ4pZmgJiJVqvjmrnTyoRmWmk9f+M5pKl0ao/Avq4CgaVtSg/E+1GscAH689boBofqWdC1AQs8oxa52v5dv1ge17VcrdgXa6/xlIokEBnFDg6fnhwjDrLsDAG1KaOQwHB5HKuEWLqR5qaTh2MShgOLyRPwA+ca8Hf7wZivguLBKRyggIrccr9c2MreJLc8D6gYNmS/6fFZFZgPLZOREI0UmRElYxY7gnGdpWANfa3MwTqEeZkAzlL9cqh/WcV14JzFamz5hX/y/2NDqKY2XiAEbHBLPETJn3zLjN/6dMr6ep7Nyr5L6UXNw4FhnmnJV7RbnHa/GH+Pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NdvzBXNgxJy6TqWUHB5WSZYF29QYHgnkWv6O5g2F1YE=; b=Bo8XsITbpaAswj1aUDNf3HCyc5F3TA9skapqACS/ub7Tr2v5RrceAzmjlVb97qt8+1fx5FBbYbt9vt+EbQGL60PbJPw93Qy7modWuUK9T3YeagVI2394MCyC7bVUsgZELp2OWhrWkxoCkDw2FcArMK0hLC4z7+cEryNUEVPZ0Eo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 6/8] igb: respect E1000_VMOLR_RSSE Date: Fri, 24 Mar 2023 16:34:59 +0100 Message-Id: <20230324153501.20695-7-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0096.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::35) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: f6eabe89-ffdc-4b8e-4347-08db2c99d111 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A8cYBiZ126hF+eN5WtCUWxpBElI4ueVO/JnUL8jSMDPAqgxvXzAx1xihnUSQxYEK4i43FqkME1WzDcS+o/UH2cxWoTBYkKlcttgULb68q57IrIRmJWxOvYtJj7RzQXSYA1GcMxO7B9LRrUO2ULTG76D3qUkW27qI7Mx1Xa0FA+8FC9Z34lKo/ja9QXA4cTElkHJMhsQRLurUJXksDmIUoYypKpBTy6t5IlS15jFNf18oFRtlIbhNewenlMJuiiStF6fm0Fxrr0fBpMxwZrG3TO2C4mh028DWRE4fRGrZx+wWacSkn1IZfxJwi9HrSpVr9aHSvaq9+w8l3aKgCzkOV3LXFdxtonHeDYLxVqafcS4hgvJVsAAak2b/STfYFoYbIUwUGk40HNnAM1lu3tDHHyhn7Okabp9gNIDRNykVSPZZZ52i38k6Gra3jtVHz/BxQoU8aSoBUS/GpYoM9iuuoM85FNb1zQ6S2ztQQj/Gzs0v3M7cntsxjiuu/Q5Gx4f7j0mYWEdhrQN71D+x3cNFvyXlq3WlB98GtypldESAkIEZiIfpmlu9m4QdM8Z/Lil6p5xW/odliAui9jdjBDwmGb8A8t6Yt1zrn3lp7kFdW7K7NPjzcqVqmhMRkVLQvHnhIfyCpL+FIFIQGXtKO91qVw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(4744005)(186003)(2616005)(2906002)(6486002)(26005)(6512007)(478600001)(1076003)(6506007)(83380400001)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/V8pFMep5zRnbhKnL4eveZuItG/XYn/t5AKt8nbnIfZacbaAEUVw2FrLXrir?= =?us-ascii?Q?wD7CEopMFK2vM1zuLmw8ZDNxIjZYO63qqS2vP4UmKT3k1y5ws1e36yUiYzkb?= =?us-ascii?Q?FlL07QTDLTKW3wK3BF0mPo+zsQ4jBOzL6LHmAX4S/qi1PqKt3ZT9IX7Tm3wy?= =?us-ascii?Q?UW7W+Bsgg6rI2eC7p0Qxz+IcEW+ypD5Zabv37XL66u/NjywV2OmwdQVWR+zg?= =?us-ascii?Q?FJZaHcab0XVTEU9r6SvMIBhwCXxDd1+/7W5mm+Vyo9ZN+MA2AlUjP3sTX5FF?= =?us-ascii?Q?bwwJE4/YnHQiUoU38E6W5WtFywp2t5noM/uXr2pCvcrD9k7/pj3DcSW2OEQA?= =?us-ascii?Q?w74NNtoW5S4ldlYabaWq/NxEewa5VWMyFCJZ+917l+YAXXCsOy1cJHYKC5k8?= =?us-ascii?Q?H6GPN9sE/jpte9jRTg1COSplxBU1Zq57CiEJeYhTH9e9AWT+Qgc/73jVyziJ?= =?us-ascii?Q?DD+U6WqyMra39PQAkbBL9YuuL93HOxswt28zlVXmqQm8KdKSZ6ZSCiCHmT1M?= =?us-ascii?Q?Dn87Kxc4+BI6ZKcMFfK8j064r5Ih6Qa9EiMV/uQZwSVLONq6zlhzlxz0KIYW?= =?us-ascii?Q?ChV+vvhl+KLwfDXdx+fDQ55LYLhE/sFtrDulpdJByCclwg299MKWqaJwu+Vl?= =?us-ascii?Q?vQ9VUhgH6TN68+w3X2eXi4liSpQpZ9MVhWPq4f/NmkW7fZdxP6uiz9yxr0MP?= =?us-ascii?Q?ilLHJwSq+zPbKlB/NN8X6tSIBOyZag/Bx7EaWY7CSi9/aseUzDUc0LTJfhs1?= =?us-ascii?Q?t/NqNE/uC9A5WHXo9niYl3kItxACH3Cd7sh9tU/aq/E++Yy4BpchEr8enR0z?= =?us-ascii?Q?YoMBhnWqkuDhKunggnlUeJLaDoO1iD3IzTwkNOcF6pawT8+MFo8YUrkvz3mR?= =?us-ascii?Q?0dvDB43uZJY6hiQKDsOG3vlZ7kO2VYUPlNPo74XLQlkwo4CK7Sl7I9uRKq/M?= =?us-ascii?Q?L7Tb6gzWECTUbRh7nQpOkaZcQr8vIQ0fhbdtmeFZMdJEZjT6ecjWJg5LtnGI?= =?us-ascii?Q?XK3M0TzTuxfc0gsh5s/YQ1e9uHjWaoP2iwf9rm8T0kDhFrUR3DEckEjnIiqE?= =?us-ascii?Q?dOo3P4p4KPpD0iTahmc9WFYwWWZaaFiyW/naqhRlLD3qj3V5HW65izm54T+n?= =?us-ascii?Q?2RlKG+VA0R/edImf+GxBCRXO2I5WjaOgpTIJRZbNhXuS9+U9bdzmiAdz/jwM?= =?us-ascii?Q?MP/fT+YgEQleOHmVG1zrHuPVYclgK2cNvCunl/LyeRft4BD76vLLOifXEcw9?= =?us-ascii?Q?K82fSnb7OeZtzWuqsLMTvLCuORZh/ilDmRXk6M0F1wuPCP7SAvdojJJBCt04?= =?us-ascii?Q?yf8VgOHyhcbqihGT5gioPorjfSYDZQ+LZImePd4RNKLKtnE/sX4YnK69pEfT?= =?us-ascii?Q?o5j755cTzHN+7tZs31EU2j6GQW/dIgMGz2us4UD28QEnvw2JN9SIvxs02UrG?= =?us-ascii?Q?vv7I0ktl7bkgd1UwHA7rLOytjgdOsO7HDwJtKu0t0PXxGiObPv3Ffv+ITXUr?= =?us-ascii?Q?bJ/KwLYOC7Hrou5VNEAohjj42gQ2ZWVjkFFJ6wIigJcjvZ3U4hMPVJgqKvpF?= =?us-ascii?Q?9JuUx4jDldAU/DkFTzhvJA3XdaIZAekKSLzYG8tpyrlTTt2HTQqGLL3iFIgh?= =?us-ascii?Q?Hw=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: f6eabe89-ffdc-4b8e-4347-08db2c99d111 X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 18:58:55.3494 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: acqekhUjILzHqBp/xU+/JqUOLIhyjZu6M86rTxyJ2Y86vF4FbxaLTHPKawneU7Iqn/hkszr94NBE5zjQu5Uf+oMLaeNqzuf7AW9nsDvrb2s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1b::729; envelope-from=sriram.yagnaraman@est.tech; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684392766100001 Content-Type: text/plain; charset="utf-8" RSS for VFs is only enabled if VMOLR[n].RSSE is set. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 38aa4596b1..fd61c6c550 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -1057,8 +1057,15 @@ static uint16_t igb_receive_assign(IGBCore *core, co= nst struct eth_header *ehdr, if (queues) { igb_rss_parse_packet(core, core->rx_pkt, external_tx !=3D NULL, rss_info); + /* Sec 8.26.1: PQn =3D VFn + VQn*8 */ if (rss_info->queue & 1) { - queues <<=3D 8; + for (i =3D 0; i < IGB_NUM_VM_POOLS; i++) { + if ((queues & BIT(i)) && + (core->mac[VMOLR0 + i] & E1000_VMOLR_RSSE)) { + queues |=3D BIT(i + IGB_NUM_VM_POOLS); + queues &=3D ~BIT(i); + } + } } } } else { --=20 2.34.1 From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684415; cv=pass; d=zohomail.com; s=zohoarc; b=KeKwQZ+tJoqrN4ysNsovxyk9k0GQGaELUoE6qzowxto7iwELA4Hp0+T6VCVtJ4hdqrKqrsoyB+l7szGqnx0UC8UJbeG1E5KAUFCzhrTSx70bXR5R0lfsvcfi5hT2pfISAYFVHrIcccgnIZdaIsFHvw0o7POSHHlLZjqA+Ox/u7k= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684415; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=PEEjRzKALsH8Mu6wUSgfNEoaeCf4X3DidEO1qINXbKU=; b=FB6RNGz+C/tr3Hh4w6XrpwX45Yqcue/V7gEW707j7DVX8np9MyOVPDnFvs7eEGrvgeXxzbTLPJgz/d35GBdYxP0WS9e3xqEty0hsxCzNETlN6v5CQsP577yqXVMtf9qxaNWX8+PmDBkLYdmgVHcBnqT7vBmlw0RAF1VTSuKbU7I= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679684415313331.95523647157313; Fri, 24 Mar 2023 12:00:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmd8-0005sc-15; Fri, 24 Mar 2023 14:59:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmd6-0005rz-Dg for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:12 -0400 Received: from mail-am6eur05on20729.outbound.protection.outlook.com ([2a01:111:f400:7e1b::729] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmd4-0002ID-SE for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:12 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 18:58:57 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 18:58:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IfmhXKCeDjEZWCnjU6Z87nGiuHaAmL65mKjq8E3u9if+QyR8ST3/U00JvYk16jvhtvstZnqJs3T7TH6+mG0zCHirK4+SVB+i+7VdWeoThZQ7Yal1KY4/8PxDZRRA23ZqrU2DqIWy0+vD2XkzEXeMh0yIDMm0oK+qmSI5gbdL2CGrLsoCcMqXnnNSfBvYqhsRhB4jlLBk+GKLAjcWIddbr+SvGN8R6RY+RJD6RnLQ6bZihhtA4K2oTxgnh+sfCtuhnQPEJrUxifXP5PG/nzn3Ngwmj4EcOgdl8tbpqD7nAOeypNEl89NYWksEF6QloZN1r7DY4qpXh7JX8IkKdV5wmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PEEjRzKALsH8Mu6wUSgfNEoaeCf4X3DidEO1qINXbKU=; b=geVL7eepT6297atU4r8ruDYIl0VhZH/RRjTMNt0IoGP1Zphr5LogZckjgC818qXNRYnefhk6Jj+Kv0+Ucz4deeVM7IaMiI9DbAS/MQ+iISkwxW1/+Ab4aX++XAE7S08e9nqzeUPe3DRufS5c3h2nJRFh4uF2MDOG5Yu4CuL6XZmcq16wOOP+MMN47tv8gKnPcKKRwRqDbmmWVNQHHlgsij5oC67IcrA9oG3JSs+CDmEt43QSlwSdJdM7s4/UavQkeVP0iTKknv5jaD8Y16ebVqez69xxzNeWanNDQKEUnpymXXorrdyOmTMCS+FDKd0lDmic9Rj00wvE9ZOcKaLvfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PEEjRzKALsH8Mu6wUSgfNEoaeCf4X3DidEO1qINXbKU=; b=GiHrWdbaQmTtcZD1KmQ7Oyg1F9+0hZ1e6IimbClqsRTSa1Bwjax4jnKuZvav4j/+uLEchcwEJQ6x2zruW3j0nchDmouy/JDPghdV7kq5oM4BfpDrDNeLgMsTCxTeMe1utZUbBM8uOPGREgF0ofyWWa3+ashCCMseSy0U8Jv3+Eo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 7/8] igb: implement VF Tx and Rx stats Date: Fri, 24 Mar 2023 16:35:00 +0100 Message-Id: <20230324153501.20695-8-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0116.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::15) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c6ac994-4763-4396-cf31-08db2c99d0fb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aW7C2bGKt4Umx1iHR6yauhypEpzBOWbox/dlEXJZehB3Qj92qdpX1eR7xBTEclzJ4Gj5qLGvRWW6fiuaY274jK1YtTCT+BCVulYfxd4CMll4OQQmcJrLGBXpoPu6I7soQC14Rlap6QIVepNuh6w9d+KV+6eJyLjDn7ny+wQtIpSiMFvSnRoD1N65Gnh8qttItnQo1hv6mfYPQ8zZI9kMgMoiTF4ZivMWhheuT/Dy29IOpQXfDHuxaWI2kG6IWBQpvmYcgpWhyHzI+7uX9jCtt1tqpDrNh+YM/gF9VN2oslZW17mImvDZDfbEuS1m30kmMRKXjNWTiojqjMGQOlYje6Pm6vE3cd/jylv5RrSAGi0IVZStiity7TlbMnPAXue47uUmZaAQDBZXlNQlss/MufWiI0RDs4nuu4kjECp7GmTQ2SW+nml80omf/HrCFaVhjBetscE1fsD9ypnBdBRojW23fdAt5mzqcuX1SBRy4csiCCfgIVzDWnowpOvDVgUxqafMg97dzCtKX6ckvlrY+qoEKfcTx3pcVMKP0WlC+kiiG5j+YotHGDriV+Mjz7zPHcIM0Iph1y9hjE/umN7ZHyQFDZa/Uzkwb7HTwODEz2DPz0PIPoBoAEsPLfJAJqpJzn2ZNdr4BQs4CUY4JtW28A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(186003)(2616005)(2906002)(6486002)(6666004)(26005)(6512007)(478600001)(1076003)(6506007)(83380400001)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5yslaih7z0Zkb8xzz9b2+MIZkISEkMtEaljw4OoA+E4t/mjwChZJSGo/bpdS?= =?us-ascii?Q?8kOQNlaQlJpvfzYlSqgaqtx+ObY8/Zg6Sqjvokeea48e54b3RHnM108EuHM+?= =?us-ascii?Q?wYTj+MpWyRbMdFfCrwyfuhM5GQibaWWaWzwE9/xw1KQH3wQQUKuYVE3hZIO7?= =?us-ascii?Q?10szREPtvhJbWRE0TGAmpUx46086f8KYE+iqLGvPmSVf0/LbvEiEmGjrGu8z?= =?us-ascii?Q?7J1QNGcQ3NR+BHJdzY7ZqXjzEh/PPfx7WYL11PxOfWQPh2nEgR/+yyTR/xqv?= =?us-ascii?Q?CHqn9uhEa4GkkZp//y+K8bKc+3JdTxDPNf5i2IUn7SlVFwPEYGYUkyujSEzk?= =?us-ascii?Q?JHOvRGGqUcN1scxGom5/z6e2xm/7btIAyipl/2oSBKnsAy1xXzTyGPxVOmrf?= =?us-ascii?Q?+Ixvye22JZVXagv2xHYWRt6PGBdR3NwNpWMrZtjqh1xSj4/F2FbY4poNproH?= =?us-ascii?Q?nMv68tePNZZCoYESD/P4OSAt0m9axT5E5q+U+tG+6tL7m6pcQ0npSsTJWsLW?= =?us-ascii?Q?F/akc2MSwjThWYxuMt6UzW3X7AXmh34JiWvpZhvtmWRVbn3pEZQKdnvf1sir?= =?us-ascii?Q?fuBYpW37n2KF7ed3jULh7LcOp0jeoQSYKgWRwDTBntT0fqPmj8zhjqkYg+K9?= =?us-ascii?Q?PjTlnxLEv8Ybp0QKm76f1zQ396+pC/AaL0Iimi3vE8O3AxD1sfbOF9Osq328?= =?us-ascii?Q?QJPk6JhwHZvU4hzKPdARS+69+zOuF5BxSan5yAz0BRPHWsGjATxBgNaVjx+R?= =?us-ascii?Q?oVdtf+Uy53+UiLxyQfXQCq6+x8BfQY1RvvpyHZdhA9jzustqoKd7cCwiJzpf?= =?us-ascii?Q?e+ygHWnv05zaCpgNIG1EiwAI9MT+OWIz09e3zOpr7wBd7uBG3LSR7ME9L17X?= =?us-ascii?Q?rZctNSGkZR0q99R8TwjZ951IIOXW2ibhljhvzU8qw1haWM6On4GBnhoTWwyw?= =?us-ascii?Q?5EV6aFIxI7AFwXpSrzAhCv7GkzPio4556U6oxN4LTQnoI8VE3jeJuTvoFz0g?= =?us-ascii?Q?IaJYx9Bgr2fXj0dnggIRJvSZCOa+t3tzSq2gy6SgtBQHU21bpwsiNtwgyTzK?= =?us-ascii?Q?PCE6x9JWUZzuE3oJ4kZAIl2a1GpQSmVQj+P4oE+9wuSETDSb19wkiq/sVEUo?= =?us-ascii?Q?4X0IvF3lQpb/D8YJeSwrtaBsDlLRWrMLIS0E7SLu23YhdLm5tJbGYy75k6ry?= =?us-ascii?Q?YbW7xA4ZXVz6xLXMr+dxwLQ5lKfd2CvtjW4vANd221cHXk6rfGzu9/H9nPc1?= =?us-ascii?Q?Xj5EurL+tsjg2PTwTPkUOOA+Rqkg4NQsBz8VDTXuLl5EOmtrOgSMyMjrn9kG?= =?us-ascii?Q?FckjVLRxDMSlkUC9bESXFZmGfkPLZOxWvs0qr15V00uFq0xFFncQKDH8pdtg?= =?us-ascii?Q?7TAd9yaa1H/TheNDjh4Fu8vrZh5vKiJAC3i5w9QxEuCD67v5aYfU7B9eIDcR?= =?us-ascii?Q?pGE0ml6vp6v5t5Ny9CXCQJGQJV1vTjBg27LbwlKf6Nj97ZByjqtxZcJSZnv4?= =?us-ascii?Q?NRzVFfHasEoNsk5EDFk/4fpULoxYtTs3/+3S6fpKpAmODb1WPdA/P74s1YIa?= =?us-ascii?Q?x1NV8Dc9S6nIzXWUnU/e2eh2xQTCsCOwob4qEZ0pwrdP6RFOJcaGTEX60050?= =?us-ascii?Q?lg=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: 2c6ac994-4763-4396-cf31-08db2c99d0fb X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 18:58:55.2245 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TJokSTpIcfbWX/QlDSIRrWjSQ8faf4O6PC3yPX9Vz0xX+Md/568F0Smji4SKKDA+XoeAzDozIfY2888x1pnAb4SrLMIVpQ7pcNidKp5Qhf8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1b::729; envelope-from=sriram.yagnaraman@est.tech; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684423625100001 Content-Type: text/plain; charset="utf-8" Please note that loopback counters for VM to VM traffic is not implemented yet: VFGOTLBC, VFGPTLBC, VFGORLBC and VFGPRLBC. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index fd61c6c550..162ba8becf 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -492,7 +492,7 @@ igb_tx_pkt_send(IGBCore *core, struct igb_tx *tx, int q= ueue_index) } =20 static void -igb_on_tx_done_update_stats(IGBCore *core, struct NetTxPkt *tx_pkt) +igb_on_tx_done_update_stats(IGBCore *core, struct NetTxPkt *tx_pkt, int qn) { static const int PTCregs[6] =3D { PTC64, PTC127, PTC255, PTC511, PTC1023, PTC1522 }; @@ -519,6 +519,13 @@ igb_on_tx_done_update_stats(IGBCore *core, struct NetT= xPkt *tx_pkt) core->mac[GPTC] =3D core->mac[TPT]; core->mac[GOTCL] =3D core->mac[TOTL]; core->mac[GOTCH] =3D core->mac[TOTH]; + + if (core->mac[MRQC] & 1) { + uint16_t pool =3D qn % IGB_NUM_VM_POOLS; + + core->mac[PVFGOTC0 + (pool * 64)] +=3D tot_len; + core->mac[PVFGPTC0 + (pool * 64)]++; + } } =20 static void @@ -583,7 +590,7 @@ igb_process_tx_desc(IGBCore *core, net_tx_pkt_setup_vlan_header_ex(tx->tx_pkt, vlan, vet); } if (igb_tx_pkt_send(core, tx, queue_index)) { - igb_on_tx_done_update_stats(core, tx->tx_pkt); + igb_on_tx_done_update_stats(core, tx->tx_pkt, queue_index); } } =20 @@ -1409,7 +1416,8 @@ igb_write_to_rx_buffers(IGBCore *core, } =20 static void -igb_update_rx_stats(IGBCore *core, size_t data_size, size_t data_fcs_size) +igb_update_rx_stats(IGBCore *core, const E1000E_RingInfo *rxi, + size_t data_size, size_t data_fcs_size) { e1000x_update_rx_total_stats(core->mac, data_size, data_fcs_size); =20 @@ -1425,6 +1433,16 @@ igb_update_rx_stats(IGBCore *core, size_t data_size,= size_t data_fcs_size) default: break; } + + if (core->mac[MRQC] & 1) { + uint16_t pool =3D rxi->idx % IGB_NUM_VM_POOLS; + + core->mac[PVFGORC0 + (pool * 64)] +=3D data_size + 4; + core->mac[PVFGPRC0 + (pool * 64)]++; + if (net_rx_pkt_get_packet_type(core->rx_pkt) =3D=3D ETH_PKT_MCAST)= { + core->mac[PVFMPRC0 + (pool * 64)]++; + } + } } =20 static inline bool @@ -1526,7 +1544,7 @@ igb_write_packet_to_guest(IGBCore *core, struct NetRx= Pkt *pkt, =20 } while (desc_offset < total_size); =20 - igb_update_rx_stats(core, size, total_size); + igb_update_rx_stats(core, rxi, size, total_size); } =20 static inline void --=20 2.34.1 From nobody Sat Apr 20 14:20:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) ARC-Seal: i=2; a=rsa-sha256; t=1679684392; cv=pass; d=zohomail.com; s=zohoarc; b=SJY4CD8fp0mztklnLylC9FP/fAcHblBCWxS18kUErNXmNn7+3l/r18Ifwn3W6G6Kf2zhBs5TlY2ltFxSi1HtCfmp1Nda9vgT0QrGgIEUJFOUNWCNxEzhj7OUzrIjvmJLqjLahPXKTX1LJVrrxS6TtkZEwLC36+RCRpvwvK3C9OQ= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1679684392; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject; bh=JlQN8aSXctzk95RQ4xWEXONvfnyQcVTbIWER7lTiW18=; b=R3hjyLp4ejWglG6F548MRhKGZu+SmwTwzoDyMdHEGuoWrWIjsbmqMOkAetNab4Zo8f5vi4rpVfx0RhLAqVErUMKLxmCD7ZoDOrfIT6wKYC6aCVy/n91i8YXBiYtt/xJHH5WmZczZZe9IByFbHDpUw2HOyOL0/TUh2QppoV4NLNQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=est.tech) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1679684392431271.0357015910091; Fri, 24 Mar 2023 11:59:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfmdB-0005t2-HC; Fri, 24 Mar 2023 14:59:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmd9-0005so-38 for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:15 -0400 Received: from mail-am6eur05on20729.outbound.protection.outlook.com ([2a01:111:f400:7e1b::729] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfmd6-0002ID-UG for qemu-devel@nongnu.org; Fri, 24 Mar 2023 14:59:14 -0400 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) by DB3P189MB2380.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:439::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.38; Fri, 24 Mar 2023 18:58:57 +0000 Received: from DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc]) by DBBP189MB1433.EURP189.PROD.OUTLOOK.COM ([fe80::13ad:a312:15c6:91dc%9]) with mapi id 15.20.6178.039; Fri, 24 Mar 2023 18:58:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z/1wxawUv+sMwSYw59+vwkLbqRklcoU3sY5B4nFQiC04hTDBdGWLOvYiOH4R7EzhktA7XHsXCN9U0ZBbqqm4Z8EVDmiU2isxdI31IsAPYirVyAXiW2VZQwGmGPFFPb5xx5s5VqCHD0LDAcLT+DHG06GkVcSxOt38Kinv4mAoRGjipMrpZpzhGvEoLcLmek7RHhu4h7paYR0N/1iFbAbHweGKTto3jl1dKLlQfCKT3lBuze6RSQ8gB98yjjc50j7f1PCPhzycgYhp+oJgzIU97+i3v2qroYF2sa+0v2HUe93KO224ylYcVtXlmQ4e4f4t9xAd94qduVbREaaZKyrSyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JlQN8aSXctzk95RQ4xWEXONvfnyQcVTbIWER7lTiW18=; b=kuzjo5SJQ0JFGvXUKlTNd6Pt0UYcuQsWqtSv+S9Lyx2fKAWosp7CnVuNX6w/8OaWu/vSM4jsZVeD845ANoJretf34JzBQmvFtyKr4IqPEj6v3q1N/O9q0O8aB2AWSDoMbL2hvbIcqrpp9CMwJvimjyJIbTI5mNX/EEDVvUV9O1fx3FZaqLDdtrpueWqtgmLK69J0vOZA6tFi3Am+mMlIvfygl9oCHgfsbOZgWe5MyfC4OVx9EQfWf5gs24ObjS6Ar3jmVYBZZ1clz9lt00d+FMXRzCSP/Tlij9dT2/BdpxMpYpl5k9Z096quVpeLUa+enyQJ+emYVMIWdKIwoKyGmw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=est.tech; dmarc=pass action=none header.from=est.tech; dkim=pass header.d=est.tech; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=estab.onmicrosoft.com; s=selector2-estab-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JlQN8aSXctzk95RQ4xWEXONvfnyQcVTbIWER7lTiW18=; b=Q8m3fW5OoXU96RsWCDb65B8KRcU/AkC+78f2kR17OR/h+M/WajFYapbkx97JZB5BTpZft9kr7j15qmn/cwOSRE0Q1K5Ys3xdl4xFND6m46pLOwZyGzZ+psuNiHHEkL5UnmmGKpPX7RVP+1rsWtphlqhWUBnS2P1m28QRV9ajNsY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=est.tech; From: Sriram Yagnaraman To: Cc: qemu-devel@nongnu.org, Akihiko Odaki , Jason Wang , Dmitry Fleytman , "Michael S . Tsirkin" , Marcel Apfelbaum , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Sriram Yagnaraman Subject: [PATCH v10 8/8] igb: respect VMVIR and VMOLR for VLAN Date: Fri, 24 Mar 2023 16:35:01 +0100 Message-Id: <20230324153501.20695-9-sriram.yagnaraman@est.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230324153501.20695-1-sriram.yagnaraman@est.tech> References: <20230324153501.20695-1-sriram.yagnaraman@est.tech> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: GV3P280CA0097.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:8::29) To DBBP189MB1433.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:1e7::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DBBP189MB1433:EE_|DB3P189MB2380:EE_ X-MS-Office365-Filtering-Correlation-Id: 900ec12a-d491-4c0f-0abb-08db2c99d0f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hH2dOYIc+zTFys4Oc7Srbw1ua8pj/9SYo4w2y0IrFKqyDFXtDjWMKNOQzdg7jvtWA9YsQgB7aOE68Q+fMuYR+rOPcNKoj5rneZTt8dRVDb6NJN1CkLA0a7xNice6NUSL8UxM0Md6u6ysDn/TZIpZDp4txKT6uimJPcY4y9ynjNAYUw2g8L6g3ZBr96yhSsPPOPnMx5D+HJ/kffuKDlbdLhv8Wt29HGTQ6Oa2jCpqrMX0HEn9/jJrUUIhn/wXrMPCSRIi7JkcYY43+PURGG6VQ+7ivW3wuQeJCjx4ZYrIC1vQrRG0kiZ2OOXPdEwYolSTEkv33UAPsDbHU8ztApx+F5eUUX5NKGWADmFX9h9axXJ+4roK5VBh5CVgHVcOAvN30Xa5Dk+McEPkXmhhOJdv/A66rzi3XlhVstIZ9po4P54S0NgSoFMAptFG8um0GLRNhblHLL8GnA8TnkdUQnFOaGQp3gkUA/Lmu4QC4ctvNf7ZiryccGRwHzmFfMsNq6izbOru8pn3vtEXzOntddKBb2WpHl1oYtriYFq1pvSkyHvTZzgOOZi2CXY/f7Y3KCru+LejPVpEz7l5lmBY5SB1g/TiPTJK8TgcPgdmjl/gdP6UiwXBq87M7LQwAkYjXDbgEuZAVflzvEe7DXH+c87j7g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DBBP189MB1433.EURP189.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230028)(376002)(136003)(396003)(346002)(39840400004)(451199021)(109986019)(66946007)(54906003)(316002)(66556008)(38100700002)(8676002)(70586007)(44832011)(66476007)(86362001)(4326008)(41300700001)(36756003)(5660300002)(8936002)(186003)(2616005)(2906002)(6486002)(6666004)(26005)(6512007)(478600001)(1076003)(6506007)(83380400001)(266003)(37730700002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BqqveY/SFPwdxL25MKm+xbBCI+ikOHNXQlbddao4bjf8pvpWuXRnnmSsTDcg?= =?us-ascii?Q?wfrDUZQAX8cNt4hzEOjLzLfPp4j7S+SzkjoxYcGpatSXhJgFCEtcKEI4WpgN?= =?us-ascii?Q?GAyL5c1xpXDxKRe0W4C3pqeadDQ03/foUd9dRgnuCisElvghzAyevPKcN9cY?= =?us-ascii?Q?1TI5IGPKf1hj21A2jy4izHcMAUFtQ8mhbNXXW3VWT11gEkL7ylmCg5ZWQlyS?= =?us-ascii?Q?DfeEcjbYdeH6R1fwBy2WvlJjNWvftdT6LDeqkvZqaqm33X4T+UE/fxr4kdn4?= =?us-ascii?Q?6/5VRDw6tgL9XJZwI2kQ1Rb9wT1igaJLOpV8WMhRNyW47QXolpI5e1GGcbsJ?= =?us-ascii?Q?CvUDW1IE1tq+d26pW8Spz9n4p2s+wNVGzWT/FrfdYoSY5P2nvDk1cDLAY/P+?= =?us-ascii?Q?3O+O5VBgh2RDt368BACmOhND55Eotgb5+8S6CN8U2gTPbJgsN3Cg9V39yqZs?= =?us-ascii?Q?XUR3AHw0eaPVoFNuM5GKQgiFAANcxKBnbArX40tzNO8NPfAcYvybh8Yb12lb?= =?us-ascii?Q?cDiBDj0NJUqUeTDq7PUTgOWumTqkwttycQX+rsSByGw+zVERa4geQ9AyYD8v?= =?us-ascii?Q?T245XgN9zm5vMOv/a6li6EYGRBPdsYVX5ekg609Q9lmPV0ItgwZo5Kg2qejX?= =?us-ascii?Q?YVPOklfK7Kk2r0WOfCCbKnNAhN64Xy9hwuVoG9PZwHB+IWvY2Ejc9hyS7nUV?= =?us-ascii?Q?KVy3DZnO7TAx79mjPIau+9WYTBSRY3CsaR30qHuxyiPBi1s3kOEikfvB48UF?= =?us-ascii?Q?F4J/0rEyCPy1PxglQFr8fuy7q9hTrlMOUcSwAi4V+2q8DX3YntRYcyoL3Snq?= =?us-ascii?Q?gL7BN6k4ljY/UnFnRR9MbixlsOocU7izEsrgqSnQMERiHIeEXeP7GINEr0L+?= =?us-ascii?Q?KQsauufdV5my5QdHlDiKeB4U2Q1NhRahGku/FZG+PJrf2twwdwflbCD1DyLl?= =?us-ascii?Q?IAxmDlhDWY02vOM2j4vH8EuOG4g6/g78RVktyNqjNPyCIF+Y370Oxh9x4X7Q?= =?us-ascii?Q?3pevyD/U86UtbLkVAjiq/Hud6bwd/iBzbGxsv8AGrr1UlnqEl0ApdQPLLLtT?= =?us-ascii?Q?ZwBxHo45Um4bZs5nKgXcv/Ze2Xh+ncKd6u0/8CAuMI39JpIQIRbLdRsAvf9i?= =?us-ascii?Q?D+0HJEqjmlvA7k9d+UV/H8dVEgmJbVDIDCT5MulM8TpeOFZnKoBvfBI0YpwB?= =?us-ascii?Q?qde1H328mb78enVFIjhmMqVxzT+MxeVy7rKOUY3FV30IRs36zdC8Zonszi6c?= =?us-ascii?Q?xGPnU82SH0FzhojJnwvtMI38u73LXgVhH0I23ig24/BaQmLBksfQ4tHlYGeK?= =?us-ascii?Q?dzkIXlP3Un2uNkGjnWWEjouC0+neia0F4wOQGvEJpZjtn5C+6HMsVFS1FWY4?= =?us-ascii?Q?Y1ArNFXN2LmjEOFrG+RkA2MdU/Yd36vSOyNWtVSlQ+9OcrnlZLPLIbBUke6q?= =?us-ascii?Q?QUywNjf4V6wgvUjwuLsP3Uzr/jL2DVV12Yv9qH/6FmeGK+ybL6gUFDjzhqqj?= =?us-ascii?Q?t2rxNeVvXrIIb888/YGpIiY3T7LipCxFCg8PyoEo0KYpx5Btc9+m0sXNEn15?= =?us-ascii?Q?DlZaJEmzlJ1A8dTpt9DW9q2S1HvN76mjJhH0/YfMuGzjkyhiG5eH6APY580j?= =?us-ascii?Q?ng=3D=3D?= X-OriginatorOrg: est.tech X-MS-Exchange-CrossTenant-Network-Message-Id: 900ec12a-d491-4c0f-0abb-08db2c99d0f7 X-MS-Exchange-CrossTenant-AuthSource: DBBP189MB1433.EURP189.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2023 18:58:55.1620 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: d2585e63-66b9-44b6-a76e-4f4b217d97fd X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ByoYOoKIPDTalSSrctzlH4pKqXEvU9GcJSFcx0Pdq9RLDFnvRVGaB/tIp+LcMBLmWjqS3EO3JugrDS3ntQcQK4oka9DCdzVy3m0cLvfXCR8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3P189MB2380 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a01:111:f400:7e1b::729; envelope-from=sriram.yagnaraman@est.tech; helo=EUR05-AM6-obe.outbound.protection.outlook.com X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DATE_IN_PAST_03_06=1.592, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @estab.onmicrosoft.com) X-ZM-MESSAGEID: 1679684394512100008 Content-Type: text/plain; charset="utf-8" Add support for stripping/inserting VLAN for VFs. Had to move CSUM calculation back into the for loop, since packet data is pulled inside the loop based on strip VLAN decision for every VF. net_rx_pkt_fix_l4_csum should be extended to accept a buffer instead for igb. Work for a future patch. Signed-off-by: Sriram Yagnaraman --- hw/net/igb_core.c | 62 +++++++++++++++++++++++++++++++++++++---------- 1 file changed, 49 insertions(+), 13 deletions(-) diff --git a/hw/net/igb_core.c b/hw/net/igb_core.c index 162ba8becf..d733fed6cf 100644 --- a/hw/net/igb_core.c +++ b/hw/net/igb_core.c @@ -386,6 +386,28 @@ igb_rss_parse_packet(IGBCore *core, struct NetRxPkt *p= kt, bool tx, info->queue =3D E1000_RSS_QUEUE(&core->mac[RETA], info->hash); } =20 +static void +igb_tx_insert_vlan(IGBCore *core, uint16_t qn, struct igb_tx *tx, + uint16_t vlan, bool insert_vlan) +{ + if (core->mac[MRQC] & 1) { + uint16_t pool =3D qn % IGB_NUM_VM_POOLS; + + if (core->mac[VMVIR0 + pool] & E1000_VMVIR_VLANA_DEFAULT) { + /* always insert default VLAN */ + insert_vlan =3D true; + vlan =3D core->mac[VMVIR0 + pool] & 0xffff; + } else if (core->mac[VMVIR0 + pool] & E1000_VMVIR_VLANA_NEVER) { + insert_vlan =3D false; + } + } + + if (insert_vlan && e1000x_vlan_enabled(core->mac)) { + net_tx_pkt_setup_vlan_header_ex(tx->tx_pkt, vlan, + core->mac[VET] & 0xffff); + } +} + static bool igb_setup_tx_offloads(IGBCore *core, struct igb_tx *tx) { @@ -583,12 +605,11 @@ igb_process_tx_desc(IGBCore *core, =20 if (cmd_type_len & E1000_TXD_CMD_EOP) { if (!tx->skip_cp && net_tx_pkt_parse(tx->tx_pkt)) { - if (cmd_type_len & E1000_TXD_CMD_VLE) { - idx =3D (tx->first_olinfo_status >> 4) & 1; - uint16_t vlan =3D tx->ctx[idx].vlan_macip_lens >> 16; - uint16_t vet =3D core->mac[VET] & 0xffff; - net_tx_pkt_setup_vlan_header_ex(tx->tx_pkt, vlan, vet); - } + idx =3D (tx->first_olinfo_status >> 4) & 1; + igb_tx_insert_vlan(core, queue_index, tx, + tx->ctx[idx].vlan_macip_lens >> 16, + !!(cmd_type_len & E1000_TXD_CMD_VLE)); + if (igb_tx_pkt_send(core, tx, queue_index)) { igb_on_tx_done_update_stats(core, tx->tx_pkt, queue_index); } @@ -1547,6 +1568,20 @@ igb_write_packet_to_guest(IGBCore *core, struct NetR= xPkt *pkt, igb_update_rx_stats(core, rxi, size, total_size); } =20 +static bool +igb_rx_strip_vlan(IGBCore *core, const E1000E_RingInfo *rxi) +{ + if (core->mac[MRQC] & 1) { + uint16_t pool =3D rxi->idx % IGB_NUM_VM_POOLS; + /* Sec 7.10.3.8: CTRL.VME is ignored, only VMOLR/RPLOLR is used */ + return (net_rx_pkt_get_packet_type(core->rx_pkt) =3D=3D ETH_PKT_MC= AST) ? + core->mac[RPLOLR] & E1000_RPLOLR_STRVLAN : + core->mac[VMOLR0 + pool] & E1000_VMOLR_STRVLAN; + } + + return e1000x_vlan_enabled(core->mac); +} + static inline void igb_rx_fix_l4_csum(IGBCore *core, struct NetRxPkt *pkt) { @@ -1627,10 +1662,7 @@ igb_receive_internal(IGBCore *core, const struct iov= ec *iov, int iovcnt, =20 ehdr =3D PKT_GET_ETH_HDR(filter_buf); net_rx_pkt_set_packet_type(core->rx_pkt, get_eth_packet_type(ehdr)); - - net_rx_pkt_attach_iovec_ex(core->rx_pkt, iov, iovcnt, iov_ofs, - e1000x_vlan_enabled(core->mac), - core->mac[VET] & 0xffff); + net_rx_pkt_set_protocols(core->rx_pkt, filter_buf, size); =20 queues =3D igb_receive_assign(core, ehdr, size, &rss_info, external_tx= ); if (!queues) { @@ -1638,9 +1670,6 @@ igb_receive_internal(IGBCore *core, const struct iove= c *iov, int iovcnt, return orig_size; } =20 - total_size =3D net_rx_pkt_get_total_len(core->rx_pkt) + - e1000x_fcs_len(core->mac); - for (i =3D 0; i < IGB_NUM_QUEUES; i++) { if (!(queues & BIT(i)) || !(core->mac[RXDCTL0 + (i * 16)] & E1000_RXDCTL_QUEUE_ENABLE)) { @@ -1649,6 +1678,13 @@ igb_receive_internal(IGBCore *core, const struct iov= ec *iov, int iovcnt, =20 igb_rx_ring_init(core, &rxr, i); =20 + net_rx_pkt_attach_iovec_ex(core->rx_pkt, iov, iovcnt, iov_ofs, + igb_rx_strip_vlan(core, rxr.i), + core->mac[VET] & 0xffff); + + total_size =3D net_rx_pkt_get_total_len(core->rx_pkt) + + e1000x_fcs_len(core->mac); + if (!igb_has_rxbufs(core, rxr.i, total_size)) { n |=3D E1000_ICS_RXO; trace_e1000e_rx_not_written_to_guest(rxr.i->idx); --=20 2.34.1