[PATCH v3] hvf: Report HV_DENIED error

Antonio Caggiano posted 1 patch 10 months, 2 weeks ago
accel/hvf/hvf-all.c | 6 ++++++
1 file changed, 6 insertions(+)
[PATCH v3] hvf: Report HV_DENIED error
Posted by Antonio Caggiano 10 months, 2 weeks ago
On MacOS 11 and subsequent versions, in case the resulting binary is not
signed with the proper entitlement, handle and report the HV_DENIED
error.

Signed-off-by: Antonio Caggiano <quic_acaggian@quicinc.com>
---
v2: Use architecture specific defines from AvailabilityMacros.h to enable the
    HV_DENIED case only on MacOS 11 and subsequent versions.
v3: Fix ifdef guard.

 accel/hvf/hvf-all.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c
index 754707dbfb..4920787af6 100644
--- a/accel/hvf/hvf-all.c
+++ b/accel/hvf/hvf-all.c
@@ -38,6 +38,12 @@ void assert_hvf_ok(hv_return_t ret)
     case HV_UNSUPPORTED:
         error_report("Error: HV_UNSUPPORTED");
         break;
+#if defined(MAC_OS_VERSION_11_0) && \
+    MAC_OS_X_VERSION_MIN_REQUIRED >= MAC_OS_VERSION_11_0
+    case HV_DENIED:
+        error_report("Error: HV_DENIED");
+        break;
+#endif
     default:
         error_report("Unknown Error");
     }
-- 
2.40.0
Re: [PATCH v3] hvf: Report HV_DENIED error
Posted by Philippe Mathieu-Daudé 10 months, 2 weeks ago
On 8/6/23 14:30, Antonio Caggiano wrote:
> On MacOS 11 and subsequent versions, in case the resulting binary is not
> signed with the proper entitlement, handle and report the HV_DENIED
> error.
> 
> Signed-off-by: Antonio Caggiano <quic_acaggian@quicinc.com>
> ---
> v2: Use architecture specific defines from AvailabilityMacros.h to enable the
>      HV_DENIED case only on MacOS 11 and subsequent versions.
> v3: Fix ifdef guard.
> 
>   accel/hvf/hvf-all.c | 6 ++++++
>   1 file changed, 6 insertions(+)

Queued, thanks!