Migration test refactoring

[PATCH 11/42] migration-test: Update test_ignore_shared to use args

Posted by Juan Quintela 2 years, 8 months ago

It missed this treatment:

commit 11f1a4ce14803f15d59cff42a4cfb7ac50d36bd0
Author: Juan Quintela <quintela@redhat.com>
Date:   Mon Nov 29 18:57:51 2021 +0100

    migration-test: Check for shared memory like for everything else

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 tests/qtest/migration-test.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 743aa873e6..7178c8e679 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
@@ -1597,8 +1597,11 @@ static void test_ignore_shared(void)
 {
     g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
     QTestState *from, *to;
+    MigrateStart args = {
+        .use_shmem = true
+    };
 
-    if (test_migrate_start(&from, &to, uri, false, true, NULL, NULL)) {
+    if (test_migrate_start(&from, &to, uri, &args)) {
         return;
     }
 
-- 
2.40.1

Re: [PATCH 11/42] migration-test: Update test_ignore_shared to use args

Posted by Peter Xu 2 years, 7 months ago

On Fri, Jun 09, 2023 at 12:49:12AM +0200, Juan Quintela wrote:
> It missed this treatment:
> 
> commit 11f1a4ce14803f15d59cff42a4cfb7ac50d36bd0
> Author: Juan Quintela <quintela@redhat.com>
> Date:   Mon Nov 29 18:57:51 2021 +0100
> 
>     migration-test: Check for shared memory like for everything else
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>

This is still under "#if 0" block.. and the old code doesn't even compile,
but the change looks fine.

Reviewed-by: Peter Xu <peterx@redhat.com>

> ---
>  tests/qtest/migration-test.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index 743aa873e6..7178c8e679 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -1597,8 +1597,11 @@ static void test_ignore_shared(void)
>  {
>      g_autofree char *uri = g_strdup_printf("unix:%s/migsocket", tmpfs);
>      QTestState *from, *to;
> +    MigrateStart args = {
> +        .use_shmem = true
> +    };
>  
> -    if (test_migrate_start(&from, &to, uri, false, true, NULL, NULL)) {
> +    if (test_migrate_start(&from, &to, uri, &args)) {
>          return;
>      }
>  
> -- 
> 2.40.1
> 

-- 
Peter Xu

Re: [PATCH 11/42] migration-test: Update test_ignore_shared to use args

Posted by Juan Quintela 2 years, 7 months ago

Peter Xu <peterx@redhat.com> wrote:
> On Fri, Jun 09, 2023 at 12:49:12AM +0200, Juan Quintela wrote:
>> It missed this treatment:
>> 
>> commit 11f1a4ce14803f15d59cff42a4cfb7ac50d36bd0
>> Author: Juan Quintela <quintela@redhat.com>
>> Date:   Mon Nov 29 18:57:51 2021 +0100
>> 
>>     migration-test: Check for shared memory like for everything else
>> 
>> Signed-off-by: Juan Quintela <quintela@redhat.com>
>
> This is still under "#if 0" block.. and the old code doesn't even compile,
> but the change looks fine.

With the change it compiles O:-)

> Reviewed-by: Peter Xu <peterx@redhat.com>

Thanks.