[PATCH] hw/i386/pc: Clean up pc_machine_initfn

Suravee Suthikulpanit posted 1 patch 10 months, 3 weeks ago
hw/i386/pc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] hw/i386/pc: Clean up pc_machine_initfn
Posted by Suravee Suthikulpanit 10 months, 3 weeks ago
To use the newly introduced PC machine class local variable.

Suggedted-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
---
 hw/i386/pc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 33ffb03a32..f8d105e829 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1864,7 +1864,7 @@ static void pc_machine_initfn(Object *obj)
     pcms->smbios_entry_point_type = pcmc->default_smbios_ep_type;
 
     /* acpi build is enabled by default if machine supports it */
-    pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build;
+    pcms->acpi_build_enabled = pcmc->has_acpi_build;
     pcms->smbus_enabled = true;
     pcms->sata_enabled = true;
     pcms->i8042_enabled = true;
-- 
2.34.1
Re: [PATCH] hw/i386/pc: Clean up pc_machine_initfn
Posted by Philippe Mathieu-Daudé 10 months, 3 weeks ago
On 9/6/23 18:41, Suravee Suthikulpanit wrote:
> To use the newly introduced PC machine class local variable.
> 
> Suggedted-by: Igor Mammedov <imammedo@redhat.com>

"Suggested-by"

> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
>   hw/i386/pc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 33ffb03a32..f8d105e829 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1864,7 +1864,7 @@ static void pc_machine_initfn(Object *obj)
>       pcms->smbios_entry_point_type = pcmc->default_smbios_ep_type;
>   
>       /* acpi build is enabled by default if machine supports it */
> -    pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build;
> +    pcms->acpi_build_enabled = pcmc->has_acpi_build;
>       pcms->smbus_enabled = true;
>       pcms->sata_enabled = true;
>       pcms->i8042_enabled = true;