From nobody Mon May 12 12:17:21 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1695048213; cv=none; d=zohomail.com; s=zohoarc; b=Swc69KZWMS7WzlVOjvbXobCtPTO1ZgyOKE0Sak+MfFfDwTT9CkvU5VO7mcqgNqxTTNU2fNhnINQOLCaP96cJwy9mI8QGN/N4yvi8iUFN58pux9PL2cL9PElG3C0WVKhR2HWB/04IHPNEEIzkNP+oyaYZVfwI+UVVvm44BCoEPXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1695048213; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rCGxSHuWGPFauDO78J2cjgmvZQU9Lb4U+fA74G/EWJo=; b=CR4niIQlaIZsVdsK64Lqqx9pHcIDn4vHc6NVNh4PjmrOQ7/ZFkzCEb5PvTi5mQiRn12nAHNW+L5F6h5m8MGMAF5iEsKbV5zSOW6IrJk1qm3bwHue9O1FQ8MA0w7T1bNCs9sgVlyXmSbBkKstqKFITj/vegU8bonmC2HDJRiN6tI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1695048213061723.3293211376806; Mon, 18 Sep 2023 07:43:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qiFSF-0002uy-76; Mon, 18 Sep 2023 10:42:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiFSA-0002t2-DY for qemu-devel@nongnu.org; Mon, 18 Sep 2023 10:42:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qiFS0-0002Yh-3h for qemu-devel@nongnu.org; Mon, 18 Sep 2023 10:42:22 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-297-20ST3Oq7MNOk7BsJi2wFCA-1; Mon, 18 Sep 2023 10:42:08 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 17EEC811E7E for ; Mon, 18 Sep 2023 14:42:08 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.39.192.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EA0FC140E950 for ; Mon, 18 Sep 2023 14:42:07 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id E308521E6904; Mon, 18 Sep 2023 16:42:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695048130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rCGxSHuWGPFauDO78J2cjgmvZQU9Lb4U+fA74G/EWJo=; b=Ia6iHavNAZq23lccxKv6KN5M4xxlFsotsd1nbp35PizcpNpqJuWE+MdGlR51F2AoxtdrpS nIdS9xq5S9OWYRb2pwV/IWkKxR61ySdr1vsX3yuVfzNiBW43t/OUcSzsPOO3e+mm3n8Xa+ 88Br/Fd+PR4qw5ftL+5rXxiwd6pej70= X-MC-Unique: 20ST3Oq7MNOk7BsJi2wFCA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Cc: quintela@redhat.com, peterx@redhat.com, leobras@redhat.com Subject: [PATCH 02/52] migration/rdma: Clean up qemu_rdma_data_init()'s return type Date: Mon, 18 Sep 2023 16:41:16 +0200 Message-ID: <20230918144206.560120-3-armbru@redhat.com> In-Reply-To: <20230918144206.560120-1-armbru@redhat.com> References: <20230918144206.560120-1-armbru@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1695048215398100013 Content-Type: text/plain; charset="utf-8" qemu_rdma_data_init() return type is void *. It actually returns RDMAContext *, and all its callers assign the value to an RDMAContext *. Unclean. Return RDMAContext * instead. Signed-off-by: Markus Armbruster Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 544d83be7e..3b9e21f8de 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2739,7 +2739,7 @@ static void qemu_rdma_return_path_dest_init(RDMAConte= xt *rdma_return_path, rdma_return_path->is_return_path =3D true; } =20 -static void *qemu_rdma_data_init(const char *host_port, Error **errp) +static RDMAContext *qemu_rdma_data_init(const char *host_port, Error **err= p) { RDMAContext *rdma =3D NULL; InetSocketAddress *addr; --=20 2.41.0