[v8] Implement reconnect for vhost-user-scsi

[PATCH v8 0/5] Implement reconnect for vhost-user-scsi

Posted by Li Feng 1 year, 7 months ago

Changes for v8:
- [PATCH 3/5] vhost-user-scsi: support reconnect to backend
  - Fix code style suggested by Manos Pitsidianakis
- [PATCH 4/5] vhost-user-scsi: start vhost when guest kicks
  - Use 'DEVICE()' macro in vhost_user_scsi_handle_output to replace the
    'parent_obj.parent_obj.parent_obj.parent_obj'.

Changes for v7:
- [PATCH 3/5] vhost-user-scsi: support reconnect to backend
  - Add reporting the error in vhost-scsi;
  - Rebase to master and fix the conflict.
- Add "Reviewed-by" tags.

Changes for v6:
- [PATCH] vhost-user: fix lost reconnect
  - Fix missing assign event_cb.

Changes for v5:
- No logic has been changed, just move part of the code from patch 4 to patch 5.

Changes for v4:
- Merge
  https://lore.kernel.org/all/20230830045722.611224-1-fengli@smartx.com/ to
  this series.
- Add ERRP_GUARD in vhost_user_scsi_realize;
- Reword the commit messages.

Changes for v3:
- Split the vhost_user_scsi_handle_output to a separate patch;
- Move the started_vu from vhost scsi common header to vhost-user-scsi header;
- Fix a log print error;

Changes for v2:
- Split the v1 patch to small separate patchset;
- New patch for fixing fd leak, which has sent to reviewers in another
  mail;
- Implement the `vhost_user_scsi_handle_output`;
- Add the started_vu safe check;
- Fix error handler;
- Check the inflight before set/get inflight fd.

Li Feng (5):
  vhost-user-common: send get_inflight_fd once
  vhost: move and rename the conn retry times
  vhost-user-scsi: support reconnect to backend
  vhost-user-scsi: start vhost when guest kicks
  vhost-user: fix lost reconnect

 hw/block/vhost-user-blk.c             |   6 +-
 hw/scsi/vhost-scsi-common.c           |  47 ++---
 hw/scsi/vhost-scsi.c                  |   6 +-
 hw/scsi/vhost-user-scsi.c             | 250 +++++++++++++++++++++++---
 hw/virtio/vhost-user-gpio.c           |   5 +-
 hw/virtio/vhost-user.c                |  10 +-
 include/hw/virtio/vhost-scsi-common.h |   2 +-
 include/hw/virtio/vhost-user-scsi.h   |   6 +
 include/hw/virtio/vhost-user.h        |   3 +-
 include/hw/virtio/vhost.h             |   2 +
 10 files changed, 277 insertions(+), 60 deletions(-)

-- 
2.41.0

Re: [PATCH v8 0/5] Implement reconnect for vhost-user-scsi

Posted by Li Feng 1 year, 6 months ago

Hello Guys,
Ping… 
These patches have been waiting for a long time. Can they be merged?

Best Regards, 
li

> On 9 Oct 2023, at 12:46 PM, Li Feng <fengli@smartx.com> wrote:
> 
> Changes for v8:
> - [PATCH 3/5] vhost-user-scsi: support reconnect to backend
>  - Fix code style suggested by Manos Pitsidianakis
> - [PATCH 4/5] vhost-user-scsi: start vhost when guest kicks
>  - Use 'DEVICE()' macro in vhost_user_scsi_handle_output to replace the
>    'parent_obj.parent_obj.parent_obj.parent_obj'.
> 
> Changes for v7:
> - [PATCH 3/5] vhost-user-scsi: support reconnect to backend
>  - Add reporting the error in vhost-scsi;
>  - Rebase to master and fix the conflict.
> - Add "Reviewed-by" tags.
> 
> Changes for v6:
> - [PATCH] vhost-user: fix lost reconnect
>  - Fix missing assign event_cb.
> 
> Changes for v5:
> - No logic has been changed, just move part of the code from patch 4 to patch 5.
> 
> Changes for v4:
> - Merge
>  https://lore.kernel.org/all/20230830045722.611224-1-fengli@smartx.com/ to
>  this series.
> - Add ERRP_GUARD in vhost_user_scsi_realize;
> - Reword the commit messages.
> 
> Changes for v3:
> - Split the vhost_user_scsi_handle_output to a separate patch;
> - Move the started_vu from vhost scsi common header to vhost-user-scsi header;
> - Fix a log print error;
> 
> Changes for v2:
> - Split the v1 patch to small separate patchset;
> - New patch for fixing fd leak, which has sent to reviewers in another
>  mail;
> - Implement the `vhost_user_scsi_handle_output`;
> - Add the started_vu safe check;
> - Fix error handler;
> - Check the inflight before set/get inflight fd.
> 
> Li Feng (5):
>  vhost-user-common: send get_inflight_fd once
>  vhost: move and rename the conn retry times
>  vhost-user-scsi: support reconnect to backend
>  vhost-user-scsi: start vhost when guest kicks
>  vhost-user: fix lost reconnect
> 
> hw/block/vhost-user-blk.c             |   6 +-
> hw/scsi/vhost-scsi-common.c           |  47 ++---
> hw/scsi/vhost-scsi.c                  |   6 +-
> hw/scsi/vhost-user-scsi.c             | 250 +++++++++++++++++++++++---
> hw/virtio/vhost-user-gpio.c           |   5 +-
> hw/virtio/vhost-user.c                |  10 +-
> include/hw/virtio/vhost-scsi-common.h |   2 +-
> include/hw/virtio/vhost-user-scsi.h   |   6 +
> include/hw/virtio/vhost-user.h        |   3 +-
> include/hw/virtio/vhost.h             |   2 +
> 10 files changed, 277 insertions(+), 60 deletions(-)
> 
> -- 
> 2.41.0
>

Re: [PATCH v8 0/5] Implement reconnect for vhost-user-scsi

Posted by Michael S. Tsirkin 1 year, 6 months ago

Queued. Thanks!
On Wed, Oct 18, 2023 at 04:26:10PM +0800, Li Feng wrote:
> Hello Guys,
> 
> Ping… 
> 
> These patches have been waiting for a long time. Can they be merged?
> 
> 
> Best Regards, 
> 
> li
> 
> 
>     On 9 Oct 2023, at 12:46 PM, Li Feng <fengli@smartx.com> wrote:
> 
>     Changes for v8:
>     - [PATCH 3/5] vhost-user-scsi: support reconnect to backend
>      - Fix code style suggested by Manos Pitsidianakis
>     - [PATCH 4/5] vhost-user-scsi: start vhost when guest kicks
>      - Use 'DEVICE()' macro in vhost_user_scsi_handle_output to replace the
>        'parent_obj.parent_obj.parent_obj.parent_obj'.
> 
>     Changes for v7:
>     - [PATCH 3/5] vhost-user-scsi: support reconnect to backend
>      - Add reporting the error in vhost-scsi;
>      - Rebase to master and fix the conflict.
>     - Add "Reviewed-by" tags.
> 
>     Changes for v6:
>     - [PATCH] vhost-user: fix lost reconnect
>      - Fix missing assign event_cb.
> 
>     Changes for v5:
>     - No logic has been changed, just move part of the code from patch 4 to
>     patch 5.
> 
>     Changes for v4:
>     - Merge
>      https://lore.kernel.org/all/20230830045722.611224-1-fengli@smartx.com/ to
>      this series.
>     - Add ERRP_GUARD in vhost_user_scsi_realize;
>     - Reword the commit messages.
> 
>     Changes for v3:
>     - Split the vhost_user_scsi_handle_output to a separate patch;
>     - Move the started_vu from vhost scsi common header to vhost-user-scsi
>     header;
>     - Fix a log print error;
> 
>     Changes for v2:
>     - Split the v1 patch to small separate patchset;
>     - New patch for fixing fd leak, which has sent to reviewers in another
>      mail;
>     - Implement the `vhost_user_scsi_handle_output`;
>     - Add the started_vu safe check;
>     - Fix error handler;
>     - Check the inflight before set/get inflight fd.
> 
>     Li Feng (5):
>      vhost-user-common: send get_inflight_fd once
>      vhost: move and rename the conn retry times
>      vhost-user-scsi: support reconnect to backend
>      vhost-user-scsi: start vhost when guest kicks
>      vhost-user: fix lost reconnect
> 
>     hw/block/vhost-user-blk.c             |   6 +-
>     hw/scsi/vhost-scsi-common.c           |  47 ++---
>     hw/scsi/vhost-scsi.c                  |   6 +-
>     hw/scsi/vhost-user-scsi.c             | 250 +++++++++++++++++++++++---
>     hw/virtio/vhost-user-gpio.c           |   5 +-
>     hw/virtio/vhost-user.c                |  10 +-
>     include/hw/virtio/vhost-scsi-common.h |   2 +-
>     include/hw/virtio/vhost-user-scsi.h   |   6 +
>     include/hw/virtio/vhost-user.h        |   3 +-
>     include/hw/virtio/vhost.h             |   2 +
>     10 files changed, 277 insertions(+), 60 deletions(-)
> 
>     --
>     2.41.0
> 
> 
>