record/replay fixes, maybe for 8.2 or for post release stable?

[PATCH 05/11] replay: remove host_clock_last

Posted by Alex Bennée 1 year, 5 months ago

Fixes: a02fe2ca70 (replay: Remove host_clock_last)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 replay/replay-internal.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index b6836354ac..516147ddbc 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -80,8 +80,6 @@ typedef struct ReplayState {
         This counter is global, because requests from different
         block devices should not get overlapping ids. */
     uint64_t block_request_id;
-    /*! Prior value of the host clock */
-    uint64_t host_clock_last;
     /*! Asynchronous event id read from the log */
     uint64_t read_event_id;
 } ReplayState;
-- 
2.39.2

Re: [PATCH 05/11] replay: remove host_clock_last

Posted by Pavel Dovgalyuk 1 year, 5 months ago

On 05.12.2023 23:41, Alex Bennée wrote:
> Fixes: a02fe2ca70 (replay: Remove host_clock_last)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   replay/replay-internal.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/replay/replay-internal.h b/replay/replay-internal.h
> index b6836354ac..516147ddbc 100644
> --- a/replay/replay-internal.h
> +++ b/replay/replay-internal.h
> @@ -80,8 +80,6 @@ typedef struct ReplayState {
>           This counter is global, because requests from different
>           block devices should not get overlapping ids. */
>       uint64_t block_request_id;
> -    /*! Prior value of the host clock */
> -    uint64_t host_clock_last;
>       /*! Asynchronous event id read from the log */
>       uint64_t read_event_id;
>   } ReplayState;

Reviewed-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>

Re: [PATCH 05/11] replay: remove host_clock_last

Posted by Richard Henderson 1 year, 5 months ago

On 12/5/23 12:41, Alex Bennée wrote:
> Fixes: a02fe2ca70 (replay: Remove host_clock_last)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   replay/replay-internal.h | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH 05/11] replay: remove host_clock_last

Posted by Philippe Mathieu-Daudé 1 year, 5 months ago

On 5/12/23 21:41, Alex Bennée wrote:
> Fixes: a02fe2ca70 (replay: Remove host_clock_last)
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   replay/replay-internal.h | 2 --
>   1 file changed, 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>