From nobody Fri Jun 20 18:58:10 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1708094775; cv=none; d=zohomail.com; s=zohoarc; b=OihFRheFJvFHUlD6EYwUDbOjJBlzyAU1K3QWWqdxFhbDz3vb8QDOCZfNzO1z2UCuyLmJEvDOddNwBZErLrnSuIn1Cci22K4GXY/DQUteAO5dqD4mwBCH45O2grRqNOLQ5tNmI9NMuAZEZ4r4/Z0SBy/Pso66EwbvbZNSIU062tI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1708094775; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=KP3NDJ7dfHzQCSzt0PgrNJvgys3Oy0XprB8gfHPtz30=; b=a6Eww1fCQdfOWd1xgXAVY3474FY6cmpu3V6aM4QduSKniYXZGfbyfz3IBGMA2nrWtT//KzTodwXgSOnOte6d5GFZFJfCcVnXmqMf4IxXsp3NHhyO7r6Zm6hlstkSiXNZB4l2DtHgwGbSfpi5HkBE2By84xTG0g6PBUsedzySBr4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 170809477517131.32542257242335; Fri, 16 Feb 2024 06:46:15 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1razTB-0005ir-Qc; Fri, 16 Feb 2024 09:45:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1razTA-0005iG-SI for qemu-devel@nongnu.org; Fri, 16 Feb 2024 09:45:40 -0500 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1razT8-0005aA-Ff for qemu-devel@nongnu.org; Fri, 16 Feb 2024 09:45:40 -0500 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-563c595f968so2012887a12.0 for ; Fri, 16 Feb 2024 06:45:37 -0800 (PST) Received: from m1x-phil.lan ([176.187.210.246]) by smtp.gmail.com with ESMTPSA id f23-20020a170906561700b00a3d828c54f1sm1615697ejq.135.2024.02.16.06.45.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 16 Feb 2024 06:45:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708094736; x=1708699536; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KP3NDJ7dfHzQCSzt0PgrNJvgys3Oy0XprB8gfHPtz30=; b=SzmN/DfKCfAwW582Cvc2v0biW/fAtalTGq1AJWkI9i+9ZcXvaJjo8eNaddx1qW0pKk 5ljPpcuunycwZGgPaz2mYsSXI+WcDWn8/+DaHCiEVU5S6F5XL/4qFWFnJvuggEU/2h76 WmbrDts/3J7Uo49MGa2tk7P345eZxhQWROhs0asdYgYY7883HR/gwWqsb500CXqNNB0k sUzfW0SzD6BDNyjpzPKBL7PdV0QmpgIh3F1sn6ZsnmQ3PBKX21o3Npq1lzFe4foYvCqx jmeAK5+9gXISASm86rA9608uIJQGymya6sQugyF0Yn9hhLKDe42uD9G5uqQinx5wEzOA 8NBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708094736; x=1708699536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KP3NDJ7dfHzQCSzt0PgrNJvgys3Oy0XprB8gfHPtz30=; b=YQpl8vMfhvbXRXwy0pbW852dItOYfQou61JMP6RVzQpI0WI+SSdxBEArfu37zbH3jS N9TBF9OClxXx0zXB0Bf61aKe6X0433XapivYfhI0LACyBdgOHBtbERiBxa+Tpnyr5ReT RaE0vk+B3p7X+S6CrZloxLCPLkrCWwAaci2FXfjJdUYwP7Pg+QXh3T5pEIb5mdG0e1q1 vWa72dX2m10mWPMgMD/5STbJUiXwRWl+/aPPo8T/zoNOJIramn5qKDRmDs6dQ++DbOk1 6rvK8a1frcV2NUJftznKyIiCNTz4vsxllkdXEnGd1n16FdorSx5wqAF/LCDCpCRZfesH 9B4w== X-Gm-Message-State: AOJu0YzIqgBkc5eU8isUu+yuZTIITyilItK4bYXodsRimit1huXA5L7k eAnSyz7J+qlmbQo8A3NbK3LWX3+U9xB7iFs1UyV+vO7uj46MvhvItE0esniYaEyo2m4WxC0fjNa L X-Google-Smtp-Source: AGHT+IFezJ1NTj0Ec/JML69adDR/zjxsCrFj4UPkbD8Hzygfn8YmPSIF0oVv3Yt9F2bgz1Z1iNIpbw== X-Received: by 2002:a17:906:b794:b0:a3d:2233:13fa with SMTP id dt20-20020a170906b79400b00a3d223313famr3587856ejb.55.1708094736506; Fri, 16 Feb 2024 06:45:36 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Gustavo Romero Cc: Thomas Huth , Laurent Vivier , qemu-arm@nongnu.org, alex.bennee@linaro.org, Paolo Bonzini , Anton Kochkov , richard.henderson@linaro.org, Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH v2 6/6] tests/qtest: Add ivshmem-flat test Date: Fri, 16 Feb 2024 15:44:56 +0100 Message-ID: <20240216144456.34992-7-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240216144456.34992-1-philmd@linaro.org> References: <20240216144456.34992-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=philmd@linaro.org; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1708094776559100003 From: Gustavo Romero Add qtest for the ivshmem-flat device. Signed-off-by: Gustavo Romero Message-ID: <20231127052024.435743-4-gustavo.romero@linaro.org> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/qtest/ivshmem-flat-test.c | 320 ++++++++++++++++++++++++++++++++ tests/qtest/meson.build | 2 + 2 files changed, 322 insertions(+) create mode 100644 tests/qtest/ivshmem-flat-test.c diff --git a/tests/qtest/ivshmem-flat-test.c b/tests/qtest/ivshmem-flat-tes= t.c new file mode 100644 index 0000000000..5489a0d915 --- /dev/null +++ b/tests/qtest/ivshmem-flat-test.c @@ -0,0 +1,320 @@ +/* + * Inter-VM Shared Memory Flat Device qtests + * + * SPDX-FileCopyrightText: 2023 Linaro Ltd. + * SPDX-FileContributor: Gustavo Romero + * SPDX-License-Identifier: GPL-2.0-or-later + * + */ + +#include "ivshmem-utils.h" + +#define IVSHMEM_FLAT_MMR_ADDR 0x400FF000 +#define IVSHMEM_FLAT_SHM_ADDR 0x40100000 +#define SHM_SIZE 131072 /* 128k */ + +static ServerThread thread; + +uint32_t *shm_ptr; +char *shm_rel_path; +char *server_socket_path; + +static void cleanup(void) +{ + if (shm_ptr) { + munmap(shm_ptr, SHM_SIZE); + shm_ptr =3D NULL; + } + + if (shm_rel_path) { + shm_unlink(shm_rel_path); + shm_rel_path =3D NULL; + } + + if (server_socket_path) { + unlink(server_socket_path); + server_socket_path =3D NULL; + } +} + +static void abort_handler(void *data) +{ + test_ivshmem_server_stop(&thread); + cleanup(); +} + +/* + * Check if exactly 1 positive pulse (low->high->low) on 'irq' IRQ line ha= ppens + * in 'timeout' second(s). 'irq' must be intercepted using qtest_irq_inter= cept_* + * before this function can be used on it. It returns 0 when pulse is dete= cted, + * otherwise 1. + */ +static int test_ivshmem_flat_irq_positive_pulse(QTestState *qts, int irq, + int timeout) +{ + uint64_t num_raises =3D 0; + uint64_t num_lows =3D 0; + uint64_t end_time; + + end_time =3D g_get_monotonic_time() + timeout * G_TIME_SPAN_SECOND; + do { + num_raises =3D qtest_get_irq_raised_counter(qts, 0); + if (num_raises) { + num_lows =3D qtest_get_irq_lowered_counter(qts, 0); + /* Check for 1 raise and 1 low IRQ event. */ + if (num_raises =3D=3D num_lows && num_lows =3D=3D 1) { + return 0; + } else { + g_message("%s: Timeout expired", __func__); + return 1; + } + } + qtest_clock_step(qts, 10000); + } while (g_get_monotonic_time() < end_time); + + return 1; +} + +static inline uint32_t read_reg(QTestState *qts, enum Reg reg) +{ + uint32_t v; + + qtest_memread(qts, IVSHMEM_FLAT_MMR_ADDR + reg, &v, sizeof(v)); + + return v; +} + +static inline void write_reg(QTestState *qts, enum Reg reg, uint32_t v) +{ + qtest_memwrite(qts, IVSHMEM_FLAT_MMR_ADDR + reg, &v, sizeof(v)); +} + +/* + * Setup a test VM with ivshmem-flat device attached, IRQ properly set, and + * connected to the ivshmem-server. + */ +static QTestState *setup_vm(void) +{ + QTestState *qts; + const char *cmd_line; + + cmd_line =3D g_strdup_printf("-machine lm3s6965evb " + "-chardev socket,path=3D%s,id=3Divshm " + "-device ivshmem-flat,chardev=3Divshm," + "x-irq-qompath=3D'/machine/unattached/devic= e[1]/nvic/unnamed-gpio-in[0]'," + "x-bus-qompath=3D'/sysbus',shmem-size=3D%d", + server_socket_path, SHM_SIZE); + qts =3D qtest_init(cmd_line); + + return qts; +} + +static void test_ivshmem_flat_irq(void) +{ + QTestState *vm_state; + uint16_t own_id; + + vm_state =3D setup_vm(); + + qtest_irq_intercept_out_named(vm_state, + "/machine/peripheral-anon/device[0]", + "irq-output"); + + /* IVPOSTION has the device's own ID distributed by the ivshmem-server= . */ + own_id =3D read_reg(vm_state, IVPOSITION); + + /* Make device notify itself. */ + write_reg(vm_state, DOORBELL, (own_id << 16) | 0 /* vector 0 */); + + /* + * Check intercepted device's IRQ output line. Named IRQ line 'irq-out= put' + * was associated to qtest IRQ 0 and after self notification qtest IRQ= 0 + * must be toggled by the device. The test fails if no toggling is det= ected + * in 2 seconds. + */ + g_assert(test_ivshmem_flat_irq_positive_pulse(vm_state, 0, 2) =3D=3D 0= ); + + qtest_quit(vm_state); +} + +static void test_ivshmem_flat_shm_write(void) +{ + QTestState *vm_state; + int num_elements, i; + uint32_t *data; + + vm_state =3D setup_vm(); + + /* Prepare test data with random values. */ + data =3D g_malloc(SHM_SIZE); + num_elements =3D SHM_SIZE / sizeof(*data); + for (i =3D 0; i < num_elements; i++) { + data[i] =3D g_test_rand_int(); + } + + /* + * Write test data to VM address IVSHMEM_FLAT_SHM_ADDR, where the shar= ed + * memory region is located. + */ + qtest_memwrite(vm_state, IVSHMEM_FLAT_SHM_ADDR, data, SHM_SIZE); + + /* + * Since the shared memory fd is mmapped into this test process VMA at + * shm_ptr, every byte written by the VM in its shared memory region s= hould + * also be available in the test process via shm_ptr. Thus, data in sh= m_ptr + * is compared back against the original test data. + */ + for (i =3D 0; i < num_elements; i++) { + g_assert_cmpint(shm_ptr[i], =3D=3D, data[i]); + } + + qtest_quit(vm_state); +} + +static void test_ivshmem_flat_shm_read(void) +{ + QTestState *vm_state; + int num_elements, i; + uint32_t *data; + uint32_t v; + + vm_state =3D setup_vm(); + + /* Prepare test data with random values. */ + data =3D g_malloc(SHM_SIZE); + num_elements =3D SHM_SIZE / sizeof(*data); + for (i =3D 0; i < num_elements; i++) { + data[i] =3D g_test_rand_int(); + } + + /* + * Copy test data to the shared memory region so it can be read from t= he VM + * (IVSHMEM_FLAT_SHM_ADDR location). + */ + memcpy(shm_ptr, data, SHM_SIZE); + + /* Check data */ + for (i =3D 0; i < num_elements; i++) { + qtest_memread(vm_state, IVSHMEM_FLAT_SHM_ADDR + i * sizeof(v), &v, + sizeof(v)); + g_assert_cmpint(v, =3D=3D, data[i]); + } + + qtest_quit(vm_state); +} + +static void test_ivshmem_flat_shm_pair(void) +{ + QTestState *vm0_state, *vm1_state; + uint16_t vm0_peer_id, vm1_peer_id; + int num_elements, i; + uint32_t *data; + uint32_t v; + + vm0_state =3D setup_vm(); + vm1_state =3D setup_vm(); + + /* Get peer ID for the VM so it can be used for one notify each other.= */ + vm0_peer_id =3D read_reg(vm0_state, IVPOSITION); + vm1_peer_id =3D read_reg(vm1_state, IVPOSITION); + + /* Observe vm1 IRQ output line first. */ + qtest_irq_intercept_out_named(vm1_state, + "/machine/peripheral-anon/device[0]", + "irq-output"); + + /* Notify (interrupt) VM1 from VM0. */ + write_reg(vm0_state, DOORBELL, (vm1_peer_id << 16) | 0 /* vector 0 */); + + /* Check if VM1 IRQ output line is toggled after notification from VM0= . */ + g_assert(test_ivshmem_flat_irq_positive_pulse(vm1_state, 0, 2) =3D=3D = 0); + + /* Secondly, observe VM0 IRQ output line first. */ + qtest_irq_intercept_out_named(vm0_state, + "/machine/peripheral-anon/device[0]", + "irq-output"); + + /* ... and do the opposite: notify (interrupt) VM0 from VM1. */ + write_reg(vm1_state, DOORBELL, (vm0_peer_id << 16) | 0 /* vector 0 */); + + /* Check if VM0 IRQ output line is toggled after notification from VM0= . */ + g_assert(test_ivshmem_flat_irq_positive_pulse(vm0_state, 0, 2) =3D=3D = 0); + + /* Prepare test data with random values. */ + data =3D g_malloc(SHM_SIZE); + num_elements =3D SHM_SIZE / sizeof(*data); + for (i =3D 0; i < num_elements; i++) { + data[i] =3D g_test_rand_int(); + } + + /* Write test data on VM0. */ + qtest_memwrite(vm0_state, IVSHMEM_FLAT_SHM_ADDR, data, SHM_SIZE); + + /* Check test data on VM1. */ + for (i =3D 0; i < num_elements; i++) { + qtest_memread(vm1_state, IVSHMEM_FLAT_SHM_ADDR + i * sizeof(v), &v, + sizeof(v)); + g_assert_cmpint(v, =3D=3D, data[i]); + } + + /* Prepare new test data with random values. */ + for (i =3D 0; i < num_elements; i++) { + data[i] =3D g_test_rand_int(); + } + + /* Write test data on VM1. */ + qtest_memwrite(vm1_state, IVSHMEM_FLAT_SHM_ADDR, data, SHM_SIZE); + + /* Check test data on VM0. */ + for (i =3D 0; i < num_elements; i++) { + qtest_memread(vm0_state, IVSHMEM_FLAT_SHM_ADDR + i * sizeof(v), &v, + sizeof(v)); + g_assert_cmpint(v, =3D=3D, data[i]); + } + + qtest_quit(vm0_state); + qtest_quit(vm1_state); +} + +int main(int argc, char *argv[]) +{ + int shm_fd, r; + + g_test_init(&argc, &argv, NULL); + + /* If test fails, stop server, cleanup socket and shm files. */ + qtest_add_abrt_handler(abort_handler, NULL); + + shm_rel_path =3D mktempshm(SHM_SIZE, &shm_fd); + g_assert(shm_rel_path); + + /* + * Map shm to this test's VMA so it's possible to read/write from/to i= t. For + * VMs with the ivhsmem-flat device attached, this region will also be + * mapped in their own memory layout, at IVSHMEM_FLAT_SHM_ADDR (defaul= t). + */ + shm_ptr =3D mmap(0, SHM_SIZE, PROT_READ | PROT_WRITE, MAP_SHARED, shm_= fd, 0); + g_assert(shm_ptr !=3D MAP_FAILED); + + server_socket_path =3D mktempsocket(); + /* It never fails, so no assert(). */ + + /* + * Currently, ivshmem-flat device only supports notification via 1 vec= tor, + * i.e. vector 0. + */ + test_ivshmem_server_start(&thread, server_socket_path, shm_rel_path, 1= ); + + /* Register tests. */ + qtest_add_func("/ivshmem-flat/irq", test_ivshmem_flat_irq); + qtest_add_func("/ivshmem-flat/shm-write", test_ivshmem_flat_shm_write); + qtest_add_func("/ivshmem-flat/shm-read", test_ivshmem_flat_shm_read); + qtest_add_func("/ivshmem-flat/pair", test_ivshmem_flat_shm_pair); + + r =3D g_test_run(); + + test_ivshmem_server_stop(&thread); + cleanup(); + + return r; +} diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build index bc6457220c..c0468bc6e0 100644 --- a/tests/qtest/meson.build +++ b/tests/qtest/meson.build @@ -205,6 +205,7 @@ qtests_stm32l4x5 =3D \ 'stm32l4x5_syscfg-test'] =20 qtests_arm =3D \ + (config_all_devices.has_key('CONFIG_IVSHMEM_FLAT_DEVICE') ? ['ivshmem-fl= at-test'] : []) + \ (config_all_devices.has_key('CONFIG_MPS2') ? ['sse-timer-test'] : []) + \ (config_all_devices.has_key('CONFIG_CMSDK_APB_DUALTIMER') ? ['cmsdk-apb-= dualtimer-test'] : []) + \ (config_all_devices.has_key('CONFIG_CMSDK_APB_TIMER') ? ['cmsdk-apb-time= r-test'] : []) + \ @@ -320,6 +321,7 @@ qtests =3D { 'dbus-vmstate-test': files('migration-helpers.c') + dbus_vmstate1, 'erst-test': files('erst-test.c'), 'ivshmem-test': ['ivshmem-utils.c', '../../contrib/ivshmem-server/ivshme= m-server.c'], + 'ivshmem-flat-test': ['ivshmem-utils.c', '../../contrib/ivshmem-server/i= vshmem-server.c'], 'migration-test': migration_files, 'pxe-test': files('boot-sector.c'), 'qos-test': [chardev, io, qos_test_ss.apply({}).sources()], --=20 2.41.0