[v1] accel/tcg: Improve disassembly for target and plugin

[PATCH 33/32] accel/tcg: Remove cpu_ldsb_code / cpu_ldsw_code

Posted by Philippe Mathieu-Daudé 1 year, 10 months ago

Previous commits replaced them by translator_ld* calls.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/exec/cpu_ldst.h | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
index eb8f3f0595..85ca104dc9 100644
--- a/include/exec/cpu_ldst.h
+++ b/include/exec/cpu_ldst.h
@@ -438,16 +438,6 @@ uint32_t cpu_lduw_code(CPUArchState *env, abi_ptr addr);
 uint32_t cpu_ldl_code(CPUArchState *env, abi_ptr addr);
 uint64_t cpu_ldq_code(CPUArchState *env, abi_ptr addr);
 
-static inline int cpu_ldsb_code(CPUArchState *env, abi_ptr addr)
-{
-    return (int8_t)cpu_ldub_code(env, addr);
-}
-
-static inline int cpu_ldsw_code(CPUArchState *env, abi_ptr addr)
-{
-    return (int16_t)cpu_lduw_code(env, addr);
-}
-
 /**
  * tlb_vaddr_to_host:
  * @env: CPUArchState
-- 
2.41.0

Re: [PATCH 33/32] accel/tcg: Remove cpu_ldsb_code / cpu_ldsw_code

Posted by Richard Henderson 1 year, 10 months ago

On 4/5/24 03:15, Philippe Mathieu-Daudé wrote:
> Previous commits replaced them by translator_ld* calls.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   include/exec/cpu_ldst.h | 10 ----------
>   1 file changed, 10 deletions(-)

Thanks, queued.


r~

> 
> diff --git a/include/exec/cpu_ldst.h b/include/exec/cpu_ldst.h
> index eb8f3f0595..85ca104dc9 100644
> --- a/include/exec/cpu_ldst.h
> +++ b/include/exec/cpu_ldst.h
> @@ -438,16 +438,6 @@ uint32_t cpu_lduw_code(CPUArchState *env, abi_ptr addr);
>   uint32_t cpu_ldl_code(CPUArchState *env, abi_ptr addr);
>   uint64_t cpu_ldq_code(CPUArchState *env, abi_ptr addr);
>   
> -static inline int cpu_ldsb_code(CPUArchState *env, abi_ptr addr)
> -{
> -    return (int8_t)cpu_ldub_code(env, addr);
> -}
> -
> -static inline int cpu_ldsw_code(CPUArchState *env, abi_ptr addr)
> -{
> -    return (int16_t)cpu_lduw_code(env, addr);
> -}
> -
>   /**
>    * tlb_vaddr_to_host:
>    * @env: CPUArchState