qga: Re-enable the qga-ssh-test when running without fuzzing

[PATCH] qga: Re-enable the qga-ssh-test when running without fuzzing

Posted by Thomas Huth 1 week, 4 days ago

According to the comment in qga/meson.build, the test got disabled
since there were problems with the fuzzing job. But instead of
disabling this test completely, we should still be fine running
it when fuzzing is disabled.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 qga/meson.build | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/qga/meson.build b/qga/meson.build
index 1c3d2a3d1b..46c1d83d7f 100644
--- a/qga/meson.build
+++ b/qga/meson.build
@@ -181,12 +181,11 @@ test_env = environment()
 test_env.set('G_TEST_SRCDIR', meson.current_source_dir())
 test_env.set('G_TEST_BUILDDIR', meson.current_build_dir())
 
-# disable qga-ssh-test for now. glib's G_TEST_OPTION_ISOLATE_DIRS triggers
+# disable qga-ssh-test with fuzzing: glib's G_TEST_OPTION_ISOLATE_DIRS triggers
 # the leak detector in build-oss-fuzz Gitlab CI test. we should re-enable
 # this when an alternative is implemented or when the underlying glib
 # issue is identified/fix
-#if host_os != 'windows'
-if false
+if host_os != 'windows' and not get_option('fuzzing')
   srcs = [files('commands-posix-ssh.c')]
   i = 0
   foreach output: qga_qapi_outputs
-- 
2.44.0

Re: [PATCH] qga: Re-enable the qga-ssh-test when running without fuzzing

Posted by Konstantin Kostiuk 1 week, 1 day ago

Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>



On Fri, Apr 26, 2024 at 7:23 PM Thomas Huth <thuth@redhat.com> wrote:

> According to the comment in qga/meson.build, the test got disabled
> since there were problems with the fuzzing job. But instead of
> disabling this test completely, we should still be fine running
> it when fuzzing is disabled.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  qga/meson.build | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/qga/meson.build b/qga/meson.build
> index 1c3d2a3d1b..46c1d83d7f 100644
> --- a/qga/meson.build
> +++ b/qga/meson.build
> @@ -181,12 +181,11 @@ test_env = environment()
>  test_env.set('G_TEST_SRCDIR', meson.current_source_dir())
>  test_env.set('G_TEST_BUILDDIR', meson.current_build_dir())
>
> -# disable qga-ssh-test for now. glib's G_TEST_OPTION_ISOLATE_DIRS triggers
> +# disable qga-ssh-test with fuzzing: glib's G_TEST_OPTION_ISOLATE_DIRS
> triggers
>  # the leak detector in build-oss-fuzz Gitlab CI test. we should re-enable
>  # this when an alternative is implemented or when the underlying glib
>  # issue is identified/fix
> -#if host_os != 'windows'
> -if false
> +if host_os != 'windows' and not get_option('fuzzing')
>    srcs = [files('commands-posix-ssh.c')]
>    i = 0
>    foreach output: qga_qapi_outputs
> --
> 2.44.0
>
>

Re: [PATCH] qga: Re-enable the qga-ssh-test when running without fuzzing

Posted by Philippe Mathieu-Daudé 1 week, 4 days ago

On 26/4/24 18:23, Thomas Huth wrote:
> According to the comment in qga/meson.build, the test got disabled
> since there were problems with the fuzzing job. But instead of
> disabling this test completely, we should still be fine running
> it when fuzzing is disabled.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   qga/meson.build | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>