From nobody Mon Jun 9 12:32:44 2025 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1714588288; cv=none; d=zohomail.com; s=zohoarc; b=hTVCgDCMZJkPSrZW1r2Sk32VXUXdHwmtfY3GWkglBaUpzEiLCBAh9rqtV9q8mjob6YI4/n+Q7J42mAgRrzyuEBLPs5JCTutLzXXHOaMWtyv585+tv28aJ1nSIxz6/U7auI/oiHWCyU5IvqE/aX3IKoKAvVU8/P/KH6+fbKOYDm8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1714588288; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mwEVoCc93jx5nfg7NRvnFyOc5Hj+ZUL12dTpbCUFPNw=; b=hWgRqW7q2PTg+zevI4TMxUT2khl6i5arzLtx0Z0x8w0PssZA1lk4OyzUuZlD1bUqfcTC19WY6kiEAThWolntVT43s05AsLhSTH6gF73syoxUVrBky1mqql68MFW1pY+pxCc8v4s0D3Vz3s939jGTHEYEpn2SsMArSGLCMu5vfCQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 171458828871378.7388483350046; Wed, 1 May 2024 11:31:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s2EhM-0006Mj-BD; Wed, 01 May 2024 14:28:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2EhK-0006Jo-Qv for qemu-devel@nongnu.org; Wed, 01 May 2024 14:28:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s2EhI-0003Ka-NB for qemu-devel@nongnu.org; Wed, 01 May 2024 14:28:54 -0400 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-56-EUIZLs3aOTmTEOZxAnXtDA-1; Wed, 01 May 2024 14:28:45 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EF2471005055; Wed, 1 May 2024 18:28:44 +0000 (UTC) Received: from toolbox.redhat.com (unknown [10.42.28.121]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E8936958; Wed, 1 May 2024 18:28:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714588132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mwEVoCc93jx5nfg7NRvnFyOc5Hj+ZUL12dTpbCUFPNw=; b=BhiIYjN8Vos0GVKcZmB+EDROVaPtLQmpmWNBKBgbAASg0xHqh1yPKMcLI4SucPtHMaP45w Pf5O9f2p2VMZDkaOnTWKPOBES/Lio8ayraqzsFsBfLUlLOlNhUgrWw8YGryiyLIKPmu6J+ N4lailEqcqM86w1ELvNLUrl4Z6rsplY= X-MC-Unique: EUIZLs3aOTmTEOZxAnXtDA-1 From: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= To: qemu-devel@nongnu.org Cc: Harsh Prateek Bora , Peter Maydell , Nicholas Piggin , Richard Henderson , Yanan Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Halil Pasic , Laurent Vivier , qemu-arm@nongnu.org, Daniel Henrique Barboza , Eduardo Habkost , qemu-ppc@nongnu.org, David Gibson , Ilya Leoshkevich , Eric Farman , Christian Borntraeger , "Michael S. Tsirkin" , Paolo Bonzini , Marcel Apfelbaum , David Hildenbrand , qemu-s390x@nongnu.org, =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH 03/14] hw/s390x: convert 'ccw' machine definitions to use new macros Date: Wed, 1 May 2024 19:27:48 +0100 Message-ID: <20240501182759.2934195-4-berrange@redhat.com> In-Reply-To: <20240501182759.2934195-1-berrange@redhat.com> References: <20240501182759.2934195-1-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.897, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1714588290831100003 This changes the DEFINE_CCW_MACHINE macro to use the common helpers for constructing versioned symbol names and strings, bringing greater consistency across targets. The added benefit is that it avoids the need to repeat the version number twice in two different formats in the calls to DEFINE_CCW_MACHINE. A DEFINE_CCW_MACHINE_AS_LATEST helper is added so that it is not required to pass 'false' for every single historical machine type. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 96 +++++++++++++++++++++----------------- 1 file changed, 53 insertions(+), 43 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 4dcc213820..9324fecdca 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -15,6 +15,7 @@ #include "qapi/error.h" #include "exec/ram_addr.h" #include "exec/confidential-guest-support.h" +#include "hw/boards.h" #include "hw/s390x/s390-virtio-hcall.h" #include "hw/s390x/sclp.h" #include "hw/s390x/s390_flic.h" @@ -832,35 +833,44 @@ bool css_migration_enabled(void) return get_machine_class()->css_migration_enabled; } =20 -#define DEFINE_CCW_MACHINE(suffix, verstr, latest) = \ - static void ccw_machine_##suffix##_class_init(ObjectClass *oc, = \ - void *data) = \ +#define DEFINE_CCW_MACHINE_IMPL(latest, ...) = \ + static void MACHINE_VER_SYM(class_init, ccw, __VA_ARGS__)( = \ + ObjectClass *oc, = \ + void *data) = \ { = \ MachineClass *mc =3D MACHINE_CLASS(oc); = \ - ccw_machine_##suffix##_class_options(mc); = \ - mc->desc =3D "Virtual s390x machine (version " verstr ")"; = \ + MACHINE_VER_SYM(class_options, ccw, __VA_ARGS__)(mc); = \ + mc->desc =3D "Virtual s390x machine (version " MACHINE_VER_STR(__V= A_ARGS__) ")"; \ if (latest) { = \ mc->alias =3D "s390-ccw-virtio"; = \ mc->is_default =3D true; = \ } = \ } = \ - static void ccw_machine_##suffix##_instance_init(Object *obj) = \ + static void MACHINE_VER_SYM(instance_init, ccw, __VA_ARGS__)(Object *o= bj) \ { = \ MachineState *machine =3D MACHINE(obj); = \ - current_mc =3D S390_CCW_MACHINE_CLASS(MACHINE_GET_CLASS(machine));= \ - ccw_machine_##suffix##_instance_options(machine); = \ + current_mc =3D S390_CCW_MACHINE_CLASS(MACHINE_GET_CLASS(machine));= \ + MACHINE_VER_SYM(instance_options, ccw, __VA_ARGS__)(machine); = \ } = \ - static const TypeInfo ccw_machine_##suffix##_info =3D { = \ - .name =3D MACHINE_TYPE_NAME("s390-ccw-virtio-" verstr), = \ + static const TypeInfo MACHINE_VER_SYM(info, ccw, __VA_ARGS__) =3D = \ + { = \ + .name =3D MACHINE_VER_TYPE_NAME("s390-ccw-virtio", __VA_ARGS__), = \ .parent =3D TYPE_S390_CCW_MACHINE, = \ - .class_init =3D ccw_machine_##suffix##_class_init, = \ - .instance_init =3D ccw_machine_##suffix##_instance_init, = \ + .class_init =3D MACHINE_VER_SYM(class_init, ccw, __VA_ARGS__), = \ + .instance_init =3D MACHINE_VER_SYM(instance_init, ccw, __VA_ARGS__= ), \ }; = \ - static void ccw_machine_register_##suffix(void) = \ + static void MACHINE_VER_SYM(register, ccw, __VA_ARGS__)(void) = \ { = \ - type_register_static(&ccw_machine_##suffix##_info); = \ + type_register_static(&MACHINE_VER_SYM(info, ccw, __VA_ARGS__)); = \ } = \ - type_init(ccw_machine_register_##suffix) + type_init(MACHINE_VER_SYM(register, ccw, __VA_ARGS__)) + +#define DEFINE_CCW_MACHINE_AS_LATEST(major, minor) \ + DEFINE_CCW_MACHINE_IMPL(true, major, minor) + +#define DEFINE_CCW_MACHINE(major, minor) \ + DEFINE_CCW_MACHINE_IMPL(false, major, minor) + =20 static void ccw_machine_9_1_instance_options(MachineState *machine) { @@ -869,7 +879,7 @@ static void ccw_machine_9_1_instance_options(MachineSta= te *machine) static void ccw_machine_9_1_class_options(MachineClass *mc) { } -DEFINE_CCW_MACHINE(9_1, "9.1", true); +DEFINE_CCW_MACHINE_AS_LATEST(9, 1); =20 static void ccw_machine_9_0_instance_options(MachineState *machine) { @@ -881,7 +891,7 @@ static void ccw_machine_9_0_class_options(MachineClass = *mc) ccw_machine_9_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_9_0, hw_compat_9_0_len); } -DEFINE_CCW_MACHINE(9_0, "9.0", false); +DEFINE_CCW_MACHINE(9, 0); =20 static void ccw_machine_8_2_instance_options(MachineState *machine) { @@ -893,7 +903,7 @@ static void ccw_machine_8_2_class_options(MachineClass = *mc) ccw_machine_9_0_class_options(mc); compat_props_add(mc->compat_props, hw_compat_8_2, hw_compat_8_2_len); } -DEFINE_CCW_MACHINE(8_2, "8.2", false); +DEFINE_CCW_MACHINE(8, 2); =20 static void ccw_machine_8_1_instance_options(MachineState *machine) { @@ -907,7 +917,7 @@ static void ccw_machine_8_1_class_options(MachineClass = *mc) mc->smp_props.drawers_supported =3D false; mc->smp_props.books_supported =3D false; } -DEFINE_CCW_MACHINE(8_1, "8.1", false); +DEFINE_CCW_MACHINE(8, 1); =20 static void ccw_machine_8_0_instance_options(MachineState *machine) { @@ -919,7 +929,7 @@ static void ccw_machine_8_0_class_options(MachineClass = *mc) ccw_machine_8_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_8_0, hw_compat_8_0_len); } -DEFINE_CCW_MACHINE(8_0, "8.0", false); +DEFINE_CCW_MACHINE(8, 0); =20 static void ccw_machine_7_2_instance_options(MachineState *machine) { @@ -931,7 +941,7 @@ static void ccw_machine_7_2_class_options(MachineClass = *mc) ccw_machine_8_0_class_options(mc); compat_props_add(mc->compat_props, hw_compat_7_2, hw_compat_7_2_len); } -DEFINE_CCW_MACHINE(7_2, "7.2", false); +DEFINE_CCW_MACHINE(7, 2); =20 static void ccw_machine_7_1_instance_options(MachineState *machine) { @@ -955,7 +965,7 @@ static void ccw_machine_7_1_class_options(MachineClass = *mc) compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); s390mc->max_threads =3D S390_MAX_CPUS; } -DEFINE_CCW_MACHINE(7_1, "7.1", false); +DEFINE_CCW_MACHINE(7, 1); =20 static void ccw_machine_7_0_instance_options(MachineState *machine) { @@ -970,7 +980,7 @@ static void ccw_machine_7_0_class_options(MachineClass = *mc) ccw_machine_7_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_7_0, hw_compat_7_0_len); } -DEFINE_CCW_MACHINE(7_0, "7.0", false); +DEFINE_CCW_MACHINE(7, 0); =20 static void ccw_machine_6_2_instance_options(MachineState *machine) { @@ -985,7 +995,7 @@ static void ccw_machine_6_2_class_options(MachineClass = *mc) ccw_machine_7_0_class_options(mc); compat_props_add(mc->compat_props, hw_compat_6_2, hw_compat_6_2_len); } -DEFINE_CCW_MACHINE(6_2, "6.2", false); +DEFINE_CCW_MACHINE(6, 2); =20 static void ccw_machine_6_1_instance_options(MachineState *machine) { @@ -1003,7 +1013,7 @@ static void ccw_machine_6_1_class_options(MachineClas= s *mc) compat_props_add(mc->compat_props, hw_compat_6_1, hw_compat_6_1_len); mc->smp_props.prefer_sockets =3D true; } -DEFINE_CCW_MACHINE(6_1, "6.1", false); +DEFINE_CCW_MACHINE(6, 1); =20 static void ccw_machine_6_0_instance_options(MachineState *machine) { @@ -1018,7 +1028,7 @@ static void ccw_machine_6_0_class_options(MachineClas= s *mc) ccw_machine_6_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_6_0, hw_compat_6_0_len); } -DEFINE_CCW_MACHINE(6_0, "6.0", false); +DEFINE_CCW_MACHINE(6, 0); =20 static void ccw_machine_5_2_instance_options(MachineState *machine) { @@ -1030,7 +1040,7 @@ static void ccw_machine_5_2_class_options(MachineClas= s *mc) ccw_machine_6_0_class_options(mc); compat_props_add(mc->compat_props, hw_compat_5_2, hw_compat_5_2_len); } -DEFINE_CCW_MACHINE(5_2, "5.2", false); +DEFINE_CCW_MACHINE(5, 2); =20 static void ccw_machine_5_1_instance_options(MachineState *machine) { @@ -1042,7 +1052,7 @@ static void ccw_machine_5_1_class_options(MachineClas= s *mc) ccw_machine_5_2_class_options(mc); compat_props_add(mc->compat_props, hw_compat_5_1, hw_compat_5_1_len); } -DEFINE_CCW_MACHINE(5_1, "5.1", false); +DEFINE_CCW_MACHINE(5, 1); =20 static void ccw_machine_5_0_instance_options(MachineState *machine) { @@ -1054,7 +1064,7 @@ static void ccw_machine_5_0_class_options(MachineClas= s *mc) ccw_machine_5_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_5_0, hw_compat_5_0_len); } -DEFINE_CCW_MACHINE(5_0, "5.0", false); +DEFINE_CCW_MACHINE(5, 0); =20 static void ccw_machine_4_2_instance_options(MachineState *machine) { @@ -1067,7 +1077,7 @@ static void ccw_machine_4_2_class_options(MachineClas= s *mc) mc->fixup_ram_size =3D s390_fixup_ram_size; compat_props_add(mc->compat_props, hw_compat_4_2, hw_compat_4_2_len); } -DEFINE_CCW_MACHINE(4_2, "4.2", false); +DEFINE_CCW_MACHINE(4, 2); =20 static void ccw_machine_4_1_instance_options(MachineState *machine) { @@ -1081,7 +1091,7 @@ static void ccw_machine_4_1_class_options(MachineClas= s *mc) ccw_machine_4_2_class_options(mc); compat_props_add(mc->compat_props, hw_compat_4_1, hw_compat_4_1_len); } -DEFINE_CCW_MACHINE(4_1, "4.1", false); +DEFINE_CCW_MACHINE(4, 1); =20 static void ccw_machine_4_0_instance_options(MachineState *machine) { @@ -1095,7 +1105,7 @@ static void ccw_machine_4_0_class_options(MachineClas= s *mc) ccw_machine_4_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_4_0, hw_compat_4_0_len); } -DEFINE_CCW_MACHINE(4_0, "4.0", false); +DEFINE_CCW_MACHINE(4, 0); =20 static void ccw_machine_3_1_instance_options(MachineState *machine) { @@ -1111,7 +1121,7 @@ static void ccw_machine_3_1_class_options(MachineClas= s *mc) ccw_machine_4_0_class_options(mc); compat_props_add(mc->compat_props, hw_compat_3_1, hw_compat_3_1_len); } -DEFINE_CCW_MACHINE(3_1, "3.1", false); +DEFINE_CCW_MACHINE(3, 1); =20 static void ccw_machine_3_0_instance_options(MachineState *machine) { @@ -1126,7 +1136,7 @@ static void ccw_machine_3_0_class_options(MachineClas= s *mc) ccw_machine_3_1_class_options(mc); compat_props_add(mc->compat_props, hw_compat_3_0, hw_compat_3_0_len); } -DEFINE_CCW_MACHINE(3_0, "3.0", false); +DEFINE_CCW_MACHINE(3, 0); =20 static void ccw_machine_2_12_instance_options(MachineState *machine) { @@ -1140,7 +1150,7 @@ static void ccw_machine_2_12_class_options(MachineCla= ss *mc) ccw_machine_3_0_class_options(mc); compat_props_add(mc->compat_props, hw_compat_2_12, hw_compat_2_12_len); } -DEFINE_CCW_MACHINE(2_12, "2.12", false); +DEFINE_CCW_MACHINE(2, 12); =20 static void ccw_machine_2_11_instance_options(MachineState *machine) { @@ -1161,7 +1171,7 @@ static void ccw_machine_2_11_class_options(MachineCla= ss *mc) compat_props_add(mc->compat_props, hw_compat_2_11, hw_compat_2_11_len); compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); } -DEFINE_CCW_MACHINE(2_11, "2.11", false); +DEFINE_CCW_MACHINE(2, 11); =20 static void ccw_machine_2_10_instance_options(MachineState *machine) { @@ -1173,7 +1183,7 @@ static void ccw_machine_2_10_class_options(MachineCla= ss *mc) ccw_machine_2_11_class_options(mc); compat_props_add(mc->compat_props, hw_compat_2_10, hw_compat_2_10_len); } -DEFINE_CCW_MACHINE(2_10, "2.10", false); +DEFINE_CCW_MACHINE(2, 10); =20 static void ccw_machine_2_9_instance_options(MachineState *machine) { @@ -1197,7 +1207,7 @@ static void ccw_machine_2_9_class_options(MachineClas= s *mc) compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); s390mc->css_migration_enabled =3D false; } -DEFINE_CCW_MACHINE(2_9, "2.9", false); +DEFINE_CCW_MACHINE(2, 9); =20 static void ccw_machine_2_8_instance_options(MachineState *machine) { @@ -1214,7 +1224,7 @@ static void ccw_machine_2_8_class_options(MachineClas= s *mc) compat_props_add(mc->compat_props, hw_compat_2_8, hw_compat_2_8_len); compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); } -DEFINE_CCW_MACHINE(2_8, "2.8", false); +DEFINE_CCW_MACHINE(2, 8); =20 static void ccw_machine_2_7_instance_options(MachineState *machine) { @@ -1229,7 +1239,7 @@ static void ccw_machine_2_7_class_options(MachineClas= s *mc) ccw_machine_2_8_class_options(mc); compat_props_add(mc->compat_props, hw_compat_2_7, hw_compat_2_7_len); } -DEFINE_CCW_MACHINE(2_7, "2.7", false); +DEFINE_CCW_MACHINE(2, 7); =20 static void ccw_machine_2_6_instance_options(MachineState *machine) { @@ -1249,7 +1259,7 @@ static void ccw_machine_2_6_class_options(MachineClas= s *mc) compat_props_add(mc->compat_props, hw_compat_2_6, hw_compat_2_6_len); compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); } -DEFINE_CCW_MACHINE(2_6, "2.6", false); +DEFINE_CCW_MACHINE(2, 6); =20 static void ccw_machine_2_5_instance_options(MachineState *machine) { @@ -1261,7 +1271,7 @@ static void ccw_machine_2_5_class_options(MachineClas= s *mc) ccw_machine_2_6_class_options(mc); compat_props_add(mc->compat_props, hw_compat_2_5, hw_compat_2_5_len); } -DEFINE_CCW_MACHINE(2_5, "2.5", false); +DEFINE_CCW_MACHINE(2, 5); =20 static void ccw_machine_2_4_instance_options(MachineState *machine) { @@ -1286,7 +1296,7 @@ static void ccw_machine_2_4_class_options(MachineClas= s *mc) compat_props_add(mc->compat_props, hw_compat_2_4, hw_compat_2_4_len); compat_props_add(mc->compat_props, compat, G_N_ELEMENTS(compat)); } -DEFINE_CCW_MACHINE(2_4, "2.4", false); +DEFINE_CCW_MACHINE(2, 4); =20 static void ccw_machine_register_types(void) { --=20 2.43.0