[PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame'

Dr. David Alan Gilbert posted 7 patches 1 year, 11 months ago
[PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame'
Posted by Dr. David Alan Gilbert 1 year, 11 months ago
Since 'setup_rt_frame' has never been implemented, this struct
is unused.

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
 linux-user/cris/signal.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c
index 4f532b2903..10948bcf30 100644
--- a/linux-user/cris/signal.c
+++ b/linux-user/cris/signal.c
@@ -35,14 +35,6 @@ struct target_signal_frame {
     uint16_t retcode[4];      /* Trampoline code. */
 };
 
-struct rt_signal_frame {
-    siginfo_t *pinfo;
-    void *puc;
-    siginfo_t info;
-    ucontext_t uc;
-    uint16_t retcode[4];      /* Trampoline code. */
-};
-
 static void setup_sigcontext(struct target_sigcontext *sc, CPUCRISState *env)
 {
     __put_user(env->regs[0], &sc->regs.r0);
-- 
2.45.0
Re: [PATCH 1/7] linux-user: cris: Remove unused struct 'rt_signal_frame'
Posted by Richard Henderson 1 year, 11 months ago
On 5/5/24 10:14, Dr. David Alan Gilbert wrote:
> Since 'setup_rt_frame' has never been implemented, this struct
> is unused.
> 
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
>   linux-user/cris/signal.c | 8 --------
>   1 file changed, 8 deletions(-)

Cris is scheduled for removal in 9.2.
We could ignore this until then.

But either way,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

> 
> diff --git a/linux-user/cris/signal.c b/linux-user/cris/signal.c
> index 4f532b2903..10948bcf30 100644
> --- a/linux-user/cris/signal.c
> +++ b/linux-user/cris/signal.c
> @@ -35,14 +35,6 @@ struct target_signal_frame {
>       uint16_t retcode[4];      /* Trampoline code. */
>   };
>   
> -struct rt_signal_frame {
> -    siginfo_t *pinfo;
> -    void *puc;
> -    siginfo_t info;
> -    ucontext_t uc;
> -    uint16_t retcode[4];      /* Trampoline code. */
> -};
> -
>   static void setup_sigcontext(struct target_sigcontext *sc, CPUCRISState *env)
>   {
>       __put_user(env->regs[0], &sc->regs.r0);