The structs 'target_fpxreg' and 'target_xmmreg' are unused since
Paolo's:

Commit 2796f290b546 ("linux-user: i386/signal: support FXSAVE fpstate on
32-bit emulation")

Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
 linux-user/i386/signal.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/linux-user/i386/signal.c b/linux-user/i386/signal.c
index 990048f42a..9bf602b388 100644
--- a/linux-user/i386/signal.c
+++ b/linux-user/i386/signal.c
@@ -34,16 +34,6 @@ struct target_fpreg {
     uint16_t exponent;
 };
 
-struct target_fpxreg {
-    uint16_t significand[4];
-    uint16_t exponent;
-    uint16_t padding[3];
-};
-
-struct target_xmmreg {
-    uint32_t element[4];
-};
-
 struct target_fpx_sw_bytes {
     uint32_t magic1;
     uint32_t extended_size;
-- 
2.45.0

On 5/5/24 10:14, Dr. David Alan Gilbert wrote:
> The structs 'target_fpxreg' and 'target_xmmreg' are unused since
> Paolo's:
> 
> Commit 2796f290b546 ("linux-user: i386/signal: support FXSAVE fpstate on
> 32-bit emulation")
> 
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
>   linux-user/i386/signal.c | 10 ----------
>   1 file changed, 10 deletions(-)

I have

https://lore.kernel.org/qemu-devel/20240409050302.1523277-1-richard.henderson@linaro.org/

which cleans this up.  I need to refresh and resubmit.


r~

> 
> diff --git a/linux-user/i386/signal.c b/linux-user/i386/signal.c
> index 990048f42a..9bf602b388 100644
> --- a/linux-user/i386/signal.c
> +++ b/linux-user/i386/signal.c
> @@ -34,16 +34,6 @@ struct target_fpreg {
>       uint16_t exponent;
>   };
>   
> -struct target_fpxreg {
> -    uint16_t significand[4];
> -    uint16_t exponent;
> -    uint16_t padding[3];
> -};
> -
> -struct target_xmmreg {
> -    uint32_t element[4];
> -};
> -
>   struct target_fpx_sw_bytes {
>       uint32_t magic1;
>       uint32_t extended_size;

* Richard Henderson (richard.henderson@linaro.org) wrote:
> On 5/5/24 10:14, Dr. David Alan Gilbert wrote:
> > The structs 'target_fpxreg' and 'target_xmmreg' are unused since
> > Paolo's:
> > 
> > Commit 2796f290b546 ("linux-user: i386/signal: support FXSAVE fpstate on
> > 32-bit emulation")
> > 
> > Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> > ---
> >   linux-user/i386/signal.c | 10 ----------
> >   1 file changed, 10 deletions(-)
> 
> I have
> 
> https://lore.kernel.org/qemu-devel/20240409050302.1523277-1-richard.henderson@linaro.org/
> 
> which cleans this up.  I need to refresh and resubmit.

Ah yes, that's fine.

Dave

> 
> 
> r~
> 
> > 
> > diff --git a/linux-user/i386/signal.c b/linux-user/i386/signal.c
> > index 990048f42a..9bf602b388 100644
> > --- a/linux-user/i386/signal.c
> > +++ b/linux-user/i386/signal.c
> > @@ -34,16 +34,6 @@ struct target_fpreg {
> >       uint16_t exponent;
> >   };
> > -struct target_fpxreg {
> > -    uint16_t significand[4];
> > -    uint16_t exponent;
> > -    uint16_t padding[3];
> > -};
> > -
> > -struct target_xmmreg {
> > -    uint32_t element[4];
> > -};
> > -
> >   struct target_fpx_sw_bytes {
> >       uint32_t magic1;
> >       uint32_t extended_size;
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/