[v5] vfio: Improve error reporting (part 2)

[PATCH v5 09/10] vfio: Also trace event failures in vfio_save_complete_precopy()

Posted by Cédric Le Goater 1 year, 11 months ago

vfio_save_complete_precopy() currently returns before doing the trace
event. Change that.

Signed-off-by: Cédric Le Goater <clg@redhat.com>
---
 hw/vfio/migration.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
index 87437490bd50321b3eb27770c932078597053746..88591695a7b61c1c623c707334c5c57f5e54c58a 100644
--- a/hw/vfio/migration.c
+++ b/hw/vfio/migration.c
@@ -581,9 +581,6 @@ static int vfio_save_complete_precopy(QEMUFile *f, void *opaque)
 
     qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE);
     ret = qemu_file_get_error(f);
-    if (ret) {
-        return ret;
-    }
 
     trace_vfio_save_complete_precopy(vbasedev->name, ret);
 
-- 
2.45.0

Re: [PATCH v5 09/10] vfio: Also trace event failures in vfio_save_complete_precopy()

Posted by Avihai Horon 1 year, 11 months ago

On 06/05/2024 12:20, Cédric Le Goater wrote:
> External email: Use caution opening links or attachments
>
>
> vfio_save_complete_precopy() currently returns before doing the trace
> event. Change that.
>
> Signed-off-by: Cédric Le Goater <clg@redhat.com>

Reviewed-by: Avihai Horon <avihaih@nvidia.com>

> ---
>   hw/vfio/migration.c | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
> index 87437490bd50321b3eb27770c932078597053746..88591695a7b61c1c623c707334c5c57f5e54c58a 100644
> --- a/hw/vfio/migration.c
> +++ b/hw/vfio/migration.c
> @@ -581,9 +581,6 @@ static int vfio_save_complete_precopy(QEMUFile *f, void *opaque)
>
>       qemu_put_be64(f, VFIO_MIG_FLAG_END_OF_STATE);
>       ret = qemu_file_get_error(f);
> -    if (ret) {
> -        return ret;
> -    }
>
>       trace_vfio_save_complete_precopy(vbasedev->name, ret);
>
> --
> 2.45.0
>