From nobody Sun Apr 12 13:44:53 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1715020266; cv=none; d=zohomail.com; s=zohoarc; b=cWE9C86vcbwEm6vx45dKMrXfTbyRsleZ32E4kCS/9g5Fj1T2bavMA3BfyD6TANogqhB9DUjSizrrRP4/zb79TSp85EbTGjEwQouLdTXSOyIJyAq+HjYMSch/8YyuUpfTJ8N6bqNgRiFq8udkSsjFAZnmYDMFAz4CGKKdKXTo6dA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715020266; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=KAaXr9ns9mtsogcMvLcEkKAPNjim8WmVar/tNdJD40g=; b=Tx3QCXHgcOtXq8CQ4zrkzMg2vjtLNDXoal4ww3Ng36MZojqonCFoKzILWMM/OaY+OtNTncnoUoy5RpF2tFAIqi43P2ugZhH42KusqPhuqZ3Usq48kFQ8JswAaTknz5+7wzOJ0g/+oWcJRnDqtS+PwoDCELUjTYlumnfZYaL4sTI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1715020266599107.2239883644188; Mon, 6 May 2024 11:31:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s436Y-0000Yz-G9; Mon, 06 May 2024 14:30:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436D-0000Ss-Uv for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:10 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436A-0006l2-TL for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=KAaXr9ns9mtsogcMvLcEkKAPNjim8WmVar/tNdJD40g=; b=viudSrrTvVL1Aqo dk4M6vTAG/WOHSW7imrIo9iWnozrEXr5yaAB91u2I5vPPcYilqyM5NE7Nvic4yotI9/Eg9hbMrsun CoK0zFxuePXlMzeso0TgPHYLDzjZEsulZmdZHjs7bB/xPQC57ow7fOAtjFzdMdKfW4NlZA4cH66ll m4=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH 1/4] target/hexagon: idef-parser remove unused defines Date: Mon, 6 May 2024 20:31:14 +0200 Message-ID: <20240506183117.32268-2-anjo@rev.ng> In-Reply-To: <20240506183117.32268-1-anjo@rev.ng> References: <20240506183117.32268-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1715020268271100004 Content-Type: text/plain; charset="utf-8" Before switching to GArray/g_string_printf we used fixed size arrays for output buffers and instructions arguments among other things. Macros defining the sizes of these buffers were left behind, remove them. Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- target/hexagon/idef-parser/idef-parser.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef= -parser/idef-parser.h index 3faa1deecd..8594cbe3a2 100644 --- a/target/hexagon/idef-parser/idef-parser.h +++ b/target/hexagon/idef-parser/idef-parser.h @@ -23,16 +23,6 @@ #include #include =20 -#define TCGV_NAME_SIZE 7 -#define MAX_WRITTEN_REGS 32 -#define OFFSET_STR_LEN 32 -#define ALLOC_LIST_LEN 32 -#define ALLOC_NAME_SIZE 32 -#define INIT_LIST_LEN 32 -#define OUT_BUF_LEN (1024 * 1024) -#define SIGNATURE_BUF_LEN (128 * 1024) -#define HEADER_BUF_LEN (128 * 1024) - /* Variadic macros to wrap the buffer printing functions */ #define EMIT(c, ...) = \ do { = \ --=20 2.44.0 From nobody Sun Apr 12 13:44:53 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1715020288; cv=none; d=zohomail.com; s=zohoarc; b=cMm9A9ebbBlrhfs9fShfGDg2K95Wfrtv95ysQEDqK8UGZCKDQ6vmbDnBhDbwKbDb1WnH0WRde5WopTwEpAZwOL/REj2PKk48d2V0LDQCVbH7xUXopmBeEZMV9erzdQvMJC/+oE869tQPFza/Qv9hzKYRdnMXt7Z0t9/sKNPgYH4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715020288; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=L7ffjuGdMo43jXmJvGa+HxLJv69hT0GcyLQXHjLWZDk=; b=h6k+atrSmXgIW5e4JieCeTB0M8ubJhjylOMDCXRVuys5MTYf8vu36RlEOTERsNPWr8BjI3HtCO87hkV40DMtn83NglP305iJ0Ozb4y63S0Db2+zSRNwFw72tX6r+gHJ1zyZ1i63PEjwOFHCZQY/G6wrYnq9D7JAI4iik93G9Jig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1715020288349164.18174115809336; Mon, 6 May 2024 11:31:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s437R-0000vu-Rm; Mon, 06 May 2024 14:31:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436E-0000Su-38 for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:10 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436B-0006lS-Uj for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=L7ffjuGdMo43jXmJvGa+HxLJv69hT0GcyLQXHjLWZDk=; b=NDGHP4q9sd8hSqh IsuUcDFZ4lhs3EEnSNdvHaFls6Qu9xI+Lhc6F000reTmzf40A63u2j/jREke5GcgLZZLomJcc5cZ2 D9k6xKfcwKlfuTr9V4EauoEmEMIOo/cVd6OPeK31JIn/f+YcsL7zokEFanVFe44oE9pLCD86aK1ST IM=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH 2/4] target/hexagon: idef-parser remove undefined functions Date: Mon, 6 May 2024 20:31:15 +0200 Message-ID: <20240506183117.32268-3-anjo@rev.ng> In-Reply-To: <20240506183117.32268-1-anjo@rev.ng> References: <20240506183117.32268-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1715020289955100004 Content-Type: text/plain; charset="utf-8" Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson --- target/hexagon/idef-parser/parser-helpers.h | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/target/hexagon/idef-parser/parser-helpers.h b/target/hexagon/i= def-parser/parser-helpers.h index 7c58087169..2087d534a9 100644 --- a/target/hexagon/idef-parser/parser-helpers.h +++ b/target/hexagon/idef-parser/parser-helpers.h @@ -143,8 +143,6 @@ void commit(Context *c); =20 #define OUT(c, locp, ...) FOR_EACH((c), (locp), OUT_IMPL, __VA_ARGS__) =20 -const char *cmp_swap(Context *c, YYLTYPE *locp, const char *type); - /** * Temporary values creation */ @@ -236,8 +234,6 @@ HexValue gen_extract_op(Context *c, HexValue *index, HexExtract *extract); =20 -HexValue gen_read_reg(Context *c, YYLTYPE *locp, HexValue *reg); - void gen_write_reg(Context *c, YYLTYPE *locp, HexValue *reg, HexValue *val= ue); =20 void gen_assign(Context *c, @@ -274,13 +270,6 @@ HexValue gen_ctpop_op(Context *c, YYLTYPE *locp, HexVa= lue *src); =20 HexValue gen_rotl(Context *c, YYLTYPE *locp, HexValue *src, HexValue *n); =20 -HexValue gen_deinterleave(Context *c, YYLTYPE *locp, HexValue *mixed); - -HexValue gen_interleave(Context *c, - YYLTYPE *locp, - HexValue *odd, - HexValue *even); - HexValue gen_carry_from_add(Context *c, YYLTYPE *locp, HexValue *op1, @@ -349,8 +338,6 @@ HexValue gen_rvalue_ternary(Context *c, YYLTYPE *locp, = HexValue *cond, =20 const char *cond_to_str(TCGCond cond); =20 -void emit_header(Context *c); - void emit_arg(Context *c, YYLTYPE *locp, HexValue *arg); =20 void emit_footer(Context *c); --=20 2.44.0 From nobody Sun Apr 12 13:44:53 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1715020287; cv=none; d=zohomail.com; s=zohoarc; b=MGWg4h/87Dd6tpgA7xwXOdjJY8RIy9ID0KvNgJMY3dcB4KstcUrxYpw6qIdf5vZiDDve9k/MycgWrxEYzXJ0ni9Snl/jqfBQuR2FLT8ptAXbfGYA8WInFbWoUO2d3jJ3kDO+LA5CncUEroMoiDLwvq5yrx8ZPUTPP+47Gnb56Eg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715020287; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=pKujwA3KPnHlFZcH0s4W2NUvMS0SIdrbZna3AKE57Nk=; b=TYMRk/l2woZLTfy4uY8LqQkrNodjQCVcJbNWYp9TwpCTDfg7YisS4XrLG3s2ZGBIeT5066KkRG2JiianXPZJCiAWXvv221kOMxh2BRhP5ckadVK4ck+xMKqOnj9L+Ivu+fmUV5aWzgmyjLz8cTyOrWl4skmeu5fyrsluduafCO8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1715020287870378.6120333469995; Mon, 6 May 2024 11:31:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s437H-0000ge-0X; Mon, 06 May 2024 14:31:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436F-0000UB-R5 for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:10 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436E-0006lX-5b for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=pKujwA3KPnHlFZcH0s4W2NUvMS0SIdrbZna3AKE57Nk=; b=r5+qv4xFoK3gmoE 3G3hc3uZuMaEKMfp7yOwdZrtLr0tM3FdGiafbVSHyKBqAkRFD8ckkuA+PE+Wx3ab9etoSO4oBmJUw daFsTyS5114gqqF6u4Me/EldCPRU/fP9x3lXSFfrey41HwQ7eN3h2rSW/0WP24A8zX574vogZf56W 48=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH 3/4] target/hexagon: idef-parser fix leak of init_list Date: Mon, 6 May 2024 20:31:16 +0200 Message-ID: <20240506183117.32268-4-anjo@rev.ng> In-Reply-To: <20240506183117.32268-1-anjo@rev.ng> References: <20240506183117.32268-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1715020289945100003 Content-Type: text/plain; charset="utf-8" gen_inst_init_args() is called for instructions using a predicate as an rvalue. Upon first call, the list of arguments which might need initialization init_list is freed to indicate that they have been processed. For instructions without an rvalue predicate, gen_inst_init_args() isn't called and init_list will never be freed. Free init_list from free_instruction() if it hasn't already been freed. Signed-off-by: Anton Johansson --- target/hexagon/idef-parser/parser-helpers.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index 95f2b43076..bae01c2bb8 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -2121,6 +2121,13 @@ void free_instruction(Context *c) g_string_free(g_array_index(c->inst.strings, GString*, i), TRUE); } g_array_free(c->inst.strings, TRUE); + /* + * Free list of arguments that might need initialization, if they have= n't + * already been free'd. + */ + if (c->inst.init_list) { + g_array_free(c->inst.init_list, TRUE); + } /* Free INAME token value */ g_string_free(c->inst.name, TRUE); /* Free variables and registers */ --=20 2.44.0 From nobody Sun Apr 12 13:44:53 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1715020307; cv=none; d=zohomail.com; s=zohoarc; b=FGdb3fj1EhXpGR34AnzBQJ/VqQoFz8T9ix3KTfzq1RNJR8hupnyaJHQYutiiBGwRLzhbnaJFH9tIjw50W/hjKaa9vOIYWPvURgBK4pLV0/wHCLngH7AVe72hiGm3l0UMJeg87NSI3crNNwB1+viY3+YWVK57lOZRj57z/RAWqCg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715020307; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=GJF+Sz6x4AUpNN0GfoyFi916cCA6Pbkoi+xPdgr51OQ=; b=jqLTYzMuFYJfwh3B6hMwtpt52cUYm8s5CQiyOkNqvMi8b2pokQV8NcylZhBWfJuf4119n/5fUqS5NQe8vFUqerMZWjahTMBeiwhrQMTKpcX07i9svWicnBZ6AnWYUypdMTSk0CbKr6L8GUvarjMtLNiUvYWyF0EY1lr0ftCueUg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1715020307283262.16714308612825; Mon, 6 May 2024 11:31:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s437R-0000vv-RY; Mon, 06 May 2024 14:31:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436E-0000Sw-6Y for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:10 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s436B-0006lp-61 for qemu-devel@nongnu.org; Mon, 06 May 2024 14:30:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=GJF+Sz6x4AUpNN0GfoyFi916cCA6Pbkoi+xPdgr51OQ=; b=KLBYfskOO58Eouz l7gjXynTSy27s70Y3/tLkAitHQx7AJw+zoR7AsecWPHAiApQGkfwiJSmkODgZFr7r3adI1en5/vL/ PTGSbvHZ4kg2AmfnAFP7688HrI/8x7JZBY01/+I4cBdirHJdksNM3NoGnSLHYfn06Ea/DvTEYV9Sp dE=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH 4/4] target/hexagon: idef-parser simplify predicate init Date: Mon, 6 May 2024 20:31:17 +0200 Message-ID: <20240506183117.32268-5-anjo@rev.ng> In-Reply-To: <20240506183117.32268-1-anjo@rev.ng> References: <20240506183117.32268-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1715020308048100001 Content-Type: text/plain; charset="utf-8" Only predicate instruction arguments need to be initialized by idef-parser. This commit removes registers from the init_list and simplifies gen_inst_init_args() slightly. Signed-off-by: Anton Johansson --- target/hexagon/idef-parser/idef-parser.y | 2 -- target/hexagon/idef-parser/parser-helpers.c | 20 +++++++++----------- 2 files changed, 9 insertions(+), 13 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef= -parser/idef-parser.y index cd2612eb8c..9ffb9f9699 100644 --- a/target/hexagon/idef-parser/idef-parser.y +++ b/target/hexagon/idef-parser/idef-parser.y @@ -233,8 +233,6 @@ code : '{' statements '}' argument_decl : REG { emit_arg(c, &@1, &$1); - /* Enqueue register into initialization list */ - g_array_append_val(c->inst.init_list, $1); } | PRED { diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index bae01c2bb8..33e8f82007 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1652,26 +1652,24 @@ void gen_inst(Context *c, GString *iname) =20 =20 /* - * Initialize declared but uninitialized registers, but only for - * non-conditional instructions + * Initialize declared but uninitialized instruction arguments. Only neede= d for + * predicate arguments, initialization of registers is handled by the Hexa= gon + * frontend. */ void gen_inst_init_args(Context *c, YYLTYPE *locp) { + /* If init_list is NULL arguments have already been initialized */ if (!c->inst.init_list) { return; } =20 for (unsigned i =3D 0; i < c->inst.init_list->len; i++) { HexValue *val =3D &g_array_index(c->inst.init_list, HexValue, i); - if (val->type =3D=3D REGISTER_ARG) { - /* Nothing to do here */ - } else if (val->type =3D=3D PREDICATE) { - char suffix =3D val->is_dotnew ? 'N' : 'V'; - EMIT_HEAD(c, "tcg_gen_movi_i%u(P%c%c, 0);\n", val->bit_width, - val->pred.id, suffix); - } else { - yyassert(c, locp, false, "Invalid arg type!"); - } + yyassert(c, locp, val->type =3D=3D PREDICATE, + "Only predicates need to be initialized!"); + char suffix =3D val->is_dotnew ? 'N' : 'V'; + EMIT_HEAD(c, "tcg_gen_movi_i%u(P%c%c, 0);\n", val->bit_width, + val->pred.id, suffix); } =20 /* Free argument init list once we have initialized everything */ --=20 2.44.0