From nobody Sun Apr 12 15:25:08 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1715761559; cv=none; d=zohomail.com; s=zohoarc; b=ieNtwbcM+NMhMn7lH0h2lPGCfhYVrLlH/SCM1XW/iczY9aYiZh37BUT17/6rxRp4YkU2JoOVvkVeX3LQiWloH/f14HUv7BqHPJzkFvNeaNx8kN0EJ60exJXUXlssJqy96weTZ3MG1P+7Pqo6QX1LAkcKrlqduJi4gtUXN8PVA1g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1715761559; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8V96JaL5d+BDmzTOUvOuvSy27gTQ4ZnV2iuMig2H0Sg=; b=DbfAqb8RgpS4TDINBYnmZu5WsQInoFrRO7Rf1OM/7YbRPDUnIZEHLqRuxbEvfvonF5ir+d3RVFd3RCT2ZR9U/P9NyANknLs1dRI4HVBK8zZ3ACP5DNnaxpmDUwGeXxRtmIyaB7DvbytRff5mixJjr1NNNtFI3REXjVXjvnHs2c4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1715761559723119.80786694367225; Wed, 15 May 2024 01:25:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s79w7-0002Gd-0G; Wed, 15 May 2024 04:24:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s79w5-0002F6-Er for qemu-devel@nongnu.org; Wed, 15 May 2024 04:24:29 -0400 Received: from mgamail.intel.com ([198.175.65.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s79w3-0007B1-SG for qemu-devel@nongnu.org; Wed, 15 May 2024 04:24:29 -0400 Received: from orviesa006.jf.intel.com ([10.64.159.146]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 01:24:16 -0700 Received: from unknown (HELO SPR-S2600BT.bj.intel.com) ([10.240.192.124]) by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2024 01:24:15 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715761467; x=1747297467; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DTf3l3gNL+/MEzKemJXwdZjfqVeaFHkkSy2ozo0sBso=; b=EjSrBYibYu2+Z5kwUxMJahvutqIt3BQ5umI6qzk0i1v0/ZjA0w8pQTq7 DpgdrEtT3OMyLGutSuFEc5LScJVGUcbodaoRv+90kWS/4loXgtwlHBQFT LMRlSIFIPDTrE9nP6/x4/sHjkaNTXiB1Ud9g2s6RDPI4hVMXQetY0OH6g YRcl5hqOfDxiMFemRvc/ajOeRvOo49crMe666LJbxrLLMwwwbFHHsZoyV PxwTiHNR7tSxNWDWS48DEZXgr7IbjMYSxkV0UuwNRdj/fJ4YDS+5dr0av vkgqrm5QYsjsMIzfbQG8QFde62iocxYq/EfbSuhBGcRcDS2VRj77TkVis Q==; X-CSE-ConnectionGUID: AFsgf+UEQbGM3J2xhpHW+A== X-CSE-MsgGUID: jR9IM7AcQ0G3cHK4FQ9LFw== X-IronPort-AV: E=McAfee;i="6600,9927,11073"; a="11961569" X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="11961569" X-CSE-ConnectionGUID: UCGlrDnUSgmk7QB8BHZCRg== X-CSE-MsgGUID: uxRQkFMZS/2N97n2PuWkTg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,161,1712646000"; d="scan'208";a="31396374" From: Zhenzhong Duan To: qemu-devel@nongnu.org Cc: alex.williamson@redhat.com, clg@redhat.com, eric.auger@redhat.com, chao.p.peng@intel.com, Zhenzhong Duan Subject: [PATCH 14/16] vfio/pci: Use g_autofree for vfio_region_info pointer Date: Wed, 15 May 2024 16:20:39 +0800 Message-Id: <20240515082041.556571-15-zhenzhong.duan@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240515082041.556571-1-zhenzhong.duan@intel.com> References: <20240515082041.556571-1-zhenzhong.duan@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.18; envelope-from=zhenzhong.duan@intel.com; helo=mgamail.intel.com X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.974, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1715761561042100003 Content-Type: text/plain; charset="utf-8" Pointer opregion is freed after vfio_pci_igd_opregion_init(). Use 'g_autofree' to avoid the g_free() calls. Signed-off-by: Zhenzhong Duan Reviewed-by: C=C3=A9dric Le Goater --- hw/vfio/pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index ecfbb9619f..be87478716 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3146,7 +3146,7 @@ static void vfio_realize(PCIDevice *pdev, Error **err= p) =20 if (!vdev->igd_opregion && vdev->features & VFIO_FEATURE_ENABLE_IGD_OPREGION) { - struct vfio_region_info *opregion; + g_autofree struct vfio_region_info *opregion =3D NULL; =20 if (vdev->pdev.qdev.hotplugged) { error_setg(errp, @@ -3165,7 +3165,6 @@ static void vfio_realize(PCIDevice *pdev, Error **err= p) } =20 ret =3D vfio_pci_igd_opregion_init(vdev, opregion, errp); - g_free(opregion); if (ret) { goto out_teardown; } --=20 2.34.1