[PATCH] ui/gtk-egl.c: fix build break

Anushree Mathur posted 1 patch 1 year, 11 months ago
ui/gtk-egl.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] ui/gtk-egl.c: fix build break
Posted by Anushree Mathur 1 year, 11 months ago
Qemu build is failing due to an unused variable.
Removing it to fix the build break.

Signed-off-by: Anushree Mathur <anushree.mathur@linux.vnet.ibm.com>
---
 ui/gtk-egl.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
index 0473f689c9..3177992b91 100644
--- a/ui/gtk-egl.c
+++ b/ui/gtk-egl.c
@@ -70,7 +70,6 @@ void gd_egl_draw(VirtualConsole *vc)
     QemuDmaBuf *dmabuf = vc->gfx.guest_fb.dmabuf;
 #endif
     int ww, wh, ws;
-    int fence_fd;
 
     if (!vc->gfx.gls) {
         return;
-- 
2.45.0
Re: [PATCH] ui/gtk-egl.c: fix build break
Posted by Philippe Mathieu-Daudé 1 year, 11 months ago
Hi Anushree,

On 15/5/24 13:50, Anushree Mathur wrote:
> Qemu build is failing due to an unused variable.
> Removing it to fix the build break.
> 
> Signed-off-by: Anushree Mathur <anushree.mathur@linux.vnet.ibm.com>
> ---
>   ui/gtk-egl.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/ui/gtk-egl.c b/ui/gtk-egl.c
> index 0473f689c9..3177992b91 100644
> --- a/ui/gtk-egl.c
> +++ b/ui/gtk-egl.c
> @@ -70,7 +70,6 @@ void gd_egl_draw(VirtualConsole *vc)
>       QemuDmaBuf *dmabuf = vc->gfx.guest_fb.dmabuf;
>   #endif
>       int ww, wh, ws;
> -    int fence_fd;
>   
>       if (!vc->gfx.gls) {
>           return;

Well, it is used few lines later when CONFIG_GBM
is defined ;)

Cédric sent a complete patch:
https://lore.kernel.org/qemu-devel/20240515100520.574383-1-clg@redhat.com/