From nobody Mon Apr 6 16:17:30 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1716469097; cv=none; d=zohomail.com; s=zohoarc; b=h4Eq3/hyRZ/SvKKQa9WkTkQubt4cx0oNwkeV4Y1LZQERaCKuhDnXTcMXrQ/4ReBUZB/a0SseKQzIH04JOWmk8Gn60VgGQMweebQecO1kRIdJTS+s5LBPq0cF34mdAixGUd6Jc0Cm+jCs+XqRGgL2/K5skPAGL3nG6NOxbq7ATxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716469097; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=YLs8er0Kmukkg2xMHbQauOaFPZSyEKBKVcJd+Oy8+JM=; b=HXUHyJ/zPZKS4fGG1EvPptqfHi8FnfDxIvuHlaSSyumIKGqwq/6y/n0mXcmiu9LbS69PmCUl6acrG1CPIF+X/l5nd9/IFxJdR1y64vCB9aLNa6VfovKhRjQRbrLkY5jHYl9nJjGh9k8f3Z243U/xx3G9oPYiXGyr6+QLkzr3eQ0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716469096989832.6282678949855; Thu, 23 May 2024 05:58:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA80x-0005fa-2r; Thu, 23 May 2024 08:57:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80v-0005fK-BO for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:45 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80p-0004Kh-4S for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=YLs8er0Kmukkg2xMHbQauOaFPZSyEKBKVcJd+Oy8+JM=; b=wY++wwClDQNebtm /T2Of//DhDAEyqO7H6Nu6wt/PuVA4qMRk8RVKShgbe4sBIHo/6PaSGQ4S3grZQqRvM7IPFXQeNS7X 4Vk72QCMeV1D+8z+AJtQMsACBRxcJHlDbRY4N6dvEYxrcvL5UUi68uVFaL86EKrlFFsvfJ7Z5Xw4v f8=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH v4 1/4] target/hexagon: idef-parser remove unused defines Date: Thu, 23 May 2024 14:58:58 +0200 Message-ID: <20240523125901.27797-2-anjo@rev.ng> In-Reply-To: <20240523125901.27797-1-anjo@rev.ng> References: <20240523125901.27797-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1716469097775100002 Content-Type: text/plain; charset="utf-8" Before switching to GArray/g_string_printf we used fixed size arrays for output buffers and instructions arguments among other things. Macros defining the sizes of these buffers were left behind, remove them. Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson Reviewed-by: Brian Cain --- target/hexagon/idef-parser/idef-parser.h | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.h b/target/hexagon/idef= -parser/idef-parser.h index 3faa1deecd..8594cbe3a2 100644 --- a/target/hexagon/idef-parser/idef-parser.h +++ b/target/hexagon/idef-parser/idef-parser.h @@ -23,16 +23,6 @@ #include #include =20 -#define TCGV_NAME_SIZE 7 -#define MAX_WRITTEN_REGS 32 -#define OFFSET_STR_LEN 32 -#define ALLOC_LIST_LEN 32 -#define ALLOC_NAME_SIZE 32 -#define INIT_LIST_LEN 32 -#define OUT_BUF_LEN (1024 * 1024) -#define SIGNATURE_BUF_LEN (128 * 1024) -#define HEADER_BUF_LEN (128 * 1024) - /* Variadic macros to wrap the buffer printing functions */ #define EMIT(c, ...) = \ do { = \ --=20 2.45.0 From nobody Mon Apr 6 16:17:30 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1716469131; cv=none; d=zohomail.com; s=zohoarc; b=MxxGFuWM0oei2H3SFiLEl/OxSWA21ngTSCRoLlgLQnxC/g3qULv4aEG+351+lDDwnP3+4qpdfMLpZWfASzrVGpNrgVTCBAeVzrE+dOlvqjy3vkIkdbEPXNnkrEc9lMgy8BYbBN/OPeM7t2JX2m4WyucTDyZDdsfh3H0G07saj3M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716469131; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=q8GFhwyj1wzUnTITHpuWLzFkE4XYpGj04PGduoH5mdA=; b=Se4I8/6QHM+/GnDL2+yq9pJqy4XdVfl9FCqE26D0TrYKUn8a4feguMclLScK1ApPUYdxhYZliaWABOkRl7CplIGk/dChR1TGrfNXByHOt2ukUp51qNwBhoWAhe3tDFLYWULyI3lSVIfADQ+0hx0NSjqPi1evB+0QD5gXNGDu/P0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716469131827645.7565010743175; Thu, 23 May 2024 05:58:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA816-0005jn-JV; Thu, 23 May 2024 08:57:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80x-0005ft-AJ for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:48 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80r-0004Ko-W5 for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=q8GFhwyj1wzUnTITHpuWLzFkE4XYpGj04PGduoH5mdA=; b=rshDQAMVS6zYLgf NfPD3+ANZS5rdyhsv2etoAiaBtuMZrQsh3T26FVffiBg5bkbcLVSwYiCQFzDSoFt7p/S8fy8heLqq SaRwTpfI2MUNrshbi3siOgmZk7CYUa+vZbA9w7cQRJr6JLkksLJl0KH0+mzuBPrYwNZVOykCIPix3 ck=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH v4 2/4] target/hexagon: idef-parser remove undefined functions Date: Thu, 23 May 2024 14:58:59 +0200 Message-ID: <20240523125901.27797-3-anjo@rev.ng> In-Reply-To: <20240523125901.27797-1-anjo@rev.ng> References: <20240523125901.27797-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1716469133500100003 Content-Type: text/plain; charset="utf-8" Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson Reviewed-by: Brian Cain --- target/hexagon/idef-parser/parser-helpers.h | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/target/hexagon/idef-parser/parser-helpers.h b/target/hexagon/i= def-parser/parser-helpers.h index 7c58087169..2087d534a9 100644 --- a/target/hexagon/idef-parser/parser-helpers.h +++ b/target/hexagon/idef-parser/parser-helpers.h @@ -143,8 +143,6 @@ void commit(Context *c); =20 #define OUT(c, locp, ...) FOR_EACH((c), (locp), OUT_IMPL, __VA_ARGS__) =20 -const char *cmp_swap(Context *c, YYLTYPE *locp, const char *type); - /** * Temporary values creation */ @@ -236,8 +234,6 @@ HexValue gen_extract_op(Context *c, HexValue *index, HexExtract *extract); =20 -HexValue gen_read_reg(Context *c, YYLTYPE *locp, HexValue *reg); - void gen_write_reg(Context *c, YYLTYPE *locp, HexValue *reg, HexValue *val= ue); =20 void gen_assign(Context *c, @@ -274,13 +270,6 @@ HexValue gen_ctpop_op(Context *c, YYLTYPE *locp, HexVa= lue *src); =20 HexValue gen_rotl(Context *c, YYLTYPE *locp, HexValue *src, HexValue *n); =20 -HexValue gen_deinterleave(Context *c, YYLTYPE *locp, HexValue *mixed); - -HexValue gen_interleave(Context *c, - YYLTYPE *locp, - HexValue *odd, - HexValue *even); - HexValue gen_carry_from_add(Context *c, YYLTYPE *locp, HexValue *op1, @@ -349,8 +338,6 @@ HexValue gen_rvalue_ternary(Context *c, YYLTYPE *locp, = HexValue *cond, =20 const char *cond_to_str(TCGCond cond); =20 -void emit_header(Context *c); - void emit_arg(Context *c, YYLTYPE *locp, HexValue *arg); =20 void emit_footer(Context *c); --=20 2.45.0 From nobody Mon Apr 6 16:17:30 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1716469133; cv=none; d=zohomail.com; s=zohoarc; b=QZUcgNGQ2WSTLE5bGlyRva8ZUjCw1vM1M+uFs0/ev4mrQ3d97ZBhK2VcY/d+hUMXdFC/aFVCQhRBSWYGs0tK8gOGgv0u4ummBsI79Vl4S3HFU3aqsTbPVOFb5g2R9bHaw9nFyTbHSTVHkfuhNOPnO6R8n6yCPgQUSQ9YTtC5aM4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716469133; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=uPKJDyrgHzE6Cx7vqCcjvPT2ToVwNYtkyg7CRmTUkKo=; b=RknwxmpCeYqt7UoFmyM5e1hQCkPX+ukzzgKFoLnfNQ9SKDl1Q0jW+IN079QNOO575nUva9fnkrXek1RrZJWb4ChoEOdSQZ28g3IXl+CDdpO7xBct5Wvy5FAanCkXT+Dc9oQAM8DQUXA68b0Dm/rhb38UZG59iGOQ73yDNhzhhg0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716469133167272.28056910228656; Thu, 23 May 2024 05:58:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA815-0005jB-JK; Thu, 23 May 2024 08:57:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80w-0005fc-Rs for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:47 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80r-0004Kv-W8 for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=uPKJDyrgHzE6Cx7vqCcjvPT2ToVwNYtkyg7CRmTUkKo=; b=KsnjWL4+ay/S8UC jjm/tI7dXjyYuLk6LJscbbrE6ioOYD+RZIjB5WNSqFd6n5uh64BCsm7wC8kHpkqqsI/uqdnHMhMTX 0B9FBHDI8iGnUy8Hf6IuvxB8tfiAZHm6UaH98rfBOtAhoYmRMvkEfKlFyI5VtuQMZdCZ3J3DYe0pY XE=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH v4 3/4] target/hexagon: idef-parser fix leak of init_list Date: Thu, 23 May 2024 14:59:00 +0200 Message-ID: <20240523125901.27797-4-anjo@rev.ng> In-Reply-To: <20240523125901.27797-1-anjo@rev.ng> References: <20240523125901.27797-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1716469133511100004 Content-Type: text/plain; charset="utf-8" gen_inst_init_args() is called for instructions using a predicate as an rvalue. Upon first call, the list of arguments which might need initialization init_list is freed to indicate that they have been processed. For instructions without an rvalue predicate, gen_inst_init_args() isn't called and init_list will never be freed. Free init_list from free_instruction() if it hasn't already been freed. A comment in free_instruction is also updated. Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson Reviewed-by: Brian Cain --- target/hexagon/idef-parser/parser-helpers.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index 95f2b43076..c150c308be 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -2121,9 +2121,16 @@ void free_instruction(Context *c) g_string_free(g_array_index(c->inst.strings, GString*, i), TRUE); } g_array_free(c->inst.strings, TRUE); + /* + * Free list of arguments that might need initialization, if they have= n't + * already been freed. + */ + if (c->inst.init_list) { + g_array_free(c->inst.init_list, TRUE); + } /* Free INAME token value */ g_string_free(c->inst.name, TRUE); - /* Free variables and registers */ + /* Free declared TCGv variables */ g_array_free(c->inst.allocated, TRUE); /* Initialize instruction-specific portion of the context */ memset(&(c->inst), 0, sizeof(Inst)); --=20 2.45.0 From nobody Mon Apr 6 16:17:30 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1716469113; cv=none; d=zohomail.com; s=zohoarc; b=M0ha8A4RH+gPfhcB2BjqQo713sMXERMX7cHO4fx1P7djs4HAHTxP0dZWamV+rFzfGgkyGf0yVsCSSFOhDqXtlQGuTgvrrC6vurtn5QoM3laclhDbE4Nk7nqqtP7kOxKDNR2wBIGCp+4eZkz/jk/zfPJfaj6AlShVfiujPTAIzvk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1716469113; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=BhGdJdl/2jounm6xKaCif8D5yPM70uCPtDdYjdncQog=; b=HSEY/ZhKLv7xWsvXXZMpRuyOaOaCROfnXJv2ai9b5s0e7j6O4RoBjRwsjiDWC44oomFuIa3caEHQrDXlfHhvi9RexaWBe4pwo3zFeHTFrrlQCc3/weKun4Z0LYA3EXa4/kJ+k0u8mKZWC6gF1hlOikOIIDoTvaEOmkiAJCdxClU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1716469113205462.3917765534144; Thu, 23 May 2024 05:58:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sA813-0005iS-0e; Thu, 23 May 2024 08:57:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80x-0005fu-BD for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:48 -0400 Received: from rev.ng ([5.9.113.41]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sA80t-0004L1-Sw for qemu-devel@nongnu.org; Thu, 23 May 2024 08:57:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rev.ng; s=dkim; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive:List-Unsubscribe:List-Unsubscribe-Post: List-Help; bh=BhGdJdl/2jounm6xKaCif8D5yPM70uCPtDdYjdncQog=; b=r1cdX4IUJ0FmUrN 088shzs0rHE56VUy6lJjswg6HFbg2K1Uh4YEtvN3mE2Lv7qFlW3LYrsc0HfOvHw8/gxYSQf3STcIA mfTxNgEOjnivLhyjiZDeeWGy56Do/Jt5NUKkDne53EYgyjx8K2GhyYlpvx9qemu2kDN+ztDUdGDvL Ag=; To: qemu-devel@nongnu.org Cc: ale@rev.ng, ltaylorsimpson@gmail.com, bcain@quicinc.com Subject: [PATCH v4 4/4] target/hexagon: idef-parser simplify predicate init Date: Thu, 23 May 2024 14:59:01 +0200 Message-ID: <20240523125901.27797-5-anjo@rev.ng> In-Reply-To: <20240523125901.27797-1-anjo@rev.ng> References: <20240523125901.27797-1-anjo@rev.ng> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=5.9.113.41; envelope-from=anjo@rev.ng; helo=rev.ng X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Anton Johansson From: Anton Johansson via Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1716469113610100001 Content-Type: text/plain; charset="utf-8" Only predicate instruction arguments need to be initialized by idef-parser. This commit removes registers from the init_list and simplifies gen_inst_init_args() slightly. Signed-off-by: Anton Johansson Reviewed-by: Taylor Simpson Reviewed-by: Brian Cain --- target/hexagon/idef-parser/idef-parser.y | 2 -- target/hexagon/idef-parser/parser-helpers.c | 26 +++++++++++---------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/target/hexagon/idef-parser/idef-parser.y b/target/hexagon/idef= -parser/idef-parser.y index cd2612eb8c..9ffb9f9699 100644 --- a/target/hexagon/idef-parser/idef-parser.y +++ b/target/hexagon/idef-parser/idef-parser.y @@ -233,8 +233,6 @@ code : '{' statements '}' argument_decl : REG { emit_arg(c, &@1, &$1); - /* Enqueue register into initialization list */ - g_array_append_val(c->inst.init_list, $1); } | PRED { diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/i= def-parser/parser-helpers.c index c150c308be..a7dcd85fe4 100644 --- a/target/hexagon/idef-parser/parser-helpers.c +++ b/target/hexagon/idef-parser/parser-helpers.c @@ -1652,26 +1652,28 @@ void gen_inst(Context *c, GString *iname) =20 =20 /* - * Initialize declared but uninitialized registers, but only for - * non-conditional instructions + * Initialize declared but uninitialized instruction arguments. Only neede= d for + * predicate arguments, initialization of registers is handled by the Hexa= gon + * frontend. */ void gen_inst_init_args(Context *c, YYLTYPE *locp) { + HexValue *val =3D NULL; + char suffix; + + /* If init_list is NULL arguments have already been initialized */ if (!c->inst.init_list) { return; } =20 for (unsigned i =3D 0; i < c->inst.init_list->len; i++) { - HexValue *val =3D &g_array_index(c->inst.init_list, HexValue, i); - if (val->type =3D=3D REGISTER_ARG) { - /* Nothing to do here */ - } else if (val->type =3D=3D PREDICATE) { - char suffix =3D val->is_dotnew ? 'N' : 'V'; - EMIT_HEAD(c, "tcg_gen_movi_i%u(P%c%c, 0);\n", val->bit_width, - val->pred.id, suffix); - } else { - yyassert(c, locp, false, "Invalid arg type!"); - } + val =3D &g_array_index(c->inst.init_list, HexValue, i); + suffix =3D val->is_dotnew ? 'N' : 'V'; + yyassert(c, locp, val->type =3D=3D PREDICATE, + "Only predicates need to be initialized!"); + yyassert(c, locp, val->bit_width =3D=3D 32, + "Predicates should always be 32 bits"); + EMIT_HEAD(c, "tcg_gen_movi_i32(P%c%c, 0);\n", val->pred.id, suffix= ); } =20 /* Free argument init list once we have initialized everything */ --=20 2.45.0