From nobody Tue Feb 10 22:10:18 2026 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1717835988; cv=none; d=zohomail.com; s=zohoarc; b=QG2dFnP0YRi5ot+6zLdeneTLsTXSvfiXMty+yKakUSJH0iL1SD0Z0VHlyS0dQQcgZBvFjk469bSEyFEKZ5ZC3Up8eBX2Q1bxvZUtdg7OH6bDK9usI5xbWb/ZbBWOKK6Z3/bZSfEnfaBoxR6kfA6rriTc4wd8Kv4CYEf4sGimy4g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1717835988; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xc/U+YMat7XpkxN0Aso1HqXRcKOMnxcWoqmk4VW3ERw=; b=XjZniJ1JD+NvDRqp3d8kx1mdVByuoF6yaQA8OyoL2i9/rX4v42V8TdFKJUxQ7Hxa/rYlDiprQ8cJzZXVv21skvxLSv5DzrGKno9tUC2x8V77bsdmxyycOXVZQuQ7joFRqf6j+Rl85gaUmmI2qbeAu9Z1rlQvO8KrgJ21TJM5N34= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1717835988598471.66368151398615; Sat, 8 Jun 2024 01:39:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sFrXq-0000qw-9J; Sat, 08 Jun 2024 04:35:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFrXm-0000pE-Lt for qemu-devel@nongnu.org; Sat, 08 Jun 2024 04:35:22 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sFrXl-00006M-6l for qemu-devel@nongnu.org; Sat, 08 Jun 2024 04:35:22 -0400 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-315-OrUdCOVlM9OS0zg3_OJ66w-1; Sat, 08 Jun 2024 04:35:17 -0400 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-57c602f0125so1047003a12.0 for ; Sat, 08 Jun 2024 01:35:16 -0700 (PDT) Received: from avogadro.local ([151.81.115.112]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57aae13dc46sm3970363a12.52.2024.06.08.01.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jun 2024 01:35:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717835719; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xc/U+YMat7XpkxN0Aso1HqXRcKOMnxcWoqmk4VW3ERw=; b=SOAwhU15EqHdwCS8DE6cHOaKb2aQJInkn0GMjZPDL9gHNXgTvYcDfRTh05oEPlUMlO6HcH zSlFuuOt1ikTyjy30VvlrO5IR05cULIFWqGo6pA/20W4U4UBEYfO8KB8pqa0eKCJX6S1/A wQqRJ4bR/nXciXcktbfA5mxcpP6VwCg= X-MC-Unique: OrUdCOVlM9OS0zg3_OJ66w-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717835715; x=1718440515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xc/U+YMat7XpkxN0Aso1HqXRcKOMnxcWoqmk4VW3ERw=; b=k89Utsn/Q42JIUUnbLJC0s2+ClNV4KHLR8xcDjuF4pr2rWm5Nmrvp7ZW8+elBaNpTa 3Ozr/00v8VRohMs944/lGrATgpqYq2fTigiep8CBdcX7BLuvQbam9MHLAbj03wfA+zNJ hTbsXJB+5TIf2vYMkjkm17oK9E7O+AwuiSyBj0Hxrvg5+VFAWGgHIK4qFR/T3QPFkRhC a35xW258nkSpBCwrkn0Y9zqbjUJoDMXB4U0StfVGytMpeidMYGdoyGIDFuRRAf7ky1eC vaJBG+lL6R5dIEQ5ANP/WCgLex1rjmewCIMTTzxCA6vz/LvscIV5Qc1EK6tmBXGonj04 Pzng== X-Gm-Message-State: AOJu0YyvCP1ySNng1TsDqoK1AH52D0ieODbWXlrppD2EggpcsOcgxhhn cS10lYhjyop9mCiE8t+Kln97iC/CbNYa1dAEh85ZUsUiKxvWYl7zXPoAjPh5hPSYQB0ZOCFwbob S7U2s32UBSWhwCJJLnFJCbdPi47yOiwgfamTli/I21uz6IPdNejvyvIbq6r/GH62AyIYo6kZPVj E7iW0LuDzbOxuR1PICN7ZQFd3aY9J/V9vBTJFt X-Received: by 2002:a05:6402:3547:b0:57c:7340:304d with SMTP id 4fb4d7f45d1cf-57c73403738mr48039a12.15.1717835714958; Sat, 08 Jun 2024 01:35:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJ8PM2rVXBGx+6cZeM9LaoO2f/6l0dsdxPUG9USlLDYlvBnpk3DvMmja7kytXcqTZxsNTe8g== X-Received: by 2002:a05:6402:3547:b0:57c:7340:304d with SMTP id 4fb4d7f45d1cf-57c73403738mr48028a12.15.1717835714631; Sat, 08 Jun 2024 01:35:14 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Michal Privoznik Subject: [PULL 21/42] machine, hostmem: improve error messages for unsupported features Date: Sat, 8 Jun 2024 10:33:54 +0200 Message-ID: <20240608083415.2769160-22-pbonzini@redhat.com> X-Mailer: git-send-email 2.45.1 In-Reply-To: <20240608083415.2769160-1-pbonzini@redhat.com> References: <20240608083415.2769160-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1717835988987100001 Content-Type: text/plain; charset="utf-8" Detect early unsupported MADV_MERGEABLE and MADV_DONTDUMP, and print a clea= rer error message that points to the deficiency of the host. Cc: Michal Privoznik Signed-off-by: Paolo Bonzini --- backends/hostmem.c | 16 ++++++++++++++++ hw/core/machine.c | 8 ++++++++ 2 files changed, 24 insertions(+) diff --git a/backends/hostmem.c b/backends/hostmem.c index 1edc0ede2a5..6da3d7383e3 100644 --- a/backends/hostmem.c +++ b/backends/hostmem.c @@ -170,6 +170,14 @@ static void host_memory_backend_set_merge(Object *obj,= bool value, Error **errp) { HostMemoryBackend *backend =3D MEMORY_BACKEND(obj); =20 + if (QEMU_MADV_MERGEABLE =3D=3D QEMU_MADV_INVALID) { + if (value) { + error_setg(errp, "Memory merging is not supported on this host= "); + } + assert(!backend->merge); + return; + } + if (!host_memory_backend_mr_inited(backend)) { backend->merge =3D value; return; @@ -196,6 +204,14 @@ static void host_memory_backend_set_dump(Object *obj, = bool value, Error **errp) { HostMemoryBackend *backend =3D MEMORY_BACKEND(obj); =20 + if (QEMU_MADV_DONTDUMP =3D=3D QEMU_MADV_INVALID) { + if (!value) { + error_setg(errp, "Dumping guest memory cannot be disabled on t= his host"); + } + assert(backend->dump); + return; + } + if (!host_memory_backend_mr_inited(backend)) { backend->dump =3D value; return; diff --git a/hw/core/machine.c b/hw/core/machine.c index a0ee43ca5c0..c93d2492443 100644 --- a/hw/core/machine.c +++ b/hw/core/machine.c @@ -428,6 +428,10 @@ static void machine_set_dump_guest_core(Object *obj, b= ool value, Error **errp) { MachineState *ms =3D MACHINE(obj); =20 + if (!value && QEMU_MADV_DONTDUMP =3D=3D QEMU_MADV_INVALID) { + error_setg(errp, "Dumping guest memory cannot be disabled on this = host"); + return; + } ms->dump_guest_core =3D value; } =20 @@ -442,6 +446,10 @@ static void machine_set_mem_merge(Object *obj, bool va= lue, Error **errp) { MachineState *ms =3D MACHINE(obj); =20 + if (value && QEMU_MADV_MERGEABLE =3D=3D QEMU_MADV_INVALID) { + error_setg(errp, "Memory merging is not supported on this host"); + return; + } ms->mem_merge =3D value; } =20 --=20 2.45.1