[v2] hw/misc: Set valid access size for Exynos4210 RNG

[PATCH v2] hw/misc: Set valid access size for Exynos4210 RNG

Posted by Zheyu Ma 10 months, 3 weeks ago

This commit ensures that accesses to the RNG memory region are properly
validated and align with expected access sizes.

Reproducer:
cat << EOF | qemu-system-aarch64 -display none \
-machine accel=qtest, -m 512M -machine smdkc210 -qtest stdio
readb 0x10830454
EOF

Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
---
 hw/misc/exynos4210_rng.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/misc/exynos4210_rng.c b/hw/misc/exynos4210_rng.c
index 0756bd3205..674d8eece5 100644
--- a/hw/misc/exynos4210_rng.c
+++ b/hw/misc/exynos4210_rng.c
@@ -217,6 +217,8 @@ static const MemoryRegionOps exynos4210_rng_ops = {
     .read = exynos4210_rng_read,
     .write = exynos4210_rng_write,
     .endianness = DEVICE_NATIVE_ENDIAN,
+    .valid.min_access_size = 4,
+    .valid.max_access_size = 4,
 };
 
 static void exynos4210_rng_reset(DeviceState *dev)
-- 
2.34.1

Re: [PATCH v2] hw/misc: Set valid access size for Exynos4210 RNG

Posted by Philippe Mathieu-Daudé 10 months, 3 weeks ago

On 18/6/24 17:51, Zheyu Ma wrote:
> This commit ensures that accesses to the RNG memory region are properly
> validated and align with expected access sizes.

Please point to the device specifications.

> Reproducer:
> cat << EOF | qemu-system-aarch64 -display none \
> -machine accel=qtest, -m 512M -machine smdkc210 -qtest stdio
> readb 0x10830454
> EOF
> 
> Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
> ---
>   hw/misc/exynos4210_rng.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/misc/exynos4210_rng.c b/hw/misc/exynos4210_rng.c
> index 0756bd3205..674d8eece5 100644
> --- a/hw/misc/exynos4210_rng.c
> +++ b/hw/misc/exynos4210_rng.c
> @@ -217,6 +217,8 @@ static const MemoryRegionOps exynos4210_rng_ops = {
>       .read = exynos4210_rng_read,
>       .write = exynos4210_rng_write,
>       .endianness = DEVICE_NATIVE_ENDIAN,
> +    .valid.min_access_size = 4,
> +    .valid.max_access_size = 4,
>   };
>   
>   static void exynos4210_rng_reset(DeviceState *dev)