v5:
03: drop extra check on is is runstate running


Vladimir Sementsov-Ogievskiy (3):
  qdev-monitor: add option to report GenericError from find_device_state
  vhost-user-blk: split vhost_user_blk_sync_config()
  qapi: introduce device-sync-config

 hw/block/vhost-user-blk.c | 27 ++++++++++++++------
 hw/virtio/virtio-pci.c    |  9 +++++++
 include/hw/qdev-core.h    |  3 +++
 qapi/qdev.json            | 24 ++++++++++++++++++
 system/qdev-monitor.c     | 53 ++++++++++++++++++++++++++++++++++++---
 5 files changed, 105 insertions(+), 11 deletions(-)

-- 
2.34.1

ping. Markus, Eric, could someone give an ACC for QAPI part?

On 25.06.24 15:18, Vladimir Sementsov-Ogievskiy wrote:
> v5:
> 03: drop extra check on is is runstate running
> 
> 
> Vladimir Sementsov-Ogievskiy (3):
>    qdev-monitor: add option to report GenericError from find_device_state
>    vhost-user-blk: split vhost_user_blk_sync_config()
>    qapi: introduce device-sync-config
> 
>   hw/block/vhost-user-blk.c | 27 ++++++++++++++------
>   hw/virtio/virtio-pci.c    |  9 +++++++
>   include/hw/qdev-core.h    |  3 +++
>   qapi/qdev.json            | 24 ++++++++++++++++++
>   system/qdev-monitor.c     | 53 ++++++++++++++++++++++++++++++++++++---
>   5 files changed, 105 insertions(+), 11 deletions(-)
> 

-- 
Best regards,
Vladimir

Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:

> ping. Markus, Eric, could someone give an ACC for QAPI part?

I apologize for the delay.  It was pretty bad.

On 18.07.24 11:31, Markus Armbruster wrote:
> Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> writes:
> 
>> ping. Markus, Eric, could someone give an ACC for QAPI part?
> 
> I apologize for the delay.  It was pretty bad.
> 

No problem, I myself make worse delays now when busy with other work, thanks for reviewing!

-- 
Best regards,
Vladimir

I have no issues with these APIs, but I'm not a QMP expert so others
should review those bits.

For the vhost-user-blk code:

Acked-by: Raphael Norwitz <raphael@enfabrica.net>

On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy
<vsementsov@yandex-team.ru> wrote:
>
> v5:
> 03: drop extra check on is is runstate running
>
>
> Vladimir Sementsov-Ogievskiy (3):
>   qdev-monitor: add option to report GenericError from find_device_state
>   vhost-user-blk: split vhost_user_blk_sync_config()
>   qapi: introduce device-sync-config
>
>  hw/block/vhost-user-blk.c | 27 ++++++++++++++------
>  hw/virtio/virtio-pci.c    |  9 +++++++
>  include/hw/qdev-core.h    |  3 +++
>  qapi/qdev.json            | 24 ++++++++++++++++++
>  system/qdev-monitor.c     | 53 ++++++++++++++++++++++++++++++++++++---
>  5 files changed, 105 insertions(+), 11 deletions(-)
>
> --
> 2.34.1
>

On Mon, Jul 01, 2024 at 08:42:39AM -0400, Raphael Norwitz wrote:
> I have no issues with these APIs, but I'm not a QMP expert so others
> should review those bits.
> 
> For the vhost-user-blk code:
> 
> Acked-by: Raphael Norwitz <raphael@enfabrica.net>

Could the relevant bits get ack from qapi maintainers please?



> On Tue, Jun 25, 2024 at 8:19 AM Vladimir Sementsov-Ogievskiy
> <vsementsov@yandex-team.ru> wrote:
> >
> > v5:
> > 03: drop extra check on is is runstate running
> >
> >
> > Vladimir Sementsov-Ogievskiy (3):
> >   qdev-monitor: add option to report GenericError from find_device_state
> >   vhost-user-blk: split vhost_user_blk_sync_config()
> >   qapi: introduce device-sync-config
> >
> >  hw/block/vhost-user-blk.c | 27 ++++++++++++++------
> >  hw/virtio/virtio-pci.c    |  9 +++++++
> >  include/hw/qdev-core.h    |  3 +++
> >  qapi/qdev.json            | 24 ++++++++++++++++++
> >  system/qdev-monitor.c     | 53 ++++++++++++++++++++++++++++++++++++---
> >  5 files changed, 105 insertions(+), 11 deletions(-)
> >
> > --
> > 2.34.1
> >