[PATCH v2 03/21] docs/qapidoc: remove unused intersperse function

John Snow posted 21 patches 10 months, 2 weeks ago
[PATCH v2 03/21] docs/qapidoc: remove unused intersperse function
Posted by John Snow 10 months, 2 weeks ago
This function has been unused since fd62bff901b.

Signed-off-by: John Snow <jsnow@redhat.com>
---
 docs/sphinx/qapidoc.py | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py
index f270b494f01..3c0565d0ceb 100644
--- a/docs/sphinx/qapidoc.py
+++ b/docs/sphinx/qapidoc.py
@@ -50,16 +50,6 @@
 __version__ = '1.0'
 
 
-# Function borrowed from pydash, which is under the MIT license
-def intersperse(iterable, separator):
-    """Yield the members of *iterable* interspersed with *separator*."""
-    iterable = iter(iterable)
-    yield next(iterable)
-    for item in iterable:
-        yield separator
-        yield item
-
-
 class QAPISchemaGenRSTVisitor(QAPISchemaVisitor):
     """A QAPI schema visitor which generates docutils/Sphinx nodes
 
-- 
2.45.0
Re: [PATCH v2 03/21] docs/qapidoc: remove unused intersperse function
Posted by Markus Armbruster 10 months, 2 weeks ago
John Snow <jsnow@redhat.com> writes:

> This function has been unused since fd62bff901b.
>
> Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

I assume you won't mind me adding a bit of polish: "since commit
fd62bff901b (sphinx/qapidoc: Drop code to generate doc for simple union
tag)".
Re: [PATCH v2 03/21] docs/qapidoc: remove unused intersperse function
Posted by Markus Armbruster 10 months, 2 weeks ago
Accidental duplicate, please ignore.
Re: [PATCH v2 03/21] docs/qapidoc: remove unused intersperse function
Posted by John Snow 10 months, 2 weeks ago
On Thu, Jun 27, 2024, 2:02 AM Markus Armbruster <armbru@redhat.com> wrote:

> John Snow <jsnow@redhat.com> writes:
>
> > This function has been unused since fd62bff901b.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
> I assume you won't mind me adding a bit of polish: "since commit
> fd62bff901b (sphinx/qapidoc: Drop code to generate doc for simple union
> tag)".
>

Please be my guest!

--js

(Looking at it, that's a very weird phrase, isn't it?)

>
Re: [PATCH v2 03/21] docs/qapidoc: remove unused intersperse function
Posted by Markus Armbruster 10 months, 2 weeks ago
John Snow <jsnow@redhat.com> writes:

> This function has been unused since fd62bff901b.
>
> Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Markus Armbruster <armbru@redhat.com>

I assume you won't mind me adding a bit of polish: "since commit
fd62bff901b (sphinx/qapidoc: Drop code to generate doc for simple union
tag)".