[v2] Fix check-qtest-ppc64 sanitizer errors

[PATCH v2 12/15] tests/qtest: Free old machine variable name

Posted by Akihiko Odaki 10 months, 2 weeks ago

This fixes LeakSanitizer warnings.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/qtest/libqtest.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index f89da7b80797..1605c0c9f615 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -1509,6 +1509,7 @@ static struct MachInfo *qtest_get_machines(const char *var)
     int idx;
 
     if (g_strcmp0(qemu_var, var)) {
+        g_free(qemu_var);
         qemu_var = g_strdup(var);
 
         /* new qemu, clear the cache */

-- 
2.45.2

Re: [PATCH v2 12/15] tests/qtest: Free old machine variable name

Posted by Peter Maydell 10 months, 2 weeks ago

On Thu, 27 Jun 2024 at 14:40, Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>
> This fixes LeakSanitizer warnings.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>  tests/qtest/libqtest.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
> index f89da7b80797..1605c0c9f615 100644
> --- a/tests/qtest/libqtest.c
> +++ b/tests/qtest/libqtest.c
> @@ -1509,6 +1509,7 @@ static struct MachInfo *qtest_get_machines(const char *var)
>      int idx;
>
>      if (g_strcmp0(qemu_var, var)) {
> +        g_free(qemu_var);
>          qemu_var = g_strdup(var);
>
>          /* new qemu, clear the cache */
>
> --
> 2.45.2

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM