From nobody Sat Dec 28 10:37:15 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1719606149; cv=none; d=zohomail.com; s=zohoarc; b=Dtz6v/mhzVre3ancK2ahM5NqRiV6YWPCmGlYrvkK4ZCT1PpJcOzhN+YAxoq8YnmocOzuvDwB0PjfFuodPfYxmoFgDhV5lWs7GBd+YfjrCCEBp0ta4+RGfYEvN8LrRZgGTfM/PsA4FLg/M38uox1WWN1lxLYarIGBegOw0XpUbS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719606149; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IuwFr81seUA4HCmSEHEEcL3uEHCXfggSjJwHqNFXCHM=; b=iRjOH+gxMGc57XN/x320jP5ErY0GpDyEE3Yt0W48pKUZ1v0LhbEPf2lXsIe2rKocfwwomheWI55DRCxwCs8B2Q1nJvNbEYQeWSaS5gYOvOomJn+oAh+2ATxaLyjF/DyCTSsTmSAAXHGQ6QvhtsxeMR1Wnob5h332MgAT23GFpjs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1719606149329693.6148748354847; Fri, 28 Jun 2024 13:22:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNI61-0002Ta-Ei; Fri, 28 Jun 2024 16:21:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNI60-0002Sw-7e for qemu-devel@nongnu.org; Fri, 28 Jun 2024 16:21:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNI5w-0004Gg-RW for qemu-devel@nongnu.org; Fri, 28 Jun 2024 16:21:22 -0400 Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-4i8nV4wdMiuKerUgaxTvVw-1; Fri, 28 Jun 2024 16:21:14 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CF0A21944D17; Fri, 28 Jun 2024 20:21:12 +0000 (UTC) Received: from sparse.com (unknown [10.47.238.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id CE025300021A; Fri, 28 Jun 2024 20:21:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719606076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IuwFr81seUA4HCmSEHEEcL3uEHCXfggSjJwHqNFXCHM=; b=fqoWuVaMhl6qnmfCpLDC/wZuL6lE3ZIf8IhiWxLoLGZJA74B77bjacBf+LyIqINpFGEqEg tsZnjopijmjtAiMbAI0wWcAci5KFxUSyvK5fwh/WWpfrnzysUTcmeKZzGuE12kdDhDBWsd aDFbNyX2CGsyMIUPB3qYihnEWgpPOtA= X-MC-Unique: 4i8nV4wdMiuKerUgaxTvVw-1 From: Nir Soffer To: qemu-devel@nongnu.org Cc: Hanna Reitz , Stefan Hajnoczi , Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Nir Soffer Subject: [PATCH v3 1/2] qemu-iotest/245: Add missing discard=unmap Date: Fri, 28 Jun 2024 23:20:57 +0300 Message-ID: <20240628202058.1964986-2-nsoffer@redhat.com> In-Reply-To: <20240628202058.1964986-1-nsoffer@redhat.com> References: <20240628202058.1964986-1-nsoffer@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=nsoffer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.206, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1719606150459100001 Content-Type: text/plain; charset="utf-8" The test works since we punch holes by default even when opening the image without discard=3Don or discard=3Dunmap. Fix the test to enable discard. Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/245 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245 index a934c9d1e6..f96610f510 100755 --- a/tests/qemu-iotests/245 +++ b/tests/qemu-iotests/245 @@ -590,11 +590,11 @@ class TestBlockdevReopen(iotests.QMPTestCase): =20 # Insert (and remove) a compress filter @iotests.skip_if_unsupported(['compress']) def test_insert_compress_filter(self): # Add an image to the VM: hd (raw) -> hd0 (qcow2) -> hd0-file (fil= e) - opts =3D {'driver': 'raw', 'node-name': 'hd', 'file': hd_opts(0)} + opts =3D {'driver': 'raw', 'node-name': 'hd', 'file': hd_opts(0), = 'discard': 'unmap'} self.vm.cmd('blockdev-add', conv_keys =3D False, **opts) =20 # Add a 'compress' filter filter_opts =3D {'driver': 'compress', 'node-name': 'compress0', --=20 2.45.2 From nobody Sat Dec 28 10:37:15 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1719606150; cv=none; d=zohomail.com; s=zohoarc; b=W24OI+o/lrl1mp9lkUvGxx/zS5MUlEsbnyvQpe49U7gRSpIxWxbBc++RnvgmveKR2XR8YYK3YQbgKp+dWWUyt6YBNPX70PYYWN181phL546NlZoEPKYadckzDWHDNDwbBjsmUwae0IVQ6sFR2Pb8VW8b29mne8OyJrE9vAyO6UA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1719606150; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=9hj42MrpU84nBzKHwTpBWziHGiAUGlacUsDnrjj2PLA=; b=HKFKRV8Im606fjMDXpGMUqpkIPnBQmZIsmbWQOMwNvwdK720CjwDyRPV7gkEnAzZ9JYxl1K5mtC+tQhzZczOa+YCVarg4XnqTmRjXYjqBxHfUQu+GomjgcZ9Oi8rfB+oC4GCk83n8LwJ1vZVvzw/qvxssA1huyWsbqTCrl68oi4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1719606150152319.57611005650506; Fri, 28 Jun 2024 13:22:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNI6D-0002YA-MK; Fri, 28 Jun 2024 16:21:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNI65-0002WC-Vp for qemu-devel@nongnu.org; Fri, 28 Jun 2024 16:21:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNI63-0004Ip-K2 for qemu-devel@nongnu.org; Fri, 28 Jun 2024 16:21:29 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-662-PKCr2aWMMmmzjqmspT4E6A-1; Fri, 28 Jun 2024 16:21:22 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 031D8195608F; Fri, 28 Jun 2024 20:21:21 +0000 (UTC) Received: from sparse.com (unknown [10.47.238.2]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 58B95300021A; Fri, 28 Jun 2024 20:21:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719606086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9hj42MrpU84nBzKHwTpBWziHGiAUGlacUsDnrjj2PLA=; b=LAaebIczrOffOqFTU5qvNMrxZBXxjtifYFAEim9bnMtr55x2wqVl/PzjAxzen8QBj+7qQS V8xOzxK+vNFVIsbecpIRxXiLQapnC3pSl9LfAP8gGcskPGrAwIf80oUkTSMBQIg8Bp1adA sReMwug4J/UsbriEwEDcbC0NZbAV+X4= X-MC-Unique: PKCr2aWMMmmzjqmspT4E6A-1 From: Nir Soffer To: qemu-devel@nongnu.org Cc: Hanna Reitz , Stefan Hajnoczi , Kevin Wolf , Fam Zheng , qemu-block@nongnu.org, Nir Soffer Subject: [PATCH v3 2/2] Consider discard option when writing zeros Date: Fri, 28 Jun 2024 23:20:58 +0300 Message-ID: <20240628202058.1964986-3-nsoffer@redhat.com> In-Reply-To: <20240628202058.1964986-1-nsoffer@redhat.com> References: <20240628202058.1964986-1-nsoffer@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=nsoffer@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.206, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1719606150505100005 Content-Type: text/plain; charset="utf-8" When opening an image with discard=3Doff, we punch hole in the image when writing zeroes, making the image sparse. This breaks users that want to ensure that writes cannot fail with ENOSPACE by using fully allocated images[1]. bdrv_co_pwrite_zeroes() correctly disables BDRV_REQ_MAY_UNMAP if we opened the child without discard=3Dunmap or discard=3Don. But we don't go through this function when accessing the top node. Move the check down to bdrv_co_do_pwrite_zeroes() which seems to be used in all code paths. This change implements the documented behavior, punching holes only when opening the image with discard=3Don or discard=3Dunmap. This may not be the best default but can improve it later. The test depends on a file system supporting discard, deallocating the entire file when punching hole with the length of the entire file. Tested with xfs, ext4, and tmpfs. [1] https://lists.nongnu.org/archive/html/qemu-discuss/2024-06/msg00003.html Signed-off-by: Nir Soffer Reviewed-by: Stefan Hajnoczi --- block/io.c | 9 +- tests/qemu-iotests/tests/write-zeroes-unmap | 127 ++++++++++++++++++ .../qemu-iotests/tests/write-zeroes-unmap.out | 81 +++++++++++ 3 files changed, 213 insertions(+), 4 deletions(-) create mode 100755 tests/qemu-iotests/tests/write-zeroes-unmap create mode 100644 tests/qemu-iotests/tests/write-zeroes-unmap.out diff --git a/block/io.c b/block/io.c index 7217cf811b..301514c880 100644 --- a/block/io.c +++ b/block/io.c @@ -1860,10 +1860,15 @@ bdrv_co_do_pwrite_zeroes(BlockDriverState *bs, int6= 4_t offset, int64_t bytes, /* By definition there is no user buffer so this flag doesn't make sen= se */ if (flags & BDRV_REQ_REGISTERED_BUF) { return -EINVAL; } =20 + /* If opened with discard=3Doff we should never unmap. */ + if (!(bs->open_flags & BDRV_O_UNMAP)) { + flags &=3D ~BDRV_REQ_MAY_UNMAP; + } + /* Invalidate the cached block-status data range if this write overlap= s */ bdrv_bsc_invalidate_range(bs, offset, bytes); =20 assert(alignment % bs->bl.request_alignment =3D=3D 0); head =3D offset % alignment; @@ -2313,14 +2318,10 @@ int coroutine_fn bdrv_co_pwrite_zeroes(BdrvChild *c= hild, int64_t offset, { IO_CODE(); trace_bdrv_co_pwrite_zeroes(child->bs, offset, bytes, flags); assert_bdrv_graph_readable(); =20 - if (!(child->bs->open_flags & BDRV_O_UNMAP)) { - flags &=3D ~BDRV_REQ_MAY_UNMAP; - } - return bdrv_co_pwritev(child, offset, bytes, NULL, BDRV_REQ_ZERO_WRITE | flags); } =20 /* diff --git a/tests/qemu-iotests/tests/write-zeroes-unmap b/tests/qemu-iotes= ts/tests/write-zeroes-unmap new file mode 100755 index 0000000000..7cfeeaf839 --- /dev/null +++ b/tests/qemu-iotests/tests/write-zeroes-unmap @@ -0,0 +1,127 @@ +#!/usr/bin/env bash +# group: quick +# +# Test write zeros unmap. +# +# Copyright (C) Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . +# + +seq=3D"$(basename $0)" +echo "QA output created by $seq" + +trap _cleanup_test_img exit + +# get standard environment, filters and checks +cd .. +. ./common.rc +. ./common.filter + +_supported_fmt raw +_supported_proto file +_supported_os Linux + +create_test_image() { + _make_test_img -f $IMGFMT 1m +} + +filter_command() { + _filter_testdir | _filter_qemu_io | _filter_qemu | _filter_hmp +} + +print_disk_usage() { + du -sh $TEST_IMG | _filter_testdir +} + +echo +echo "=3D=3D=3D defaults - write zeros =3D=3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -z 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT \ + | filter_command +print_disk_usage + +echo +echo "=3D=3D=3D defaults - write zeros unmap =3D=3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -zu 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT \ + | filter_command +print_disk_usage + + +echo +echo "=3D=3D=3D defaults - write actual zeros =3D=3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -P 0 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT \ + | filter_command +print_disk_usage + +echo +echo "=3D=3D=3D discard=3Doff - write zeroes unmap =3D=3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -zu 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT,discard=3Doff \ + | filter_command +print_disk_usage + +echo +echo "=3D=3D=3D detect-zeroes=3Don - write actual zeros =3D=3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -P 0 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT,detect-zeroes=3Don \ + | filter_command +print_disk_usage + +echo +echo "=3D=3D=3D detect-zeroes=3Don,discard=3Don - write actual zeros =3D= =3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -P 0 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT,detect-zeroes=3Don,discard=3Don \ + | filter_command +print_disk_usage + +echo +echo "=3D=3D=3D discard=3Don - write zeroes =3D=3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -z 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT,discard=3Don \ + | filter_command +print_disk_usage + +echo +echo "=3D=3D=3D discard=3Don - write zeroes unmap =3D=3D=3D" +echo + +create_test_image +echo -e 'qemu-io none0 "write -zu 0 1m"\nquit' \ + | $QEMU -monitor stdio -drive if=3Dnone,file=3D$TEST_IMG,format=3D$IMG= FMT,discard=3Don \ + | filter_command +print_disk_usage diff --git a/tests/qemu-iotests/tests/write-zeroes-unmap.out b/tests/qemu-i= otests/tests/write-zeroes-unmap.out new file mode 100644 index 0000000000..c931994897 --- /dev/null +++ b/tests/qemu-iotests/tests/write-zeroes-unmap.out @@ -0,0 +1,81 @@ +QA output created by write-zeroes-unmap + +=3D=3D=3D defaults - write zeros =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -z 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +1.0M TEST_DIR/t.raw + +=3D=3D=3D defaults - write zeros unmap =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -zu 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +1.0M TEST_DIR/t.raw + +=3D=3D=3D defaults - write actual zeros =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -P 0 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +1.0M TEST_DIR/t.raw + +=3D=3D=3D discard=3Doff - write zeroes unmap =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -zu 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +1.0M TEST_DIR/t.raw + +=3D=3D=3D detect-zeroes=3Don - write actual zeros =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -P 0 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +1.0M TEST_DIR/t.raw + +=3D=3D=3D detect-zeroes=3Don,discard=3Don - write actual zeros =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -P 0 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +1.0M TEST_DIR/t.raw + +=3D=3D=3D discard=3Don - write zeroes =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -z 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +1.0M TEST_DIR/t.raw + +=3D=3D=3D discard=3Don - write zeroes unmap =3D=3D=3D + +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D1048576 +QEMU X.Y.Z monitor - type 'help' for more information +(qemu) qemu-io none0 "write -zu 0 1m" +wrote 1048576/1048576 bytes at offset 0 +1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) +(qemu) quit +0 TEST_DIR/t.raw --=20 2.45.2