Hi,
In this new version we followed Daniel's suggestion in the v1 review [1]
and moved all 'globals' related functions and definitions from qdev to
object. Functions were renamed as follows:
- qdev_prop_register_global() is now object_prop_register_global()
- qdev_find_global_prop() is now object_find_global_prop()
- qdev_prop_check_globals() is now object_prop_check_globals()
- qdev_prop_set_globals() is now object_prop_set_globals()
The API change that were done in patch 1 is now being done on
object_prop_set_globals().
It crossed my mind to rename test-qdev-global-props.c to
test-object-global-props.c, but since the file is dealing exclusively
with qdev related tests I think the rename was unneeded.
No other changes made.
Changes from v1:
- patch 1:
- move all globals related function and declarations from qdev files
to object
- v1 review: https://lore.kernel.org/qemu-devel/20240703094626.1704990-1-dbarboza@ventanamicro.com/
[1] https://lore.kernel.org/qemu-devel/ZoUwMr1X170aQNDS@redhat.com/
Daniel Henrique Barboza (2):
qom/object, qdev: move globals functions to object.c
qom/object, accel-system: add support to Accel globals
accel/accel-system.c | 2 +
hw/core/cpu-common.c | 2 +-
hw/core/qdev-properties-system.c | 2 +-
hw/core/qdev-properties.c | 71 -------------------------
hw/core/qdev.c | 2 +-
include/hw/qdev-core.h | 27 ----------
include/hw/qdev-properties.h | 5 --
include/qom/object.h | 34 ++++++++++++
qom/object.c | 82 +++++++++++++++++++++++++++++
system/vl.c | 6 +--
target/i386/cpu.c | 2 +-
target/sparc/cpu.c | 2 +-
tests/unit/test-qdev-global-props.c | 4 +-
13 files changed, 128 insertions(+), 113 deletions(-)
--
2.45.2