[PATCH v5 00/19] Reconstruct loongson ipi driver

Philippe Mathieu-Daudé posted 19 patches 1 month, 3 weeks ago
MAINTAINERS                           |   6 +-
docs/about/emulation.rst              |   2 +-
include/hw/intc/loongarch_ipi.h       |  25 ++
include/hw/intc/loongson_ipi.h        |  50 +---
include/hw/intc/loongson_ipi_common.h |  72 ++++++
include/hw/loongarch/virt.h           |   1 -
hw/intc/loongarch_ipi.c               |  68 +++++
hw/intc/loongson_ipi.c                | 355 +++-----------------------
hw/intc/loongson_ipi_common.c         | 344 +++++++++++++++++++++++++
hw/loongarch/virt.c                   |   4 +-
hw/rtc/ls7a_rtc.c                     |   2 +-
hw/intc/Kconfig                       |   8 +
hw/intc/meson.build                   |   2 +
hw/loongarch/Kconfig                  |   2 +-
14 files changed, 570 insertions(+), 371 deletions(-)
create mode 100644 include/hw/intc/loongarch_ipi.h
create mode 100644 include/hw/intc/loongson_ipi_common.h
create mode 100644 hw/intc/loongarch_ipi.c
create mode 100644 hw/intc/loongson_ipi_common.c
[PATCH v5 00/19] Reconstruct loongson ipi driver
Posted by Philippe Mathieu-Daudé 1 month, 3 weeks ago
Since v4:
- Fix build failure due to rebase (Song)
- Loongarch -> LoongArch (Song)
- Added Song's tags

Since v3:
- Use DEFINE_TYPES() macro (unreviewed patch #1)
- Update MAINTAINERS
- Added Bibo's tags

Thanks,

Phil.

Bibo Mao (16):
  hw/intc/loongson_ipi: Access memory in little endian
  hw/intc/loongson_ipi: Rename LoongsonIPI -> LoongsonIPIState
  hw/intc/loongson_ipi: Extract loongson_ipi_common_finalize()
  hw/intc/loongson_ipi: Extract loongson_ipi_common_realize()
  hw/intc/loongson_ipi: Add TYPE_LOONGSON_IPI_COMMON stub
  hw/intc/loongson_ipi: Move common definitions to loongson_ipi_common.h
  hw/intc/loongson_ipi: Move IPICore::mmio_mem to LoongsonIPIState
  hw/intc/loongson_ipi: Move IPICore structure to loongson_ipi_common.h
  hw/intc/loongson_ipi: Pass LoongsonIPICommonState to send_ipi_data()
  hw/intc/loongson_ipi: Add LoongsonIPICommonClass::get_iocsr_as handler
  hw/intc/loongson_ipi: Add LoongsonIPICommonClass::cpu_by_arch_id
    handler
  hw/intc/loongson_ipi: Expose loongson_ipi_core_read/write helpers
  hw/intc/loongson_ipi: Move common code to loongson_ipi_common.c
  hw/intc/loongarch_ipi: Add loongarch IPI support
  hw/loongarch/virt: Replace Loongson IPI with LoongArch IPI
  hw/intc/loongson_ipi: Restrict to MIPS

Philippe Mathieu-Daudé (3):
  hw/intc/loongson_ipi: Declare QOM types using DEFINE_TYPES() macro
  hw/intc/loongson_ipi: Remove unused headers
  docs: Correct Loongarch -> LoongArch

 MAINTAINERS                           |   6 +-
 docs/about/emulation.rst              |   2 +-
 include/hw/intc/loongarch_ipi.h       |  25 ++
 include/hw/intc/loongson_ipi.h        |  50 +---
 include/hw/intc/loongson_ipi_common.h |  72 ++++++
 include/hw/loongarch/virt.h           |   1 -
 hw/intc/loongarch_ipi.c               |  68 +++++
 hw/intc/loongson_ipi.c                | 355 +++-----------------------
 hw/intc/loongson_ipi_common.c         | 344 +++++++++++++++++++++++++
 hw/loongarch/virt.c                   |   4 +-
 hw/rtc/ls7a_rtc.c                     |   2 +-
 hw/intc/Kconfig                       |   8 +
 hw/intc/meson.build                   |   2 +
 hw/loongarch/Kconfig                  |   2 +-
 14 files changed, 570 insertions(+), 371 deletions(-)
 create mode 100644 include/hw/intc/loongarch_ipi.h
 create mode 100644 include/hw/intc/loongson_ipi_common.h
 create mode 100644 hw/intc/loongarch_ipi.c
 create mode 100644 hw/intc/loongson_ipi_common.c

-- 
2.41.0


Re: [PATCH v5 00/19] Reconstruct loongson ipi driver
Posted by Richard Henderson 1 month, 3 weeks ago
On 7/18/24 23:32, Philippe Mathieu-Daudé wrote:
> Since v4:
> - Fix build failure due to rebase (Song)
> - Loongarch -> LoongArch (Song)
> - Added Song's tags
> 
> Since v3:
> - Use DEFINE_TYPES() macro (unreviewed patch #1)
> - Update MAINTAINERS
> - Added Bibo's tags

Ho hum, I didn't notice v5 when I just reviewed v4.

For the series:
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH v5 00/19] Reconstruct loongson ipi driver
Posted by Jiaxun Yang 1 month, 2 weeks ago

在2024年7月18日七月 下午9:32,Philippe Mathieu-Daudé写道:
> Since v4:
> - Fix build failure due to rebase (Song)
> - Loongarch -> LoongArch (Song)
> - Added Song's tags
>
> Since v3:
> - Use DEFINE_TYPES() macro (unreviewed patch #1)
> - Update MAINTAINERS
> - Added Bibo's tags

For the whole series:

Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Thanks! Tested on MIPS loongson3-virt with 2, 4 CPUs, all working fine.

I'll get this covered by CI later.
- Jiaxun

>
> Thanks,
>
> Phil.
>
> Bibo Mao (16):
>   hw/intc/loongson_ipi: Access memory in little endian
>   hw/intc/loongson_ipi: Rename LoongsonIPI -> LoongsonIPIState
>   hw/intc/loongson_ipi: Extract loongson_ipi_common_finalize()
>   hw/intc/loongson_ipi: Extract loongson_ipi_common_realize()
>   hw/intc/loongson_ipi: Add TYPE_LOONGSON_IPI_COMMON stub
>   hw/intc/loongson_ipi: Move common definitions to loongson_ipi_common.h
>   hw/intc/loongson_ipi: Move IPICore::mmio_mem to LoongsonIPIState
>   hw/intc/loongson_ipi: Move IPICore structure to loongson_ipi_common.h
>   hw/intc/loongson_ipi: Pass LoongsonIPICommonState to send_ipi_data()
>   hw/intc/loongson_ipi: Add LoongsonIPICommonClass::get_iocsr_as handler
>   hw/intc/loongson_ipi: Add LoongsonIPICommonClass::cpu_by_arch_id
>     handler
>   hw/intc/loongson_ipi: Expose loongson_ipi_core_read/write helpers
>   hw/intc/loongson_ipi: Move common code to loongson_ipi_common.c
>   hw/intc/loongarch_ipi: Add loongarch IPI support
>   hw/loongarch/virt: Replace Loongson IPI with LoongArch IPI
>   hw/intc/loongson_ipi: Restrict to MIPS
>
> Philippe Mathieu-Daudé (3):
>   hw/intc/loongson_ipi: Declare QOM types using DEFINE_TYPES() macro
>   hw/intc/loongson_ipi: Remove unused headers
>   docs: Correct Loongarch -> LoongArch
>
>  MAINTAINERS                           |   6 +-
>  docs/about/emulation.rst              |   2 +-
>  include/hw/intc/loongarch_ipi.h       |  25 ++
>  include/hw/intc/loongson_ipi.h        |  50 +---
>  include/hw/intc/loongson_ipi_common.h |  72 ++++++
>  include/hw/loongarch/virt.h           |   1 -
>  hw/intc/loongarch_ipi.c               |  68 +++++
>  hw/intc/loongson_ipi.c                | 355 +++-----------------------
>  hw/intc/loongson_ipi_common.c         | 344 +++++++++++++++++++++++++
>  hw/loongarch/virt.c                   |   4 +-
>  hw/rtc/ls7a_rtc.c                     |   2 +-
>  hw/intc/Kconfig                       |   8 +
>  hw/intc/meson.build                   |   2 +
>  hw/loongarch/Kconfig                  |   2 +-
>  14 files changed, 570 insertions(+), 371 deletions(-)
>  create mode 100644 include/hw/intc/loongarch_ipi.h
>  create mode 100644 include/hw/intc/loongson_ipi_common.h
>  create mode 100644 hw/intc/loongarch_ipi.c
>  create mode 100644 hw/intc/loongson_ipi_common.c
>
> -- 
> 2.41.0

-- 
- Jiaxun
Re: [PATCH v5 00/19] Reconstruct loongson ipi driver
Posted by Philippe Mathieu-Daudé 1 month, 2 weeks ago
On 19/7/24 14:56, Jiaxun Yang wrote:
> 
> 
> 在2024年7月18日七月 下午9:32,Philippe Mathieu-Daudé写道:
>> Since v4:
>> - Fix build failure due to rebase (Song)
>> - Loongarch -> LoongArch (Song)
>> - Added Song's tags
>>
>> Since v3:
>> - Use DEFINE_TYPES() macro (unreviewed patch #1)
>> - Update MAINTAINERS
>> - Added Bibo's tags
> 
> For the whole series:
> 
> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Tested-by: Jiaxun Yang <jiaxun.yang@flygoat.com>

Yeah!

> Thanks! Tested on MIPS loongson3-virt with 2, 4 CPUs, all working fine.
> 
> I'll get this covered by CI later.

Thanks,

I'm queuing this series.