From nobody Tue Apr 30 17:25:02 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1623479959; cv=none; d=zohomail.com; s=zohoarc; b=GJSIFYYEd6vAYdIfEIEAd+UIHG/6A5Zx+5cG65thxqeoAzcZXcNjGysC1pNPVnR7cHCOsCQPiqHHYqAzovGHNwe6oF8ojuJv7X+KuodVJuUe6JMgxzwq8rRwiDo2nDJQCMa8U3jBcPuf1DWzmYlvOXPEKbBWvSqdhrLwR5OgmlE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1623479959; h=Content-Type:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=O8FM9eqyBLedaVhXuxy1OMJoAvfvBV+KFhyeVhD0AdE=; b=kEJa3ki9dFSNJTZWeOqpuZHpJia2dgvnt5HJ4s9/TJ8W1Y/PHwJnogSx/EzFl926cIkFnMNUo1NpASoWGAT9Fauq6gK6lEdsM9XIUuPJXJMSXe5EuHzZ1A9JFugchpByGaw9IuqMgg1V6ozFmIlDjd0DeonP1dQDdCP5AMavsIk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1623479959765701.8547855698251; Fri, 11 Jun 2021 23:39:19 -0700 (PDT) Received: from localhost ([::1]:37132 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrxIc-0000ub-Pb for importer2@patchew.org; Sat, 12 Jun 2021 02:39:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40298) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrwk1-0006kS-59 for qemu-devel@nongnu.org; Sat, 12 Jun 2021 02:03:33 -0400 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]:43740) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lrwjz-0001H4-BQ for qemu-devel@nongnu.org; Sat, 12 Jun 2021 02:03:32 -0400 Received: by mail-oi1-x231.google.com with SMTP id x196so8216335oif.10 for ; Fri, 11 Jun 2021 23:03:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=O8FM9eqyBLedaVhXuxy1OMJoAvfvBV+KFhyeVhD0AdE=; b=jeNmlwHLq2iKb2GBOdvOKQTUvzhG+5Mk0xg+94V1/2wB+FEhSPMpSQJyq/bJkT3eWs dlsPpk+jYfInOItejTBZuW4iYWCiefd7QDSSy4oHeHhspFhwyrZt6H6GHn3oAHm6XBrS dUD+Jg0B6wm5P1nb9NurjIrfNBH/97v7+sqn+YRJKelbAV9lO4/v5WQAb88QbQNqrbPA xppeuBnTH7g2SbEdz4n7lBKz/9Nb3M/iw2iGaMmhDj5GcUy9M7cAWGUPq1moe2jYpO8M V7oZRBx9ManhEk2VseevTfmtJ6najbMEpdM196YHXQr5cufhBabh3HMKZI6cf9CzHfX2 xHaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=O8FM9eqyBLedaVhXuxy1OMJoAvfvBV+KFhyeVhD0AdE=; b=AXmtn2wniymL9zekEY+/2mZ5ZVoNJ+3+NVVInxIfAEQqHjNSRSqLpvD7WdjXyYG2oX iYCv68ssO85NdD8wB2v1/5HX5AxBAUUZg2fufDEjrTPGUNjZTI9lx+l1s9CB7a6WfwTd W6d7NrX36OVMNMEoDQ2CSbNiK0BBhGt9VukIYxzcdx9pU+5Vb+042sgB3Oir11DBVjZb Oe2JH6y/y4Ean31oRSZpijCcOxz5lKqLSXPe687VCjJktj5V1stXlSpWH8FzZOz8/+jL uxP+XCFnnprQcCktCmbR8ySh4daDQXVr5tsJIgAwSl5+bOG9mXYaZDjZOBLZwbGfcRWz g/uA== X-Gm-Message-State: AOAM531rxGITepJngH5T6tck7xryW4WjcvIMO5pKr2rGz1O7pMkalCoX EBnvy54gIphmOrV+mKcS3n42Qmd1XHS9m1exCVMWSXdP0LMfoA== X-Google-Smtp-Source: ABdhPJxjczIxpugYbnepkgJT9HtB6Bn8ga9F2zaYT9T1OcpmFQCrnEObzygZcEQWL8xS3ee8FZSLJBCV3zu/9012Ew0= X-Received: by 2002:a05:6808:68d:: with SMTP id k13mr4651017oig.83.1623477809036; Fri, 11 Jun 2021 23:03:29 -0700 (PDT) MIME-Version: 1.0 From: Liu Cyrus Date: Sat, 12 Jun 2021 14:03:17 +0800 Message-ID: Subject: Subject: [PATCH] hw/vmxnet3: fix vmxnet3 g_assert_not_reached bug To: qemu-devel@nongnu.org Content-Type: multipart/alternative; boundary="0000000000001bc0f705c48b625d" Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::231; envelope-from=cyruscyliu@gmail.com; helo=mail-oi1-x231.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 12 Jun 2021 02:38:22 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @gmail.com) Content-Transfer-Encoding: quoted-printable --0000000000001bc0f705c48b625d MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 RnJvbTogY3lydXNjeWxpdSA8Y3lydXNjeWxpdUBnbWFpbC5jb20+CgpBIGdfYXNzZXJ0X25vdF9y ZWFjaGVkIG9mIHZteG5ldDMgY2FuIGJlIHRyaWdnZXJlZCBieSBhIGd1ZXN0IHdpdGggdGhlIHJv b3QKcHJpdmlsZWdlLgpSZW1vdmUgdGhlIFZNWE5FVDNfUkVHX0lDUiBicmFuY2ggdGh1cyBnZXQg cmlkIG9mIHRoaXMgY3Jhc2guCgpGaXhlczogNzg2ZmQyYjBmODdiICgiVk1YTkVUMyBkZXZpY2Ug aW1wbGVtZW50YXRpb24iKQpSZXNvbHZlczogaHR0cHM6Ly9naXRsYWIuY29tL3FlbXUtcHJvamVj dC9xZW11Ly0vaXNzdWVzLzMwOQpCdWdsaW5rOiBodHRwczovL2J1Z3MubGF1bmNocGFkLm5ldC9x ZW11LytidWcvMTkxMzkyMwpTaWduZWQtb2ZmLWJ5OiBjeXJ1c2N5bGl1IDxjeXJ1c2N5bGl1QGdt YWlsLmNvbT4KLS0tCiBody9uZXQvdm14bmV0My5jIHwgNyAtLS0tLS0tCiAxIGZpbGUgY2hhbmdl ZCwgNyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ody9uZXQvdm14bmV0My5jIGIvaHcvbmV0 L3ZteG5ldDMuYwppbmRleCBlZmYyOTlmLi5hMzg4OTE4IDEwMDY0NAotLS0gYS9ody9uZXQvdm14 bmV0My5jCisrKyBiL2h3L25ldC92bXhuZXQzLmMKQEAgLTE3ODYsMTMgKzE3ODYsNiBAQCB2bXhu ZXQzX2lvX2JhcjFfd3JpdGUodm9pZCAqb3BhcXVlLAogICAgICAgICB2bXhuZXQzX3NldF92YXJp YWJsZV9tYWMocywgdmFsLCBzLT50ZW1wX21hYyk7CiAgICAgICAgIGJyZWFrOwoKLSAgICAvKiBJ bnRlcnJ1cHQgQ2F1c2UgUmVnaXN0ZXIgKi8KLSAgICBjYXNlIFZNWE5FVDNfUkVHX0lDUjoKLSAg ICAgICAgVk1XX0NCUFJOKCJXcml0ZSBCQVIxIFtWTVhORVQzX1JFR19JQ1JdID0zRCAlIiBQUkl4 NjQgIiwgc2l6ZSAlZCIsCi0gICAgICAgICAgICAgICAgICB2YWwsIHNpemUpOwotICAgICAgICBn X2Fzc2VydF9ub3RfcmVhY2hlZCgpOwotICAgICAgICBicmVhazsKLQogICAgIC8qIEV2ZW50IENh dXNlIFJlZ2lzdGVyICovCiAgICAgY2FzZSBWTVhORVQzX1JFR19FQ1I6CiAgICAgICAgIFZNV19D QlBSTigiV3JpdGUgQkFSMSBbVk1YTkVUM19SRUdfRUNSXSA9M0QgJSIgUFJJeDY0ICIsIHNpemUg JWQiLAotLQoyLjcuNAoKSGkgZm9sa3MsIHRoaXMgaXMgYSBzdWdnZXN0aW9uIGZvciBmaXhpbmcg dGhpcyBidWcuCkknbSB3aWxsaW5nIHRvIGRpc2N1c3MgdGhpcyB3aXRoIHlvdSBiZWNhdXNlIEkn bSBuZXcgdG8gY29udHJpYnV0ZSB0byBRRU1VLgoKQmVzdCwKUWlhbmc= --0000000000001bc0f705c48b625d Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
From: cyruscyliu <cyruscyliu@gmail.com>

A g_asser= t_not_reached of vmxnet3 can be triggered by a guest with the root privileg= e.
Remove the VMXNET3_REG_ICR branch thus get rid of this crash.<= /div>
Fixes: 786fd2b0f87b ("VMXNET3 device implementation")Resolves: ht= tps://gitlab.com/qemu-project/qemu/-/issues/309
Buglink:=C2=A0https://bugs.launchpad.= net/qemu/+bug/1913923
Signed-off-by: cyruscyliu <cyruscyliu@gmail.com>
---
=C2=A0h= w/net/vmxnet3.c | 7 -------
=C2=A01 file changed, 7 deletions(-)

= diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index eff299f..a388918 = 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -1786,13 += 1786,6 @@ vmxnet3_io_bar1_write(void *opaque,
=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0vmxnet3_set_variable_mac(s, val, s->temp_mac);
=C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0break;

- =C2=A0 =C2=A0/* Interrupt Cause Reg= ister */
- =C2=A0 =C2=A0case VMXNET3_REG_ICR:
- =C2=A0 =C2=A0 =C2=A0 = =C2=A0VMW_CBPRN("Write BAR1 [VMXNET3_REG_ICR] =3D %" PRIx64 "= ;, size %d",
- =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0val, size);
- =C2=A0 =C2=A0 =C2=A0 =C2=A0g_assert_not_reached(= );
- =C2=A0 =C2=A0 =C2=A0 =C2=A0break;
-
=C2=A0 =C2=A0 =C2=A0/* Ev= ent Cause Register */
=C2=A0 =C2=A0 =C2=A0case VMXNET3_REG_ECR:
=C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0VMW_CBPRN("Write BAR1 [VMXNET3_REG_ECR]= =3D %" PRIx64 ", size %d",
--
2.7.4

Hi folks, this is a suggestion for fixing this bug.=C2=A0
I'm willing to discu= ss this with you because I'm new to contribute to QEMU.

Best,=
Qiang
--0000000000001bc0f705c48b625d--