linux-user: Show 4th argument of rt_sigprocmask() in strace

[PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace

Posted by Helge Deller 2 years, 10 months ago

Add output for the missing 4th parameter (size_t sigsetsize).

Signed-off-by: Helge Deller <deller@gmx.de>
---
v2: Use %u instead of %d, as suggested by Laurent Vivier


diff --git a/linux-user/strace.c b/linux-user/strace.c
index 3157e4b420..f0f6ada8cb 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
     }
     qemu_log("%s,", how);
     print_pointer(arg1, 0);
-    print_pointer(arg2, 1);
+    print_pointer(arg2, 0);
+    print_raw_param("%u", arg3, 1);
     print_syscall_epilogue(name);
 }
 #endif

Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace

Posted by Laurent Vivier 2 years, 10 months ago

Le 30/01/2023 à 23:20, Helge Deller a écrit :
> Add output for the missing 4th parameter (size_t sigsetsize).
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> v2: Use %u instead of %d, as suggested by Laurent Vivier
> 
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 3157e4b420..f0f6ada8cb 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
>       }
>       qemu_log("%s,", how);
>       print_pointer(arg1, 0);
> -    print_pointer(arg2, 1);
> +    print_pointer(arg2, 0);
> +    print_raw_param("%u", arg3, 1);
>       print_syscall_epilogue(name);
>   }
>   #endif
> 

Applied to my linux-user-for-8.0 branch.

Thanks,
Laurent

Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace

Posted by Laurent Vivier 2 years, 10 months ago

Le 30/01/2023 à 23:20, Helge Deller a écrit :
> Add output for the missing 4th parameter (size_t sigsetsize).
> 
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
> v2: Use %u instead of %d, as suggested by Laurent Vivier
> 
> 
> diff --git a/linux-user/strace.c b/linux-user/strace.c
> index 3157e4b420..f0f6ada8cb 100644
> --- a/linux-user/strace.c
> +++ b/linux-user/strace.c
> @@ -3146,7 +3146,8 @@ print_rt_sigprocmask(CPUArchState *cpu_env, const struct syscallname *name,
>       }
>       qemu_log("%s,", how);
>       print_pointer(arg1, 0);
> -    print_pointer(arg2, 1);
> +    print_pointer(arg2, 0);
> +    print_raw_param("%u", arg3, 1);
>       print_syscall_epilogue(name);
>   }
>   #endif
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

Re: [PATCH v2] linux-user: Show 4th argument of rt_sigprocmask() in strace

Posted by Richard Henderson 2 years, 10 months ago

On 1/30/23 12:20, Helge Deller wrote:
> Add output for the missing 4th parameter (size_t sigsetsize).
> 
> Signed-off-by: Helge Deller<deller@gmx.de>
> ---
> v2: Use %u instead of %d, as suggested by Laurent Vivier
> 

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~