From nobody Wed Apr 24 17:48:29 2024 Delivered-To: importer2@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=aol.com ARC-Seal: i=1; a=rsa-sha256; t=1674349105; cv=none; d=zohomail.com; s=zohoarc; b=n9lCsY/eV7fkF8jVpGd6h0lHwyP5K01d7+043J8175YGztQbcdUAqglfCA+wc/H9YkqzCqet17mHoU9v8udHOSaGepI9wFa5pfuDF8u/pOxyOazU/FTzuqWeAUDxv5HtfXbypXJ8slfyjtse3SWzNtqfcsYFbRtnUmfWTHdanv4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1674349105; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+5j1CLbOk83+kLzMtFdUlyfegANarV75tev3JSlOpik=; b=gzBMJUBw97Vyw+xkSEk+21A1sCRHaGgR8rKoGaLktTUzsOM+DzzjbXzgJLluq/pW8/fRFZrHTbIpC45lc/TTmN/xPp9JTMdjKKAFpQttlZa6E+d5dTsT3SSKzWG3DRnQvL+XeQ27xUN9aa1yAl3nQTDemF8+7U64lu0fR/68o0M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer2=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1674349105037849.5414043056411; Sat, 21 Jan 2023 16:58:25 -0800 (PST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pJOfm-0002aA-27; Sat, 21 Jan 2023 19:57:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJOfl-0002Zb-0b for qemu-devel@nongnu.org; Sat, 21 Jan 2023 19:57:25 -0500 Received: from sonic308-8.consmr.mail.gq1.yahoo.com ([98.137.68.32]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pJOfh-0006X1-Po for qemu-devel@nongnu.org; Sat, 21 Jan 2023 19:57:24 -0500 Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.gq1.yahoo.com with HTTP; Sun, 22 Jan 2023 00:57:15 +0000 Received: by hermes--production-bf1-6bb65c4965-z9bcn (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID e61cba04d8e7c7463f511e9383474b44; Sun, 22 Jan 2023 00:57:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aol.com; s=a2048; t=1674349035; bh=+5j1CLbOk83+kLzMtFdUlyfegANarV75tev3JSlOpik=; h=From:To:Cc:Subject:Date:References:From:Subject:Reply-To; b=jCj4LBQTzyseZ/J9DGWQAMPaGNaxOV6nEEhXRPXjEYGZOZVKj5av0mpQU11h0jCaYBav0EEVVnRl4yduXaBRaEZffSqs6F09z6IEQgdvCtS0AEPPob5MJ1iKsVUPMRX9hftax10e0ytFtvv2XTX8WgA52JYELP3qS3szsiRihjxhhWJFqSq4HlwHLyRbfv5KGVbhzKxiuveVn8fSKh9emLfvXN8x77u78M1xuo/v+A7Fy747hnMixKSTOf7mJBSU/NWqGDTTOTq9rdEN8SBOn54gLujFCae1UAjGqUNRNEJZvB0WHRd9RxOVcEraR3Uh2+ho5Abuw3LRm+iI9T6J1w== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1674349035; bh=Zcu4F8g7U+DBJ23Vhr6FaGdxk5IGtkT9rEocEdowBv0=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FyvBVCzo6nklhrm2IMik12hG7iUf9tZOpVdt11jN+ff2O4NV1LQDE3nPhnHiOpdAAx+wCdKk6WTQRR8sLp7u2+Bh+RBjvfklr/FhqdZJmKnLJ+2SKgw+tgeLkZNSOW7oK23krPuOejp7ZF7BkAaIvYAqMg0k4NwlFKe98eT7fOJFCjFjoUXq95oLMIS8QxKFyNt+aPQ1mlA/JW/2poxhx+eh8JjPsrAc7IxOJa+MX9sFrKY7bZPME+3Kwfvik5V3nenXj2sP+IRpoku06HD9zekPxxhzS3Ls9p3bhId85+7xmxpuW/h6wp+NZ3zWZeusU03pHe0Bs8TKMw8bWAa5HA== X-YMail-OSG: HC1dXbgVM1k5F_7RnUpJI1.ZcVaQCmYb1DmdjdND1Msq2rqmNBYNpO646r48yq_ 5p4kJD3cBJALUYbTmvH03fOjvMtQTnL5QudpdSzKkqXTbPLMO.GpbIt53kGLuQ62uHQ6LoAu6MV5 _lYBwQQ99AcwM3WJSs4.ehlSfiHmIicQc_gMNxs2fE4fr6iTwrQ2KRW.cnpHlZzEWNXVmGdJaUxs sz1LkmVWyXNMkpcrRG0QLInc_wFoQMtQxJ02Qec6LeRfjq_nKqsXtoXDWnN0eK2ldpNIL5cryTX6 4_MiGR2HJwTQZbCbLWL5dg1nLGY9Z1fVBMHuE034iztA7r2go1UV9G5mgb5xDYmRoZxN2rh_7xSa 5HqFILp_NMYzjLBfBD459b_zzo2KmeGhB.h1UT54wfQS2tO2ELUshSkxKwMCxBWQpoCU7fJ47jv6 5Ox96iK7I3PWpGr.JYgscpAZXFUtTJ1iw0bo.3VTDoUNF9B9QMQHi6QRGSZEpqtvVzcOHJs3HHYH QCcvTjsSu.IYnueD8iAgQM1SHT7wTC_9P408Cdend8S2otc5OqmUv.MDFnARMIrMhIoS41sx8Fi0 sgSDsl6h.ieVXwcrnITydGm_syxequGg3WvldvbGEro6Cd9QnpS3KDdQ5riyAX6hmYrBsT7AzYEL i_llwf2A4v0Y1WWR7m8EGKzqyxRHJQt7IWEMZTySRx5p6qGBH759rNfVqTv99quuNcZ1UoeUFoI5 tgvi7RZk3wv7cIwDRbN2YwqbqvdShiVtsuKpcJxY0nf93u4tc4PV.JtWw7Xr2hY4TzHdKSgIgfu3 fSNIJ5LLTV4dV.LiUaVFx3YPuwyyn4jOMkwhNDVdw0tJT94INEzzpRZ6pfcQoAwC5gT2AOU6psAx pSMtIB6C9Uh8qbbm.Wih1rBNUuGoFUWbqN.UZ7hX3IJexOSpmh4BmeKrUIi4s87tc99PN2N2vmY2 sdqqjTW4qGHaSRlHqRrCengnwjAwjEGeya5X2Iyvn8emPMxfmj.T49GMfGGBFPWPoVWPzT..VVGp oYJ45VbtBzJiyspHYVOo_f7Kr6Fu1bszHwVr6syW7aMtTIKbH1G9yGkLz7uEqDcfMLsd4HvBkcnv YAbk8HkjeWKgL4GnwKCBveYuyi7J8Ai1v4XbLqaLYorZ3H5XDFap7caKaockK1dqdaHnHUeBeJZe P4VeMGqZp32dM_L.J6Xqxa08uK93e3c59sX0zB3UN.uN.2_87QQuZi1Bx6iqSpPQeWboJI0MeDCY sl6Sab2YdmCJodALlCle5dKamD57glVQTMsYFz0l_0zvgogLQ5bNxxm.fyPeYiT.DkCLW5vjTSa7 R7BaHHU.fdzuKu2b0cyaOpRgyCpwAtRfh5pxG0lbn6hyR9lya9iHr2vAo3YHmdlKFKrTVgGQ8CEe DlaUYLGkZy2_0yPmeuVdylKTwJe9XlPT3qaXfEb4vGUNXr2eJ6OI04YzGKmE0I3XuMwgPdTiO7v2 VFk1zyXjnRtEf_FCIZwauMaBI0DNWmMlzkLvvbvkHgZho_bG_b0fm6QdKobVZGIUOAATddP56xSW WCzdAL4xeusLcUA4LA_hjALF30YCu2dXG2OOLy3wxP47vN1mBqvqsQTGUGdJEADT_pZ.zti6jUrI X_QZMFcelCIhx_._vgklVTfnZzGpMzehH8LEMemdCEkQ7mZIBliYd0mmk4H7U4u67chVFzOe1W7T 74AyGJqCVW6dZkTDUpvfJSBp0QDAxFVZI49GceCeBJGGH_9RrA6SYQZ6HuERWE7NnQZqquWqMLTB YBWvrEevcS95ystzH3XDQrhXufOY6hLa83xjYm_f3S5TQc8LMQyqP0nAbQwqa8ylGbf8XBc06_FL iJUkZc4rJKlHjsXhnUdysB57c0KDEW67Cwz34MJ8foWFT87TdJHADwxGP.XHLmegPjYTYlPqCZ0p XGjBQSnN_1zqcQ1AghAfmX_TslBFS6ayFvmICurjsLyESLeYYuR8EqqdizLSwbMLVA2sdC8TtqWg 1qHx4hD9mVtaq7k.p8UEjw_FqrbbRAKSUowjIYH2G8CgYERP26c1WQCBFzKYk7lVU.jav4TedOLj 824S2D3XvA5osBciG7XBDrw9Xkn5t6ZuVbgMRJPx_4nZ5ti81kd2V3WldBGOxSG7tlcVr6Pda64w o4AW5pvbzXGXnNqZAAS3qrl4er3Fd4jwPOZ0yMTYB3eyVU78WvYZn7Wd0rtxab7l.fIpxcqpbo3E orcP62QkFbdH1Beg- X-Sonic-MF: From: Chuck Zmudzinski To: qemu-devel@nongnu.org Cc: Stefano Stabellini , Anthony Perard , Paul Durrant , Paolo Bonzini , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Marcel Apfelbaum , Igor Mammedov , xen-devel@lists.xenproject.org, qemu-stable@nongnu.org Subject: [PATCH v11] xen/pt: reserve PCI slot 2 for Intel igd-passthru Date: Sat, 21 Jan 2023 19:57:02 -0500 Message-Id: X-Mailer: git-send-email 2.39.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable References: Content-Length: 16467 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer2=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=98.137.68.32; envelope-from=brchuckz@aim.com; helo=sonic308-8.consmr.mail.gq1.yahoo.com X-Spam_score_int: -4 X-Spam_score: -0.5 X-Spam_bar: / X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer2=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer2=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @aol.com) X-ZM-MESSAGEID: 1674349106957100001 Content-Type: text/plain; charset="utf-8" Intel specifies that the Intel IGD must occupy slot 2 on the PCI bus, as noted in docs/igd-assign.txt in the Qemu source code. Currently, when the xl toolstack is used to configure a Xen HVM guest with Intel IGD passthrough to the guest with the Qemu upstream device model, a Qemu emulated PCI device will occupy slot 2 and the Intel IGD will occupy a different slot. This problem often prevents the guest from booting. The only available workarounds are not good: Configure Xen HVM guests to use the old and no longer maintained Qemu traditional device model available from xenbits.xen.org which does reserve slot 2 for the Intel IGD or use the "pc" machine type instead of the "xenfv" machine type and add the xen platform device at slot 3 using a command line option instead of patching qemu to fix the "xenfv" machine type directly. The second workaround causes some degredation in startup performance such as a longer boot time and reduced resolution of the grub menu that is displayed on the monitor. This patch avoids that reduced startup performance when using the Qemu upstream device model for Xen HVM guests configured with the igd-passthru=3Don option. To implement this feature in the Qemu upstream device model for Xen HVM guests, introduce the following new functions, types, and macros: * XEN_PT_DEVICE_CLASS declaration, based on the existing TYPE_XEN_PT_DEVICE * XEN_PT_DEVICE_GET_CLASS macro helper function for XEN_PT_DEVICE_CLASS * typedef XenPTQdevRealize function pointer * XEN_PCI_IGD_SLOT_MASK, the value of slot_reserved_mask to reserve slot 2 * xen_igd_reserve_slot and xen_igd_clear_slot functions Michael Tsirkin: * Introduce XEN_PCI_IGD_DOMAIN, XEN_PCI_IGD_BUS, XEN_PCI_IGD_DEV, and XEN_PCI_IGD_FN - use them to compute the value of XEN_PCI_IGD_SLOT_MASK The new xen_igd_reserve_slot function uses the existing slot_reserved_mask member of PCIBus to reserve PCI slot 2 for Xen HVM guests configured using the xl toolstack with the gfx_passthru option enabled, which sets the igd-passthru=3Don option to Qemu for the Xen HVM machine type. The new xen_igd_reserve_slot function also needs to be implemented in hw/xen/xen_pt_stub.c to prevent FTBFS during the link stage for the case when Qemu is configured with --enable-xen and --disable-xen-pci-passthrough, in which case it does nothing. The new xen_igd_clear_slot function overrides qdev->realize of the parent PCI device class to enable the Intel IGD to occupy slot 2 on the PCI bus since slot 2 was reserved by xen_igd_reserve_slot when the PCI bus was created in hw/i386/pc_piix.c for the case when igd-passthru=3Don. Move the call to xen_host_pci_device_get, and the associated error handling, from xen_pt_realize to the new xen_igd_clear_slot function to initialize the device class and vendor values which enables the checks for the Intel IGD to succeed. The verification that the host device is an Intel IGD to be passed through is done by checking the domain, bus, slot, and function values as well as by checking that gfx_passthru is enabled, the device class is VGA, and the device vendor in Intel. Signed-off-by: Chuck Zmudzinski Reviewed-by: Michael S. Tsirkin Reviewed-by: Stefano Stabellini --- Notes that might be helpful to reviewers of patched code in hw/xen: The new functions and types are based on recommendations from Qemu docs: https://qemu.readthedocs.io/en/latest/devel/qom.html Notes that might be helpful to reviewers of patched code in hw/i386: The small patch to hw/i386/pc_piix.c is protected by CONFIG_XEN so it does not affect builds that do not have CONFIG_XEN defined. xen_igd_gfx_pt_enabled() in the patched hw/i386/pc_piix.c file is an existing function that is only true when Qemu is built with xen-pci-passthrough enabled and the administrator has configured the Xen HVM guest with Qemu's igd-passthru=3Don option. v2: Remove From: tag at top of commit message v3: Changed the test for the Intel IGD in xen_igd_clear_slot: if (is_igd_vga_passthrough(&s->real_device) && (s->real_device.vendor_id =3D=3D PCI_VENDOR_ID_INTEL)) { is changed to if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot =3D=3D 2) && (s->hostaddr.function =3D=3D 0)) { I hoped that I could use the test in v2, since it matches the other tests for the Intel IGD in Qemu and Xen, but those tests do not work because the necessary data structures are not set with their values yet. So instead use the test that the administrator has enabled gfx_passthru and the device address on the host is 02.0. This test does detect the Intel IGD correctly. v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's email address to match the address used by the same author in commits be9c61da and c0e86b76 =20 Change variable for XEN_PT_DEVICE_CLASS: xptc changed to xpdc v5: The patch of xen_pt.c was re-worked to allow a more consistent test for the Intel IGD that uses the same criteria as in other places. This involved moving the call to xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot and updating the checks for the Intel IGD in xen_igd_clear_slot: =20 if (xen_igd_gfx_pt_enabled() && (s->hostaddr.slot =3D=3D 2) && (s->hostaddr.function =3D=3D 0)) { is changed to if (is_igd_vga_passthrough(&s->real_device) && s->real_device.domain =3D=3D 0 && s->real_device.bus =3D=3D 0 && s->real_device.dev =3D=3D 2 && s->real_device.func =3D=3D 0 && s->real_device.vendor_id =3D=3D PCI_VENDOR_ID_INTEL) { Added an explanation for the move of xen_host_pci_device_get from xen_pt_realize to xen_igd_clear_slot to the commit message. Rebase. v6: Fix logging by removing these lines from the move from xen_pt_realize to xen_igd_clear_slot that was done in v5: XEN_PT_LOG(d, "Assigning real physical device %02x:%02x.%d" " to devfn 0x%x\n", s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); This log needs to be in xen_pt_realize because s->dev.devfn is not set yet in xen_igd_clear_slot. v7: The v7 that was posted to the mailing list was incorrect. v8 is what v7 was intended to be. v8: Inhibit out of context log message and needless processing by adding 2 lines at the top of the new xen_igd_clear_slot function: if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) return; Rebase. This removed an unnecessary header file from xen_pt.h=20 v9: Move check for xen_igd_gfx_pt_enabled() from pc_piix.c to xen_pt.c Move #include "hw/pci/pci_bus.h" from xen_pt.h to xen_pt.c Introduce macros for the IGD devfn constants and use them to compute the value of XEN_PCI_IGD_SLOT_MASK Also use the new macros at an appropriate place in xen_pt_realize Add Cc: to stable - This has been broken for a long time, ever since support for igd-passthru was added to Qemu 7 years ago. Mention new macros in the commit message (Michael Tsirkin) N.B.: I could not follow the suggestion to move the statement pci_bus->slot_reserved_mask &=3D ~XEN_PCI_IGD_SLOT_MASK; to after pci_qdev_realize for symmetry. Doing that results in an error when creating the guest: =20 libxl: error: libxl_qmp.c:1837:qmp_ev_parse_error_messages: Domain 4:PC= I: slot 2 function 0 not available for xen-pci-passthrough, reserved libxl: error: libxl_pci.c:1809:device_pci_add_done: Domain 4:libxl__dev= ice_pci_add failed for PCI device 0:0:2.0 (rc -28) libxl: error: libxl_create.c:1921:domcreate_attach_devices: Domain 4:un= able to add pci devices v10: Change in xen_pt.c at xen_igd_clear_slot from if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) return; xen_host_pci_device_get(&s->real_device, s->hostaddr.domain, s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, errp); if (*errp) { error_append_hint(errp, "Failed to \"open\" the real pci device"); return; } to: xen_host_pci_device_get(&s->real_device, s->hostaddr.domain, s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, errp); if (*errp) { error_append_hint(errp, "Failed to \"open\" the real pci device"); return; } if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) { xpdc->pci_qdev_realize(qdev, errp); return; } Testing shows this fixes the problem of xen_host_pci_device_get and xpdc->pci_qdev_realize not being called if xen_igd_clear_slot returns because the bit to reserve slot 2 in slot_reserved_mask is not set. Without this change, guest creation fails in the cases when the bit to reserve slot 2 in slot_reserved_mask is not set. Thanks, Stefano! =20 Also, in addition to mentioning the workaround of using the traditional qemu device model available from xenbits.xen.org in the commit message, also mention in the commit message the workaround of using the "pc" machine type instead of the "xenfv" machine type, which results in reduced startup performance. =20 Rebase. =20 Add Igor Mammedov to Cc. v11: I noticed a style mistake that has been present in the past few versions that no one noticed. This version fixes it. No functional change in v11. I also did more tests on different guests such as guests that don't have igd-passthru=3Don set. No regressions were observed. =20 The style mistake (missing braces) is fixed as follows: xen_pt.c at xen_igd_reserve_slot is changed from if (!xen_igd_gfx_pt_enabled()) return; to if (!xen_igd_gfx_pt_enabled()) { return; } hw/i386/pc_piix.c | 1 + hw/xen/xen_pt.c | 64 ++++++++++++++++++++++++++++++++++++-------- hw/xen/xen_pt.h | 20 ++++++++++++++ hw/xen/xen_pt_stub.c | 4 +++ 4 files changed, 78 insertions(+), 11 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index df64dd8dcc..a9d535c815 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -421,6 +421,7 @@ static void pc_xen_hvm_init(MachineState *machine) } =20 pc_xen_hvm_init_pci(machine); + xen_igd_reserve_slot(pcms->bus); pci_create_simple(pcms->bus, -1, "xen-platform"); } #endif diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index 8db0532632..85c93cffcf 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -57,6 +57,7 @@ #include =20 #include "hw/pci/pci.h" +#include "hw/pci/pci_bus.h" #include "hw/qdev-properties.h" #include "hw/qdev-properties-system.h" #include "hw/xen/xen.h" @@ -780,15 +781,6 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) s->hostaddr.bus, s->hostaddr.slot, s->hostaddr.function, s->dev.devfn); =20 - xen_host_pci_device_get(&s->real_device, - s->hostaddr.domain, s->hostaddr.bus, - s->hostaddr.slot, s->hostaddr.function, - errp); - if (*errp) { - error_append_hint(errp, "Failed to \"open\" the real pci device"); - return; - } - s->is_virtfn =3D s->real_device.is_virtfn; if (s->is_virtfn) { XEN_PT_LOG(d, "%04x:%02x:%02x.%d is a SR-IOV Virtual Function\n", @@ -803,8 +795,10 @@ static void xen_pt_realize(PCIDevice *d, Error **errp) s->io_listener =3D xen_pt_io_listener; =20 /* Setup VGA bios for passthrough GFX */ - if ((s->real_device.domain =3D=3D 0) && (s->real_device.bus =3D=3D 0) = && - (s->real_device.dev =3D=3D 2) && (s->real_device.func =3D=3D 0)) { + if ((s->real_device.domain =3D=3D XEN_PCI_IGD_DOMAIN) && + (s->real_device.bus =3D=3D XEN_PCI_IGD_BUS) && + (s->real_device.dev =3D=3D XEN_PCI_IGD_DEV) && + (s->real_device.func =3D=3D XEN_PCI_IGD_FN)) { if (!is_igd_vga_passthrough(&s->real_device)) { error_setg(errp, "Need to enable igd-passthru if you're trying" " to passthrough IGD GFX"); @@ -950,11 +944,58 @@ static void xen_pci_passthrough_instance_init(Object = *obj) PCI_DEVICE(obj)->cap_present |=3D QEMU_PCI_CAP_EXPRESS; } =20 +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ + if (!xen_igd_gfx_pt_enabled()) { + return; + } + + XEN_PT_LOG(0, "Reserving PCI slot 2 for IGD\n"); + pci_bus->slot_reserved_mask |=3D XEN_PCI_IGD_SLOT_MASK; +} + +static void xen_igd_clear_slot(DeviceState *qdev, Error **errp) +{ + ERRP_GUARD(); + PCIDevice *pci_dev =3D (PCIDevice *)qdev; + XenPCIPassthroughState *s =3D XEN_PT_DEVICE(pci_dev); + XenPTDeviceClass *xpdc =3D XEN_PT_DEVICE_GET_CLASS(s); + PCIBus *pci_bus =3D pci_get_bus(pci_dev); + + xen_host_pci_device_get(&s->real_device, + s->hostaddr.domain, s->hostaddr.bus, + s->hostaddr.slot, s->hostaddr.function, + errp); + if (*errp) { + error_append_hint(errp, "Failed to \"open\" the real pci device"); + return; + } + + if (!(pci_bus->slot_reserved_mask & XEN_PCI_IGD_SLOT_MASK)) { + xpdc->pci_qdev_realize(qdev, errp); + return; + } + + if (is_igd_vga_passthrough(&s->real_device) && + s->real_device.domain =3D=3D XEN_PCI_IGD_DOMAIN && + s->real_device.bus =3D=3D XEN_PCI_IGD_BUS && + s->real_device.dev =3D=3D XEN_PCI_IGD_DEV && + s->real_device.func =3D=3D XEN_PCI_IGD_FN && + s->real_device.vendor_id =3D=3D PCI_VENDOR_ID_INTEL) { + pci_bus->slot_reserved_mask &=3D ~XEN_PCI_IGD_SLOT_MASK; + XEN_PT_LOG(pci_dev, "Intel IGD found, using slot 2\n"); + } + xpdc->pci_qdev_realize(qdev, errp); +} + static void xen_pci_passthrough_class_init(ObjectClass *klass, void *data) { DeviceClass *dc =3D DEVICE_CLASS(klass); PCIDeviceClass *k =3D PCI_DEVICE_CLASS(klass); =20 + XenPTDeviceClass *xpdc =3D XEN_PT_DEVICE_CLASS(klass); + xpdc->pci_qdev_realize =3D dc->realize; + dc->realize =3D xen_igd_clear_slot; k->realize =3D xen_pt_realize; k->exit =3D xen_pt_unregister_device; k->config_read =3D xen_pt_pci_read_config; @@ -977,6 +1018,7 @@ static const TypeInfo xen_pci_passthrough_info =3D { .instance_size =3D sizeof(XenPCIPassthroughState), .instance_finalize =3D xen_pci_passthrough_finalize, .class_init =3D xen_pci_passthrough_class_init, + .class_size =3D sizeof(XenPTDeviceClass), .instance_init =3D xen_pci_passthrough_instance_init, .interfaces =3D (InterfaceInfo[]) { { INTERFACE_CONVENTIONAL_PCI_DEVICE }, diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h index cf10fc7bbf..e184699740 100644 --- a/hw/xen/xen_pt.h +++ b/hw/xen/xen_pt.h @@ -40,7 +40,20 @@ typedef struct XenPTReg XenPTReg; #define TYPE_XEN_PT_DEVICE "xen-pci-passthrough" OBJECT_DECLARE_SIMPLE_TYPE(XenPCIPassthroughState, XEN_PT_DEVICE) =20 +#define XEN_PT_DEVICE_CLASS(klass) \ + OBJECT_CLASS_CHECK(XenPTDeviceClass, klass, TYPE_XEN_PT_DEVICE) +#define XEN_PT_DEVICE_GET_CLASS(obj) \ + OBJECT_GET_CLASS(XenPTDeviceClass, obj, TYPE_XEN_PT_DEVICE) + +typedef void (*XenPTQdevRealize)(DeviceState *qdev, Error **errp); + +typedef struct XenPTDeviceClass { + PCIDeviceClass parent_class; + XenPTQdevRealize pci_qdev_realize; +} XenPTDeviceClass; + uint32_t igd_read_opregion(XenPCIPassthroughState *s); +void xen_igd_reserve_slot(PCIBus *pci_bus); void igd_write_opregion(XenPCIPassthroughState *s, uint32_t val); void xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s, XenHostPCIDevice *dev); @@ -75,6 +88,13 @@ typedef int (*xen_pt_conf_byte_read) =20 #define XEN_PCI_INTEL_OPREGION 0xfc =20 +#define XEN_PCI_IGD_DOMAIN 0 +#define XEN_PCI_IGD_BUS 0 +#define XEN_PCI_IGD_DEV 2 +#define XEN_PCI_IGD_FN 0 +#define XEN_PCI_IGD_SLOT_MASK \ + (1UL << PCI_SLOT(PCI_DEVFN(XEN_PCI_IGD_DEV, XEN_PCI_IGD_FN))) + typedef enum { XEN_PT_GRP_TYPE_HARDWIRED =3D 0, /* 0 Hardwired reg group */ XEN_PT_GRP_TYPE_EMU, /* emul reg group */ diff --git a/hw/xen/xen_pt_stub.c b/hw/xen/xen_pt_stub.c index 2d8cac8d54..5c108446a8 100644 --- a/hw/xen/xen_pt_stub.c +++ b/hw/xen/xen_pt_stub.c @@ -20,3 +20,7 @@ void xen_igd_gfx_pt_set(bool value, Error **errp) error_setg(errp, "Xen PCI passthrough support not built in"); } } + +void xen_igd_reserve_slot(PCIBus *pci_bus) +{ +} --=20 2.39.0