[PATCH v3 0/3] Misc AC97 clean ups

BALATON Zoltan posted 3 patches 1 year, 12 months ago
hw/audio/ac97.c | 758 +++++++++++++++++++++++-------------------------
1 file changed, 363 insertions(+), 395 deletions(-)
[PATCH v3 0/3] Misc AC97 clean ups
Posted by BALATON Zoltan 1 year, 12 months ago
During trying to implement via-ac97 I did some small clean ups to ac97
which is in this series. The via-ac97 is not working yet so that's not
included but these unrelated clean ups could be merged now.

v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
v2: Added R-b and changes from Peter Maydell

Regards.

BALATON Zoltan (3):
  hw/audio/ac97: Coding style fixes to avoid checkpatch errors
  hw/audio/ac97: Remove unimplemented reset functions
  hw/audio/ac97: Remove unneeded local variables

 hw/audio/ac97.c | 758 +++++++++++++++++++++++-------------------------
 1 file changed, 363 insertions(+), 395 deletions(-)

-- 
2.30.4


Re: [PATCH v3 0/3] Misc AC97 clean ups
Posted by BALATON Zoltan 1 year, 11 months ago
On Sat, 23 Apr 2022, BALATON Zoltan wrote:
> During trying to implement via-ac97 I did some small clean ups to ac97
> which is in this series. The via-ac97 is not working yet so that's not
> included but these unrelated clean ups could be merged now.
>
> v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
> v2: Added R-b and changes from Peter Maydell

Ping?

https://patchew.org/QEMU/cover.1650706617.git.balaton@eik.bme.hu/

> Regards.
>
> BALATON Zoltan (3):
>  hw/audio/ac97: Coding style fixes to avoid checkpatch errors
>  hw/audio/ac97: Remove unimplemented reset functions
>  hw/audio/ac97: Remove unneeded local variables
>
> hw/audio/ac97.c | 758 +++++++++++++++++++++++-------------------------
> 1 file changed, 363 insertions(+), 395 deletions(-)
>
>
Re: [PATCH v3 0/3] Misc AC97 clean ups
Posted by BALATON Zoltan 1 year, 11 months ago
On Mon, 2 May 2022, BALATON Zoltan wrote:
> On Sat, 23 Apr 2022, BALATON Zoltan wrote:
>> During trying to implement via-ac97 I did some small clean ups to ac97
>> which is in this series. The via-ac97 is not working yet so that's not
>> included but these unrelated clean ups could be merged now.
>> 
>> v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
>> v2: Added R-b and changes from Peter Maydell
>
> Ping?
>
> https://patchew.org/QEMU/cover.1650706617.git.balaton@eik.bme.hu/

Ping2

Gerd, are you getting these messages?

>> Regards.
>> 
>> BALATON Zoltan (3):
>>  hw/audio/ac97: Coding style fixes to avoid checkpatch errors
>>  hw/audio/ac97: Remove unimplemented reset functions
>>  hw/audio/ac97: Remove unneeded local variables
>> 
>> hw/audio/ac97.c | 758 +++++++++++++++++++++++-------------------------
>> 1 file changed, 363 insertions(+), 395 deletions(-)
>> 
>
Re: [PATCH v3 0/3] Misc AC97 clean ups
Posted by BALATON Zoltan 1 year, 11 months ago
On Mon, 9 May 2022, BALATON Zoltan wrote:
> On Mon, 2 May 2022, BALATON Zoltan wrote:
>> On Sat, 23 Apr 2022, BALATON Zoltan wrote:
>>> During trying to implement via-ac97 I did some small clean ups to ac97
>>> which is in this series. The via-ac97 is not working yet so that's not
>>> included but these unrelated clean ups could be merged now.
>>> 
>>> v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
>>> v2: Added R-b and changes from Peter Maydell
>> 
>> Ping?
>> 
>> https://patchew.org/QEMU/cover.1650706617.git.balaton@eik.bme.hu/
>
> Ping2
>
> Gerd, are you getting these messages?

I got no reply to this so far so I think Gerd is not seeing my messages. 
Could someone who can reach him bring it to his attention please?

>>> Regards.
>>> 
>>> BALATON Zoltan (3):
>>>  hw/audio/ac97: Coding style fixes to avoid checkpatch errors
>>>  hw/audio/ac97: Remove unimplemented reset functions
>>>  hw/audio/ac97: Remove unneeded local variables
>>> 
>>> hw/audio/ac97.c | 758 +++++++++++++++++++++++-------------------------
>>> 1 file changed, 363 insertions(+), 395 deletions(-)
>>> 
>
Re: [PATCH v3 0/3] Misc AC97 clean ups
Posted by Paolo Bonzini 1 year, 11 months ago
On 5/17/22 21:47, BALATON Zoltan wrote:
> On Mon, 9 May 2022, BALATON Zoltan wrote:
>> On Mon, 2 May 2022, BALATON Zoltan wrote:
>>> On Sat, 23 Apr 2022, BALATON Zoltan wrote:
>>>> During trying to implement via-ac97 I did some small clean ups to ac97
>>>> which is in this series. The via-ac97 is not working yet so that's not
>>>> included but these unrelated clean ups could be merged now.
>>>>
>>>> v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
>>>> v2: Added R-b and changes from Peter Maydell
>>>
>>> Ping?
>>>
>>> https://patchew.org/QEMU/cover.1650706617.git.balaton@eik.bme.hu/
>>
>> Ping2
>>
>> Gerd, are you getting these messages?
> 
> I got no reply to this so far so I think Gerd is not seeing my messages. 
> Could someone who can reach him bring it to his attention please?

I'll queue these in his stead.

Paolo


Re: [PATCH v3 0/3] Misc AC97 clean ups
Posted by Gerd Hoffmann 1 year, 10 months ago
On Wed, May 18, 2022 at 12:37:18PM +0200, Paolo Bonzini wrote:
> On 5/17/22 21:47, BALATON Zoltan wrote:
> > On Mon, 9 May 2022, BALATON Zoltan wrote:
> > > On Mon, 2 May 2022, BALATON Zoltan wrote:
> > > > On Sat, 23 Apr 2022, BALATON Zoltan wrote:
> > > > > During trying to implement via-ac97 I did some small clean ups to ac97
> > > > > which is in this series. The via-ac97 is not working yet so that's not
> > > > > included but these unrelated clean ups could be merged now.
> > > > > 
> > > > > v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
> > > > > v2: Added R-b and changes from Peter Maydell
> > > > 
> > > > Ping?
> > > > 
> > > > https://patchew.org/QEMU/cover.1650706617.git.balaton@eik.bme.hu/
> > > 
> > > Ping2
> > > 
> > > Gerd, are you getting these messages?
> > 
> > I got no reply to this so far so I think Gerd is not seeing my messages.
> > Could someone who can reach him bring it to his attention please?
> 
> I'll queue these in his stead.

[ /me cleaning up my mailbox, looking for pending patches along the way ]

Thanks.  It seems to not have landed in master yet even though.  Still
sitting in your queue?  Or should I take it?

take care,
  Gerd
Re: [PATCH v3 0/3] Misc AC97 clean ups
Posted by BALATON Zoltan 1 year, 10 months ago
On Thu, 9 Jun 2022, Gerd Hoffmann wrote:
> On Wed, May 18, 2022 at 12:37:18PM +0200, Paolo Bonzini wrote:
>> On 5/17/22 21:47, BALATON Zoltan wrote:
>>> On Mon, 9 May 2022, BALATON Zoltan wrote:
>>>> On Mon, 2 May 2022, BALATON Zoltan wrote:
>>>>> On Sat, 23 Apr 2022, BALATON Zoltan wrote:
>>>>>> During trying to implement via-ac97 I did some small clean ups to ac97
>>>>>> which is in this series. The via-ac97 is not working yet so that's not
>>>>>> included but these unrelated clean ups could be merged now.
>>>>>>
>>>>>> v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
>>>>>> v2: Added R-b and changes from Peter Maydell
>>>>>
>>>>> Ping?
>>>>>
>>>>> https://patchew.org/QEMU/cover.1650706617.git.balaton@eik.bme.hu/
>>>>
>>>> Ping2
>>>>
>>>> Gerd, are you getting these messages?
>>>
>>> I got no reply to this so far so I think Gerd is not seeing my messages.
>>> Could someone who can reach him bring it to his attention please?
>>
>> I'll queue these in his stead.
>
> [ /me cleaning up my mailbox, looking for pending patches along the way ]
>
> Thanks.  It seems to not have landed in master yet even though.  Still
> sitting in your queue?  Or should I take it?

I think they are already in master as commits ab9f0f7d44d...dba2b2941ca so 
all is fine.

Regards,
BALATON Zoltan
Re: [PATCH v3 0/3] Misc AC97 clean ups
Posted by Gerd Hoffmann 1 year, 10 months ago
On Thu, Jun 09, 2022 at 04:12:25PM +0200, BALATON Zoltan wrote:
> On Thu, 9 Jun 2022, Gerd Hoffmann wrote:
> > On Wed, May 18, 2022 at 12:37:18PM +0200, Paolo Bonzini wrote:
> > > On 5/17/22 21:47, BALATON Zoltan wrote:
> > > > On Mon, 9 May 2022, BALATON Zoltan wrote:
> > > > > On Mon, 2 May 2022, BALATON Zoltan wrote:
> > > > > > On Sat, 23 Apr 2022, BALATON Zoltan wrote:
> > > > > > > During trying to implement via-ac97 I did some small clean ups to ac97
> > > > > > > which is in this series. The via-ac97 is not working yet so that's not
> > > > > > > included but these unrelated clean ups could be merged now.
> > > > > > > 
> > > > > > > v3: Fixed misalignments and drop spaces before commas (Víctor Colombo)
> > > > > > > v2: Added R-b and changes from Peter Maydell
> > > > > > 
> > > > > > Ping?
> > > > > > 
> > > > > > https://patchew.org/QEMU/cover.1650706617.git.balaton@eik.bme.hu/
> > > > > 
> > > > > Ping2
> > > > > 
> > > > > Gerd, are you getting these messages?
> > > > 
> > > > I got no reply to this so far so I think Gerd is not seeing my messages.
> > > > Could someone who can reach him bring it to his attention please?
> > > 
> > > I'll queue these in his stead.
> > 
> > [ /me cleaning up my mailbox, looking for pending patches along the way ]
> > 
> > Thanks.  It seems to not have landed in master yet even though.  Still
> > sitting in your queue?  Or should I take it?
> 
> I think they are already in master as commits ab9f0f7d44d...dba2b2941ca so
> all is fine.

Ok, pulling brings them, seems they got merged in the last 1-2 days.

take care,
  Gerd