From nobody Sat May 10 05:24:50 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1606216115; cv=none; d=zohomail.com; s=zohoarc; b=gUFNw2EfWD8e/YqywpncEvMYKFa9J7hcXNQNceYhvW9mM16RvX8lGjYt27/W7dcY0CNB4bqHoxpo1WNOI9JyDmdqeUnEueqAe9sjYIF0juVivKXHxSyNEyzAqKd8/PtzR/T4QmzX03/LmrCVU896bVgqznku5TTXRciNmBKVT1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606216115; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ARHkFBAubNqXWTv0lWRbYpDm+Jatc16hLPP913eKJC8=; b=aVw5l2+2vZrviNMZMPO7VXhRthpxZrHGpQ+pQmg2RyKw6F3NeEYGKmYBQsv84LJP3pxf8hMH51lCZmy0Dnr1xTQBhEz/D4GxC/LDn1ERrC7fDwfkbHrpFl66WZ2pbc0vmb6w3bS4hpc0Ug0hqB9Z00XNxxMb9gdNB5pxXqKaxao= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1606216115974377.7969591991439; Tue, 24 Nov 2020 03:08:35 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732824AbgKXLIU (ORCPT ); Tue, 24 Nov 2020 06:08:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:33618 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731900AbgKXLGc (ORCPT ); Tue, 24 Nov 2020 06:06:32 -0500 Received: from mail.kernel.org (ip5f5ad5c3.dynamic.kabel-deutschland.de [95.90.213.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB64B2073C; Tue, 24 Nov 2020 11:06:30 +0000 (UTC) Received: from mchehab by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1khW9U-000FZo-SZ; Tue, 24 Nov 2020 12:06:28 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606215991; bh=E29yRqHDAxKKhkniYtM5PwuGkBSa5WeUgbjUjAiAehk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jRYKSORKq97+/Wl3PNZWu7hppyMY7IwnGatqemHl5SnHigvdCgoyFxpiQ1HcNgO6b L8M56Boy0y78Wwe/u4zKBBT+nSc4kQ/9gumCuv8YujyT2g3N8aeeZPaGQb7u9v/Mx1 yFsqnsfR9qP+nyC+nvLbjOQhu9giLhca1PRG1aZY= From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , "Daniel W. S. Almeida" , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH 11/31] media: vidtv: pre-initialize mux arrays Date: Tue, 24 Nov 2020 12:06:07 +0100 Message-Id: <0969e607fe7f43aed2feb38d88e143f81164f426.1606215584.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Instead of first zeroing all fields at the mux structs and then filling, do some initialization for the const data when they're created. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/test-drivers/vidtv/vidtv_mux.c | 46 +++++++++++--------- 1 file changed, 26 insertions(+), 20 deletions(-) diff --git a/drivers/media/test-drivers/vidtv/vidtv_mux.c b/drivers/media/t= est-drivers/vidtv/vidtv_mux.c index 6df9cfd7f33b..728ae7c78827 100644 --- a/drivers/media/test-drivers/vidtv/vidtv_mux.c +++ b/drivers/media/test-drivers/vidtv/vidtv_mux.c @@ -129,11 +129,32 @@ static void vidtv_mux_update_clk(struct vidtv_mux *m) =20 static u32 vidtv_mux_push_si(struct vidtv_mux *m) { - struct vidtv_psi_pat_write_args pat_args =3D {}; - struct vidtv_psi_pmt_write_args pmt_args =3D {}; - struct vidtv_psi_sdt_write_args sdt_args =3D {}; - struct vidtv_psi_nit_write_args nit_args =3D {}; - struct vidtv_psi_eit_write_args eit_args =3D {}; + struct vidtv_psi_pat_write_args pat_args =3D { + .buf =3D m->mux_buf, + .buf_sz =3D m->mux_buf_sz, + .pat =3D m->si.pat, + }; + struct vidtv_psi_pmt_write_args pmt_args =3D { + .buf =3D m->mux_buf, + .buf_sz =3D m->mux_buf_sz, + .pcr_pid =3D m->pcr_pid, + }; + struct vidtv_psi_sdt_write_args sdt_args =3D { + .buf =3D m->mux_buf, + .buf_sz =3D m->mux_buf_sz, + .sdt =3D m->si.sdt, + }; + struct vidtv_psi_nit_write_args nit_args =3D { + .buf =3D m->mux_buf, + .buf_sz =3D m->mux_buf_sz, + .nit =3D m->si.nit, + + }; + struct vidtv_psi_eit_write_args eit_args =3D { + .buf =3D m->mux_buf, + .buf_sz =3D m->mux_buf_sz, + .eit =3D m->si.eit, + }; u32 initial_offset =3D m->mux_buf_offset; struct vidtv_mux_pid_ctx *pat_ctx; struct vidtv_mux_pid_ctx *pmt_ctx; @@ -149,10 +170,7 @@ static u32 vidtv_mux_push_si(struct vidtv_mux *m) nit_ctx =3D vidtv_mux_get_pid_ctx(m, VIDTV_NIT_PID); eit_ctx =3D vidtv_mux_get_pid_ctx(m, VIDTV_EIT_PID); =20 - pat_args.buf =3D m->mux_buf; pat_args.offset =3D m->mux_buf_offset; - pat_args.pat =3D m->si.pat; - pat_args.buf_sz =3D m->mux_buf_sz; pat_args.continuity_counter =3D &pat_ctx->cc; =20 m->mux_buf_offset +=3D vidtv_psi_pat_write_into(pat_args); @@ -169,38 +187,26 @@ static u32 vidtv_mux_push_si(struct vidtv_mux *m) =20 pmt_ctx =3D vidtv_mux_get_pid_ctx(m, pmt_pid); =20 - pmt_args.buf =3D m->mux_buf; pmt_args.offset =3D m->mux_buf_offset; pmt_args.pmt =3D m->si.pmt_secs[i]; pmt_args.pid =3D pmt_pid; - pmt_args.buf_sz =3D m->mux_buf_sz; pmt_args.continuity_counter =3D &pmt_ctx->cc; - pmt_args.pcr_pid =3D m->pcr_pid; =20 /* write each section into buffer */ m->mux_buf_offset +=3D vidtv_psi_pmt_write_into(pmt_args); } =20 - sdt_args.buf =3D m->mux_buf; sdt_args.offset =3D m->mux_buf_offset; - sdt_args.sdt =3D m->si.sdt; - sdt_args.buf_sz =3D m->mux_buf_sz; sdt_args.continuity_counter =3D &sdt_ctx->cc; =20 m->mux_buf_offset +=3D vidtv_psi_sdt_write_into(sdt_args); =20 - nit_args.buf =3D m->mux_buf; nit_args.offset =3D m->mux_buf_offset; - nit_args.nit =3D m->si.nit; - nit_args.buf_sz =3D m->mux_buf_sz; nit_args.continuity_counter =3D &nit_ctx->cc; =20 m->mux_buf_offset +=3D vidtv_psi_nit_write_into(nit_args); =20 - eit_args.buf =3D m->mux_buf; eit_args.offset =3D m->mux_buf_offset; - eit_args.eit =3D m->si.eit; - eit_args.buf_sz =3D m->mux_buf_sz; eit_args.continuity_counter =3D &eit_ctx->cc; =20 m->mux_buf_offset +=3D vidtv_psi_eit_write_into(eit_args); --=20 2.28.0