[SeaBIOS] [PATCH v2 2/3] pci: clean up the debug message for pci capability found

Jing Liu posted 3 patches 6 years, 8 months ago
There is a newer version of this series
[SeaBIOS] [PATCH v2 2/3] pci: clean up the debug message for pci capability found
Posted by Jing Liu 6 years, 8 months ago
Improve the debug message when QEMU resource reserve cap
is not found and when the vendor-id or device-id does't match
REDHAT special ones.

Signed-off-by: Jing Liu <jing2.liu@linux.intel.com>
---
 src/fw/pciinit.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
index d2cea2b..62a32f1 100644
--- a/src/fw/pciinit.c
+++ b/src/fw/pciinit.c
@@ -541,10 +541,12 @@ static u8 pci_find_resource_reserve_capability(u16 bdf)
                         cap_len);
                 return 0;
             }
+        } else {
+            dprintf(1, "PCI: QEMU resource reserve cap not found\n");
         }
         return cap;
     } else {
-        dprintf(1, "PCI: QEMU resource reserve cap not found\n");
+        dprintf(1, "PCI: QEMU resource reserve cap VID or DID doesn't match.\n");
         return 0;
     }
 }
-- 
1.8.3.1


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH v2 2/3] pci: clean up the debug message for pci capability found
Posted by Marcel Apfelbaum 6 years, 8 months ago

On 08/16/2018 05:32 AM, Jing Liu wrote:
> Improve the debug message when QEMU resource reserve cap
> is not found and when the vendor-id or device-id does't match
> REDHAT special ones.
>
> Signed-off-by: Jing Liu <jing2.liu@linux.intel.com>
> ---
>   src/fw/pciinit.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/fw/pciinit.c b/src/fw/pciinit.c
> index d2cea2b..62a32f1 100644
> --- a/src/fw/pciinit.c
> +++ b/src/fw/pciinit.c
> @@ -541,10 +541,12 @@ static u8 pci_find_resource_reserve_capability(u16 bdf)
>                           cap_len);
>                   return 0;
>               }
> +        } else {
> +            dprintf(1, "PCI: QEMU resource reserve cap not found\n");
>           }
>           return cap;
>       } else {
> -        dprintf(1, "PCI: QEMU resource reserve cap not found\n");
> +        dprintf(1, "PCI: QEMU resource reserve cap VID or DID doesn't match.\n");
>           return 0;
>       }
>   }

Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>


Thanks,
Marcel

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios