From nobody Sat May 10 06:45:46 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1612335905; cv=none; d=zohomail.com; s=zohoarc; b=IMQVNHsLKUKzBWNMi44JAREfmcuPR3XAWeGlCnQHUgEdziBIbbJvFFkgkk59YcfDfW5t2FyCfKOKXQZu6eP8uiwHy6L9jx0mT7fduP7mkgfJ/ZavNXaeW4IXFk1u25p8SrSvK6bACnvTIt3B/WnkSr11AVwXy8bI8gihcTTur6w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612335905; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1fbkbe14hUC5ZXLsAZsUDCm+2mie0R39XmLIKUhRu3w=; b=lJjSgxmSOgKzErBSFZsNY5sBVkepYYjkjZobkPpx4SViA7ANfjF1PHP20sIQOT41dlJ0D8xU28H8l0vJ6hrytHQLZGXClGMatqNcz5fImSVPugtYBjd5syb9J243wGag2Y37SS/6kAbEugvfbaFlmFZFNZjN2cXWRqsQtHI2PTo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 161233590546170.13103632245429; Tue, 2 Feb 2021 23:05:05 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232137AbhBCHEd (ORCPT ); Wed, 3 Feb 2021 02:04:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:35486 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232012AbhBCHDY (ORCPT ); Wed, 3 Feb 2021 02:03:24 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 792C864E30; Wed, 3 Feb 2021 07:02:00 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1l7CAo-001CAn-AU; Wed, 03 Feb 2021 08:01:58 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612335720; bh=4knJo6OkRBqQrTR3UVhhAX+TpSaav9x8tCsbL69SdgQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ngLI2w461tDcIne3RSvMw0lQtKF989ppIZFq3V28daW4JQJPpye4OFF3+figBnpb0 0X8US8qw/bACXvBQHvkkXNdKW6EGOf+y1b9MFK9UxdH/KdAo5CiMwniKKpLknxa8jq YNjNiOn/HwLKfz2+PeeV/5ovLKHuJ3bDHwqJ6XGwPeLPZynxwnSSnYuSXRK4sb0Kho ruCohXIFQVGP9SKRX1cxY9J5/zTK7/tZLkjWRriL7FDAc4qzjHfNRS6Jxonu1DrFWP Q4eR+mHh53232YVGdy6l3Ule3UtSFleQ+qKki6omhiQJLkMSGt5hdx7bztbEDdgbGg AQiqovtODnMqA== From: Mauro Carvalho Chehab Cc: Mauro Carvalho Chehab , Binghui Wang , Bjorn Helgaas , Lorenzo Pieralisi , Rob Herring , Xiaowei Song , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: [PATCH v2 11/11] pci: dwc: pcie-kirin: cleanup kirin970_pcie_get_eyeparam() Date: Wed, 3 Feb 2021 08:01:55 +0100 Message-Id: <1584b35df936f50bb3187c233b9110c53652a518.1612335031.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Cleanup the routine, to let it clearer that eye_param is optional and that, if not specified, the driver will assume the default. While here, also drop the useless debug prints. Signed-off-by: Mauro Carvalho Chehab --- drivers/pci/controller/dwc/pcie-kirin.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-kirin.c b/drivers/pci/controll= er/dwc/pcie-kirin.c index c5404f1eca28..88f10aff8b09 100644 --- a/drivers/pci/controller/dwc/pcie-kirin.c +++ b/drivers/pci/controller/dwc/pcie-kirin.c @@ -246,21 +246,18 @@ static long kirin_pcie_get_clk(struct kirin_pcie *kir= in_pcie, void kirin970_pcie_get_eyeparam(struct kirin_pcie *pcie) { struct device *dev =3D pcie->pci->dev; - int i; struct device_node *np; + int ret, i; =20 np =3D dev->of_node; =20 - if (of_property_read_u32_array(np, "eye_param", pcie->eye_param, 5)) { - for (i =3D 0; i < 5; i++) + ret =3D of_property_read_u32_array(np, "eye_param", pcie->eye_param, 5); + if (!ret) + return; + + /* There's no optional eye_param property. Set array to default */ + for (i =3D 0; i < 5; i++) pcie->eye_param[i] =3D EYEPARAM_NOCFG; - } - - dev_dbg(dev, "eye_param_vboost =3D [0x%x]\n", pcie->eye_param[0]); - dev_dbg(dev, "eye_param_iboost =3D [0x%x]\n", pcie->eye_param[1]); - dev_dbg(dev, "eye_param_pre =3D [0x%x]\n", pcie->eye_param[2]); - dev_dbg(dev, "eye_param_post =3D [0x%x]\n", pcie->eye_param[3]); - dev_dbg(dev, "eye_param_main =3D [0x%x]\n", pcie->eye_param[4]); } =20 static void kirin970_pcie_set_eyeparam(struct kirin_pcie *kirin_pcie) --=20 2.29.2