From nobody Mon Dec 15 23:14:01 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=linux.alibaba.com ARC-Seal: i=1; a=rsa-sha256; t=1605864631; cv=none; d=zohomail.com; s=zohoarc; b=n++0tU0b8vGnCgOa1GybWpXVeQe0iHAyvriNp2PPQq5sDMFzpeaEAwJEKD8UluYt78msGLGUCPj1D9azzk2UvshKsjeOlFqmkcRqkzEmRMfCa4F6vJWcarxA9jrdjB8VEKdlWBivYw+iK6M/v3YvtNWlvNKJSlLUIkZbRo79eWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605864631; h=Cc:Date:From:List-Id:Message-ID:Subject:To; bh=P4OzeglIdzcDwmJ05JbaYkub950l7vstilXDFUgtDPA=; b=USMHyZLSAhXFX/tR/bvLYrYcFRUfGAj3yqdSvRDZOtfvfeMYL8U1cHrbiliHSiiwJ35UfEmmGerleyHtGXZCa+8weZono2+zZfi++zn0DhZLK6PgbzyAnmTXiXy5+hM4tSro6c+7XlToFg5K4gmOPPf6CQsgvmYmZLhcGT4ErLE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1605864631743696.2035424496045; Fri, 20 Nov 2020 01:30:31 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727347AbgKTJaM (ORCPT ); Fri, 20 Nov 2020 04:30:12 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:42686 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727024AbgKTJaK (ORCPT ); Fri, 20 Nov 2020 04:30:10 -0500 Received: from aliy80.localdomain(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UFzA.8j_1605864606) by smtp.aliyun-inc.com(127.0.0.1); Fri, 20 Nov 2020 17:30:07 +0800 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=alimailimapcm10staff010182156082;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0UFzA.8j_1605864606; From: Alex Shi Cc: Andrew Morton , Johannes Weiner , Shakeel Butt , Roman Gushchin , Michal Hocko , Yafang Shao , Alexander Duyck , Hui Su , Wei Yang , linux-kernel@vger.kernel.org Subject: [PATCH next-akpm] mm/memcg: add missed warning in mem_cgroup_lruvec Date: Fri, 20 Nov 2020 17:30:03 +0800 Message-Id: <1605864603-49118-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" commit "(mm/memcontrol:rewrite mem_cgroup_page_lruvec())" on mm tree use mem_cgroup_lruvec to rewrite mem_cgroup_page_lruvec, but it missed a DEBUG_VM warning as following, since we always charge a page before return from allocation. Add back this warning is helpful: VM_WARN_ON_ONCE_PAGE(!memcg, page); Signed-off-by: Alex Shi Cc: Andrew Morton =20 Cc: Johannes Weiner =20 Cc: Shakeel Butt =20 Cc: Roman Gushchin =20 Cc: Michal Hocko =20 Cc: Yafang Shao =20 Cc: Alexander Duyck =20 Cc: Hui Su Cc: Wei Yang =20 Cc: linux-kernel@vger.kernel.org=20 --- include/linux/memcontrol.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h index 925b09ace986..7809020ef7bd 100644 --- a/include/linux/memcontrol.h +++ b/include/linux/memcontrol.h @@ -618,6 +618,7 @@ static inline struct lruvec *mem_cgroup_lruvec(struct m= em_cgroup *memcg, goto out; } =20 + VM_WARN_ON_ONCE_PAGE(!memcg, page); if (!memcg) memcg =3D root_mem_cgroup; =20 --=20 2.29.GIT