From nobody Sat May 10 02:16:10 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass(p=none dis=none) header.from=kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1619518677; cv=none; d=zohomail.com; s=zohoarc; b=W8eYNXxRYJR9cbH5xXS6Y/8axVkA8gwytRjnRyCx2FeBRmmSIJhyVAlgI2YNnOnPJfDVzSmZI2VIDLjQXK/35Q3lsHKNdLU28Xqfen01GpP5kb6gcZossYcpa/hNh89nRBgQg+4w5lHNXSuokVBMrJNPAoCmTFh/HUWG8hNyy+w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1619518677; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ov9INiNJQ9EjSNAXOplGis0CoH/4o7eSRe39sYD+EEE=; b=Two5Yg7uH2pv+5Y8pZIu6/MTVGsg15OIoc8+2jkjB0ZbGplAL7MPL2abh0nVZCG4cAf+SVVDTEM9Cw5hFmWKRTgI5XzX9dOA6nxbW0yt5eqwaX7aEhztNHd/ZdzTsjlub3R2Y3WXOh178aILBfhiP8Zze84HIlTYeUdLZBh/BMA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1619518677890441.5498507802099; Tue, 27 Apr 2021 03:17:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235661AbhD0KSj (ORCPT ); Tue, 27 Apr 2021 06:18:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:34658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235591AbhD0KOs (ORCPT ); Tue, 27 Apr 2021 06:14:48 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3311061922; Tue, 27 Apr 2021 10:13:53 +0000 (UTC) Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1lbKj1-000j7X-DE; Tue, 27 Apr 2021 12:13:51 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1619518433; bh=xptLiLCkGNJuz7QvbfWAgofgWCEJyWuHFXhmxlDN2vI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V8SvGjsspDfm0f4oLRWagweTDHcBq+I65mtRH9GDCgOGhJNQh/w4S8YPgVYBN+oHg LpAJyNKJERXzYKRpABbvHip/BdXCo2S2WMIb6TaSDtf+aM+LrkPp676vvGDXjMy3oz MnPID0Mb3Wqg8DlMztHz+eToj9nPREI+M50JzaKiTa1cxLXYC6fNtc3/u5QfleQdbg NTIzlgZXNnQwV3k4TsOd/f8mmLhZGrsvDx3K7FHIrRgaye6BpgCctMuurG5FPGBtBE YOfa5tXRGpdNJslzFodyWCIGD7iy+Hh6Buz3ZOaJruYCbVvZ4smkAJOaAvhiyhStIR qFJhm+b0it46A== From: Mauro Carvalho Chehab Cc: linuxarm@huawei.com, mauro.chehab@huawei.com, Mauro Carvalho Chehab , Mauro Carvalho Chehab , Philipp Zabel , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: [PATCH v2 61/79] media: coda: use pm_runtime_resume_and_get() Date: Tue, 27 Apr 2021 12:13:28 +0200 Message-Id: <2016c20ba94df57736e677fc7acf5cb109ac75a5.1619518193.git.mchehab+huawei@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: Mauro Carvalho Chehab To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Commit dd8088d5a896 ("PM: runtime: Add pm_runtime_resume_and_get to deal wi= th usage counter") added pm_runtime_resume_and_get() in order to automatically handle dev->power.usage_count decrement on errors. Use the new API, in order to cleanup the error check logic. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/platform/coda/coda-common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/plat= form/coda/coda-common.c index bd666c858fa1..13ff05e7d850 100644 --- a/drivers/media/platform/coda/coda-common.c +++ b/drivers/media/platform/coda/coda-common.c @@ -2660,10 +2660,10 @@ static int coda_open(struct file *file) ctx->use_vdoa =3D false; =20 /* Power up and upload firmware if necessary */ - ret =3D pm_runtime_get_sync(dev->dev); + ret =3D pm_runtime_resume_and_get(dev->dev); if (ret < 0) { v4l2_err(&dev->v4l2_dev, "failed to power up: %d\n", ret); - goto err_pm_get; + goto err_fh_del; } =20 ret =3D clk_prepare_enable(dev->clk_per); @@ -2709,6 +2709,7 @@ static int coda_open(struct file *file) clk_disable_unprepare(dev->clk_per); err_pm_get: pm_runtime_put_sync(dev->dev); +err_fh_del: v4l2_fh_del(&ctx->fh); v4l2_fh_exit(&ctx->fh); err_coda_name_init: --=20 2.30.2