[SeaBIOS] [PATCH v2 5/6] add support for etc/sercon-iobase cbfs file

Gerd Hoffmann posted 6 patches 7 years, 7 months ago
There is a newer version of this series
[SeaBIOS] [PATCH v2 5/6] add support for etc/sercon-iobase cbfs file
Posted by Gerd Hoffmann 7 years, 7 months ago
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 src/optionroms.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/optionroms.c b/src/optionroms.c
index 21b72a8ba0..432e8cb02a 100644
--- a/src/optionroms.c
+++ b/src/optionroms.c
@@ -438,6 +438,9 @@ vgarom_setup(void)
     ret = romfile_loadint("etc/sercon-enable", 0);
     if (ret)
         iobase = PORT_SERIAL1;
+    ret = romfile_loadint("etc/sercon-iobase", 0);
+    if (ret)
+        iobase = ret;
 
     if (rom_get_last() == BUILD_ROM_START) {
         // No VGA rom found
-- 
2.9.3


_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios
Re: [SeaBIOS] [PATCH v2 5/6] add support for etc/sercon-iobase cbfs file
Posted by Kevin O'Connor 7 years, 7 months ago
On Thu, Sep 14, 2017 at 09:08:21AM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  src/optionroms.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/optionroms.c b/src/optionroms.c
> index 21b72a8ba0..432e8cb02a 100644
> --- a/src/optionroms.c
> +++ b/src/optionroms.c
> @@ -438,6 +438,9 @@ vgarom_setup(void)
>      ret = romfile_loadint("etc/sercon-enable", 0);
>      if (ret)
>          iobase = PORT_SERIAL1;
> +    ret = romfile_loadint("etc/sercon-iobase", 0);
> +    if (ret)
> +        iobase = ret;

Is "etc/sercon-enable" going to be purely local to seabios, or is
there an intent to produce that from qemu?  If it's purely local, why
not change paravirt.c to produce etc/sercon-iobase=PORT_SERIAL1 when
fwcfg nographics mode is found?

What about the name "etc/sercon-port" instead?

-Kevin

_______________________________________________
SeaBIOS mailing list
SeaBIOS@seabios.org
https://mail.coreboot.org/mailman/listinfo/seabios