From nobody Sat May 10 07:32:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) smtp.mailfrom=seabios-bounces@seabios.org Return-Path: Received: from mail.coreboot.org (mail.coreboot.org [80.81.252.135]) by mx.zohomail.com with SMTPS id 1519686266603260.87107515394325; Mon, 26 Feb 2018 15:04:26 -0800 (PST) Received: from [127.0.0.1] (helo=ra.coreboot.org) by mail.coreboot.org with esmtp (Exim 4.86_2) (envelope-from ) id 1eqRqD-0008Vo-Ck; Tue, 27 Feb 2018 00:05:53 +0100 Received: from mail-eopbgr10110.outbound.protection.outlook.com ([40.107.1.110] helo=EUR02-HE1-obe.outbound.protection.outlook.com) by mail.coreboot.org with esmtps (TLSv1.2:ECDHE-RSA-AES256-SHA384:256) (Exim 4.86_2) (envelope-from ) id 1eqPZ5-00042X-KQ for seabios@seabios.org; Mon, 26 Feb 2018 21:40:13 +0100 Received: from localhost.localdomain (96.82.2.57) by VI1PR04MB1357.eurprd04.prod.outlook.com (2a01:111:e400:5348::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.527.15; Mon, 26 Feb 2018 20:37:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=SILICOMLTD.onmicrosoft.com; s=selector1-silicomusa-com01i; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ReSYHEoU/iK2q9uT/FDQ/6CdwY6QsPLHse9yjBumSVg=; b=5hXjskhd3aRiwqGtdw2VT0oMTCG6wvgF3ijnwQAq4zfsUpCw0Vlf37AM0Uc3GRBvOqv4mgHV+niaXRmTTlTPm1DbsT6fXSh17qSuYA4dB6w3xgC33Vz8G8wenwUJv4In14XbE/0P0YLdcats9U9mvD4+oDwmJ+49yekp9I1c69s= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=stephend@silicom-usa.com; From: Stephen Douthit To: Kevin O'Connor , Stefan Berger , seabios@seabios.org Date: Mon, 26 Feb 2018 15:37:33 -0500 Message-Id: <20180226203734.558-3-stephend@silicom-usa.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180226203734.558-1-stephend@silicom-usa.com> References: <20180226203734.558-1-stephend@silicom-usa.com> MIME-Version: 1.0 X-Originating-IP: [96.82.2.57] X-ClientProxiedBy: DM5PR21CA0049.namprd21.prod.outlook.com (2603:10b6:3:129::11) To VI1PR04MB1357.eurprd04.prod.outlook.com (2a01:111:e400:5348::12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4c462851-84d3-4ef7-7cfa-08d57d58d2ee X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:VI1PR04MB1357; X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1357; 3:eRgtlCxEN6RYbMH/VzJhdPMqCWX3GtckktyZ+5AnNApG7QSnfYQIueS4vtjPKld9qCUVNDv7gD9VydhYPgIdVhSHASZuU5KQl0FIRNqyaKPo2ouHZ1Gtmd6WLvxOe8EVKf7YX+8BzbERz7V4WCR2bucdp/e+x71o47y+mojCfC2bDsdNiMrsLRqhgRsPvqpCOwLtgAMaH8MqbPsTDhCLibAvCeXZ+CrEC+6rnm0TmEeN+WneBvhjkKpCzxP1lKhh; 25:LUMUMYcLBrm6/D+pnZ6IBo+rA95DB66Z6be6GCrOCINdUV86BgEGcZGjTibkm/dcPadmVnk8aP6hixEccYqMVHiFOVS0AQ1P74+mJUwVYfNc3fjaUjIWup9636mBnufAasU0k2DO3wRbu7Da6IoG74eTfiiGO0eaX2QjP+QI3RjfwttVjcku5VQWO7eWHa/ughAB7tqcIAvfC8y2lG4pXkJjfkZfGAXRfBbDjTFGTYgrP5mV7imSxxuOF6hSVMKcjOtux7R/0KId1XXLgTZ4WCfydEsX+Zza1jV4l1zbaZsYLNlOSIU8fePETkC4T1WfX9lgkB7FdfONjT3JuqlhfQ==; 31:EqqtvYOkpoOa7JUQ/X24mFP6cWWbXA77LMtbi5kxIjlpsRLIbp11GtOTUGrjzfWpzLMV1LbNA4HosyrS0pEbbHevx/Rue6PwM3HL29NVwEHLOLoC1lMk6LxHR1qm07Ws138i2jIbsCEZqJR4IUwvwrtCB+Rq3/mtx+mSUfqV9lTa4Ygx/PSc1DZUt+3/ftLeV6JxpPc9kulvixgWIoNEDqXX2C0/NdQY5rC3pGlU4W8= X-MS-TrafficTypeDiagnostic: VI1PR04MB1357: X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1357; 20:r2xkiOFEa+2WlR6Cq7JDNl9jQfFBSaSJo6OQaQs6L1DQIiJcLgdRJhPyE0jdGOJyE/wiJJK5WXI+3HlLuoJxKBjMa1l7hWyn3TDq0HY6oPRSTjZmzXtjpy8ZRMoinC13qgjjarkoMhyFL9CpLyvXGYPQprWlCa9AX8KzQbk4sgKnChTpMVRY1fh5gIgTmTldshFIThxpXBDmuFWSxpNmMsPn0gDbOXIWD5Srq1UfVBidUYccBYZQjkEXWoXwdOS4WSOhSiXwLJq5OtSbTtXlnu48Oqnst0p8VldtQKibV7CNZLIiIR0X4ctK9Q32oHVN7cKWbLLM1BfbvIMo6NvaHcfmEnbLONHaywOU2EQDrsPIo4ULFHRAI4+omkg1pW95EtnboBpKOHyHkP52ziWLiOZsQtGJMVffS/hKOg2ANmwzPrU4hxk5CVuZljemZ8aBu3RypsIH7LR1WEVLJIjDiXf3U5ccnJ7PZqLkDA6QXDQs7f1bG8uoFXG8FCy4PacX; 4:Jl5SHEV7H0vSqt9HnjRatmavg5GEDWHQfx10tSujmgUohpFoGrCB5RcC8ny2WBnW0dhNg3DqWPN2DTNXYPAC1XCc9lRQHpdoGeAI64H6VoPc9YovrUqxqM7379fjuqEvf27muDys9HXiC+V9EJsOD7bZV35Uq0dpnATyHQ36n5gyW3JaFfJY+pfaVdwx5gSIiRWN9BHW+IVmor94U5T586QKzq0JfFnpkjKN27BwBvVpD2DdtHAJMfwAKq/XDjD3p34Z7S/6ujgUvZQ847kewg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(8121501046)(5005006)(93006095)(93001095)(3231220)(944501161)(52105095)(3002001)(10201501046)(6041288)(20161123560045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(6072148)(201708071742011); SRVR:VI1PR04MB1357; BCL:0; PCL:0; RULEID:; SRVR:VI1PR04MB1357; X-Forefront-PRVS: 05954A7C45 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(6069001)(366004)(396003)(39850400004)(39380400002)(376002)(346002)(199004)(189003)(6116002)(3846002)(25786009)(386003)(106356001)(6666003)(6506007)(76176011)(50226002)(105586002)(1076002)(8936002)(48376002)(50466002)(53936002)(8676002)(6512007)(2906002)(59450400001)(97736004)(7736002)(5660300001)(36756003)(478600001)(52116002)(47776003)(66066001)(305945005)(110136005)(81156014)(81166006)(86362001)(16586007)(316002)(16526019)(6486002)(26005)(186003)(51416003)(1857600001)(2950100002)(68736007); DIR:OUT; SFP:1102; SCL:1; SRVR:VI1PR04MB1357; H:localhost.localdomain; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: none (zoho.com: 80.81.252.135 is neither permitted nor denied by domain of seabios.org) client-ip=80.81.252.135; envelope-from=seabios-bounces@seabios.org; helo=mail.coreboot.org; Received-SPF: None (protection.outlook.com: silicom-usa.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR04MB1357; 23:gHcP8Y+bwWn0QEphaZKiAbP9vJV4IssKZPGriq5J0?= =?us-ascii?Q?1YLeOpfM0888/pkxZMaEOyNrVZamT0X+awN++rP9pdFasmOUb9dvjTifJFTx?= =?us-ascii?Q?AfV0LcSCWhKJfBYIXCMv9bUFq6IBFrIrs0KIjfIox3PGlAaxlWPeWhu6pbwk?= =?us-ascii?Q?Rcpj1jGF3z4vkHRhBA7qdfrVXuJhZs0Jyxz9h9MkNADrAzA0PlA4SSCePL3M?= =?us-ascii?Q?lxBNgo3krrfpc5/axeMIj9Hx4gAgkK9PFbFxLdQOb0EwAWCGwhqs/utBqoKV?= =?us-ascii?Q?CaeGu3nYCTkY0UZxDVfjSX8nqvigvlsulfCb85Cbxwm6g4hBNKWBTAtd5Akl?= =?us-ascii?Q?V3G08R7OmB9yuodt//HnL2pSybDiN9VNEQUWQRTk6BY+bxUvGcLN0Ce5AThS?= =?us-ascii?Q?BpzHM5ULaJyvrmtV7CdXgKfwndQb7elK7ogL/Krg9q53Tdv1iY8VLDB4pcl1?= =?us-ascii?Q?96hfAAKPLg84/oJwC+MfO19I21+zQc3pBVF4q3pgiH49LsDQSos57FDOivkj?= =?us-ascii?Q?c+xdtRhZ4OYpBDmjBURpcIe0jo8SYg7gYY5rIMc1sPhd0JMSMhVbCBd+JVya?= =?us-ascii?Q?rXSNLMfLdiI/ENFLkb8TJwHwwzsl5j5yKm53c4AGv/cj13NM1ozCCXgSJrTL?= =?us-ascii?Q?UoDUShPGc/v2gh/pUiopCx6WcWYPb9Ym2NGIS/78f8DpdKSeTLA/8HIuKlhg?= =?us-ascii?Q?6CS17oVJI+2vmB6SupakXOgDlDC+Fx7xC7osoOLO6YQhhQJwSRmJB8NTfvRs?= =?us-ascii?Q?FpPJ9nZdWYflqyQ1EVvxbodyazJlXnEkfy0eUMaJy8a6Vrlwpcy/ybvN0Da6?= =?us-ascii?Q?0b5/N4VwOJfT/cnfY8wwc7TMgStkNBciVHPOCgMe16wViL2EiTQWN7f3NSPb?= =?us-ascii?Q?gLXAOlCj58ai+1mmp7j1Dv70D5E1bw3AKsJkT85phkxM7GNx6vkfmx/GvGWD?= =?us-ascii?Q?8EEaHvLdKKrqpjtyvslJh4mpQdqkA6NidJz8HssAq/Sf3AA0FpOqvnQ9YzKw?= =?us-ascii?Q?1L2xfINmD7UewVGwVsEjwYfvpP3t71oXMD72XBeXDxDDNSVBJUn/eqQhN538?= =?us-ascii?Q?M+3HHlUM1o+N0ehGjveJmxuwvHSZ9zQbat8PPR4GJFzir3/nL4ZRGFrwcL/k?= =?us-ascii?Q?sDYdaQXe8OwLB5lGjCxJPU63i9CP963QWCIBJpJ9VhCc/VeIR4SPQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; VI1PR04MB1357; 6:50Dw4VkXXQKSFAWKkf/j7hOc154d7XkDeYTbxagDSenE4Uy6csKo22Ji1Yu2gWq/HDQp3eTVH1INXtDnZjgZyM9hAvE2CebfhOE1iGZngcpmCjmVsz1QFxe+dE8yShHflWS8s1BQpZK8Ik+S8acVVhebcQoDptrO1io30rcDRJKysp2ObpwBHOPFiDhYpMxtv4nTk9Mxs/mlZXLwe1ufGGXtXNhUjUbYPCrRGkGURyj3WMa9DxENlMj93onMCwHcLnbt4KVjxpJFQc0hMFZGkmZ8xHWErptr7w30PpBB6juQ5O//C7NN2z1pvd5CyWJocwYLYWJKqVZGCu8W7uNbGGKWuztGhqXZgYNlHHS4bXI=; 5:s8KpWoD6RAfZz6oedtfwc8a+eWgdIdyvB1B1VolenvhbAZkB8TuUXcIxvEUMcBNhUKVzznWvcu8M6BjXmbG2LJJc6QwPVK88aU6AM4TLyWHtIXNxhrK3IZncFihCVMXhfPApzi7yjVCuacTDuq2+6swTVF14pdGR95P9muYO7Oc=; 24:y/Nj1kbpqpUPJekqv/RyCm92s721deQkCl4caJHCFMm0fND5v7PZRbSBt4jGyPL/fVk75Vz1Z7z8Y05TD/EJicB8kdLtm4e+M5plGAUI66M=; 7:tTrr+3AYYAaAy46LgfQBBzj44nctrouL8C9u0Q8YUWHiknBPV+DxEItQq64MajcAOJhhfhhZ2UYC5TOtWTGOY8mf5K324d4A5m+e77wcvD2G4vRIkCbVvnzIt4q05ljqos3Q54uyq+7EIXQJleLoJivFX1SVYb5RU2SDs5CyjLq5SznN+XFa6P0swCDWTruMT0IonZlAgYfl5dsqCUZ1hMyUrL7fGKb1B/DTc1jjxzJSyRCPTg4k2/mWWs+o0HfU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: silicom-usa.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Feb 2018 20:37:58.3169 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4c462851-84d3-4ef7-7cfa-08d57d58d2ee X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c9e326d8-ce47-4930-8612-cc99d3c87ad1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB1357 X-Spam-Score: -0.6 (/) X-Mailman-Approved-At: Tue, 27 Feb 2018 00:05:50 +0100 Subject: [SeaBIOS] [PATCH 2/3] tpm: Wait for interface startup when probing X-BeenThere: seabios@seabios.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SeaBIOS mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Errors-To: seabios-bounces@seabios.org Sender: "SeaBIOS" X-Duff: Orig. Duff, Duff Lite, Duff Dry, Duff Dark, Raspberry Duff, Lady Duff, Red Duff, Tartar Control Duff X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZohoMail: RDKM_2 RSF_4 Z_629925259 SPT_0 Content-Type: text/plain; charset="utf-8" This is based on wait_startup() from the Linux tpm_tis driver. Signed-off-by: Stephen Douthit Tested-by: Stephen Douthit Reviewed-by: Stefan Berger --- src/hw/tpm_drivers.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/hw/tpm_drivers.c b/src/hw/tpm_drivers.c index 8d6fc33..789d70a 100644 --- a/src/hw/tpm_drivers.c +++ b/src/hw/tpm_drivers.c @@ -86,6 +86,11 @@ static u32 wait_reg8(u8* reg, u32 time, u8 mask, u8 expe= ct) return rc; } =20 +static u32 tis_wait_access(u8 locty, u32 time, u8 mask, u8 expect) +{ + return wait_reg8(TIS_REG(locty, TIS_REG_ACCESS), time, mask, expect); +} + static u32 tis_wait_sts(u8 locty, u32 time, u8 mask, u8 expect) { return wait_reg8(TIS_REG(locty, TIS_REG_STS), time, mask, expect); @@ -102,7 +107,13 @@ static u32 tis_probe(void) if (!CONFIG_TCGBIOS) return 0; =20 - u32 rc =3D 0; + /* Wait for the interface to report it's ready */ + u32 rc =3D tis_wait_access(0, TIS_DEFAULT_TIMEOUT_A, + TIS_ACCESS_TPM_REG_VALID_STS, + TIS_ACCESS_TPM_REG_VALID_STS); + if (rc) + return 0; + u32 didvid =3D readl(TIS_REG(0, TIS_REG_DID_VID)); =20 if ((didvid !=3D 0) && (didvid !=3D 0xffffffff)) --=20 2.14.3 _______________________________________________ SeaBIOS mailing list SeaBIOS@seabios.org https://mail.coreboot.org/mailman/listinfo/seabios