From nobody Sat May 10 06:47:48 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1604042091; cv=none; d=zohomail.com; s=zohoarc; b=hAoGcBLq+SvTSeG9gk66DLk5QvaP2xX9xst8YuW+bBGBY597dJvaDsef7tXVTe8cESwzl5XQU9LAe8dJ3sU4huP99JRwYG3LR1jX0GcnheszKI6VrsIJsIzdmOt9K8B7FeL2MoirKa2hpkMcCK9DJMxMB1svaVEVEy1XEb0LDTc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1604042091; h=Cc:Date:From:List-Id:Message-ID:Subject:To; bh=Nn37IfTCXj7OmHgyU0P/qf2aXP/R5yi/4Un5UCinwUE=; b=RKDM4qoS0V6r8BDg0Ozwoxz3KEmLLeeBDIOsXw1vZ4KjM4H1a6jFlN0hs7/xIuHjkRZyoqDvj8XhLgKT54/9roREKATYVnNhgl8j//Z1jeERRDWGFA1ijPDeh7lq00kYNHdBCPY5msZPFBT/gp4KPP5YBF7dVS7Ljc+stRv2I2g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1604042091464722.4322418245564; Fri, 30 Oct 2020 00:14:51 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725913AbgJ3HOu (ORCPT ); Fri, 30 Oct 2020 03:14:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725355AbgJ3HOr (ORCPT ); Fri, 30 Oct 2020 03:14:47 -0400 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CD01C0613CF for ; Fri, 30 Oct 2020 00:14:46 -0700 (PDT) Received: by mail-pf1-x441.google.com with SMTP id w65so4496589pfd.3 for ; Fri, 30 Oct 2020 00:14:45 -0700 (PDT) Received: from brooklyn.i.sslab.ics.keio.ac.jp (sslab-relay.ics.keio.ac.jp. [131.113.126.173]) by smtp.googlemail.com with ESMTPSA id y203sm4996152pfb.70.2020.10.30.00.14.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 00:14:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sslab.ics.keio.ac.jp; s=google; h=from:to:cc:subject:date:message-id; bh=Nn37IfTCXj7OmHgyU0P/qf2aXP/R5yi/4Un5UCinwUE=; b=MJ4AKEXn7TirRPKSoWVdZOqbNugwSZWnOJSKdKoZwBvgJ2HvloooFF8TK6++IkvgR/ LG3qbXpz+St1TZ8+d/VnMmvoAStv2CDgczOGUs2r11P8ViMcwHmgfRpj/wLW7hlo+TwC I+EuRT6mAu0aLtMGFtMtMoxEfM8ODh7OnnIb8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Nn37IfTCXj7OmHgyU0P/qf2aXP/R5yi/4Un5UCinwUE=; b=tNzDGaf3ICo5nmq4rsuxgdpgv8pXz+2Fyi86Hx7QlmxqKRvKAYFwgvRt5fhO4evUsu AhZcsOVGj1+wMb4rUCch3Ut1EpETl3NuPPa/6odhw9N0TomYHM1+12waA53Aio+BTF99 dLadFgrwllKAr69KOZJIcPQELisPJyLZfZpUzMm90XlYMCW+V3fP+OYDQVhcOczj3uKq zt4xmZBa4bVDrF0SSPdqsLynwPhCJo4ObDI7ep+XUR0Z0w+rMxzexq47EFccvwnrAIU4 Bqa9ipg2cciRRU0yLxK43G9oHqCdDF6XM+silrgPoLLSjXFzM2qli2YGxMyvpeSLc4ZD aclw== X-Gm-Message-State: AOAM5325qHdJHxUpx9VMQ70dZBJyE/fVMVECdIrFwCotYIJhPDZvkIMj Sx6PQSe+1kADhTKVwMaDePbWWw== X-Google-Smtp-Source: ABdhPJyM76ixBnDtfwwg71qY1GdE0SSR1uXigQAvZciL/lMm6nMzKuHOPOTW2EhMHzsyMoq95V1IpA== X-Received: by 2002:a17:90a:73c9:: with SMTP id n9mr1231337pjk.90.1604042085301; Fri, 30 Oct 2020 00:14:45 -0700 (PDT) From: Keita Suzuki Cc: keitasuzuki.park@sslab.ics.keio.ac.jp, takafumi@sslab.ics.keio.ac.jp, Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Jakub Kicinski , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] i40e: Fix memory leak in i40e_probe Date: Fri, 30 Oct 2020 07:14:30 +0000 Message-Id: <20201030071431.10488-1-keitasuzuki.park@sslab.ics.keio.ac.jp> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Struct i40e_veb is allocated in function i40e_setup_pf_switch, and stored to an array field veb inside struct i40e_pf. However when i40e_setup_misc_vector fails, this memory leaks. Fix this by calling exit and teardown functions. Signed-off-by: Keita Suzuki --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethe= rnet/intel/i40e/i40e_main.c index 4f8a2154b93f..428964c4ade1 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_main.c +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c @@ -15104,6 +15104,8 @@ static int i40e_probe(struct pci_dev *pdev, const s= truct pci_device_id *ent) if (err) { dev_info(&pdev->dev, "setup of misc vector failed: %d\n", err); + i40e_cloud_filter_exit(pf); + i40e_fdir_teardown(pf); goto err_vsis; } } --=20 2.17.1