From nobody Mon Dec 15 01:54:19 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1606792305; cv=none; d=zohomail.com; s=zohoarc; b=aRenLhScqG4tr68+juGrAw1WQXRKQMS9EylVkPYAs9/PHtQIuavXAkcepvuaDH0en5LOsECpKH8HJkTaDExeJNsQnPL+CdRSHHDySq5oVe0zliPNFXoN78+cDF+aJTo7Q+uUU2oZWZbk1A42OH+Q2wYJZfe2r/SZebH09DtiYJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1606792305; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:MIME-Version:Message-ID:Subject:To; bh=gnCgr28WEiDduK90s68FeRurpfqrU8CADp/ISUAFXek=; b=ScZ8FamIZY4YYKkrZ06iwfR4vVCci83RkBU1Fq1Ecoc/50SfQhKvCnbru3FacS6Kap4+Fw5zIZ2ssqHTDCMcMl24mNpH4AxHqPKyOd0UDRKtiTQ1oIeGWSvDaEogCcKF98KuVjhm6DK/nlhwZ2w1ZKMihj5HgjmiuaYA1tKdxcc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1606792305108349.5393192856469; Mon, 30 Nov 2020 19:11:45 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727412AbgLADLJ (ORCPT ); Mon, 30 Nov 2020 22:11:09 -0500 Received: from server-x.ipv4.hkg02.ds.network ([27.111.83.178]:51584 "EHLO mail.gtsys.com.hk" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1725859AbgLADLI (ORCPT ); Mon, 30 Nov 2020 22:11:08 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.gtsys.com.hk (Postfix) with ESMTP id DF2B7200D28A; Tue, 1 Dec 2020 11:10:21 +0800 (HKT) Received: from mail.gtsys.com.hk ([127.0.0.1]) by localhost (mail.gtsys.com.hk [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yRNd_2PMXOKD; Tue, 1 Dec 2020 11:10:21 +0800 (HKT) Received: from s01.gtsys.com.hk (unknown [10.128.4.2]) by mail.gtsys.com.hk (Postfix) with ESMTP id C5B26200D287; Tue, 1 Dec 2020 11:10:21 +0800 (HKT) Received: from armhf2.gtsys.com.hk (unknown [10.128.4.15]) by s01.gtsys.com.hk (Postfix) with ESMTP id B5F1AC019E2; Tue, 1 Dec 2020 11:10:21 +0800 (HKT) Received: by armhf2.gtsys.com.hk (Postfix, from userid 1000) id 888CE200756; Tue, 1 Dec 2020 11:10:21 +0800 (HKT) X-Virus-Scanned: Debian amavisd-new at gtsys.com.hk From: Chris Ruehl Cc: Chris Ruehl , Kishon Vijay Abraham I , Vinod Koul , Heiko Stuebner , Douglas Anderson , Ulf Hansson , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0 Date: Tue, 1 Dec 2020 11:10:14 +0800 Message-Id: <20201201031015.23314-1-chris.ruehl@gtsys.com.hk> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" rockchip_emmc_phy_init() return variable is not set with the error value if clk_get() failed. The debug message print 0 on error and the function always return 0. Fix it using PTR_ERR(). Fixes: 52c0624a10cce phy: rockchip-emmc: Set phyctrl_frqsel based on card c= lock Signed-off-by: Chris Ruehl --- drivers/phy/rockchip/phy-rockchip-emmc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/phy/rockchip/phy-rockchip-emmc.c b/drivers/phy/rockchi= p/phy-rockchip-emmc.c index 48e2d75b1004..75faee5c0d27 100644 --- a/drivers/phy/rockchip/phy-rockchip-emmc.c +++ b/drivers/phy/rockchip/phy-rockchip-emmc.c @@ -253,6 +253,7 @@ static int rockchip_emmc_phy_init(struct phy *phy) */ rk_phy->emmcclk =3D clk_get(&phy->dev, "emmcclk"); if (IS_ERR(rk_phy->emmcclk)) { + ret =3D PTR_ERR(rk_phy->emmcclk); dev_dbg(&phy->dev, "Error getting emmcclk: %d\n", ret); rk_phy->emmcclk =3D NULL; } --=20 2.20.1