From nobody Sun May 11 22:39:56 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1609168359; cv=none; d=zohomail.com; s=zohoarc; b=N+lQeazqYyE/9vsiAm8wmQ0XJd43MkGqmsUZp0Ttd09WJ3v9k2m/oitsz2znvXHNo7O+kZW8kSOdUNQY/3sjD0oAk3ApcTgp9MDlPonO8Fml+WYDUviyEIE2OrAlIg5xPW8TCWYHOJQbzZZw7N1Wqfmp86IXuiftS1Z33OJlE1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1609168359; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:MIME-Version:Message-ID:Subject:To; bh=8rF2MWGAOEsWs06S9iHqzALnLEi1PQMJ8OPtBzR9Nqs=; b=edZGQo52UpzeZnDbwkSevJEPLDIKJ54b5OEB7ZqnGEIDYOU9Q5ngybNTVz4Vq3suK1O6ySYuRApf5LLEyLWF79De5LMEzslgpzvAkkksWvuc5g+i88aOiqIPm3AEA53scXme2V84GT5BLxriBVk8MCLfeE3/ufmAsGLjYcSsp5g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1609168359330686.3822914623219; Mon, 28 Dec 2020 07:12:39 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2441055AbgL1PL5 (ORCPT ); Mon, 28 Dec 2020 10:11:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408243AbgL1PLO (ORCPT ); Mon, 28 Dec 2020 10:11:14 -0500 Received: from forward104j.mail.yandex.net (forward104j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::107]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 603B2C06179C; Mon, 28 Dec 2020 07:10:25 -0800 (PST) Received: from myt4-e3ad475e0976.qloud-c.yandex.net (myt4-e3ad475e0976.qloud-c.yandex.net [IPv6:2a02:6b8:c12:240b:0:640:e3ad:475e]) by forward104j.mail.yandex.net (Yandex) with ESMTP id 29E934A1251; Mon, 28 Dec 2020 18:02:10 +0300 (MSK) Received: from myt5-ca5ec8faf378.qloud-c.yandex.net (myt5-ca5ec8faf378.qloud-c.yandex.net [2a02:6b8:c12:2514:0:640:ca5e:c8fa]) by myt4-e3ad475e0976.qloud-c.yandex.net (mxback/Yandex) with ESMTP id JEUUKoOEkX-2AHaDoXU; Mon, 28 Dec 2020 18:02:10 +0300 Received: by myt5-ca5ec8faf378.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id ZBhtlKloNv-29JGqOcW; Mon, 28 Dec 2020 18:02:09 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) X-Greylist: delayed 448 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 28 Dec 2020 07:10:25 PST DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1609167730; bh=8rF2MWGAOEsWs06S9iHqzALnLEi1PQMJ8OPtBzR9Nqs=; h=Date:Subject:To:From:Message-Id:Cc; b=B6fKFPSvKV6fwY6lhdpbE2UvTRig+gCaW1QNNAJIgwjz/s2lRVw9kXSfO+ijUnSPE pqMK1SxqvVhqYzBEWrrxyPBuXdg/tFgC+FqYxwBBNcRA5sPcwlQnCHlFWSkaa/Hxct geFarzIYTgG2s/AUS90cDwPM8lUMXGvm06FCjFzw= Authentication-Results: myt4-e3ad475e0976.qloud-c.yandex.net; dkim=pass header.i=@maquefel.me From: Nikita Shubin Cc: Nikita Shubin , Linus Walleij , Bartosz Golaszewski , Grygorii Strashko , Thierry Reding , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpiolib: warning on gpiochip->to_irq defined Date: Mon, 28 Dec 2020 18:00:52 +0300 Message-Id: <20201228150052.2633-1-nikita.shubin@maquefel.me> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" gpiochip->to_irq method is redefined in gpiochip_add_irqchip. A lot of gpiod driver's still define ->to_irq method, let's give a gentle warning that they can no longer rely on it, so they can remove it on ocassion. Fixes: e0d8972898139 ("gpio: Implement tighter IRQ chip integration") Signed-off-by: Nikita Shubin --- drivers/gpio/gpiolib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 5ce0c14c637b..44538d1a771a 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1489,6 +1489,9 @@ static int gpiochip_add_irqchip(struct gpio_chip *gc, type =3D IRQ_TYPE_NONE; } =20 + if (gc->to_irq) + chip_err(gc, "to_irq is redefined in %s and you shouldn't rely on it\n",= __func__); + gc->to_irq =3D gpiochip_to_irq; gc->irq.default_type =3D type; gc->irq.lock_key =3D lock_key; --=20 2.29.2