From nobody Sat May 10 06:11:17 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610146296; cv=none; d=zohomail.com; s=zohoarc; b=TMpTKCjJv23s8BDmxjMqGSyiClmqRhvirQCnnj5Xpde8tKqNKwkkMEf3rHyI40KVD4EtgQYtAXszekcrUIVOV2aEtd59psvJabDrd1tF4OTCATGORrbI7yj7vSRw020VcuqsuAqzD5ON6xQ7WfmwxP61KqdVAcDHgYdyIU7HMqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610146296; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=HCP+UiqivE5Sl8wYg29qb2EI1nN4FyBAZjFb96c2xmg=; b=Sq2vRxYju+xPnS7KPFLdBaWgb5pOztoQU0O6IAMsRjDVqotbC7PkuPxgSo1NYBOk5g1Bzo1dmqqDbfUO2SqqBZB2D+7k3O7rLhnrw7MwKhQoa1gD0vp+JV5nnhYqd8sqv5ujwY+R+Q+cFfmyvt/UQ29fj3ETi922rlcp+Ig2/3U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1610146296599695.0813227024418; Fri, 8 Jan 2021 14:51:36 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726410AbhAHWvf (ORCPT ); Fri, 8 Jan 2021 17:51:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbhAHWvd (ORCPT ); Fri, 8 Jan 2021 17:51:33 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D21AC061757; Fri, 8 Jan 2021 14:50:53 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id r7so10407439wrc.5; Fri, 08 Jan 2021 14:50:53 -0800 (PST) Received: from adgra-XPS-15-9570.home (2a01cb0008bd270094076597458eade1.ipv6.abo.wanadoo.fr. [2a01:cb00:8bd:2700:9407:6597:458e:ade1]) by smtp.gmail.com with ESMTPSA id o23sm15900644wro.57.2021.01.08.14.50.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 14:50:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=HCP+UiqivE5Sl8wYg29qb2EI1nN4FyBAZjFb96c2xmg=; b=bZ/IBuSBUJ/NvDj43ey+PTXQizDEtnkr7Q/fi5VKyTeDZrBQKRxabC2HSD2d/5GBYa wvrd/qXjxCNa+tr+1MLmOYhRK/QpfltThjCm5PMHaJhKbu8wYuNbBP+6WvgDlkBGNn8s 6evuqp8JltCPV0A421RTun/dsy0+R6mpoI8t8dZHZGOO1VMAssXRHXVKMF2ikCMPgQCu fBovZ6qgx4KVuAwSk2OIspYz9WYw38Kd1w5fTDs2Ug7Sgbl3LIBZSUWKUaWb30e2CgR9 uHv0NoxN3F031ioNrJOTLNgKq15Y8Jvdef9gOu+TTq6uAQidVSj7f6nuOK0NRek+ZYJj WQOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HCP+UiqivE5Sl8wYg29qb2EI1nN4FyBAZjFb96c2xmg=; b=PFeLMab4x2wVFGDQ5wz09Rtpnz/rrj/vZfzVXP1mWgn/JbsGmDR84hSME25SA3FsRj Pqr1sWxYMuTSLycVRL9qz7PzOxuj+EGw1XWgiFWRTiqyQjshhK0jTQ8bK2GCUnWq85c7 +sQKmZf3qzWIm1pZ6FrkWSjQ34bqQWqnlMmb4rCfivRPo0g0W0ea80byASj+nOcO1lTq ayFMt9vRDchshpENUZX4wtaCBU4S3zKl0S7WUan1wZuzRw33HXiJMfs5Z/oIfpdnrfSi qlHn0/OdNSHVbDsmWHIVglP7Oc0myDC1iIjRJTzyrlCz3rSN6/5JAQiZCNjyq7oteaIw D5GA== X-Gm-Message-State: AOAM533hxDiX5mmB5nB3h9LiBXQgifwx+9i/dhk1wjDYtK05fNBFmBr7 hytoDBGHX71y4yPygWel5J0= X-Google-Smtp-Source: ABdhPJxZxLOuudJaP6+enCfc8zpXg+QIZEb+aQGA1lhlQO5VPvOSypEFu3TOPlh2S8q649MEpqKUQQ== X-Received: by 2002:a05:6000:100f:: with SMTP id a15mr5645875wrx.300.1610146251982; Fri, 08 Jan 2021 14:50:51 -0800 (PST) From: Adrien Grassein Cc: broonie@kernel.org, jagan@amarulasolutions.com, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adrien Grassein Subject: [PATCH v3 1/6] regulator: pf8x00: add a doc for the module Date: Fri, 8 Jan 2021 23:50:01 +0100 Message-Id: <20210108225006.153700-2-adrien.grassein@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108225006.153700-1-adrien.grassein@gmail.com> References: <20210108225006.153700-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" pf8x00 module build was not documented. Signed-off-by: Adrien Grassein Reviewed-by: Jagan Teki --- drivers/regulator/Kconfig | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index eafa13be6e3e..ba8c09d90701 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -846,6 +846,10 @@ config REGULATOR_PF8X00 Say y here to support the regulators found on the NXP PF8100/PF8121A/PF8200 PMIC. =20 + Say M here if you want to support for the regulators found + on the NXP PF8100/PF8121A/PF8200 PMIC. The module will be named + "pf8x00-regulator". + config REGULATOR_PFUZE100 tristate "Freescale PFUZE100/200/3000/3001 regulator driver" depends on I2C && OF --=20 2.25.1 From nobody Sat May 10 06:11:17 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610146348; cv=none; d=zohomail.com; s=zohoarc; b=MWSTARPoD+X3LJW7T+YQ26euB+81DX24Hu+bNetn7ltyXgZs0lFPPW8YdveLU/PBSjBQ5I3dC9nddeIlXrMTNcDgheSfJjHGZIaliF1rhE9Cp/fJP4iKv6Fd3mZsoHrIxBnQbe6QQTNeTagx9UzhIs6XRGe3ir9mUrQxoQ+vtQY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610146348; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=iCW93FwLsL6N6oiIX3yAfaWwuZ02R+spflo+eRFZf6w=; b=UWzpxlGeXdaT4VTqQ1Lhv1gZyN5Di2EkYbeu5Cm3TAJye9GLA1dY6jEo+Nt3L9z9xoQ9IGnsSFZHWaBUf86z65VGYUYOcW+n4rYL3BxqlO+jcbZkyToD9Jjfq2JnRcoTXbLnI9JcLlJM5CZp9YN00V/33VZEF3lf8m8KAN9vyfQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1610146348913326.28344884936325; Fri, 8 Jan 2021 14:52:28 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726510AbhAHWvp (ORCPT ); Fri, 8 Jan 2021 17:51:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbhAHWve (ORCPT ); Fri, 8 Jan 2021 17:51:34 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3985C061786; Fri, 8 Jan 2021 14:50:53 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id g25so7545145wmh.1; Fri, 08 Jan 2021 14:50:53 -0800 (PST) Received: from adgra-XPS-15-9570.home (2a01cb0008bd270094076597458eade1.ipv6.abo.wanadoo.fr. [2a01:cb00:8bd:2700:9407:6597:458e:ade1]) by smtp.gmail.com with ESMTPSA id o23sm15900644wro.57.2021.01.08.14.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 14:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=iCW93FwLsL6N6oiIX3yAfaWwuZ02R+spflo+eRFZf6w=; b=QPbNGB4k/GYs/E+8BuvBqbkPJsIdg4u0T3aqxjPuPXCABnHM3NDUaTaHJvP0FPNd+N zljjqTh+FkP0DSM8a0n5tqQLCndRStDKEOeV1KDWNSWbH/1JBCG9hfWfkztrUjMaieM9 c7rHvOqdeFUYyJNkTpT3RXSqcf/pLSwVGlJuLSs9NY7wly7EyyFAhcn220N4e4OC6Fu2 iPz8AAkCJ4m8j8Q1MzxTOrpYxH3U8FEt422OBo01o3ZFo39F35GRVcJo/OU2hFVBh5Mh iS3jXXuopazdgp5hJKS1+g9/mibG4QP4+8TTKbOTLuRQHg2pxSeHvtrbk7xs476MeDrb r09A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=iCW93FwLsL6N6oiIX3yAfaWwuZ02R+spflo+eRFZf6w=; b=J+ggz3gmihQi8nMNsNl2e4QF+JFA/J63Ahgfk0AghM2dUuimVDQj4uBq7F5YPhGrLJ LAy6T71hrRhqAUchT9DDNKX2IzvPMPvQYr5O7MaXdLcAx7avasL1BUYEKinCrm2XsCMg uYsBVjNz+eF3gCFyL3Nc+ZHAel8Sg10B2BAnuDZZhyzyRj7eSyo9VwS/dELa+NxW3gQE Qgx0AspeMs7mV30qEJ1iZQVhsz/E5CuXzkigkLWZh+Jbtt5JYZuNBdU+N9Vrj45K9kbQ 9sGm/lzZtZelWFQ7ojlL63wz742mAWzL5uwHJGqzzOz6rEYxEZw5M6wY3hG7vSSkfPB0 /eeQ== X-Gm-Message-State: AOAM530XRHfFqmfs60jygUVdrJJG+IT4mkE9WKSLx/EKjb71U+iiN773 qiz+WRaJeRNS8mahTqBmMvLZ6UegjXQ= X-Google-Smtp-Source: ABdhPJwumdwfKYVp622MpKu+ZHSaDqMdi0tyJXdK9G4yeJ1HCpeGU5NB+G/XS+WnBuzKO+hbMLjwEQ== X-Received: by 2002:a1c:7d58:: with SMTP id y85mr4886405wmc.50.1610146252713; Fri, 08 Jan 2021 14:50:52 -0800 (PST) From: Adrien Grassein Cc: broonie@kernel.org, jagan@amarulasolutions.com, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adrien Grassein Subject: [PATCH v3 2/6] regulator: dt-bindings: pf8x00: fix nxp,phase-shift doc Date: Fri, 8 Jan 2021 23:50:02 +0100 Message-Id: <20210108225006.153700-3-adrien.grassein@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108225006.153700-1-adrien.grassein@gmail.com> References: <20210108225006.153700-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" nxp,phase-shift is an enum so use enum format to describe it. Minimum and maximum values are also wrong. Signed-off-by: Adrien Grassein --- .../bindings/regulator/nxp,pf8x00-regulator.yaml | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulat= or.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.= yaml index 956156fe52a3..095cfdae7b67 100644 --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml @@ -73,21 +73,11 @@ properties: =20 nxp,phase-shift: $ref: "/schemas/types.yaml#/definitions/uint32" - minimum: 45 - maximum: 0 + default: 0 + enum: [ 0, 45, 90, 135, 180, 225, 270, 315 ] description: BUCK regulators phase shift control in degrees. =20 - Listed phase shift control values in degrees are, - 45 - 90 - 135 - 180 - 225 - 270 - 315 - 0 (default) - unevaluatedProperties: false =20 "^vsnvs$": --=20 2.25.1 From nobody Sat May 10 06:11:17 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610146346; cv=none; d=zohomail.com; s=zohoarc; b=l54qSuwoMXjmax1B84SVMe9x9twbD/09/9EuDX8hfuzfTa3BCgvzDqwqs+mfQn3jlkG+V6al22gM06UskDtnNflMZpBBvH2H11xElx/Re1IveP4l+hoIxkEFZe5YdBHWfdVwC+XZjXFpPFvTIjo9y3Ow5n4GWZV3Gy261zrjZ1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610146346; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=nNfTtBLIcdTbFMkk31wtAgNDzDDOmgueHCelKbYklYI=; b=Racv7C+3KrzA/SzQzcy8UiZez7VilYK6EvJgV2nyv60B0bJA/ldCM8JlRPs+ByTDx81kFapHyvH8pNMtsYpPQcP7vsjWqz0NrX3NyGi3VNBO1E2v221Bdlside497CiMIg9Iq0IUuKgYxLfN/xt3gnopsEBIQcNJ/9GN5TjRyCw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1610146346647894.5474335775424; Fri, 8 Jan 2021 14:52:26 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726477AbhAHWvi (ORCPT ); Fri, 8 Jan 2021 17:51:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726267AbhAHWvf (ORCPT ); Fri, 8 Jan 2021 17:51:35 -0500 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7A9AC061793; Fri, 8 Jan 2021 14:50:54 -0800 (PST) Received: by mail-wr1-x430.google.com with SMTP id m5so10398830wrx.9; Fri, 08 Jan 2021 14:50:54 -0800 (PST) Received: from adgra-XPS-15-9570.home (2a01cb0008bd270094076597458eade1.ipv6.abo.wanadoo.fr. [2a01:cb00:8bd:2700:9407:6597:458e:ade1]) by smtp.gmail.com with ESMTPSA id o23sm15900644wro.57.2021.01.08.14.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 14:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nNfTtBLIcdTbFMkk31wtAgNDzDDOmgueHCelKbYklYI=; b=bjlTAJZWOBYHyVIhT0A5CAmT19N2z0qXhgawBe1eNWly9S2QDd1dRm/Kk0KzUAzd69 FLGcsNLJHKn0V0hs1bUV+luLpavtY+hIMAkpPSyN1asJhi+PqXqmFq61xizY1kkv6vcx kxGoMRbZQ/2Y6EIn2EMze60EIgOjWmfsdwvEPsbzdmNJI0ESE1s+oV6lIQajhx2E4/eQ t/hd5LfkJr8XqxVbbKLypc3+vevdPS30zAKpTbyE6EAcLYxuPKBA79cD7+5h/DB4z58q vb4uOvubAzCUjOiMkdqrCAnlhhfXN3xS9EPAmPj4bi3fBSFAkvel9TSDuNp61thBnrZh LC4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nNfTtBLIcdTbFMkk31wtAgNDzDDOmgueHCelKbYklYI=; b=IPOyB3jeFvN/JmTtDqenFfP57If/B7AgU4Pk03sdHqagdf04Etxk6FK3uwNvgoNhTH w3YwZvWLuTFeNP66+3Kz+9d8dLH1l7K4Lm94SgrSeEYGwPi1CVzPx6if7ueKv/EizRuK 8yH+qBeLsuab4pjH389E8dM+8FqaOUzqsZ5KYt1f7Xt9zWy6g8jTDOG8kCkyP5nuotdz QAMpAB6928VqN24HefB6Hp5Ym8GgrHFBJAiAfcxh+KfVvWE4MkgI5L0//E920YKz4lH5 mLlWotkt3XkPGcGgqDqZ50ENM6so0yyA43beGrJ3yKuaCjBKAkkmsBb6kJKVQKnD1THt htDg== X-Gm-Message-State: AOAM533C2ecvx9pFdpknmXCOLBMEjNIQrZ0y3lyu5CH/zr/CsS2iEarN ux69C/NqM/u4KUOUFE+h3iA= X-Google-Smtp-Source: ABdhPJwz8V38Vk02bPYrifZgSuZZPbOBBGT5Z17x1GqY9PVGwOKHY+5MMO7raJTkQeOMgzc8ImuZ/w== X-Received: by 2002:adf:e60f:: with SMTP id p15mr5563251wrm.60.1610146253533; Fri, 08 Jan 2021 14:50:53 -0800 (PST) From: Adrien Grassein Cc: broonie@kernel.org, jagan@amarulasolutions.com, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adrien Grassein , Rob Herring Subject: [PATCH v3 3/6] regulator: dt-bindings: pf8x00: remove nxp,ilim-ma property Date: Fri, 8 Jan 2021 23:50:03 +0100 Message-Id: <20210108225006.153700-4-adrien.grassein@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108225006.153700-1-adrien.grassein@gmail.com> References: <20210108225006.153700-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This property seems useless because we can use the regulator-max-microamp generic property to do the same and using generic code. The only things it changes is the default value. The original code was using "2100" (mA) as default one, but I think we should keep the value in the OTP memory as the default one. This value is automatically loaded in the register by the chip. Signed-off-by: Adrien Grassein Reviewed-by: Rob Herring --- .../bindings/regulator/nxp,pf8x00-regulator.yaml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulat= or.yaml b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.= yaml index 095cfdae7b67..05d5e9a2219c 100644 --- a/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/nxp,pf8x00-regulator.yaml @@ -58,19 +58,6 @@ properties: description: should be "buck1", ..., "buck7" =20 - nxp,ilim-ma: - $ref: "/schemas/types.yaml#/definitions/uint32" - minimum: 2100 - maximum: 4500 - description: - BUCK regulators current limit in mA. - - Listed current limits in mA are, - 2100 (default) - 2600 - 3000 - 4500 - nxp,phase-shift: $ref: "/schemas/types.yaml#/definitions/uint32" default: 0 --=20 2.25.1 From nobody Sat May 10 06:11:17 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610146346; cv=none; d=zohomail.com; s=zohoarc; b=VwZ3yyDEoL/e5t883GXLGKsjySMufOflV7chlLapquwz3eWEKX/NjtUyynGISktcPP+rVVCBt3E23x0BsHSr+TpgEYCiSTQIaeOUxiFJbz6UvDvEjcvmmjQRwe4Rk7gMzpYtwIW7+g2wlkCmwSzyB/oy1wCtegotwhG2wmeIXrk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610146346; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=k+FFPQC7Z/J2zspNeLZ507qHSJx8NoZiwyfKhZGK7II=; b=gakPPdUW3a91NnH86Yt/l4UmxWaTSDuzA3rY/ITVUtyUsvSL/sVaHi3XHnUX+U8mYHRsCrmzL8WydnFRQacv3deabyqdFkbhYCpIRelwgJoMmBGR42Q5zdpe6VbhJ/TkwbiIp0BXBWVSyBuH4F6APGUoPJzNXsxPh0IfEouL2ho= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1610146346358100.86519662834564; Fri, 8 Jan 2021 14:52:26 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726448AbhAHWvh (ORCPT ); Fri, 8 Jan 2021 17:51:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725905AbhAHWvg (ORCPT ); Fri, 8 Jan 2021 17:51:36 -0500 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90F68C061796; Fri, 8 Jan 2021 14:50:55 -0800 (PST) Received: by mail-wr1-x429.google.com with SMTP id w5so10373419wrm.11; Fri, 08 Jan 2021 14:50:55 -0800 (PST) Received: from adgra-XPS-15-9570.home (2a01cb0008bd270094076597458eade1.ipv6.abo.wanadoo.fr. [2a01:cb00:8bd:2700:9407:6597:458e:ade1]) by smtp.gmail.com with ESMTPSA id o23sm15900644wro.57.2021.01.08.14.50.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 14:50:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=k+FFPQC7Z/J2zspNeLZ507qHSJx8NoZiwyfKhZGK7II=; b=bt+JeEgIov3sNb7S9SOaiiuKAi9K0lXNZx/f6ELmOyV1G3joLiXKdp45Ch98UWEX1T oMp9NXIltR/hybKJ9ZZiGN1Wjndz8QGCG3xWe4CXUAE8P5+ujMTYqid9QYtinvmdm8u/ idHTKQ2uX59hwekSXaz964BAeo/PzI+YGTzNekQW+9bbjzpEbHwbdimcpow++lxEIWbY wUyeDygkB/+2Dk3x1h7FdiTagz72dUDbbhIzi++klCerJ/VNqfmoLdswRmHzF/AZhgG6 9dS0576obBtlLAhWmROI5zPlCWV4SOb7UjEZDXSW4Z0Zp75vP+aEgjYDtulaL3y+FeIq 7kHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=k+FFPQC7Z/J2zspNeLZ507qHSJx8NoZiwyfKhZGK7II=; b=C+tYgX/vk0AsmaHuh4D3sfZ8WLULR+TuU8utqTqKUMBJKcoOrvMDmQ/MvNjlohRpIp sOjTWjfsTd3ojIea48AwYCDh20Q7oEnZbeyHx1PLMoFdBK/cDi6VsVT5BFLm5C+6pnho Bm664Xwk8op9c5JS4l60L35qDUvP8T3f7ac4jyRLHOtBhNjQbGTI2J0pDPmglcbDFDHy GuyrkXC+tLOe0y2X24J1ma4ImqwTZmAerdES4Xp4MQUJFJibIAW8Xsxs0jClwVZk2+f8 +jSOtTd5pC50mbd1XIIusx0Si1P3dWsuwhMwdEDDPRj8+74bmQYUb45Az1uiprezgJUN 83aA== X-Gm-Message-State: AOAM531X4p5vUr940CT/h4QFvdQ80IBH0YE7xrNXAi+7HhJAZIVQevHY ks1e9Fqs2xdgktrq8K2c4s9i0jYJ3DU= X-Google-Smtp-Source: ABdhPJy4t7+zPFKzfRgpAblBTDlgp6jDfh9GpR2nEeejCXv9CL3Vox8KQnqcQ5h5di2E065P1n12fw== X-Received: by 2002:a5d:43cc:: with SMTP id v12mr5476465wrr.319.1610146254251; Fri, 08 Jan 2021 14:50:54 -0800 (PST) From: Adrien Grassein Cc: broonie@kernel.org, jagan@amarulasolutions.com, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adrien Grassein Subject: [PATCH v3 4/6] regulator: pf8x00: remove nxp,ilim-ma property Date: Fri, 8 Jan 2021 23:50:04 +0100 Message-Id: <20210108225006.153700-5-adrien.grassein@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108225006.153700-1-adrien.grassein@gmail.com> References: <20210108225006.153700-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" This property seems useless because we can use the regulator-max-microamp generic property to do the same and using generic code. The only things it changes is the default value. The original code was using "2100" (mA) as default one, but I think we should keep the value in the OTP memory as the default one. This value is automatically loaded in the register by the chip. Signed-off-by: Adrien Grassein --- drivers/regulator/pf8x00-regulator.c | 95 ++++++++++++++-------------- 1 file changed, 47 insertions(+), 48 deletions(-) diff --git a/drivers/regulator/pf8x00-regulator.c b/drivers/regulator/pf8x0= 0-regulator.c index af9918cd27aa..90383e394f85 100644 --- a/drivers/regulator/pf8x00-regulator.c +++ b/drivers/regulator/pf8x00-regulator.c @@ -105,13 +105,6 @@ enum pf8x00_ldo_states { }; #define PF8X00_LDO_BASE(i) (6 * (i - PF8X00_LDO1) + PF8X00_LDO1_CONFIG1) =20 -enum swxilim_bits { - SWXILIM_2100_MA, - SWXILIM_2600_MA, - SWXILIM_3000_MA, - SWXILIM_4500_MA, -}; -#define PF8X00_SWXILIM_SHIFT 3 #define PF8X00_SWXILIM_MASK GENMASK(4, 3) #define PF8X00_SWXPHASE_MASK GENMASK(2, 0) #define PF8X00_SWXPHASE_DEFAULT 0 @@ -128,7 +121,6 @@ enum pf8x00_devid { =20 struct pf8x00_regulator { struct regulator_desc desc; - u8 ilim; u8 phase_shift; }; =20 @@ -150,6 +142,11 @@ static const int pf8x00_ldo_voltages[] =3D { 3100000, 3150000, 3200000, 3300000, 3350000, 1650000, 1700000, 5000000, }; =20 +/* Output: 2.1A to 4.5A */ +static const unsigned int pf8x00_sw_current_table[] =3D { + 2100000, 2600000, 3000000, 4500000, +}; + #define SWV(i) (6250 * i + 400000) #define SWV_LINE(i) SWV(i*8+0), SWV(i*8+1), SWV(i*8+2), SWV(i*8+3), \ SWV(i*8+4), SWV(i*8+5), SWV(i*8+6), SWV(i*8+7) @@ -199,32 +196,6 @@ static struct pf8x00_regulator *desc_to_regulator(cons= t struct regulator_desc *d return container_of(desc, struct pf8x00_regulator, desc); } =20 -static void swxilim_select(const struct regulator_desc *desc, int ilim) -{ - struct pf8x00_regulator *data =3D desc_to_regulator(desc); - u8 ilim_sel; - - switch (ilim) { - case 2100: - ilim_sel =3D SWXILIM_2100_MA; - break; - case 2600: - ilim_sel =3D SWXILIM_2600_MA; - break; - case 3000: - ilim_sel =3D SWXILIM_3000_MA; - break; - case 4500: - ilim_sel =3D SWXILIM_4500_MA; - break; - default: - ilim_sel =3D SWXILIM_2100_MA; - break; - } - - data->ilim =3D ilim_sel; -} - static int pf8x00_of_parse_cb(struct device_node *np, const struct regulator_desc *desc, struct regulator_config *config) @@ -235,13 +206,6 @@ static int pf8x00_of_parse_cb(struct device_node *np, int val; int ret; =20 - ret =3D of_property_read_u32(np, "nxp,ilim-ma", &val); - if (ret) - dev_dbg(chip->dev, "unspecified ilim for BUCK%d, use 2100 mA\n", - desc->id - PF8X00_LDO4); - - swxilim_select(desc, val); - ret =3D of_property_read_u32(np, "nxp,phase-shift", &val); if (ret) { dev_dbg(chip->dev, @@ -272,7 +236,18 @@ static const struct regulator_ops pf8x00_ldo_ops =3D { .get_voltage_sel =3D regulator_get_voltage_sel_regmap, }; =20 -static const struct regulator_ops pf8x00_buck_ops =3D { +static const struct regulator_ops pf8x00_buck1_6_ops =3D { + .enable =3D regulator_enable_regmap, + .disable =3D regulator_disable_regmap, + .is_enabled =3D regulator_is_enabled_regmap, + .list_voltage =3D regulator_list_voltage_table, + .set_voltage_sel =3D regulator_set_voltage_sel_regmap, + .get_voltage_sel =3D regulator_get_voltage_sel_regmap, + .get_current_limit =3D regulator_get_current_limit_regmap, + .set_current_limit =3D regulator_set_current_limit_regmap, +}; + +static const struct regulator_ops pf8x00_buck7_ops =3D { .enable =3D regulator_enable_regmap, .disable =3D regulator_disable_regmap, .is_enabled =3D regulator_is_enabled_regmap, @@ -320,13 +295,41 @@ static const struct regulator_ops pf8x00_vsnvs_ops = =3D { .regulators_node =3D "regulators", \ .of_parse_cb =3D pf8x00_of_parse_cb, \ .n_voltages =3D ARRAY_SIZE(voltages), \ - .ops =3D &pf8x00_buck_ops, \ + .ops =3D &pf8x00_buck1_6_ops, \ .type =3D REGULATOR_VOLTAGE, \ .id =3D PF8X00_BUCK ## _id, \ .owner =3D THIS_MODULE, \ .volt_table =3D voltages, \ .vsel_reg =3D (base) + SW_RUN_VOLT, \ .vsel_mask =3D 0xff, \ + .curr_table =3D pf8x00_sw_current_table, \ + .n_current_limits =3D \ + ARRAY_SIZE(pf8x00_sw_current_table), \ + .csel_reg =3D (base) + SW_CONFIG2, \ + .csel_mask =3D PF8X00_SWXILIM_MASK, \ + .enable_reg =3D (base) + SW_MODE1, \ + .enable_val =3D 0x3, \ + .disable_val =3D 0x0, \ + .enable_mask =3D 0x3, \ + .enable_time =3D 500, \ + }, \ + } + +#define PF8X00BUCK7(_name, base, voltages) \ + [PF8X00_BUCK7] =3D { \ + .desc =3D { \ + .name =3D _name, \ + .of_match =3D _name, \ + .regulators_node =3D "regulators", \ + .of_parse_cb =3D pf8x00_of_parse_cb, \ + .n_voltages =3D ARRAY_SIZE(voltages), \ + .ops =3D &pf8x00_buck7_ops, \ + .type =3D REGULATOR_VOLTAGE, \ + .id =3D PF8X00_BUCK7, \ + .owner =3D THIS_MODULE, \ + .volt_table =3D voltages, \ + .vsel_reg =3D (base) + SW_RUN_VOLT, \ + .vsel_mask =3D 0xff, \ .enable_reg =3D (base) + SW_MODE1, \ .enable_val =3D 0x3, \ .disable_val =3D 0x0, \ @@ -363,7 +366,7 @@ static struct pf8x00_regulator pf8x00_regulators_data[P= F8X00_MAX_REGULATORS] =3D { PF8X00BUCK(4, "buck4", PF8X00_SW_BASE(PF8X00_BUCK4), pf8x00_sw1_to_6_volt= ages), PF8X00BUCK(5, "buck5", PF8X00_SW_BASE(PF8X00_BUCK5), pf8x00_sw1_to_6_volt= ages), PF8X00BUCK(6, "buck6", PF8X00_SW_BASE(PF8X00_BUCK6), pf8x00_sw1_to_6_volt= ages), - PF8X00BUCK(7, "buck7", PF8X00_SW_BASE(PF8X00_BUCK7), pf8x00_sw7_voltages), + PF8X00BUCK7("buck7", PF8X00_SW_BASE(PF8X00_BUCK7), pf8x00_sw7_voltages), PF8X00VSNVS("vsnvs", PF8X00_VSNVS_CONFIG1, pf8x00_vsnvs_voltages), }; =20 @@ -458,10 +461,6 @@ static int pf8x00_i2c_probe(struct i2c_client *client) regmap_update_bits(chip->regmap, reg, PF8X00_SWXPHASE_MASK, data->phase_shift); - - regmap_update_bits(chip->regmap, reg, - PF8X00_SWXILIM_MASK, - data->ilim << PF8X00_SWXILIM_SHIFT); } } =20 --=20 2.25.1 From nobody Sat May 10 06:11:17 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610146349; cv=none; d=zohomail.com; s=zohoarc; b=aY3gVg8oKb98usj863p+rET6LY0HCPA9uqnO4fCHb9IwawG02n7GeiOaOaHdEiHqqVqDK/NbtJRtyS6oSWocxckXIjUlMT70MlapivDYpTfrK0opK/jjseIZdfGrjBG+kHYfGaElUKq9pXM6fDZBq8/x8p2m0iBnKLAjr7rvkqw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610146349; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=M8hpe74Y0ylqdEhOyhfh9qdEDpDAnUYsjuG7nsUgvkQ=; b=Z2XMhin1pi06b+aMOc9mXwWxPB6A+YLJcC7Pm0EmHGg17xanP/Ho+l6oFhZsRlXYc4DHTwsjSLKu/gfkb45bMrKwhnJhTeWgSRiadOio2jqznmhJZQN/P01ifJaP24fowmPl9UfOQECPtXU0XcDVWdgPyYtF7LT13xsBrQyVjOk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1610146349179221.7562348395054; Fri, 8 Jan 2021 14:52:29 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726572AbhAHWwO (ORCPT ); Fri, 8 Jan 2021 17:52:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726001AbhAHWwN (ORCPT ); Fri, 8 Jan 2021 17:52:13 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63EFDC061798; Fri, 8 Jan 2021 14:50:56 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id y23so9691652wmi.1; Fri, 08 Jan 2021 14:50:56 -0800 (PST) Received: from adgra-XPS-15-9570.home (2a01cb0008bd270094076597458eade1.ipv6.abo.wanadoo.fr. [2a01:cb00:8bd:2700:9407:6597:458e:ade1]) by smtp.gmail.com with ESMTPSA id o23sm15900644wro.57.2021.01.08.14.50.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 14:50:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=M8hpe74Y0ylqdEhOyhfh9qdEDpDAnUYsjuG7nsUgvkQ=; b=YxkfN4SGdTskHQVdUnKS/YK6Wb2GAeXqCFRVTHNxJDoC4l5RUrvNvjDXjzNPe2upZD 8ppsXPzGr//DdMPd/3+wu7Z5cr4IPXziN9ouQKiEj1KfRN729nRrNA6duxQe9qwhy3n/ n+IZs2IYACFXFKFPIT45RlRQhX/v9EgolEA+mu6pjhOy6yJ+gblYr26Swp4b+zKNKPmC 5qMzydT6mPLD2H899gUl4UlfvP9bHmhMRshHTLyXqikPfPrk2JMCoXMJrOZju6t9eJoN Beg9tjqJF8HbKbzCppTdq7o7OHDko8N4kQ0Vn+stSy8GP57VkAnedvxhXOz4brZL88bb 94CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=M8hpe74Y0ylqdEhOyhfh9qdEDpDAnUYsjuG7nsUgvkQ=; b=GuQ15/4wyY5JiCnBas9W+u/UkjRSGO9TEqaj4CHfSKuYFo5fJylueTsa4/5TCLKGjl SOYnATQtHq51YxswH3gRE0Gi290o8pdfWNxFyQ6fdN8hRc3CDPV3pPeEyt6op7aJ6F2p z3rBBmn9fNR7OpWFQ25WTze1lXO38ElNLgrbNDCbJulJQQi60KGpunSNSeYz8sLDyC9R Hpzgtf2TvVLKySqKj0sFsLgPPxjusjS/kDq1ZzTiHvlcXBj8KYC0dLVyprFPmIYy0qeH eKBzFuOfPQeRVXsmwBs+VmoDsdMkBNq7enz3dpnMWjf2RMPmFgHS1fENlf1G+iAgm/jR u/4w== X-Gm-Message-State: AOAM530GDy0p090i19SMmuGcp+e50T1XpNG7RKw4p16ieyBdtmsDmbdf Rawo5wCEWfoswjU1FT39PdU= X-Google-Smtp-Source: ABdhPJyW9PBgcWEBHASPVGkghyoyo/ECt3Bn9iEbnbOBaYt5QJ5pDdmxBLXIHh3dJIljDtDFzBM5/g== X-Received: by 2002:a1c:2c83:: with SMTP id s125mr4879995wms.161.1610146255142; Fri, 08 Jan 2021 14:50:55 -0800 (PST) From: Adrien Grassein Cc: broonie@kernel.org, jagan@amarulasolutions.com, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adrien Grassein Subject: [PATCH v3 5/6] regulator: pf8x00: use linear range for buck 1-6 Date: Fri, 8 Jan 2021 23:50:05 +0100 Message-Id: <20210108225006.153700-6-adrien.grassein@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108225006.153700-1-adrien.grassein@gmail.com> References: <20210108225006.153700-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Use a linear range to describe the voltages of the bucks 1-6 instead of listing it one by one (via a macro) Signed-off-by: Adrien Grassein --- drivers/regulator/pf8x00-regulator.c | 40 +++++++--------------------- 1 file changed, 9 insertions(+), 31 deletions(-) diff --git a/drivers/regulator/pf8x00-regulator.c b/drivers/regulator/pf8x0= 0-regulator.c index 90383e394f85..4b57f74e7326 100644 --- a/drivers/regulator/pf8x00-regulator.c +++ b/drivers/regulator/pf8x00-regulator.c @@ -147,35 +147,11 @@ static const unsigned int pf8x00_sw_current_table[] = =3D { 2100000, 2600000, 3000000, 4500000, }; =20 -#define SWV(i) (6250 * i + 400000) -#define SWV_LINE(i) SWV(i*8+0), SWV(i*8+1), SWV(i*8+2), SWV(i*8+3), \ - SWV(i*8+4), SWV(i*8+5), SWV(i*8+6), SWV(i*8+7) - /* Output: 0.4V to 1.8V */ -static const int pf8x00_sw1_to_6_voltages[] =3D { - SWV_LINE(0), - SWV_LINE(1), - SWV_LINE(2), - SWV_LINE(3), - SWV_LINE(4), - SWV_LINE(5), - SWV_LINE(6), - SWV_LINE(7), - SWV_LINE(8), - SWV_LINE(9), - SWV_LINE(10), - SWV_LINE(11), - SWV_LINE(12), - SWV_LINE(13), - SWV_LINE(14), - SWV_LINE(15), - SWV_LINE(16), - SWV_LINE(17), - SWV_LINE(18), - SWV_LINE(19), - SWV_LINE(20), - SWV_LINE(21), - 1500000, 1800000, +#define PF8XOO_SW1_6_VOLTAGE_NUM 0xB2 +static const struct linear_range pf8x00_sw1_to_6_voltages[] =3D { + REGULATOR_LINEAR_RANGE(400000, 0x00, 0xB0, 6250), + REGULATOR_LINEAR_RANGE(1800000, 0xB1, 0xB1, 0), }; =20 /* Output: 1.0V to 4.1V */ @@ -240,7 +216,7 @@ static const struct regulator_ops pf8x00_buck1_6_ops = =3D { .enable =3D regulator_enable_regmap, .disable =3D regulator_disable_regmap, .is_enabled =3D regulator_is_enabled_regmap, - .list_voltage =3D regulator_list_voltage_table, + .list_voltage =3D regulator_list_voltage_linear_range, .set_voltage_sel =3D regulator_set_voltage_sel_regmap, .get_voltage_sel =3D regulator_get_voltage_sel_regmap, .get_current_limit =3D regulator_get_current_limit_regmap, @@ -294,12 +270,14 @@ static const struct regulator_ops pf8x00_vsnvs_ops = =3D { .of_match =3D _name, \ .regulators_node =3D "regulators", \ .of_parse_cb =3D pf8x00_of_parse_cb, \ - .n_voltages =3D ARRAY_SIZE(voltages), \ + .n_voltages =3D PF8XOO_SW1_6_VOLTAGE_NUM, \ .ops =3D &pf8x00_buck1_6_ops, \ .type =3D REGULATOR_VOLTAGE, \ .id =3D PF8X00_BUCK ## _id, \ .owner =3D THIS_MODULE, \ - .volt_table =3D voltages, \ + .linear_ranges =3D pf8x00_sw1_to_6_voltages, \ + .n_linear_ranges =3D \ + ARRAY_SIZE(pf8x00_sw1_to_6_voltages), \ .vsel_reg =3D (base) + SW_RUN_VOLT, \ .vsel_mask =3D 0xff, \ .curr_table =3D pf8x00_sw_current_table, \ --=20 2.25.1 From nobody Sat May 10 06:11:17 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1610146349; cv=none; d=zohomail.com; s=zohoarc; b=kBXq87TticGKKRD/OSgKjo3FX+smbmbKHjin/e+RXcHCbig8MaoXs0npt1BLsI9PE6+t7+3F8JoIKzl1u7Aa9Sk1jHLQsxB17wH2dsZ7o80j6JmzjUfPVnSYSURsuCHFUG0b3N9fKPHAt8xcWW5L7klbgXVbY5pnp5PDqAtICIk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1610146349; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=MTn9/sf2WP+vAcNsRG2ZW/CUAbf2TQCT32NuGuwVptE=; b=WrYqEAw0GXocAvVV+pAsQCikLl5UN5gsppskZL7Iq7/dAepZtPUrB2R4+wwNPXBOkzfeneMJCF2hpECIZuxV0OeGOU9Ob0HtdL2XZsPuK+fxt/9QSLBauQHCZAasEewoIaeBBUrmBMihnTPVsaLzYSQzWfD9Gf4Hxd8stQji+ws= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1610146349491829.1497925040737; Fri, 8 Jan 2021 14:52:29 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726620AbhAHWwO (ORCPT ); Fri, 8 Jan 2021 17:52:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726381AbhAHWwN (ORCPT ); Fri, 8 Jan 2021 17:52:13 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4C73C061799; Fri, 8 Jan 2021 14:50:57 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id g185so9689859wmf.3; Fri, 08 Jan 2021 14:50:57 -0800 (PST) Received: from adgra-XPS-15-9570.home (2a01cb0008bd270094076597458eade1.ipv6.abo.wanadoo.fr. [2a01:cb00:8bd:2700:9407:6597:458e:ade1]) by smtp.gmail.com with ESMTPSA id o23sm15900644wro.57.2021.01.08.14.50.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 14:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MTn9/sf2WP+vAcNsRG2ZW/CUAbf2TQCT32NuGuwVptE=; b=h8Y06fXUNifmcBRDKjduA9iraYXESamRmjF9O235AD9AswsWcWShCxDpT183OGuf66 pbbLpr0pmoH0pr6Bua6CsjBdcMNyY4Q/V0Ldl1vfHmKuyIRWNb02mql/W1OEIWoPoN88 1G8JaHmJc6y8YuhtyxfLCUsCL3R9P24yxIoyd3Mv35nyDZ5BmN0fwXIXpJlQklB1Z4+Z 7SsaJ8dnyaF3u7Fr8Qf4o42xvomA16Bzueyfyaw61TCJcCYGNBsKNpEd3E2hpjVzIPCp HuZ1ftqWQ1xj8qj7qD10hUdzwf7viSTbZbNBcwxHqETbQEOeEbS49p0Hgd7sYXrVKsGn BhGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MTn9/sf2WP+vAcNsRG2ZW/CUAbf2TQCT32NuGuwVptE=; b=EBuVXjY42Cy+xNtQ/aChJWht8b5HkzHz8BVYUu1I0ZJhIm5eSxrndoDkRvEYbtdBf5 PUMoJe3VaZdsfHpsW8aYhGxqIW4wsUSCX4sECWkaBzmimfs7ADGNv8sv3nkbN0aXYZoD QmIsLgOM9hTJoVdzZXtJAhuRyVKVLNZiDVARyCSe+VBHaSCRZZHU4HZuvyiHABmsaeDV E69ngL0Ye9FF1lWy7qwbPIBReB7ALeK19x2rBhOdGdA+klNS7Uhf0MwOkgvar35zBl6+ 0ScQjHgms87j1iUkFL8ibBWuSphcUCSrwgESmhzdqAswzrSO1tDTCNzxjqbqQA2mdDjx jx4Q== X-Gm-Message-State: AOAM533P+Yl7xL7BFpwHOSVqAHr3+mPbybgf9TOgCcSZmhNSjynL60MY xhQV7ueh1Zn5P65Wmb2ToFc= X-Google-Smtp-Source: ABdhPJwNJvGE+k5cr857pWNImY3bh1V0Yl3EQMVcQoOrQy7yyvNxR0aEaZ9zCWC/rs3aTBZgCsvqpw== X-Received: by 2002:a1c:3cd5:: with SMTP id j204mr4801107wma.53.1610146256506; Fri, 08 Jan 2021 14:50:56 -0800 (PST) From: Adrien Grassein Cc: broonie@kernel.org, jagan@amarulasolutions.com, lgirdwood@gmail.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Adrien Grassein Subject: [PATCH v3 6/6] regulator: pf8x00: fix nxp,phase-shift Date: Fri, 8 Jan 2021 23:50:06 +0100 Message-Id: <20210108225006.153700-7-adrien.grassein@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210108225006.153700-1-adrien.grassein@gmail.com> References: <20210108225006.153700-1-adrien.grassein@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Fix the ternary condition which is a bad coding style in the kernel I also remove the defering configuration of the nxp,phase-shift. The configuration is now done at parsing time. It save some memory and it's better for comprehension. I also use the OTP default configuration when the parameter is wrong or not specified. I think that it's better to use the default configuration from the chip than an arbitrary value. Signed-off-by: Adrien Grassein --- drivers/regulator/pf8x00-regulator.c | 45 +++++++++++++--------------- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/drivers/regulator/pf8x00-regulator.c b/drivers/regulator/pf8x0= 0-regulator.c index 4b57f74e7326..9932a580619c 100644 --- a/drivers/regulator/pf8x00-regulator.c +++ b/drivers/regulator/pf8x00-regulator.c @@ -107,7 +107,6 @@ enum pf8x00_ldo_states { =20 #define PF8X00_SWXILIM_MASK GENMASK(4, 3) #define PF8X00_SWXPHASE_MASK GENMASK(2, 0) -#define PF8X00_SWXPHASE_DEFAULT 0 #define PF8X00_SWXPHASE_SHIFT 7 =20 enum pf8x00_devid { @@ -121,7 +120,6 @@ enum pf8x00_devid { =20 struct pf8x00_regulator { struct regulator_desc desc; - u8 phase_shift; }; =20 struct pf8x00_chip { @@ -167,17 +165,13 @@ static const int pf8x00_vsnvs_voltages[] =3D { 0, 1800000, 3000000, 3300000, }; =20 -static struct pf8x00_regulator *desc_to_regulator(const struct regulator_d= esc *desc) -{ - return container_of(desc, struct pf8x00_regulator, desc); -} - static int pf8x00_of_parse_cb(struct device_node *np, const struct regulator_desc *desc, struct regulator_config *config) { - struct pf8x00_regulator *data =3D desc_to_regulator(desc); struct pf8x00_chip *chip =3D config->driver_data; + unsigned char id =3D desc->id - PF8X00_LDO4; + unsigned char reg =3D PF8X00_SW_BASE(id) + SW_CONFIG2; int phase; int val; int ret; @@ -185,21 +179,30 @@ static int pf8x00_of_parse_cb(struct device_node *np, ret =3D of_property_read_u32(np, "nxp,phase-shift", &val); if (ret) { dev_dbg(chip->dev, - "unspecified phase-shift for BUCK%d, use 0 degrees\n", - desc->id - PF8X00_LDO4); - val =3D PF8X00_SWXPHASE_DEFAULT; + "unspecified phase-shift for BUCK%d, using OTP configuration\n", + id); + goto end; } =20 - phase =3D val / 45; - if ((phase * 45) !=3D val) { + if (val < 0 || val > 315 || val % 45 !=3D 0) { dev_warn(config->dev, - "invalid phase_shift %d for BUCK%d, use 0 degrees\n", - (phase * 45), desc->id - PF8X00_LDO4); - phase =3D PF8X00_SWXPHASE_SHIFT; + "invalid phase_shift %d for BUCK%d, using OTP configuration\n", + val, id); + goto end; } =20 - data->phase_shift =3D (phase >=3D 1) ? phase - 1 : PF8X00_SWXPHASE_SHIFT; + phase =3D val / 45; + + if (phase >=3D 1) + phase -=3D 1; + else + phase =3D PF8X00_SWXPHASE_SHIFT; + + regmap_update_bits(chip->regmap, reg, + PF8X00_SWXPHASE_MASK, + phase); =20 +end: return 0; } =20 @@ -432,14 +435,6 @@ static int pf8x00_i2c_probe(struct i2c_client *client) "failed to register %s regulator\n", data->desc.name); return PTR_ERR(rdev); } - - if ((id >=3D PF8X00_BUCK1) && (id <=3D PF8X00_BUCK7)) { - u8 reg =3D PF8X00_SW_BASE(id) + SW_CONFIG2; - - regmap_update_bits(chip->regmap, reg, - PF8X00_SWXPHASE_MASK, - data->phase_shift); - } } =20 return 0; --=20 2.25.1