From nobody Sat May 10 11:19:11 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1611836730; cv=none; d=zohomail.com; s=zohoarc; b=ePSajtgRAD6waIhVfczlyEVFbfLqBQcs3X5udqvT4syuWZImHvsb2lMYaZ++GpCMDEx9H4vBbXxi2+lqPswTSRVqUE8i8B/9v1DxWLu1Ey9Upx4X8d6igd6DrFxt7KYw+wWIUyD8x8+Mho2yYvXB0ahP+iKIGKzPKysLovPiZz8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1611836730; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=gSqzfAVVe2QLlO6bgA/NbmqOwAH97wz2L/kiPuJirpw=; b=m5q8cQ9SN8q1Vmf33Guk2GDGQu6GtBHOA8sWNWRH4NaT8TJfOOzyBv/z/wlZGnuQK0w7lVrDlD6tVIHvLVoNlHJFJUEj8q4kpHz481Ux6iRxfYeCZvwGufeYRgkJohjwomQ8Acc2FCf/zqYeK/8hTrSIBfidFMHbBwQtCzvbF9M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1611836729998529.5921986005868; Thu, 28 Jan 2021 04:25:29 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231845AbhA1MZY (ORCPT ); Thu, 28 Jan 2021 07:25:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231560AbhA1MWv (ORCPT ); Thu, 28 Jan 2021 07:22:51 -0500 Received: from forward105j.mail.yandex.net (forward105j.mail.yandex.net [IPv6:2a02:6b8:0:801:2::108]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BFB4C061786; Thu, 28 Jan 2021 04:21:44 -0800 (PST) Received: from sas1-44e0060c3838.qloud-c.yandex.net (sas1-44e0060c3838.qloud-c.yandex.net [IPv6:2a02:6b8:c08:f21a:0:640:44e0:60c]) by forward105j.mail.yandex.net (Yandex) with ESMTP id F22A7B2404F; Thu, 28 Jan 2021 15:21:41 +0300 (MSK) Received: from sas1-27140bb19246.qloud-c.yandex.net (sas1-27140bb19246.qloud-c.yandex.net [2a02:6b8:c08:1803:0:640:2714:bb1]) by sas1-44e0060c3838.qloud-c.yandex.net (mxback/Yandex) with ESMTP id cMRMwpIY5F-LfHiMgu4; Thu, 28 Jan 2021 15:21:41 +0300 Received: by sas1-27140bb19246.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id dVFT85naok-Lfn8Fdfd; Thu, 28 Jan 2021 15:21:41 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1611836501; bh=gSqzfAVVe2QLlO6bgA/NbmqOwAH97wz2L/kiPuJirpw=; h=In-Reply-To:References:Date:Subject:To:From:Message-Id:Cc; b=qzSCQ59NZiMeJvPDmiSQVxoAjN7dthHcfgSqeKJ3V7D60hcWsMqvUa44nFSM+WGWi bcBQR0zzmkbbvWJkEXil1PAXX0NiEcqlOviJdqhBweYS86XCPust3rSuf9jR4Ja6c6 TU1F4NUaFEhj3g/uBsbrrJJyk/CbPYGSQSTwwwq4= Authentication-Results: sas1-44e0060c3838.qloud-c.yandex.net; dkim=pass header.i=@maquefel.me From: Nikita Shubin Cc: Andy Shevchenko , Nikita Shubin , Linus Walleij , Bartosz Golaszewski , Alexander Sverdlin , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 6/7] gpio: ep93xx: refactor ep93xx_gpio_add_bank Date: Thu, 28 Jan 2021 15:21:22 +0300 Message-Id: <20210128122123.25341-7-nikita.shubin@maquefel.me> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210128122123.25341-1-nikita.shubin@maquefel.me> References: <20210128122123.25341-1-nikita.shubin@maquefel.me> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" - replace plain numbers with girq->num_parents in devm_kcalloc - replace plain numbers with girq->num_parents for port F - refactor i - 1 to i + 1 to make loop more readable - combine getting IRQ's loop and setting handler's into single loop Signed-off-by: Nikita Shubin --- v2->v3 - use ->num_parents instead of ARRAY_SIZE() --- drivers/gpio/gpio-ep93xx.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c index d69ec09cd618..df55aa13bd9a 100644 --- a/drivers/gpio/gpio-ep93xx.c +++ b/drivers/gpio/gpio-ep93xx.c @@ -384,7 +384,7 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, =20 girq->parent_handler =3D ep93xx_gpio_ab_irq_handler; girq->num_parents =3D 1; - girq->parents =3D devm_kcalloc(dev, 1, + girq->parents =3D devm_kcalloc(dev, girq->num_parents, sizeof(*girq->parents), GFP_KERNEL); if (!girq->parents) @@ -406,15 +406,14 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, */ girq->parent_handler =3D ep93xx_gpio_f_irq_handler; girq->num_parents =3D 8; - girq->parents =3D devm_kcalloc(dev, 8, + girq->parents =3D devm_kcalloc(dev, girq->num_parents, sizeof(*girq->parents), GFP_KERNEL); if (!girq->parents) return -ENOMEM; /* Pick resources 1..8 for these IRQs */ - for (i =3D 1; i <=3D 8; i++) - girq->parents[i - 1] =3D platform_get_irq(pdev, i); - for (i =3D 0; i < 8; i++) { + for (i =3D 0; i < girq->num_parents; i++) { + girq->parents[i] =3D platform_get_irq(pdev, i + 1); gpio_irq =3D EP93XX_GPIO_F_IRQ_BASE + i; irq_set_chip_data(gpio_irq, &epg->gc[5]); irq_set_chip_and_handler(gpio_irq, --=20 2.29.2