From nobody Sun May 11 22:36:34 2025 Delivered-To: importer2@patchew.org Received-SPF: pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; envelope-from=linux-kernel-owner@vger.kernel.org; helo=vger.kernel.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; t=1612776290; cv=none; d=zohomail.com; s=zohoarc; b=dnV5iWyXG5X/LDNpzQuiBa+i0myyhbD/j2KYMMnNAEhu8gGpNTwKUzq5SvthlddcsBV50OU7sMPK4VcjEqKI7GadIhwF1Yg37OxNmGw94SD7LH5cIziVNnlp8T8nKwGyQxSETdL2gVB3aT++OMoQb4qsfAm3CBObZw2WUH9GpOo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1612776290; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Id:MIME-Version:Message-ID:References:Subject:To; bh=TMVXM8lOITeIf4e94RQ4XSv0Ym1M40k+VpYRONppqTc=; b=n7OrTQIgR7qoz7lh9lFZ1fQIuRmJCqBftkaJOlwPFcaUOaO7RSCAHxCp20ouyw/Lzo4I5+9y+tZUMxmMpW095rgowOpye2QtOxAL1d5Al4NJ6g0XoaW8j4qUhwoQid8Icb9z7u8mX30L+R2G+OgWpRAN5MjvCivHZLF2cqV5IEA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mx.zohomail.com with SMTP id 1612776290000338.9873074768284; Mon, 8 Feb 2021 01:24:50 -0800 (PST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231451AbhBHJX5 (ORCPT ); Mon, 8 Feb 2021 04:23:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231285AbhBHJAr (ORCPT ); Mon, 8 Feb 2021 04:00:47 -0500 Received: from forward106p.mail.yandex.net (forward106p.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:109]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19017C06178C; Mon, 8 Feb 2021 01:00:06 -0800 (PST) Received: from iva3-863a678c0048.qloud-c.yandex.net (iva3-863a678c0048.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:380:0:640:863a:678c]) by forward106p.mail.yandex.net (Yandex) with ESMTP id 1F6081C82902; Mon, 8 Feb 2021 12:00:04 +0300 (MSK) Received: from iva5-057a0d1fbbd8.qloud-c.yandex.net (iva5-057a0d1fbbd8.qloud-c.yandex.net [2a02:6b8:c0c:7f1c:0:640:57a:d1f]) by iva3-863a678c0048.qloud-c.yandex.net (mxback/Yandex) with ESMTP id eQZnP3ETh6-03HOaIIi; Mon, 08 Feb 2021 12:00:04 +0300 Received: by iva5-057a0d1fbbd8.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id N9nOuejTfy-03Jm76fA; Mon, 08 Feb 2021 12:00:03 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maquefel.me; s=mail; t=1612774804; bh=TMVXM8lOITeIf4e94RQ4XSv0Ym1M40k+VpYRONppqTc=; h=In-Reply-To:References:Date:Subject:To:From:Message-Id:Cc; b=r6FdlVPJmHY2uDxlpxsS/ehgPm+yeNLAiP0q+UlfKBl26LUsS52g9VGH1VCEYYHmn K1uJCISbW7edCeTmD/zKFW0l+XoB/CKfauK3i7r0DSONvyGHfMMgF3Za8ltqx/p2Ti DgGWNROMG7YEkqd8Ke3juvOL1DdxiRXNKmBpGYg8= Authentication-Results: iva3-863a678c0048.qloud-c.yandex.net; dkim=pass header.i=@maquefel.me From: Nikita Shubin Cc: Andy Shevchenko , Nikita Shubin , Linus Walleij , Alexander Sverdlin , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 3/7] gpio: ep93xx: Fix wrong irq numbers in port F Date: Mon, 8 Feb 2021 11:59:50 +0300 Message-Id: <20210208085954.30050-4-nikita.shubin@maquefel.me> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210208085954.30050-1-nikita.shubin@maquefel.me> References: <20210208085954.30050-1-nikita.shubin@maquefel.me> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Port F IRQ's should be statically mapped to EP93XX_GPIO_F_IRQ_BASE. So we need to specify girq->first otherwise: "If device tree is used, then first_irq will be 0 and IRQ's get mapped dynamically on the fly" And that's not the thing we want. Reviewed-by: Linus Walleij Acked-by: Alexander Sverdlin Signed-off-by: Nikita Shubin --- drivers/gpio/gpio-ep93xx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c index 3d8eb8769470..942da366220a 100644 --- a/drivers/gpio/gpio-ep93xx.c +++ b/drivers/gpio/gpio-ep93xx.c @@ -423,6 +423,7 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip= *egc, girq->default_type =3D IRQ_TYPE_NONE; girq->handler =3D handle_level_irq; gc->to_irq =3D ep93xx_gpio_f_to_irq; + girq->first =3D EP93XX_GPIO_F_IRQ_BASE; } =20 return devm_gpiochip_add_data(dev, gc, epg); --=20 2.26.2